status-im
/
nim-libp2p
mirror of https://github.com/status-im/nim-libp2p.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

avoid latency/copy when sending low-priority messages to fast peers (#1060)

This commit is contained in:
Jacek Sieka 2024-05-02 12:26:16 +02:00 committed by GitHub
parent aef44ed1ce
commit 84659af45b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
libp2p/protocols/pubsub/pubsubpeer.nim
View File

@ -339,14 +339,21 @@ proc sendEncoded*(p: PubSubPeer, msg: seq[byte], isHighPriority: bool): Future[v
## priority messages have been sent. ## priority messages have been sent.
doAssert(not isNil(p), "pubsubpeer nil!") doAssert(not isNil(p), "pubsubpeer nil!")
p.clearSendPriorityQueue()
# When queues are empty, skipping the non-priority queue for low priority
# messages reduces latency
let emptyQueues =
(p.rpcmessagequeue.sendPriorityQueue.len() +
p.rpcmessagequeue.nonPriorityQueue.len()) == 0
if msg.len <= 0: if msg.len <= 0:
debug "empty message, skipping", p, msg = shortLog(msg) debug "empty message, skipping", p, msg = shortLog(msg)
Future[void].completed() Future[void].completed()
elif msg.len > p.maxMessageSize: elif msg.len > p.maxMessageSize:
info "trying to send a msg too big for pubsub", maxSize=p.maxMessageSize, msgSize=msg.len info "trying to send a msg too big for pubsub", maxSize=p.maxMessageSize, msgSize=msg.len
Future[void].completed() Future[void].completed()
elif isHighPriority: elif isHighPriority or emptyQueues:
p.clearSendPriorityQueue()
let f = p.sendMsg(msg) let f = p.sendMsg(msg)
if not f.finished: if not f.finished:
p.rpcmessagequeue.sendPriorityQueue.addLast(f) p.rpcmessagequeue.sendPriorityQueue.addLast(f)