2024-10-28 03:06:20 +00:00
|
|
|
import pkg/serde
|
fix: modify unsubscribe cleanup routine and tests (#84)
* fix: modify unsubscribe cleanup routine
Ignore exceptions (other than CancelledError) if uninstallation of the filter fails. If it's the last step in the subscription cleanup, then filter changes for this filter will no longer be polled so if the filter continues to live on in geth for whatever reason, then it doesn't matter.
This includes a number of fixes:
- `CancelledError` is now caught inside of `getChanges`. This was causing conditions during `subscriptions.close`, where the `CancelledError` would get consumed by the `except CatchableError`, if there was an ongoing `poll` happening at the time of close.
- After creating a new filter inside of `getChanges`, the new filter is polled for changes before returning.
- `getChanges` also does not swallow `CatchableError` by returning an empty array, and instead re-raises the error if it is not `filter not found`.
- The tests were simplified by accessing the private fields of `PollingSubscriptions`. That way, there wasn't a race condition for the `newFilterId` counter inside of the mock.
- The `MockRpcHttpServer` was simplified by keeping track of the active filters only, and invalidation simply removes the filter. The tests then only needed to rely on the fact that the filter id changed in the mapping.
- Because of the above changes, we no longer needed to sleep inside of the tests, so the sleeps were removed, and the polling interval could be changed to 1ms, which not only makes the tests faster, but would further highlight any race conditions if present.
* docs: rpc custom port documentation
---------
Co-authored-by: Adam Uhlíř <adam@uhlir.dev>
2024-10-25 03:58:45 +00:00
|
|
|
import std/os
|
2023-10-24 23:42:25 +00:00
|
|
|
import std/options
|
2022-01-20 11:56:18 +00:00
|
|
|
import pkg/asynctest
|
2022-05-23 14:20:51 +00:00
|
|
|
import pkg/questionable
|
2022-01-20 11:56:18 +00:00
|
|
|
import pkg/stint
|
|
|
|
import pkg/ethers
|
2023-03-29 11:41:44 +00:00
|
|
|
import pkg/ethers/erc20
|
2022-01-20 11:56:18 +00:00
|
|
|
import ./hardhat
|
2023-10-24 23:42:25 +00:00
|
|
|
import ./helpers
|
feat: Allow contract transactions to be waited on
Allow waiting for a specified number of confirmations for contract transactions.
This change only requires an optional TransactionResponse return type to be added to the contract function. This allows the transaction hash to be passed to `.wait`.
For example, previously the `mint` method looked like this without a return value:
```
method mint(token: TestToken, holder: Address, amount: UInt256) {.base, contract.}
```
it still works without a return value, but if we want to wait for a 3 confirmations, we can now define it like this:
```
method mint(token: TestToken, holder: Address, amount: UInt256): ?TransactionResponse {.base, contract.}
```
and use like this:
```
let receipt = await token.connect(signer0)
.mint(accounts[1], 100.u256)
.wait(3) # wait for 3 confirmations
```
2022-05-17 04:57:18 +00:00
|
|
|
import ./miner
|
2022-07-11 13:15:01 +00:00
|
|
|
import ./mocks
|
2022-01-20 11:56:18 +00:00
|
|
|
|
|
|
|
type
|
2023-03-29 11:41:44 +00:00
|
|
|
TestToken = ref object of Erc20Token
|
2022-01-20 11:56:18 +00:00
|
|
|
|
2024-05-14 09:00:45 +00:00
|
|
|
method mint(token: TestToken, holder: Address, amount: UInt256): Confirmable {.base, contract.}
|
2023-06-29 08:23:14 +00:00
|
|
|
method myBalance(token: TestToken): UInt256 {.base, contract, view.}
|
2022-01-20 11:56:18 +00:00
|
|
|
|
fix: modify unsubscribe cleanup routine and tests (#84)
* fix: modify unsubscribe cleanup routine
Ignore exceptions (other than CancelledError) if uninstallation of the filter fails. If it's the last step in the subscription cleanup, then filter changes for this filter will no longer be polled so if the filter continues to live on in geth for whatever reason, then it doesn't matter.
This includes a number of fixes:
- `CancelledError` is now caught inside of `getChanges`. This was causing conditions during `subscriptions.close`, where the `CancelledError` would get consumed by the `except CatchableError`, if there was an ongoing `poll` happening at the time of close.
- After creating a new filter inside of `getChanges`, the new filter is polled for changes before returning.
- `getChanges` also does not swallow `CatchableError` by returning an empty array, and instead re-raises the error if it is not `filter not found`.
- The tests were simplified by accessing the private fields of `PollingSubscriptions`. That way, there wasn't a race condition for the `newFilterId` counter inside of the mock.
- The `MockRpcHttpServer` was simplified by keeping track of the active filters only, and invalidation simply removes the filter. The tests then only needed to rely on the fact that the filter id changed in the mapping.
- Because of the above changes, we no longer needed to sleep inside of the tests, so the sleeps were removed, and the polling interval could be changed to 1ms, which not only makes the tests faster, but would further highlight any race conditions if present.
* docs: rpc custom port documentation
---------
Co-authored-by: Adam Uhlíř <adam@uhlir.dev>
2024-10-25 03:58:45 +00:00
|
|
|
let providerUrl = getEnv("ETHERS_TEST_PROVIDER", "localhost:8545")
|
|
|
|
for url in ["ws://" & providerUrl, "http://" & providerUrl]:
|
2023-06-27 13:59:31 +00:00
|
|
|
|
|
|
|
suite "Contracts (" & url & ")":
|
|
|
|
|
|
|
|
var token: TestToken
|
|
|
|
var provider: JsonRpcProvider
|
|
|
|
var snapshot: JsonNode
|
|
|
|
var accounts: seq[Address]
|
|
|
|
|
|
|
|
setup:
|
|
|
|
provider = JsonRpcProvider.new(url, pollingInterval = 100.millis)
|
|
|
|
snapshot = await provider.send("evm_snapshot")
|
|
|
|
accounts = await provider.listAccounts()
|
|
|
|
let deployment = readDeployment()
|
|
|
|
token = TestToken.new(!deployment.address(TestToken), provider)
|
|
|
|
|
|
|
|
teardown:
|
|
|
|
discard await provider.send("evm_revert", @[snapshot])
|
2023-06-27 14:40:29 +00:00
|
|
|
await provider.close()
|
2023-06-27 13:59:31 +00:00
|
|
|
|
|
|
|
test "can call constant functions":
|
|
|
|
check (await token.name()) == "TestToken"
|
|
|
|
check (await token.totalSupply()) == 0.u256
|
|
|
|
check (await token.balanceOf(accounts[0])) == 0.u256
|
|
|
|
check (await token.allowance(accounts[0], accounts[1])) == 0.u256
|
|
|
|
|
|
|
|
test "can call non-constant functions":
|
|
|
|
token = TestToken.new(token.address, provider.getSigner())
|
|
|
|
discard await token.mint(accounts[1], 100.u256)
|
|
|
|
check (await token.totalSupply()) == 100.u256
|
|
|
|
check (await token.balanceOf(accounts[1])) == 100.u256
|
|
|
|
|
|
|
|
test "can call constant functions with a signer and the account is used for the call":
|
|
|
|
let signer0 = provider.getSigner(accounts[0])
|
|
|
|
let signer1 = provider.getSigner(accounts[1])
|
|
|
|
discard await token.connect(signer0).mint(accounts[1], 100.u256)
|
|
|
|
check (await token.connect(signer0).myBalance()) == 0.u256
|
|
|
|
check (await token.connect(signer1).myBalance()) == 100.u256
|
|
|
|
|
|
|
|
test "can call non-constant functions without a signer":
|
|
|
|
discard await token.mint(accounts[1], 100.u256)
|
|
|
|
check (await token.balanceOf(accounts[1])) == 0.u256
|
|
|
|
|
|
|
|
test "can call constant functions without a return type":
|
|
|
|
token = TestToken.new(token.address, provider.getSigner())
|
|
|
|
proc mint(token: TestToken, holder: Address, amount: UInt256) {.contract, view.}
|
|
|
|
await mint(token, accounts[1], 100.u256)
|
|
|
|
check (await balanceOf(token, accounts[1])) == 0.u256
|
|
|
|
|
|
|
|
test "can call non-constant functions without a return type":
|
|
|
|
token = TestToken.new(token.address, provider.getSigner())
|
|
|
|
proc mint(token: TestToken, holder: Address, amount: UInt256) {.contract.}
|
|
|
|
await token.mint(accounts[1], 100.u256)
|
|
|
|
check (await balanceOf(token, accounts[1])) == 100.u256
|
|
|
|
|
|
|
|
test "can call non-constant functions with a Confirmable return type":
|
|
|
|
|
|
|
|
token = TestToken.new(token.address, provider.getSigner())
|
|
|
|
proc mint(token: TestToken,
|
|
|
|
holder: Address,
|
|
|
|
amount: UInt256): Confirmable {.contract.}
|
2024-05-14 09:00:45 +00:00
|
|
|
let confirmable = await token.mint(accounts[1], 100.u256)
|
|
|
|
check confirmable is Confirmable
|
|
|
|
check confirmable.response.isSome
|
2023-06-27 13:59:31 +00:00
|
|
|
|
|
|
|
test "fails to compile when function has an implementation":
|
|
|
|
let works = compiles:
|
|
|
|
proc foo(token: TestToken, bar: Address) {.contract.} = discard
|
|
|
|
check not works
|
|
|
|
|
|
|
|
test "fails to compile when function has no parameters":
|
|
|
|
let works = compiles:
|
|
|
|
proc foo() {.contract.}
|
|
|
|
check not works
|
|
|
|
|
|
|
|
test "fails to compile when non-constant function has a return type":
|
|
|
|
let works = compiles:
|
|
|
|
proc foo(token: TestToken, bar: Address): UInt256 {.contract.}
|
|
|
|
check not works
|
|
|
|
|
|
|
|
test "can connect to different providers and signers":
|
|
|
|
let signer0 = provider.getSigner(accounts[0])
|
|
|
|
let signer1 = provider.getSigner(accounts[1])
|
|
|
|
discard await token.connect(signer0).mint(accounts[0], 100.u256)
|
2023-07-04 13:53:46 +00:00
|
|
|
discard await token.connect(signer0).transfer(accounts[1], 50.u256)
|
|
|
|
discard await token.connect(signer1).transfer(accounts[2], 25.u256)
|
2023-06-27 13:59:31 +00:00
|
|
|
check (await token.connect(provider).balanceOf(accounts[0])) == 50.u256
|
|
|
|
check (await token.connect(provider).balanceOf(accounts[1])) == 25.u256
|
|
|
|
check (await token.connect(provider).balanceOf(accounts[2])) == 25.u256
|
|
|
|
|
|
|
|
test "takes custom values for nonce, gasprice and gaslimit":
|
|
|
|
let overrides = TransactionOverrides(
|
|
|
|
nonce: some 100.u256,
|
|
|
|
gasPrice: some 200.u256,
|
|
|
|
gasLimit: some 300.u256
|
|
|
|
)
|
|
|
|
let signer = MockSigner.new(provider)
|
|
|
|
discard await token.connect(signer).mint(accounts[0], 42.u256, overrides)
|
|
|
|
check signer.transactions.len == 1
|
|
|
|
check signer.transactions[0].nonce == overrides.nonce
|
|
|
|
check signer.transactions[0].gasPrice == overrides.gasPrice
|
|
|
|
check signer.transactions[0].gasLimit == overrides.gasLimit
|
|
|
|
|
|
|
|
test "can call functions for different block heights":
|
|
|
|
let block1 = await provider.getBlockNumber()
|
|
|
|
let signer = provider.getSigner(accounts[0])
|
|
|
|
discard await token.connect(signer).mint(accounts[0], 100.u256)
|
|
|
|
let block2 = await provider.getBlockNumber()
|
|
|
|
|
|
|
|
let beforeMint = CallOverrides(blockTag: some BlockTag.init(block1))
|
|
|
|
let afterMint = CallOverrides(blockTag: some BlockTag.init(block2))
|
|
|
|
|
|
|
|
check (await token.balanceOf(accounts[0], beforeMint)) == 0
|
|
|
|
check (await token.balanceOf(accounts[0], afterMint)) == 100
|
|
|
|
|
2024-03-03 05:29:51 +00:00
|
|
|
test "can simulate transactions for different block heights":
|
|
|
|
let block1 = await provider.getBlockNumber()
|
|
|
|
let signer = provider.getSigner(accounts[0])
|
|
|
|
discard await token.connect(signer).mint(accounts[0], 100.u256)
|
|
|
|
let block2 = await provider.getBlockNumber()
|
|
|
|
|
|
|
|
let beforeMint = CallOverrides(blockTag: some BlockTag.init(block1))
|
|
|
|
let afterMint = CallOverrides(blockTag: some BlockTag.init(block2))
|
|
|
|
|
|
|
|
expect ProviderError:
|
|
|
|
discard await token.transfer(accounts[1], 50.u256, beforeMint)
|
|
|
|
discard await token.transfer(accounts[1], 50.u256, afterMint)
|
|
|
|
|
2023-06-27 13:59:31 +00:00
|
|
|
test "receives events when subscribed":
|
|
|
|
var transfers: seq[Transfer]
|
|
|
|
|
|
|
|
proc handleTransfer(transfer: Transfer) =
|
|
|
|
transfers.add(transfer)
|
|
|
|
|
|
|
|
let signer0 = provider.getSigner(accounts[0])
|
|
|
|
let signer1 = provider.getSigner(accounts[1])
|
|
|
|
|
|
|
|
let subscription = await token.subscribe(Transfer, handleTransfer)
|
|
|
|
discard await token.connect(signer0).mint(accounts[0], 100.u256)
|
2023-07-04 13:53:46 +00:00
|
|
|
discard await token.connect(signer0).transfer(accounts[1], 50.u256)
|
|
|
|
discard await token.connect(signer1).transfer(accounts[2], 25.u256)
|
2023-06-27 13:59:31 +00:00
|
|
|
|
|
|
|
check eventually transfers == @[
|
|
|
|
Transfer(receiver: accounts[0], value: 100.u256),
|
|
|
|
Transfer(sender: accounts[0], receiver: accounts[1], value: 50.u256),
|
|
|
|
Transfer(sender: accounts[1], receiver: accounts[2], value: 25.u256)
|
|
|
|
]
|
|
|
|
|
|
|
|
await subscription.unsubscribe()
|
|
|
|
|
|
|
|
test "stops receiving events when unsubscribed":
|
|
|
|
var transfers: seq[Transfer]
|
|
|
|
|
|
|
|
proc handleTransfer(transfer: Transfer) =
|
|
|
|
transfers.add(transfer)
|
|
|
|
|
|
|
|
let signer0 = provider.getSigner(accounts[0])
|
|
|
|
|
|
|
|
let subscription = await token.subscribe(Transfer, handleTransfer)
|
|
|
|
discard await token.connect(signer0).mint(accounts[0], 100.u256)
|
|
|
|
|
|
|
|
check eventually transfers.len == 1
|
|
|
|
await subscription.unsubscribe()
|
|
|
|
|
2023-07-04 13:53:46 +00:00
|
|
|
discard await token.connect(signer0).transfer(accounts[1], 50.u256)
|
2023-06-27 13:59:31 +00:00
|
|
|
await sleepAsync(100.millis)
|
|
|
|
|
|
|
|
check transfers.len == 1
|
|
|
|
|
|
|
|
test "can wait for contract interaction tx to be mined":
|
|
|
|
let signer0 = provider.getSigner(accounts[0])
|
2023-06-29 08:11:13 +00:00
|
|
|
let confirming = token.connect(signer0)
|
|
|
|
.mint(accounts[1], 100.u256)
|
|
|
|
.confirm(3)
|
|
|
|
await sleepAsync(100.millis) # wait for tx to be mined
|
|
|
|
await provider.mineBlocks(2) # two additional blocks
|
|
|
|
let receipt = await confirming
|
|
|
|
check receipt.blockNumber.isSome
|
2023-07-20 05:51:28 +00:00
|
|
|
|
|
|
|
test "can query last block event log":
|
|
|
|
|
|
|
|
let signer0 = provider.getSigner(accounts[0])
|
|
|
|
|
|
|
|
discard await token.connect(signer0).mint(accounts[0], 100.u256)
|
|
|
|
discard await token.connect(signer0).transfer(accounts[1], 50.u256)
|
|
|
|
|
|
|
|
let logs = await token.queryFilter(Transfer)
|
|
|
|
|
|
|
|
check eventually logs == @[
|
|
|
|
Transfer(sender: accounts[0], receiver: accounts[1], value: 50.u256)
|
|
|
|
]
|
|
|
|
|
|
|
|
test "can query past event logs by specifying from and to blocks":
|
|
|
|
|
|
|
|
let signer0 = provider.getSigner(accounts[0])
|
|
|
|
let signer1 = provider.getSigner(accounts[1])
|
|
|
|
|
|
|
|
discard await token.connect(signer0).mint(accounts[0], 100.u256)
|
|
|
|
discard await token.connect(signer0).transfer(accounts[1], 50.u256)
|
|
|
|
discard await token.connect(signer1).transfer(accounts[2], 25.u256)
|
|
|
|
|
|
|
|
let currentBlock = await provider.getBlockNumber()
|
|
|
|
let logs = await token.queryFilter(Transfer,
|
|
|
|
BlockTag.init(currentBlock - 1),
|
|
|
|
BlockTag.latest)
|
|
|
|
|
|
|
|
check logs == @[
|
|
|
|
Transfer(sender: accounts[0], receiver: accounts[1], value: 50.u256),
|
|
|
|
Transfer(sender: accounts[1], receiver: accounts[2], value: 25.u256)
|
|
|
|
]
|
|
|
|
|
|
|
|
test "can query past event logs by specifying a block hash":
|
|
|
|
|
|
|
|
let signer0 = provider.getSigner(accounts[0])
|
|
|
|
|
|
|
|
let receipt = await token.connect(signer0)
|
|
|
|
.mint(accounts[0], 100.u256)
|
|
|
|
.confirm(1)
|
|
|
|
discard await token.connect(signer0).transfer(accounts[1], 50.u256)
|
|
|
|
|
|
|
|
let logs = await token.queryFilter(Transfer, !receipt.blockHash)
|
|
|
|
|
|
|
|
check logs == @[
|
|
|
|
Transfer(receiver: accounts[0], value: 100.u256)
|
|
|
|
]
|
2023-10-24 23:42:25 +00:00
|
|
|
|
|
|
|
test "concurrent transactions with first failing increment nonce correctly":
|
|
|
|
let signer = provider.getSigner()
|
|
|
|
let token = TestToken.new(token.address, signer)
|
|
|
|
let helpersContract = TestHelpers.new(signer)
|
|
|
|
|
|
|
|
# emulate concurrent populateTransaction calls, where the first one fails
|
|
|
|
let futs = await allFinished(
|
|
|
|
helpersContract.doRevert("some reason"),
|
|
|
|
token.mint(accounts[0], 100.u256)
|
|
|
|
)
|
|
|
|
check futs[0].error of EstimateGasError
|
|
|
|
let receipt = await futs[1].confirm(1)
|
|
|
|
|
|
|
|
check receipt.status == TransactionStatus.Success
|
|
|
|
|
|
|
|
test "non-concurrent transactions with first failing increment nonce correctly":
|
|
|
|
let signer = provider.getSigner()
|
|
|
|
let token = TestToken.new(token.address, signer)
|
|
|
|
let helpersContract = TestHelpers.new(signer)
|
|
|
|
|
|
|
|
expect EstimateGasError:
|
|
|
|
discard await helpersContract.doRevert("some reason")
|
|
|
|
|
|
|
|
let receipt = await token
|
|
|
|
.mint(accounts[0], 100.u256)
|
|
|
|
.confirm(1)
|
|
|
|
|
|
|
|
check receipt.status == TransactionStatus.Success
|
2024-10-25 04:08:00 +00:00
|
|
|
|
|
|
|
test "can cancel procs that execute transactions":
|
|
|
|
let signer = provider.getSigner()
|
|
|
|
let token = TestToken.new(token.address, signer)
|
|
|
|
let countBefore = await signer.getTransactionCount(BlockTag.pending)
|
|
|
|
|
|
|
|
proc executeTx {.async.} =
|
|
|
|
discard await token.mint(accounts[0], 100.u256)
|
|
|
|
|
|
|
|
await executeTx().cancelAndWait()
|
|
|
|
let countAfter = await signer.getTransactionCount(BlockTag.pending)
|
|
|
|
check countBefore == countAfter
|
|
|
|
|
|
|
|
test "concurrent transactions succeed even if one is cancelled":
|
|
|
|
let signer = provider.getSigner()
|
|
|
|
let token = TestToken.new(token.address, signer)
|
|
|
|
let balanceBefore = await token.myBalance()
|
|
|
|
|
|
|
|
proc executeTx: Future[Confirmable] {.async.} =
|
|
|
|
return await token.mint(accounts[0], 100.u256)
|
|
|
|
|
|
|
|
proc executeTxWithCancellation: Future[Confirmable] {.async.} =
|
|
|
|
let fut = token.mint(accounts[0], 100.u256)
|
|
|
|
fut.cancelSoon()
|
|
|
|
return await fut
|
|
|
|
|
|
|
|
# emulate concurrent populateTransaction/sendTransaction calls, where the
|
|
|
|
# first one fails
|
|
|
|
let futs = await allFinished(
|
|
|
|
executeTxWithCancellation(),
|
|
|
|
executeTx(),
|
|
|
|
executeTx()
|
|
|
|
)
|
|
|
|
let receipt1 = await futs[1].confirm(0)
|
|
|
|
let receipt2 = await futs[2].confirm(0)
|
|
|
|
|
|
|
|
check receipt1.status == TransactionStatus.Success
|
|
|
|
check receipt2.status == TransactionStatus.Success
|
|
|
|
|
|
|
|
let balanceAfter = await token.myBalance()
|
|
|
|
check balanceAfter == balanceBefore + 200.u256
|