Thomas Bernard
4dda6d8820
update (c) lines
2024-03-12 00:37:21 +01:00
Thomas Bernard
55e650b125
fix IGDv2 WANIPConnection XML service description for AddAnyPortMapping
...
out argument is NewReservedPort, not NewExternalPort.
Changelog + check precisely lenth of 12
2024-02-25 01:40:25 +01:00
Thomas Bernard
f79e20d17d
miniupnpd: fix IGDv2 WANIPConnection XML service description
...
was :
<argument>
<name>NewExternalPort</name>
<direction>out</direction>
<relatedStateVariable>ExternalPort</relatedStateVariable>
</argument>
Should be:
<argument>
<name>NewReservedPort</name>
<direction>out</direction>
<relatedStateVariable>ExternalPort</relatedStateVariable>
</argument>
ExternalPort is 12 characters long !
fixes #708
2024-02-25 01:29:54 +01:00
Thomas Bernard
c13a4b15f1
upnpdescgen.c: include macros.h for UNUSED
...
fixes 3a2b15af4c
2022-10-16 07:43:42 +02:00
Thomas Bernard
3a2b15af4c
miniupnpd: fix warnings when compiling with IGD_V2 disabled
...
fixes #617
./upnpdescgen.c:946:1: warning: unused label 'unstack' [-Wunused-label]
unstack:
^~~~~~~~
./upnpdescgen.c:891:12: warning: unused parameter 'force_igd1' [-Wunused-parameter]
int force_igd1)
^
./upnpdescgen.c:1035:61: warning: unused parameter 'force_igd1' [-Wunused-parameter]
genServiceDesc(int * len, const struct serviceDesc * s, int force_igd1)
^
3 warnings generated.
2022-10-15 13:09:36 +02:00
Thomas Bernard
32f1d4cd1a
upnpdescgen.c: rootDesc.xml skip DeviceProtection and WANIPv6FirewallControl when force_igd1
...
see #539
2021-08-12 23:19:14 +02:00
Thomas Bernard
4d4121bf40
upnpdescgen.c: move a variable declaration
2021-08-12 23:19:14 +02:00
Thomas Bernard
d8e5659c7b
upnpdescgen.c: add force_igd1 param to XML description generation functions
2021-08-12 23:19:13 +02:00
Thomas Bernard
c0ea7926c0
upnpdescgen.c: error message when memory alloc fails
2020-06-02 00:24:15 +02:00
Thomas Bernard
3b20182c86
miniupnpd/upnpdescgen.c: check string length before memcmp() in genServiceDesc()
...
see https://github.com/miniupnp/miniupnp/issues/459
2020-05-30 11:06:24 +02:00
Pali Rohár
cce19781e6
miniupnpd: Add validation that public ip address is not reserved and is really public
...
This ensures that all requests for getting public IP address (either via UPnP IGD or PCP/PMP) would contain correct public IP address or an error (instead of some invalid private/reserved IP address).
2018-05-19 13:31:26 +02:00
Thomas Bernard
80779ff4f7
Fix commit 6cbf0ba
...
Use the "flags" global variable to store the option value
Save a lot of complexity.
2018-02-22 13:47:48 +01:00
Nye Liu
c6bf0ba6f3
Allow runtime override of igd to v1 for people running binaries with v2 enabled
...
Towards miniupnp/miniupnp#277
2018-02-19 22:14:05 -08:00
Thomas Bernard
165c5f0d57
upnpdescgen.c: check for stack overflow in genXML()
...
remove two TODO's ! ;)
2017-11-24 11:00:34 +01:00
Thomas Bernard
5923d5de6f
=> 2017
2017-05-27 10:25:53 +02:00
Thomas Bernard
144eeefd19
Merge branch 'master' into randomize_url
...
Conflicts:
miniupnpd/genconfig.sh
miniupnpd/testupnpdescgen.c
miniupnpd/upnpdescgen.c
miniupnpd/upnpglobalvars.c
miniupnpd/upnpglobalvars.h
2016-11-11 18:01:35 +01:00
Thomas Bernard
22f7836816
reorder elements in XML descriptions to follow UDA 1.1
2016-02-16 10:55:48 +01:00
Thomas Bernard
13a6a38241
add configId attribute to <root> element (UDA 1.1)
2016-02-16 10:55:03 +01:00
Thomas Bernard
9d8a988b82
add comments in upnpdescgen.c
2015-12-15 11:17:15 +01:00
Thomas Bernard
0139addbda
Merge branch 'desc_test'
2015-12-15 10:57:14 +01:00
Daniel Becker
04b344b6f8
actually return a value in SetupReady notifications
2015-12-12 02:42:13 -08:00
Thomas Bernard
a4a3e5a3f8
add comments. see 0298b66365
2015-12-12 09:31:22 +01:00
Thomas BERNARD
128bbee806
Merge pull request #180 from razzfazz/fix_dp_action_args
...
fix action arguments for DeviceProtection service (IGDv2)
2015-12-12 08:58:25 +01:00
Daniel Becker
0298b66365
fix argument names for DeviceProtection actions
2015-12-11 23:12:11 -08:00
Daniel Becker
7774c24daa
add missing parameters for DeviceProtection service actions
2015-12-11 22:56:20 -08:00
Thomas Bernard
0d0728e2d1
name WANIPv6FirewallControl:1 service WANUPv6Firewall1
...
done according to http://upnp.org/specs/gw/UPnP-gw-InternetGatewayDevice-v2-Device.pdf
2.2 (page 9)
2015-12-11 14:40:13 +01:00
Daniel Becker
d89e4aaf70
fix Layer3Forwarding serviceId to be consistent with IGDv2 spec
2015-12-11 02:13:42 -08:00
Thomas Bernard
76a5f9930b
Changes to WANIPCn.xml
...
Add default values for :
RSIPAvailable
NATEnabled
LastConnectionError
ConnectionStatus
follow the Specification regarding ConnectionType / PossibleConnectionTypes
allowed values
2015-12-11 10:57:25 +01:00
Thomas Bernard
7ae5783d85
UPNP_VERSION_MAJOR / UPNP_VERSION_MINOR macros defined in config.h
2015-09-21 22:39:30 +02:00
Thomas Bernard
a8f80040c9
Randomize URLs to avoid http://www.filet-o-firewall.com/
2015-09-14 12:10:15 +02:00
Thomas Bernard
e13525c3e7
miniupnpd: UPnP/1.1 => UPnP/2.0
2015-02-16 11:23:05 +01:00
Thomas Bernard
97c001d464
add use(less ?)ful comments
2014-10-06 14:44:45 +02:00
Thomas Bernard
7b13adafbd
miniupnpd: reduce number of global variables by using more runtime_flags
...
change ipv6_enabled/ipv6fc_inbound_pinhole_allowed/ipv6fc_firewall_enabled
global vars to flags in runtime_flags
2014-03-13 11:34:33 +01:00
Thomas Bernard
d19048ef9e
miniupnpd: Make all manufacturer info configurable
2013-12-13 12:03:28 +01:00
Leo Moll
d200fb748f
Made all manufacturer related information configurable:
...
- manufacturer_name, default is "`uname -s`"
- manufacturer_url, default is URL of OS verndor
- model_name, default is "`uname -s` router"
- model_description, default is "`uname -s` router"
- model_url, default is URL of OS verndor
2013-10-20 23:02:19 +02:00
Thomas Bernard
98fcc3c757
fix 58827720da
2013-07-30 08:59:13 +02:00
Thomas Bernard
50ec2fce4a
Have distinct UUID for the 3 devices (IGD, WAN Device, WAN Connection Device)
2013-06-13 16:03:36 +02:00
Thomas Bernard
58827720da
Remove namespace from variable name elements in Events "propertyset" to comply with UDAv1.1
...
See UPNP Device Architecture v1.1, section 4.3.2 :
<variableName>
REQUIRED. Element is name of a state variable that changed (<name> sub element of
<stateVariable> element in service description). MUST NOT be qualified with any namespace. Value
is the new value for this state variable. Case sensitive. Single data type as specified by UPnP service
description.
2013-05-29 23:29:29 +02:00
Thomas Bernard
961e1c35d3
miniupnpd: autodetect LAN interface netmask instead of defaulting to /24
...
Fix #23
2013-03-23 11:50:57 +01:00
Thomas Bernard
67bd1f9b42
updated DEFAULTCONNECTIONSERVICE_MAGICALVALUE for IGDv2
2012-10-05 00:29:55 +02:00
Thomas Bernard
1a458fe869
Ignore "-Wmissing-field-initializers" in upnpdescgen.c
2012-10-05 00:26:44 +02:00
Thomas Bernard
ee0815ac85
miniupnpd: UPC must be a 12 decimal digit code
2012-09-28 11:05:34 +02:00
Thomas Bernard
e42dfd3284
Remove Warnings caused by signed/unsigned integer comparaisons
2012-05-01 11:52:21 +02:00
Shawn Landen
5c224accbf
remove trailing whitespace from miniupnpd
2012-02-29 17:48:41 -08:00
Thomas Bernard
a0a1e45ac5
Added friendl_name= option to config file
2012-02-05 00:24:13 +01:00
Thomas Bernard
0d96346588
Adding miniupnpd
2011-09-28 21:13:20 +02:00