status-im
/
miniupnp
mirror of https://github.com/status-im/miniupnp.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

miniupnpd: fix IGDv2 WANIPConnection XML service description 

was :

<argument>
  <name>NewExternalPort</name>
  <direction>out</direction>
  <relatedStateVariable>ExternalPort</relatedStateVariable>
</argument>

Should be:

<argument>
  <name>NewReservedPort</name>
  <direction>out</direction>
  <relatedStateVariable>ExternalPort</relatedStateVariable>
</argument>

ExternalPort is 12 characters long !
fixes #708
This commit is contained in:
Thomas Bernard 2024-02-25 01:29:54 +01:00
parent 417ddcc3d3
commit f79e20d17d
No known key found for this signature in database
GPG Key ID: DB511043A31ACAAF
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
miniupnpd/upnpdescgen.c
View File

@ -1124,7 +1124,7 @@ genServiceDesc(int * len, const struct serviceDesc * s, int force_igd1)
#ifdef IGD_V2
} else if(plen >= 11 && 0 == memcmp(p, "A_ARG_TYPE_", 11)) {
str = strcat_str(str, len, &tmplen, p + 11);
} else if(plen >= 13 && 0 == memcmp(p, "ExternalPort", 13)
} else if(plen >= 12 && 0 == memcmp(p, "ExternalPort", 12)
&& args[j].dir == 2
&& 0 == memcmp(acts[i].name, "AddAnyPortMapping", 18)) {
str = strcat_str(str, len, &tmplen, "ReservedPort");