Add option to bundle server to generate full sourcemaps from babel

Reviewed By: bestander

Differential Revision: D3863894

fbshipit-source-id: a282758e022d403743841bc59277196e6741ed18
This commit is contained in:
Charles Dick 2016-09-15 06:51:24 -07:00 committed by Facebook Github Bot 6
parent bc0c34967e
commit 9f65b0f025
2 changed files with 11 additions and 3 deletions

View File

@ -257,6 +257,7 @@ class Bundler {
entryModuleOnly,
resolutionResponse,
isolateModuleIDs,
generateSourceMaps,
}) {
const onResolutionResponse = response => {
bundle.setMainModuleId(response.getModuleId(getMainModule(response)));
@ -301,6 +302,7 @@ class Bundler {
onResolutionResponse,
finalizeBundle,
isolateModuleIDs,
generateSourceMaps,
});
}
@ -352,6 +354,7 @@ class Bundler {
unbundle,
resolutionResponse,
isolateModuleIDs,
generateSourceMaps,
onResolutionResponse = noop,
onModuleTransformed = noop,
finalizeBundle = noop,
@ -385,7 +388,7 @@ class Bundler {
onProgress,
minify,
isolateModuleIDs,
generateSourceMaps: unbundle,
generateSourceMaps: unbundle || generateSourceMaps,
});
}

View File

@ -150,6 +150,10 @@ const bundleOpts = declareOpts({
resolutionResponse: {
type: 'object',
},
generateSourceMaps: {
type: 'boolean',
required: false,
}
});
const dependencyOpts = declareOpts({
@ -814,7 +818,7 @@ class Server {
sourceMapUrl: url.format(sourceMapUrlObj),
entryFile: entryFile,
dev: this._getBoolOptionFromQuery(urlObj.query, 'dev', true),
minify: this._getBoolOptionFromQuery(urlObj.query, 'minify'),
minify: this._getBoolOptionFromQuery(urlObj.query, 'minify', false),
hot: this._getBoolOptionFromQuery(urlObj.query, 'hot', false),
runModule: this._getBoolOptionFromQuery(urlObj.query, 'runModule', true),
inlineSourceMap: this._getBoolOptionFromQuery(
@ -828,11 +832,12 @@ class Server {
'entryModuleOnly',
false,
),
generateSourceMaps: this._getBoolOptionFromQuery(urlObj.query, 'babelSourcemap'),
};
}
_getBoolOptionFromQuery(query, opt, defaultVal) {
if (query[opt] == null && defaultVal != null) {
if (query[opt] == null) {
return defaultVal;
}