diff --git a/react-packager/src/Bundler/index.js b/react-packager/src/Bundler/index.js index 20993e4b..2d640dae 100644 --- a/react-packager/src/Bundler/index.js +++ b/react-packager/src/Bundler/index.js @@ -257,6 +257,7 @@ class Bundler { entryModuleOnly, resolutionResponse, isolateModuleIDs, + generateSourceMaps, }) { const onResolutionResponse = response => { bundle.setMainModuleId(response.getModuleId(getMainModule(response))); @@ -301,6 +302,7 @@ class Bundler { onResolutionResponse, finalizeBundle, isolateModuleIDs, + generateSourceMaps, }); } @@ -352,6 +354,7 @@ class Bundler { unbundle, resolutionResponse, isolateModuleIDs, + generateSourceMaps, onResolutionResponse = noop, onModuleTransformed = noop, finalizeBundle = noop, @@ -385,7 +388,7 @@ class Bundler { onProgress, minify, isolateModuleIDs, - generateSourceMaps: unbundle, + generateSourceMaps: unbundle || generateSourceMaps, }); } diff --git a/react-packager/src/Server/index.js b/react-packager/src/Server/index.js index 54ef2b1b..08576bbb 100644 --- a/react-packager/src/Server/index.js +++ b/react-packager/src/Server/index.js @@ -150,6 +150,10 @@ const bundleOpts = declareOpts({ resolutionResponse: { type: 'object', }, + generateSourceMaps: { + type: 'boolean', + required: false, + } }); const dependencyOpts = declareOpts({ @@ -814,7 +818,7 @@ class Server { sourceMapUrl: url.format(sourceMapUrlObj), entryFile: entryFile, dev: this._getBoolOptionFromQuery(urlObj.query, 'dev', true), - minify: this._getBoolOptionFromQuery(urlObj.query, 'minify'), + minify: this._getBoolOptionFromQuery(urlObj.query, 'minify', false), hot: this._getBoolOptionFromQuery(urlObj.query, 'hot', false), runModule: this._getBoolOptionFromQuery(urlObj.query, 'runModule', true), inlineSourceMap: this._getBoolOptionFromQuery( @@ -828,11 +832,12 @@ class Server { 'entryModuleOnly', false, ), + generateSourceMaps: this._getBoolOptionFromQuery(urlObj.query, 'babelSourcemap'), }; } _getBoolOptionFromQuery(query, opt, defaultVal) { - if (query[opt] == null && defaultVal != null) { + if (query[opt] == null) { return defaultVal; }