8bb6f21498
Merge pull request #1 from status-im/review
...
I've made granular commits to explain each of the changes I'm suggesting. Each commit hopefully explains why the change was made.
2020-06-12 00:31:28 +01:00
b2ad6b6ac5
Refactored processTranslation to be less prone to bugs
...
This implementation removes the need for string replace and it more faithfully interprets '{{' as a placeholder open and '}}' as a placeholder close token. This code could be further improved by implementing lexer patterns
2020-06-12 00:17:52 +01:00
6c0f4ea263
Replaced logger with native log package
2020-06-11 23:50:12 +01:00
64fe211e91
Inline type assertion
2020-06-11 22:39:34 +01:00
d2a0dfad33
Added deferred file close, and added Close err handling
2020-06-11 17:29:21 +01:00
10c06deff2
Replaced log.Errorf with log.Fatalf
...
Logger.Fatalf calls the os.Exit(1) for you
2020-06-11 17:23:12 +01:00
04ad9c78f5
Replace fmt.Fprintf with log.Errorf in main()
...
fmt.Fprintf returns an error, and if you're using fmt.Fprintf for error handling you end up with an unhandled error in your error handling :D. Logger doesn't do this
2020-06-11 17:16:31 +01:00
02693db047
Removed superfluous brackets from main()
2020-06-11 17:05:12 +01:00
48843e69df
remove usage
2020-06-09 14:11:11 -04:00
6460d86825
read from file or stdin
2020-06-09 14:09:55 -04:00
e9fc109bec
check file read error
2020-06-09 13:56:18 -04:00
09ba0dc61a
add go get instructions
2020-06-09 13:54:10 -04:00
de5547c3fb
initial pass
2020-06-09 13:53:31 -04:00
d01813a596
Initial commit
2020-06-09 13:52:01 -04:00
Samuel Hawksby-Robinson
Andre Medeiros
André Medeiros