status-im
/
libp2p-test-plans
mirror of https://github.com/status-im/libp2p-test-plans.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(perf): increase MAX_AGE_MINUTES to 120 (#215) 

- When experimenting with increasing iterations, instances are taken down
prematurely. See e.g. https://github.com/libp2p/test-plans/actions/runs/5418669631/jobs/9850992882

- When benchmarking from a local developer machine, experimenting for longer is useful.

- The AWS Lambda is only a safety net machanism. In the rare case where we
miss to clean up, running the machines for <1h or 2h doesn't matter cost wise.
This commit is contained in:
Max Inden 2023-07-05 07:06:39 +02:00 committed by GitHub
parent 1b187a379c
commit acea8b5e0c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
perf/terraform/modules/ci/cleanup.tf
View File

@ -18,7 +18,7 @@ resource "aws_lambda_function" "cleanup" {
variables = { variables = {
REGIONS = jsonencode(var.regions) REGIONS = jsonencode(var.regions)
TAGS = jsonencode(var.tags) TAGS = jsonencode(var.tags)
MAX_AGE_MINUTES = 50 MAX_AGE_MINUTES = 120
} }
} }
} }

2
perf/terraform/modules/ci/test/cleanup.yml
View File

@ -13,7 +13,7 @@ Resources:
Variables: Variables:
REGIONS: '["us-west-2", "us-east-1"]' REGIONS: '["us-west-2", "us-east-1"]'
TAGS: '{"Project":"perf", "Name":"node"}' TAGS: '{"Project":"perf", "Name":"node"}'
MAX_AGE_MINUTES: '30' MAX_AGE_MINUTES: '120'
Policies: Policies:
- AmazonEC2FullAccess - AmazonEC2FullAccess
Timeout: 30 Timeout: 30