From acea8b5e0c907b3bdf338954cbac05b0f113b64d Mon Sep 17 00:00:00 2001 From: Max Inden Date: Wed, 5 Jul 2023 07:06:39 +0200 Subject: [PATCH] fix(perf): increase MAX_AGE_MINUTES to 120 (#215) - When experimenting with increasing iterations, instances are taken down prematurely. See e.g. https://github.com/libp2p/test-plans/actions/runs/5418669631/jobs/9850992882 - When benchmarking from a local developer machine, experimenting for longer is useful. - The AWS Lambda is only a safety net machanism. In the rare case where we miss to clean up, running the machines for <1h or 2h doesn't matter cost wise. --- perf/terraform/modules/ci/cleanup.tf | 2 +- perf/terraform/modules/ci/test/cleanup.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/perf/terraform/modules/ci/cleanup.tf b/perf/terraform/modules/ci/cleanup.tf index 27e7bce..e04a377 100644 --- a/perf/terraform/modules/ci/cleanup.tf +++ b/perf/terraform/modules/ci/cleanup.tf @@ -18,7 +18,7 @@ resource "aws_lambda_function" "cleanup" { variables = { REGIONS = jsonencode(var.regions) TAGS = jsonencode(var.tags) - MAX_AGE_MINUTES = 50 + MAX_AGE_MINUTES = 120 } } } diff --git a/perf/terraform/modules/ci/test/cleanup.yml b/perf/terraform/modules/ci/test/cleanup.yml index 4311a25..9bb88d8 100644 --- a/perf/terraform/modules/ci/test/cleanup.yml +++ b/perf/terraform/modules/ci/test/cleanup.yml @@ -13,7 +13,7 @@ Resources: Variables: REGIONS: '["us-west-2", "us-east-1"]' TAGS: '{"Project":"perf", "Name":"node"}' - MAX_AGE_MINUTES: '30' + MAX_AGE_MINUTES: '120' Policies: - AmazonEC2FullAccess Timeout: 30