Commit Graph

2858 Commits

Author SHA1 Message Date
dependabot[bot] 82ca60edac
chore(deps)(deps-dev): bump typescript from 5.3.2 to 5.3.3 (#1879)
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.3.2 to 5.3.3.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml)
- [Commits](https://github.com/Microsoft/TypeScript/compare/v5.3.2...v5.3.3)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-04 23:49:47 +01:00
Sasha 2613b091b2
chore: add local peer discovery package to release tracking (#1882) 2024-03-04 23:31:16 +01:00
Arseniy Klempner 5e1bce494f
Merge pull request #1880 from waku-org/fix/remove-rpc
fix: remove rpc settings when starting nwaku image
2024-03-04 10:08:05 -08:00
Arseniy Klempner 37f24e9ea1
fix: remove rpc settings when starting nwaku image 2024-03-04 07:16:16 -08:00
Sasha 9f198dd149
feat: add bootstrapPeers option and refactor sdk (#1871)
* move relay related code

* move libp2p to utils

* define CreateWakuNodeOptions

* improve options

* make libp2p use from create function

* add bootstrapPeers option

* fix lint

* fix types, imports

* fix exports

* use bootstrap along default bootstrap

* fix test as REST does not return peer though connection is made

* rollback condition change

* enable gossipSub back for every node
2024-03-04 10:56:20 +01:00
dependabot[bot] fcc3f10f7c
chore(deps)(deps-dev): bump @size-limit/preset-big-lib (#1854)
Bumps [@size-limit/preset-big-lib](https://github.com/ai/size-limit) from 8.2.6 to 11.0.2.
- [Changelog](https://github.com/ai/size-limit/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ai/size-limit/compare/8.2.6...11.0.2)

---
updated-dependencies:
- dependency-name: "@size-limit/preset-big-lib"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sasha <118575614+weboko@users.noreply.github.com>
2024-03-01 17:16:08 +01:00
Florin Barbu 13b31df9dd
chore: fix peer ex tests (#1869)
* fix peer ex tests

* remove only

* check for undefined

* add timeout

* timeout for query

* remove logs

* add log back

* whitelist 2nd erorr

* use beforeAll

* remove only

* revert last changes

* remove console logs

* skip query suite

* leave just one query test
2024-03-01 12:31:44 +02:00
dependabot[bot] eb3d5604ef
chore(deps)(deps-dev): bump ts-loader from 9.4.4 to 9.5.1 (#1875)
Bumps [ts-loader](https://github.com/TypeStrong/ts-loader) from 9.4.4 to 9.5.1.
- [Release notes](https://github.com/TypeStrong/ts-loader/releases)
- [Changelog](https://github.com/TypeStrong/ts-loader/blob/main/CHANGELOG.md)
- [Commits](https://github.com/TypeStrong/ts-loader/compare/v9.4.4...v9.5.1)

---
updated-dependencies:
- dependency-name: ts-loader
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-29 22:28:51 +01:00
dependabot[bot] 4f2c0bcb9e
chore(deps)(deps-dev): bump rollup from 4.9.5 to 4.12.0 (#1870)
Bumps [rollup](https://github.com/rollup/rollup) from 4.9.5 to 4.12.0.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rollup/rollup/compare/v4.9.5...v4.12.0)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-29 01:16:50 +01:00
Danish Arora f3cb10d484
chore!: rename local-discovery to local-peer-cache-discovery (#1867) 2024-02-29 01:05:54 +05:30
Arseniy Klempner 78ee39a2e2
Merge pull request #1823 from waku-org/feat/create-subscription-content-topic
feat: subscribe to content topic via SDK
2024-02-28 07:27:13 -08:00
Arseniy Klempner ee2d4176f8
feat: create node and subscription by content topic 2024-02-27 15:37:57 -08:00
dependabot[bot] 382af3387e
chore(deps)(deps-dev): bump eslint-plugin-functional from 6.0.0 to 6.0.1 (#1868)
Bumps [eslint-plugin-functional](https://github.com/eslint-functional/eslint-plugin-functional) from 6.0.0 to 6.0.1.
- [Release notes](https://github.com/eslint-functional/eslint-plugin-functional/releases)
- [Changelog](https://github.com/eslint-functional/eslint-plugin-functional/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint-functional/eslint-plugin-functional/compare/v6.0.0...v6.0.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-functional
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-27 23:07:28 +01:00
dependabot[bot] 6d3ed304a8
chore(deps)(deps): bump @chainsafe/libp2p-gossipsub (#1866)
Bumps [@chainsafe/libp2p-gossipsub](https://github.com/ChainSafe/js-libp2p-gossipsub) from 11.1.0 to 12.0.0.
- [Release notes](https://github.com/ChainSafe/js-libp2p-gossipsub/releases)
- [Changelog](https://github.com/ChainSafe/js-libp2p-gossipsub/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ChainSafe/js-libp2p-gossipsub/compare/v11.1.0...v12.0.0)

---
updated-dependencies:
- dependency-name: "@chainsafe/libp2p-gossipsub"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-27 22:01:02 +05:30
Florin Barbu df8c0d79f7
test: peer exchange tests (#1859)
* peer exchange tests

* adjust after test with nwaku 25
2024-02-27 09:54:34 +02:00
dependabot[bot] 44dc47c2b1
chore(deps)(deps-dev): bump typedoc from 0.25.7 to 0.25.9 (#1864)
Bumps [typedoc](https://github.com/TypeStrong/TypeDoc) from 0.25.7 to 0.25.9.
- [Release notes](https://github.com/TypeStrong/TypeDoc/releases)
- [Changelog](https://github.com/TypeStrong/typedoc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/TypeStrong/TypeDoc/compare/v0.25.7...v0.25.9)

---
updated-dependencies:
- dependency-name: typedoc
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-26 22:10:09 +01:00
Florin Barbu 7af6b71d24
upgrade nwaku to v0.25 (#1861) 2024-02-22 16:04:43 +02:00
Arseniy Klempner 26eb7dd540
Merge pull request #1856 from waku-org/feat/rpc-to-rest
feat: migrates e2e tests to use rest instead of rpc
2024-02-19 07:39:15 -08:00
Arseniy Klempner 6009af7453
feat: migrates e2e tests to use rest instead of rpc 2024-02-16 18:52:51 -08:00
Danish Arora 199f6ab2ff
feat: local discovery (#1811)
* initialise the new package

* feat: implement LocalStorageDiscovery

* add: Startable to cspell

* add compliance test

* add: discovery tests

* rm: browser tests script

* address comments

* add type safety to getting peers from local

* only dispatch peer if it does not exist

* move ws ma extraction to utils

* chore: update package name to local-discovery

* fix: add compliance test with no external deps on service node

* use peer:identify instead of peer:update

* add: unit tests & remove sdk dependency

* move tests to self package

* update cspell + remove unrequired deps

* add types

* maintain in-memory peers for localstorage

* address comments

* chore: rename

* use name from options

* fix: saving peers

* rm: only
2024-02-16 20:06:27 +05:30
Arseniy Klempner aabd907f6a
Merge pull request #1852 from waku-org/feat/messages-subscription-rest
feat: switches to REST for calling nwaku messages/subscription endpoints
2024-02-15 14:58:08 -08:00
Arseniy Klempner 739f2bc2c9
feat: switches to REST for calling nwaku messages/subscription endpoints
This commit modifies functions in ServiceNode to use the REST API
instead of JSON RPC when reading messages for a pubsub topic or
content topic, and when ensuring a nwaku node is subscribed to a
pubsub topic. Also modifies default Docker params to enable the
rest API and provide a port.
2024-02-15 14:39:40 -08:00
dependabot[bot] a787e306b9
chore(deps)(deps): bump @libp2p/ping from 1.0.9 to 1.0.11 (#1851)
Bumps [@libp2p/ping](https://github.com/libp2p/js-libp2p) from 1.0.9 to 1.0.11.
- [Release notes](https://github.com/libp2p/js-libp2p/releases)
- [Changelog](https://github.com/libp2p/js-libp2p/blob/main/.release-please.json)
- [Commits](https://github.com/libp2p/js-libp2p/compare/ping-v1.0.9...ping-v1.0.11)

---
updated-dependencies:
- dependency-name: "@libp2p/ping"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-15 19:35:23 +01:00
Florin Barbu de5be4413b
chore: use graceful timeout mechanism (#1841)
* use graceful timeout mechanism

* set max timeout for all hooks

* small fix

* small fix

* use MOCHA_HOOK_MAX_TIMEOUT as default timeoutDuration

* force retry even when the hook fails

* use custom hooks

* fix global timeout problem

* fix unwanted change

* fix enr issue

* force retry on before error as well
2024-02-15 08:50:03 +02:00
Florin Barbu a9fb796a7b
chore: nwaku latest fixes (#1844)
* nwaku latest fixes

* small fixes

* other fixes

* other fixes
2024-02-14 10:45:00 +02:00
Sasha 90fc9a3e94
chore: fix export of crypto submodule (#1849) 2024-02-14 01:57:52 +01:00
dependabot[bot] 275499c315
chore(deps)(deps-dev): bump mocha from 10.2.0 to 10.3.0 (#1847)
Bumps [mocha](https://github.com/mochajs/mocha) from 10.2.0 to 10.3.0.
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mochajs/mocha/compare/v10.2.0...v10.3.0)

---
updated-dependencies:
- dependency-name: mocha
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-13 22:21:57 +05:30
dependabot[bot] c6b31c38e2
chore(deps)(deps-dev): bump karma-webkit-launcher from 2.1.0 to 2.4.0 (#1839)
Bumps [karma-webkit-launcher](https://github.com/google/karma-webkit-launcher) from 2.1.0 to 2.4.0.
- [Commits](https://github.com/google/karma-webkit-launcher/commits)

---
updated-dependencies:
- dependency-name: karma-webkit-launcher
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-12 23:40:47 +01:00
dependabot[bot] 73d66ea7d9
chore(deps)(deps-dev): bump lint-staged from 14.0.1 to 15.2.2 (#1842)
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 14.0.1 to 15.2.2.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Changelog](https://github.com/lint-staged/lint-staged/blob/master/CHANGELOG.md)
- [Commits](https://github.com/okonet/lint-staged/compare/v14.0.1...v15.2.2)

---
updated-dependencies:
- dependency-name: lint-staged
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-12 22:52:19 +01:00
dependabot[bot] 51ec7d9510
chore(deps)(deps-dev): bump @types/sinon from 17.0.2 to 17.0.3 (#1840)
Bumps [@types/sinon](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sinon) from 17.0.2 to 17.0.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sinon)

---
updated-dependencies:
- dependency-name: "@types/sinon"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Danish Arora <35004822+danisharora099@users.noreply.github.com>
2024-02-12 16:29:54 +05:30
Florin Barbu 928e634677
test: connection manager (#1836)
* connection management tests

* remove stric checks in test dev tsconfig

* fix after ci run

* small fix

* fix conflict

* fixes after ci run

* debug ci failure

* revert debug test
2024-02-10 11:57:01 +02:00
dependabot[bot] a717708f37
chore(deps)(deps): bump fast-check from 3.15.0 to 3.15.1 (#1837)
Bumps [fast-check](https://github.com/dubzzz/fast-check/tree/HEAD/packages/fast-check) from 3.15.0 to 3.15.1.
- [Release notes](https://github.com/dubzzz/fast-check/releases)
- [Changelog](https://github.com/dubzzz/fast-check/blob/main/packages/fast-check/CHANGELOG.md)
- [Commits](https://github.com/dubzzz/fast-check/commits/v3.15.1/packages/fast-check)

---
updated-dependencies:
- dependency-name: fast-check
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-09 00:06:00 +01:00
Arseniy Klempner f6b62b848b
Merge pull request #1827 from waku-org/chore/autosharding-test-vectors
chore: add autosharding test vectors
2024-02-08 11:04:06 -08:00
Arseniy Klempner 7e88d3b565
chore: add autosharding test vectors 2024-02-08 10:42:41 -08:00
Arseniy Klempner 1ffa5db7e7
Merge pull request #1816 from waku-org/feat/decouple-sharding-params
feat: decouple sharding params out of core
2024-02-08 10:42:07 -08:00
Arseniy Klempner e138b4f5c4
feat: decouple sharding params out of core 2024-02-08 08:42:47 -08:00
Danish Arora 601f78a8c0
chore: use updated flag for eslint (#1831) 2024-02-08 12:25:00 +05:30
dependabot[bot] b875569f41
chore(deps)(deps-dev): bump @typescript-eslint/parser (#1832)
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 6.7.5 to 6.21.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.21.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-07 23:40:06 +01:00
dependabot[bot] 1c5a359463
chore(deps)(deps-dev): bump @types/uuid from 9.0.7 to 9.0.8 (#1833)
Bumps [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) from 9.0.7 to 9.0.8.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid)

---
updated-dependencies:
- dependency-name: "@types/uuid"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-07 17:07:27 +01:00
dependabot[bot] be54c2e3e1
chore(deps)(deps-dev): bump dotenv-flow from 3.3.0 to 4.1.0 (#1830)
Bumps [dotenv-flow](https://github.com/kerimdzhanov/dotenv-flow) from 3.3.0 to 4.1.0.
- [Release notes](https://github.com/kerimdzhanov/dotenv-flow/releases)
- [Changelog](https://github.com/kerimdzhanov/dotenv-flow/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kerimdzhanov/dotenv-flow/compare/v3.3.0...v4.1.0)

---
updated-dependencies:
- dependency-name: dotenv-flow
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-07 12:07:53 +05:30
dependabot[bot] 8fb0a74767
chore(deps)(deps): bump uint8arrays from 4.0.6 to 5.0.1 (#1829)
Bumps [uint8arrays](https://github.com/achingbrain/uint8arrays) from 4.0.6 to 5.0.1.
- [Release notes](https://github.com/achingbrain/uint8arrays/releases)
- [Changelog](https://github.com/achingbrain/uint8arrays/blob/main/CHANGELOG.md)
- [Commits](https://github.com/achingbrain/uint8arrays/compare/v4.0.6...v5.0.1)

---
updated-dependencies:
- dependency-name: uint8arrays
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-07 01:38:10 +01:00
Danish Arora f8e02ab19e
fix(tests): append `p2p` with the multiaddrs from ENR (#1817)
* append `p2p` with the multiaddrs from ENR

* fix(tests): add p2p checks for ENR multiaddrs

* fix(tests): type getter

* chore(ci): remove debug flag from nwaku_master and go-waku tests
2024-02-07 01:57:41 +05:30
dependabot[bot] 749d84d5e4
chore(deps)(deps-dev): bump cspell from 7.3.6 to 8.3.2 (#1825)
Bumps [cspell](https://github.com/streetsidesoftware/cspell) from 7.3.6 to 8.3.2.
- [Release notes](https://github.com/streetsidesoftware/cspell/releases)
- [Changelog](https://github.com/streetsidesoftware/cspell/blob/main/CHANGELOG.md)
- [Commits](https://github.com/streetsidesoftware/cspell/compare/v7.3.6...v8.3.2)

---
updated-dependencies:
- dependency-name: cspell
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-05 22:57:20 +01:00
dependabot[bot] 3c0806b224
chore(deps)(deps-dev): bump @types/mocha from 10.0.1 to 10.0.6 (#1824)
Bumps [@types/mocha](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mocha) from 10.0.1 to 10.0.6.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mocha)

---
updated-dependencies:
- dependency-name: "@types/mocha"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-05 22:41:46 +01:00
dependabot[bot] 9b8f1d4a7a
chore(deps)(deps-dev): bump typedoc from 0.25.4 to 0.25.7 (#1805)
Bumps [typedoc](https://github.com/TypeStrong/TypeDoc) from 0.25.4 to 0.25.7.
- [Release notes](https://github.com/TypeStrong/TypeDoc/releases)
- [Changelog](https://github.com/TypeStrong/typedoc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/TypeStrong/TypeDoc/compare/v0.25.4...v0.25.7)

---
updated-dependencies:
- dependency-name: typedoc
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-02-02 00:31:41 +01:00
dependabot[bot] 28f441bc88
chore(deps)(deps): bump @libp2p/interface-compliance-tests (#1813)
Bumps [@libp2p/interface-compliance-tests](https://github.com/libp2p/js-libp2p) from 5.1.2 to 5.2.0.
- [Release notes](https://github.com/libp2p/js-libp2p/releases)
- [Changelog](https://github.com/libp2p/js-libp2p/blob/main/.release-please.json)
- [Commits](https://github.com/libp2p/js-libp2p/compare/peer-collections-v5.1.2...utils-v5.2.0)

---
updated-dependencies:
- dependency-name: "@libp2p/interface-compliance-tests"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-31 23:14:04 +01:00
Florin Barbu 87998700e5
remove go waku tests from ci (#1821) 2024-01-31 18:22:26 +02:00
Florin Barbu dbb51e4c86
test: fix for nwaku 24 (#1820)
* bump nwaku to v0.24.0

* fix tests on nwaku 0.24

* fix multiple service node filter sub tests

* fix timeout for metadata tests
2024-01-31 17:31:09 +02:00
Arseniy Klempner 66824d6daa
Merge pull request #1780 from waku-org/adklempner/default-cluster-id
feat: set cluster ID as optional when specifying shard info
2024-01-24 08:33:10 -08:00
Arseniy Klempner 68d3229644
feat: make ShardingParams optional in sdk, required internally 2024-01-24 07:36:00 -08:00