Commit Graph

1519 Commits

Author SHA1 Message Date
Steven Allen 1e4ce46ca7 test(id): fix nits 2020-06-04 14:55:17 -07:00
Steven Allen 1dd7a8c4d4 fix: count observations with at least one inbound connection as inbound
We prefer addresses from inbound connections. We don't want outbound connections
to hide these perfectly good addresses.
2020-06-04 14:55:13 -07:00
Steven Allen 6ca83309d2 fix(mocknet): set inbound/outbound on the right link 2020-06-04 14:55:13 -07:00
Steven Allen a0813d7292 fix: make address observation types private
We don't use and/or expose these anyways. Making them private makes it easier to
reason about their state.
2020-06-04 14:55:10 -07:00
Steven Allen 67eb8b1e93
Merge pull request #958 from libp2p/feat/signed-records-chunking
Chunking large Identify responses with Signed Records
2020-06-03 16:11:53 -07:00
Steven Allen b22add866a fix: remove more field
We no longer need it now that we keep reading till the stream closes.
2020-06-03 15:41:08 -07:00
Aarsh Shah 513e13d0d2 changes as per review 2020-06-03 15:27:03 -07:00
Aarsh Shah c4a1e220ac test large push msgs 2020-06-03 15:27:02 -07:00
Aarsh Shah 60b52f10ae more protocol strings 2020-06-03 15:27:02 -07:00
Aarsh Shah 1b36fd8697 first draft 2020-06-03 15:27:01 -07:00
vyzo 0d11b096d2
Merge pull request #959 from libp2p/gomod/update
gomod: update dependencies
2020-06-03 23:22:46 +03:00
vyzo ae7645ce85 gomod: update dependencies
go-libp2p-core@v0.5.7
go-libp2p-connmgr@v0.2.4 [indirect]
go-eventbus@v0.2.1
2020-06-03 22:44:35 +03:00
Aarsh Shah 6b34fff392
fixed compilation error (#956) 2020-05-29 19:55:04 +05:30
Aarsh Shah 3a1d20b748
Filter Interface Addresses (#936)
* Filter Host Addresses
2020-05-29 19:46:58 +05:30
Steven Allen 294ba3dfac
Merge pull request #953 from libp2p/fix/remove-addresses-immediately
fix: remove old addresses in identify immediately
2020-05-27 19:14:33 -07:00
Steven Allen be70fa2460 test: fix test for immediately forgetting addresses 2020-05-27 16:58:53 -07:00
Steven Allen 59062c6d6d fix: remove old addresses in identify immediately
Previously, we'd keep addresses discovered through the DHT for up to 2
minutes (temporary TTL) and previously seen addresses (recently connected) for
up to 10 minutes (the TTL).

1. Make sure to downgrade both connected and recently connected addresses to the
"temporary" ttl before adding new addresses.
2. Finally, downgrade addresses with the temporary TTL to 0.

This could be more efficient with a better peerstore abstraction, but this is
better than nothing.
2020-05-27 16:22:39 -07:00
Aarsh Shah 0dd65a5998
fix flaky test (#952)
Fix flaky TestIdentifyPushOnAddrChange
2020-05-21 12:02:29 +05:30
Steven Allen f6d0327e34
Merge pull request #949 from libp2p/feat/group-exclude-port
fix: group observations by zeroing port
2020-05-20 15:32:57 -07:00
Steven Allen 6ef5f5dacf fix: group observations by zeroing port
In #917, we started dropping additional address observations if we had multiple
for the same transport set. However, on further consideration, this isn't quite
correct. We _want_ to keep additional observations for multiple IP addresses.
The real issue is many observations for different ports.

So this patch simply changes the key with which we group observations from
"address protocols" to "address without the port" (well, with the port set to
0).
2020-05-20 12:13:25 -07:00
Steven Allen b396e69aee
Merge pull request #948 from libp2p/fix/ctor
fix: fix connection gater in transport constructor
2020-05-20 11:23:33 -07:00
Steven Allen 46b58740de fix: fix connection gater in transport constructor 2020-05-20 11:09:00 -07:00
Steven Allen 3bf5baf905
Merge pull request #945 from libp2p/feat/944
Fix potential flakiness in TestIDService
2020-05-20 10:28:37 -07:00
Raúl Kripalani d4d6adff6e
make the {F=>f}iltersConnectionGater private. (#946) 2020-05-20 16:27:31 +01:00
Aarsh Shah ba118a4d14 create subscriber first 2020-05-20 15:10:04 +05:30
Aarsh Shah 79ead33e32
Filter observed addresses (#917)
* filter observed addrs
2020-05-20 11:39:45 +05:30
Steven Allen 937067939b
Merge pull request #943 from libp2p/fix/record-panic
fix: don't try to marshal a nil record
2020-05-19 18:37:40 -07:00
Steven Allen 01da330ef2 fix: don't try to marshal a nil record
fixes #939
2020-05-19 18:15:33 -07:00
Steven Allen aa60461752
Merge pull request #941 from libp2p/test/peer-records-no-listen-addrs
add test to demo missing peer records after listen
2020-05-19 18:10:57 -07:00
Steven Allen 15637fc34b
Merge pull request #942 from libp2p/fix/peer-handler-empty
fix: don't leak a goroutine if a peer connects and immediately disconnects
2020-05-19 13:51:19 -07:00
Steven Allen e3a983a355 fix: don't leak a goroutine if a peer connects and immediately disconnects 2020-05-19 13:37:52 -07:00
Yusef Napora 82c11bce2a sleep longer in test 2020-05-19 16:15:28 -04:00
Yusef Napora bd9e7b59ce detect listen addr changes in BasicHost 2020-05-19 16:12:56 -04:00
Yusef Napora 3364dccbbf make test fail to demonstrate issue 2020-05-19 14:38:25 -04:00
Yusef Napora 0d6e02e95b add test to demo missing peer records after listen 2020-05-19 14:20:24 -04:00
Raúl Kripalani 7abe2e4c63
release v0.9.0: upgrade dependencies. (#937) 2020-05-19 13:23:26 +01:00
Aarsh Shah a7671efe6b
no signed peer records for mocknets (#934)
* Disable generation of Signed peer record for Mockenets.
2020-05-19 13:16:54 +05:30
Aarsh Shah 887f2c40cf
implement connection gating at the top level (#881) 2020-05-15 17:31:03 +01:00
Steven Allen b42ba0faf3
various identify fixes and nits (#922)
* various identify fixes and nits

Co-authored-by: Aarsh Shah <aarshkshah1992@gmail.com>
2020-05-14 17:24:10 +05:30
Aarsh Shah 973933ad7d
Remove race between ID, Push & Delta (#907)
* Solve races between Identify, Push and Delta.
2020-05-13 10:50:37 +05:30
Raúl Kripalani d9d18512ca
fix a compilation error introduced in 077a818. (#919) 2020-05-12 17:24:58 +01:00
Yusef Napora 077a81814f
exchange signed routing records in identify (#747)
*  Exchange signed routing records in identify


Co-authored-by: Aarsh Shah <aarshkshah1992@gmail.com>
2020-04-30 11:06:31 +05:30
Steven Allen c833e2c9fc
Merge pull request #876 from libp2p/dependabot/go_modules/github.com/libp2p/go-libp2p-peerstore-0.2.3
build(deps): bump github.com/libp2p/go-libp2p-peerstore from 0.2.2 to 0.2.3
2020-04-27 19:46:37 -07:00
Steven Allen 9cc9d5c201
Merge pull request #893 from libp2p/dependabot/go_modules/github.com/libp2p/go-stream-muxer-multistream-0.3.0
build(deps): bump github.com/libp2p/go-stream-muxer-multistream from 0.2.0 to 0.3.0
2020-04-27 19:46:13 -07:00
Steven Allen 6dc5d50fc5
Merge pull request #892 from libp2p/dependabot/go_modules/github.com/libp2p/go-conn-security-multistream-0.2.0
build(deps): bump github.com/libp2p/go-conn-security-multistream from 0.1.0 to 0.2.0
2020-04-27 19:45:51 -07:00
Steven Allen 34867586a3
Merge pull request #895 from libp2p/dependabot/go_modules/github.com/libp2p/go-ws-transport-0.3.1
build(deps): bump github.com/libp2p/go-ws-transport from 0.3.0 to 0.3.1
2020-04-27 19:45:42 -07:00
Steven Allen 75a12253a3
Merge pull request #896 from libp2p/dependabot/go_modules/github.com/libp2p/go-libp2p-discovery-0.4.0
build(deps): bump github.com/libp2p/go-libp2p-discovery from 0.3.0 to 0.4.0
2020-04-27 19:45:31 -07:00
Steven Allen 2d308cd9af
Merge pull request #901 from libp2p/dependabot/go_modules/github.com/libp2p/go-libp2p-circuit-0.2.2
build(deps): bump github.com/libp2p/go-libp2p-circuit from 0.2.1 to 0.2.2
2020-04-27 19:45:23 -07:00
dependabot-preview[bot] 408e4d1286
build(deps): bump github.com/libp2p/go-libp2p-circuit
Bumps [github.com/libp2p/go-libp2p-circuit](https://github.com/libp2p/go-libp2p-circuit) from 0.2.1 to 0.2.2.
- [Release notes](https://github.com/libp2p/go-libp2p-circuit/releases)
- [Commits](https://github.com/libp2p/go-libp2p-circuit/compare/v0.2.1...v0.2.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-27 11:27:49 +00:00
Steven Allen ef1cfe78bd
Merge pull request #899 from libp2p/fix/obserations
fix: keep observed addrs alive as long as their associated connections are alive
2020-04-24 23:58:02 -07:00