Commit Graph

1092 Commits

Author SHA1 Message Date
Chris Beams 3a22a83be7
Configure Travis to notify Gitter on failure and first success
See https://gitter.im/ethereum/ethereumj
2015-01-20 12:34:28 +01:00
Chris Beams 9127c01890
Polish formatting
The sources affected by this commit have drifted in style since earlier
polishing commits such as f34d1f4 and a155518. The shared IDEA style
configuration file can help avoid this drift in the future. Simply run
Code->Reformat Code at the project level prior to committing. Note that
this code style configuration is not perfect, and not every change it
makes should be checked in. The ideal is to simply always write code that
conforms to the style conventions, but the automated settings are there
as a helping hand when necessary.

The churn caused by drifting style and the commits that fix it damage the
utility of git over time. Reviewing changes, analyzing history, surgically
reverting commits, and many other use cases with git simply do not work as
well when styles get mixed and fixed. Let's work toward a common style.
2015-01-20 12:20:09 +01:00
Chris Beams 38c241f9e6
Disable Javadoc formatting in shared IDEA style config
We do not (yet) have an agreed-upon approach to Javadoc content and
style, therefore disable automatic formatting from within IDEA for now.
2015-01-20 12:20:09 +01:00
Chris Beams 60b51b4aa6
Use @Ignore annotation from JUnit vs. Nashhorn 2015-01-20 12:20:08 +01:00
Chris Beams 2d785f9406
Optimize imports using shared IDEA configuration
The affected sources have drifted from import organization conventions
since the shared IDEA configuration was added in commit a155518. There
are several ways to avoid this in the future:

 1. Run Code->Optimize Imports manually prior to making any commit (or
    use the shortcut key).
 2. Select 'Optimize Imports on the Fly' from
    Preferences->Editor->General->Auto Import.

If IDEA is not being used, simply follow convention.
2015-01-20 12:20:08 +01:00
Chris Beams ee0e3e8aea
Strip trailing whitespace
Trailing whitespace has crept into the sources affected by this commit
since the original stripping in commit e5fcf5b. Editors and IDEs should
be configured to strip trailing whitespace on save, or in any case
trailing whitespace should be manually stripped prior to commit/push.
2015-01-20 12:20:07 +01:00
Chris Beams d55bc10a1a
Polish Javadoc
Fix syntax for @author and @since tags, for the same reasons detailed in
commits 7d2cf7f and c38907b, respectively.

Recommendations:

 - Disable automatic Javadoc templates completely within IDEA.
 - Add Javadoc by hand when new classes are created.
 - Follow the proper conventions for `@author` and `@since` tags.
 - Do not add @since tags in src/test classes. Javadoc for these types
   will never be generated or published, and developers can query
   creation date metadata (more accurately) from git for these classes.

Note that in the future--particularly once ethereumj has its own
independent versioning--it will be desirable to use `@since` tags with
version values (for semantic versioning clarity, backward compatibility
analysis and communication, etc). Until then, the `@since DD.MM.YY`
approach will suffice.
2015-01-20 12:14:36 +01:00
Chris Beams a3a180dc59
Revert "Add --debug flag to Travis gradle script config"
This reverts commit 12991a227a.
2015-01-20 12:03:13 +01:00
Roman Mandeleil 79459a47b6 Fix property string 2015-01-20 12:51:29 +02:00
Roman Mandeleil 12991a227a Update .travis.yml 2015-01-19 22:31:46 +02:00
Roman Mandeleil a9b410b38a Fix file encoding for testing 2015-01-19 22:18:14 +02:00
Roman Mandeleil 780f0dce3e Fix test insolation 2015-01-19 20:48:52 +02:00
Roman Mandeleil 3fd0b47b1c Define config for key/val datasource selection 2015-01-19 20:28:56 +02:00
Roman Mandeleil 193f217b81 Connect KeyValueDataSource abstraction to the rest of the application
Repository , Trie implementation and Cache now going to the data through KeyValueDatasource
2015-01-19 19:34:00 +02:00
Roman Mandeleil 38cf19015b Introduce usage of key/val data source as abstraction
Implement Redis  key/val datasource
Implement LevelDb key/val datasource
2015-01-18 23:32:30 +02:00
Roman Mandeleil 5ead5a5da0 Merge pull request #203 from ligi/ligi/code_review/fix_typos_and_cleanup2
remove typos / add missing modifiers / code cleanup
2015-01-18 23:22:49 +02:00
ligi 0c96950e0e remove typos / add missing modifiers / code cleanup 2015-01-18 19:25:06 +01:00
Roman Mandeleil d097a56644 Introduce onHandShakePeer() callback will expose HelloMessage 2015-01-16 10:46:29 +02:00
Roman Mandeleil c7638c2617 Introduce getChannel() by peerId 2015-01-16 10:46:28 +02:00
Roman Mandeleil bbb9e9e303 Add onHandShakePeer() to EthereumListener 2015-01-16 10:46:28 +02:00
Roman Mandeleil c89e591d9e Merge pull request #201 from Bitcoinzie/patch-1
Update README.md
2015-01-15 17:37:33 +02:00
Roman Mandeleil 84e62f700f Merge pull request #202 from Bitcoinzie/patch-2
Adjust properties for poc-8
2015-01-15 17:37:27 +02:00
Bitcoinzie 03a25e841c Adjust properties for poc-8 2015-01-15 01:04:25 -08:00
Roman Mandeleil db413d3496 Merge pull request #199 from ligi/ligi/code_review/fix_typos_and_cleanup
fix some typos  and do some cleanup
2015-01-15 09:24:51 +02:00
Bitcoinzie 3056dcab92 Update README.md
Changed snapshot version number to reflect poc-8 changes
2015-01-14 22:30:21 -08:00
ligi 6f0ca3e635 more typo removal 2015-01-15 00:07:55 +01:00
ligi 15971ed797 fix some typos and do some cleanup 2015-01-14 23:47:29 +01:00
Roman Mandeleil e56dfacaae Merge remote-tracking branch 'origin/master' 2015-01-14 11:47:58 +02:00
Roman Mandeleil 8112d87b86 Exclude new tests that doesn't pass 2015-01-14 11:47:41 +02:00
Roman Mandeleil bed4e9f8a8 upgrade to POC-8 2015-01-14 11:42:19 +02:00
Roman Mandeleil 2243c765da Merge pull request #197 from ligi/ligi/code_review/speed_improvements
speed improvements, simplification and add test-cases
2015-01-10 22:54:50 +02:00
ligi 59a5baff81 we want EMPTY_BYTE_ARRAY 2015-01-10 21:37:40 +01:00
ligi 3a8258a07e use the available ZERO_BYTE_ARRAY 2015-01-10 21:05:00 +01:00
ligi 9ab5c21fdd speed improvements and add test-cases 2015-01-10 20:37:51 +01:00
Roman Mandeleil 910a8b9552 Comment gas charge for pre-compiled contracts 2015-01-10 16:20:08 +02:00
Roman Mandeleil e3b1e3aa1e Polish some. 2015-01-09 18:14:26 +02:00
Roman Mandeleil b017df080b Implement pre-compiled contract
In order to improve performance of certain VM functionality
 Ethereum introduce plug-in mechanism  called pre-compiled
 contracts.

 Supported functionality:

  ecRecover - (addr: 01) - recover address out of hash, v, r, s - parameters.
  sha256 - (addr: 02) - calculate hash value with sha256 algorithm
  ripempd160 - (addr:03)  - calculate hash value with repimpd algorithm
2015-01-09 16:41:36 +02:00
Roman Mandeleil 620f365205 Fix payment availability: sender.balance >= tx.value + tx.gas 2015-01-08 20:26:24 +02:00
Roman Mandeleil 18ed198750 Return stRecursiveCreate to the testing run 2015-01-08 20:01:42 +02:00
Roman Mandeleil 8bbdc3ae31 Merge remote-tracking branch 'origin/master' 2015-01-08 19:50:05 +02:00
Roman Mandeleil 7590efdb3b Remove cpp snippet 2015-01-08 19:49:12 +02:00
Roman Mandeleil 48b27d38ec Validate JUMPDEST by pre-compile + tweak injection of blockStore by the new interface 2015-01-08 19:48:37 +02:00
Roman Mandeleil 59833f3fd6 Fix BLOCKHASH op new rule
The blockhash retrieved by index on one of the
recent 256 blocks. If the index is out of that
window zero pushed into the stack as a result
2015-01-08 18:55:52 +02:00
Chris Beams c3a5dd960b
Update Travis build script and cache directories 2015-01-07 09:25:21 +01:00
Chris Beams 2af33195da
Set VM log level to ERROR for fast test execution 2015-01-07 09:17:12 +01:00
Chris Beams 84b1cef682
Increase stack size during testing
This is in order to accommodate GitHubStateTest#stSystemOperationsTest,
which tests Ethereum's rules around maximum call stack depth, and thus
requires increasing Java's own defaults.

If this option is not set, this test results in a
StackOverflowException. Note that the setting is applied to Gradle's
`test` closure as opposed to a the global `JAVA_OPTS` environment
variable, because Gradle spawns a new process for executing tests.
2015-01-07 08:55:49 +01:00
Chris Beams 11e8a55304
Revert "Ignore GitHubStateTest#stSystemOperationsTest"
This reverts commit 52b417947b.
2015-01-07 08:15:19 +01:00
Chris Beams 6ab3fb3eca
Enable Travis CI's new container-based infrastructure
This is being done in order to enable Travis's new caching functionality
and thus to speed up the build. See previous commit adding the `cache`
section to .travis.yml, and see also:

http://docs.travis-ci.com/user/workers/container-based-infrastructure/
2015-01-07 07:13:05 +01:00
Chris Beams 3f3f577fc4
Improve visibility of JAVA_OPTS env var in .travis.yml 2015-01-07 07:08:39 +01:00
Chris Beams 1eeb9e662c
Update JAVA_OPTS in `env` section of .travis.yml 2015-01-07 07:01:36 +01:00