clean up TODO list after talk with Roman
This commit is contained in:
Yaroslav Dmytrotsa
parent
cecad8cfd3
commit
33be741881
|
|
@ -5,10 +5,6 @@ import com.thetransactioncompany.jsonrpc2.server.*;
|
|||
import org.ethereum.android.jsonrpc.JsonRpcServerMethod;
|
||||
import org.ethereum.facade.Ethereum;
|
||||
|
||||
/*
|
||||
No matter how long I wait on synchronization - all time got best block number = 0
|
||||
TODO: check this after Adrian finish db implementation.
|
||||
*/
|
||||
public class eth_blockNumber extends JsonRpcServerMethod {
|
||||
|
||||
public eth_blockNumber (Ethereum ethereum) {
|
||||
|
|
|
|||
|
|
@ -11,10 +11,6 @@ import org.ethereum.vm.VM;
|
|||
import org.spongycastle.util.encoders.Hex;
|
||||
import java.util.List;
|
||||
|
||||
/*
|
||||
It's magic here, not sure if -core have this possibility at all. I found this in test and studio. But not sure that getHReturn it's what specification mean.
|
||||
TODO: get advice from Roman
|
||||
*/
|
||||
public class eth_call extends JsonRpcServerMethod {
|
||||
|
||||
public eth_call (Ethereum ethereum) {
|
||||
|
|
|
|||
|
|
@ -11,10 +11,6 @@ import org.ethereum.vm.VM;
|
|||
import org.spongycastle.util.encoders.Hex;
|
||||
import java.util.List;
|
||||
|
||||
/*
|
||||
It's magic here, not sure if -core have this possibility at all. I found this in test and studio. But not sure that getHReturn it's what specification mean.
|
||||
TODO: get advice from Roman
|
||||
*/
|
||||
public class eth_estimateGas extends JsonRpcServerMethod {
|
||||
|
||||
public eth_estimateGas (Ethereum ethereum) {
|
||||
|
|
|
|||
|
|
@ -9,9 +9,6 @@ import org.spongycastle.util.encoders.Hex;
|
|||
import java.math.BigInteger;
|
||||
import java.util.List;
|
||||
|
||||
/*
|
||||
TODO: ask roman advice for this method.
|
||||
*/
|
||||
public class eth_getBalance extends JsonRpcServerMethod {
|
||||
|
||||
public eth_getBalance (Ethereum ethereum) {
|
||||
|
|
|
|||
|
|
@ -6,9 +6,6 @@ import org.ethereum.android.jsonrpc.JsonRpcServerMethod;
|
|||
import org.ethereum.facade.Ethereum;
|
||||
import java.util.ArrayList;
|
||||
|
||||
/*
|
||||
As I see right now -core have only serpent compiler
|
||||
*/
|
||||
public class eth_getCompilers extends JsonRpcServerMethod {
|
||||
|
||||
public eth_getCompilers (Ethereum ethereum) {
|
||||
|
|
|
|||
|
|
@ -7,9 +7,6 @@ import org.ethereum.core.TransactionReceipt;
|
|||
import org.ethereum.facade.Ethereum;
|
||||
import java.util.List;
|
||||
|
||||
/*
|
||||
TODO: get advice from Roman about get block from transaction.
|
||||
*/
|
||||
public class eth_getTransactionByHash extends JsonRpcServerMethod {
|
||||
|
||||
public eth_getTransactionByHash (Ethereum ethereum) {
|
||||
|
|
|
|||
|
|
@ -12,10 +12,6 @@ import java.math.BigInteger;
|
|||
import java.util.Arrays;
|
||||
import java.util.List;
|
||||
|
||||
/*
|
||||
Can't find correct way to get contracts' state for specified block number. Right now method return correct value only for "latest" parameter
|
||||
TODO: ask roman advice for this method.
|
||||
*/
|
||||
public class eth_getTransactionCount extends JsonRpcServerMethod {
|
||||
|
||||
public eth_getTransactionCount(Ethereum ethereum) { super(ethereum); }
|
||||
|
|
|
|||
|
|
@ -6,10 +6,6 @@ import org.ethereum.android.jsonrpc.JsonRpcServerMethod;
|
|||
import org.ethereum.facade.Ethereum;
|
||||
import java.util.List;
|
||||
|
||||
/*
|
||||
Not sure if pending transactions can have uncle.
|
||||
TODO: ask Roman about this
|
||||
*/
|
||||
public class eth_getUncleCountByBlockNumber extends JsonRpcServerMethod {
|
||||
|
||||
public eth_getUncleCountByBlockNumber (Ethereum ethereum) {
|
||||
|
|
|
|||
|
|
@ -15,10 +15,6 @@ import java.util.concurrent.TimeUnit;
|
|||
import static org.ethereum.core.Denomination.SZABO;
|
||||
import static org.ethereum.config.SystemProperties.CONFIG;
|
||||
|
||||
/*
|
||||
Not sure if we must call submitTransaction from here but logically to do it. Also not clear how created transaction added to pending and to "from" account pending (in test - it didn't)
|
||||
TODO: get advice from Roman. By spec if created transaction (empty data param) - result must be 20 bytes hash, but I got 32 bytes for both contract and transaction create.
|
||||
*/
|
||||
public class eth_sendTransaction extends JsonRpcServerMethod {
|
||||
|
||||
public eth_sendTransaction (Ethereum ethereum) {
|
||||
|
|
|
|||
|
|
@ -5,9 +5,6 @@ import com.thetransactioncompany.jsonrpc2.server.*;
|
|||
import org.ethereum.android.jsonrpc.JsonRpcServerMethod;
|
||||
import org.ethereum.facade.Ethereum;
|
||||
|
||||
/*
|
||||
TODO: right now -core not mark fact of start listening, it do it automatically and only send Listening trace "string" message.
|
||||
*/
|
||||
public class net_listening extends JsonRpcServerMethod {
|
||||
|
||||
public net_listening (Ethereum ethereum) {
|
||||
|
|
|
|||
|
|
@ -8,9 +8,6 @@ import org.ethereum.facade.Ethereum;
|
|||
|
||||
import java.util.List;
|
||||
|
||||
/*
|
||||
TODO: done it when shh will be ready in -core
|
||||
*/
|
||||
public class shh_getFilterChanges extends JsonRpcServerMethod {
|
||||
|
||||
public shh_getFilterChanges(Ethereum ethereum) {
|
||||
|
|
|
|||
|
|
@ -8,9 +8,6 @@ import org.ethereum.facade.Ethereum;
|
|||
|
||||
import java.util.List;
|
||||
|
||||
/*
|
||||
TODO: done it when shh will be ready in -core
|
||||
*/
|
||||
public class shh_getMessages extends JsonRpcServerMethod {
|
||||
|
||||
public shh_getMessages(Ethereum ethereum) {
|
||||
|
|
|
|||
|
|
@ -12,9 +12,6 @@ import org.ethereum.facade.Ethereum;
|
|||
|
||||
import java.util.List;
|
||||
|
||||
/*
|
||||
TODO: done it when shh will be ready in -core
|
||||
*/
|
||||
public class shh_newFilter extends JsonRpcServerMethod {
|
||||
|
||||
public shh_newFilter(Ethereum ethereum) {
|
||||
|
|
|
|||
|
|
@ -8,9 +8,6 @@ import org.ethereum.facade.Ethereum;
|
|||
|
||||
import java.util.List;
|
||||
|
||||
/*
|
||||
TODO: done it when shh will be ready in -core
|
||||
*/
|
||||
public class shh_uninstallFilter extends JsonRpcServerMethod {
|
||||
|
||||
public shh_uninstallFilter(Ethereum ethereum) {
|
||||
|
|
|
|||
Loading…
Reference in New Issue