From 33be741881d502f422d489145ed470331542bef7 Mon Sep 17 00:00:00 2001 From: Yaroslav Dmytrotsa Date: Fri, 26 Jun 2015 08:50:40 +0300 Subject: [PATCH] clean up TODO list after talk with Roman --- .../org/ethereum/android/jsonrpc/method/eth_blockNumber.java | 4 ---- .../java/org/ethereum/android/jsonrpc/method/eth_call.java | 4 ---- .../org/ethereum/android/jsonrpc/method/eth_estimateGas.java | 4 ---- .../org/ethereum/android/jsonrpc/method/eth_getBalance.java | 3 --- .../org/ethereum/android/jsonrpc/method/eth_getCompilers.java | 3 --- .../android/jsonrpc/method/eth_getTransactionByHash.java | 3 --- .../android/jsonrpc/method/eth_getTransactionCount.java | 4 ---- .../jsonrpc/method/eth_getUncleCountByBlockNumber.java | 4 ---- .../ethereum/android/jsonrpc/method/eth_sendTransaction.java | 4 ---- .../org/ethereum/android/jsonrpc/method/net_listening.java | 3 --- .../ethereum/android/jsonrpc/method/shh_getFilterChanges.java | 3 --- .../org/ethereum/android/jsonrpc/method/shh_getMessages.java | 3 --- .../org/ethereum/android/jsonrpc/method/shh_newFilter.java | 3 --- .../ethereum/android/jsonrpc/method/shh_uninstallFilter.java | 3 --- 14 files changed, 48 deletions(-) diff --git a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_blockNumber.java b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_blockNumber.java index 9e1e0ca3..46bb6010 100644 --- a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_blockNumber.java +++ b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_blockNumber.java @@ -5,10 +5,6 @@ import com.thetransactioncompany.jsonrpc2.server.*; import org.ethereum.android.jsonrpc.JsonRpcServerMethod; import org.ethereum.facade.Ethereum; -/* -No matter how long I wait on synchronization - all time got best block number = 0 -TODO: check this after Adrian finish db implementation. -*/ public class eth_blockNumber extends JsonRpcServerMethod { public eth_blockNumber (Ethereum ethereum) { diff --git a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_call.java b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_call.java index b1b68317..c13c9c45 100644 --- a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_call.java +++ b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_call.java @@ -11,10 +11,6 @@ import org.ethereum.vm.VM; import org.spongycastle.util.encoders.Hex; import java.util.List; -/* -It's magic here, not sure if -core have this possibility at all. I found this in test and studio. But not sure that getHReturn it's what specification mean. -TODO: get advice from Roman -*/ public class eth_call extends JsonRpcServerMethod { public eth_call (Ethereum ethereum) { diff --git a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_estimateGas.java b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_estimateGas.java index c8edab44..c21bcdf8 100644 --- a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_estimateGas.java +++ b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_estimateGas.java @@ -11,10 +11,6 @@ import org.ethereum.vm.VM; import org.spongycastle.util.encoders.Hex; import java.util.List; -/* -It's magic here, not sure if -core have this possibility at all. I found this in test and studio. But not sure that getHReturn it's what specification mean. -TODO: get advice from Roman -*/ public class eth_estimateGas extends JsonRpcServerMethod { public eth_estimateGas (Ethereum ethereum) { diff --git a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getBalance.java b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getBalance.java index a0359cfc..e084122d 100644 --- a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getBalance.java +++ b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getBalance.java @@ -9,9 +9,6 @@ import org.spongycastle.util.encoders.Hex; import java.math.BigInteger; import java.util.List; -/* -TODO: ask roman advice for this method. -*/ public class eth_getBalance extends JsonRpcServerMethod { public eth_getBalance (Ethereum ethereum) { diff --git a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getCompilers.java b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getCompilers.java index c5156e7b..a785c787 100644 --- a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getCompilers.java +++ b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getCompilers.java @@ -6,9 +6,6 @@ import org.ethereum.android.jsonrpc.JsonRpcServerMethod; import org.ethereum.facade.Ethereum; import java.util.ArrayList; -/* -As I see right now -core have only serpent compiler -*/ public class eth_getCompilers extends JsonRpcServerMethod { public eth_getCompilers (Ethereum ethereum) { diff --git a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getTransactionByHash.java b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getTransactionByHash.java index c9e1fc47..b7aa3485 100644 --- a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getTransactionByHash.java +++ b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getTransactionByHash.java @@ -7,9 +7,6 @@ import org.ethereum.core.TransactionReceipt; import org.ethereum.facade.Ethereum; import java.util.List; -/* -TODO: get advice from Roman about get block from transaction. -*/ public class eth_getTransactionByHash extends JsonRpcServerMethod { public eth_getTransactionByHash (Ethereum ethereum) { diff --git a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getTransactionCount.java b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getTransactionCount.java index e9e1c11a..c86e6cc9 100644 --- a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getTransactionCount.java +++ b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getTransactionCount.java @@ -12,10 +12,6 @@ import java.math.BigInteger; import java.util.Arrays; import java.util.List; -/* -Can't find correct way to get contracts' state for specified block number. Right now method return correct value only for "latest" parameter -TODO: ask roman advice for this method. -*/ public class eth_getTransactionCount extends JsonRpcServerMethod { public eth_getTransactionCount(Ethereum ethereum) { super(ethereum); } diff --git a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getUncleCountByBlockNumber.java b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getUncleCountByBlockNumber.java index c7e754d6..00419773 100644 --- a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getUncleCountByBlockNumber.java +++ b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_getUncleCountByBlockNumber.java @@ -6,10 +6,6 @@ import org.ethereum.android.jsonrpc.JsonRpcServerMethod; import org.ethereum.facade.Ethereum; import java.util.List; -/* -Not sure if pending transactions can have uncle. -TODO: ask Roman about this -*/ public class eth_getUncleCountByBlockNumber extends JsonRpcServerMethod { public eth_getUncleCountByBlockNumber (Ethereum ethereum) { diff --git a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_sendTransaction.java b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_sendTransaction.java index dd659d8c..30071b38 100644 --- a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_sendTransaction.java +++ b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/eth_sendTransaction.java @@ -15,10 +15,6 @@ import java.util.concurrent.TimeUnit; import static org.ethereum.core.Denomination.SZABO; import static org.ethereum.config.SystemProperties.CONFIG; -/* -Not sure if we must call submitTransaction from here but logically to do it. Also not clear how created transaction added to pending and to "from" account pending (in test - it didn't) -TODO: get advice from Roman. By spec if created transaction (empty data param) - result must be 20 bytes hash, but I got 32 bytes for both contract and transaction create. -*/ public class eth_sendTransaction extends JsonRpcServerMethod { public eth_sendTransaction (Ethereum ethereum) { diff --git a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/net_listening.java b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/net_listening.java index 67f5abaf..337ffb87 100644 --- a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/net_listening.java +++ b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/net_listening.java @@ -5,9 +5,6 @@ import com.thetransactioncompany.jsonrpc2.server.*; import org.ethereum.android.jsonrpc.JsonRpcServerMethod; import org.ethereum.facade.Ethereum; -/* -TODO: right now -core not mark fact of start listening, it do it automatically and only send Listening trace "string" message. -*/ public class net_listening extends JsonRpcServerMethod { public net_listening (Ethereum ethereum) { diff --git a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/shh_getFilterChanges.java b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/shh_getFilterChanges.java index 3bfeb761..dd068c82 100644 --- a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/shh_getFilterChanges.java +++ b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/shh_getFilterChanges.java @@ -8,9 +8,6 @@ import org.ethereum.facade.Ethereum; import java.util.List; -/* -TODO: done it when shh will be ready in -core -*/ public class shh_getFilterChanges extends JsonRpcServerMethod { public shh_getFilterChanges(Ethereum ethereum) { diff --git a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/shh_getMessages.java b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/shh_getMessages.java index 51a2dda3..7607973d 100644 --- a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/shh_getMessages.java +++ b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/shh_getMessages.java @@ -8,9 +8,6 @@ import org.ethereum.facade.Ethereum; import java.util.List; -/* -TODO: done it when shh will be ready in -core -*/ public class shh_getMessages extends JsonRpcServerMethod { public shh_getMessages(Ethereum ethereum) { diff --git a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/shh_newFilter.java b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/shh_newFilter.java index 54e2ff96..8d38fbcf 100644 --- a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/shh_newFilter.java +++ b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/shh_newFilter.java @@ -12,9 +12,6 @@ import org.ethereum.facade.Ethereum; import java.util.List; -/* -TODO: done it when shh will be ready in -core -*/ public class shh_newFilter extends JsonRpcServerMethod { public shh_newFilter(Ethereum ethereum) { diff --git a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/shh_uninstallFilter.java b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/shh_uninstallFilter.java index 0dd232f5..38f3f54b 100644 --- a/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/shh_uninstallFilter.java +++ b/ethereumj-core-android/src/main/java/org/ethereum/android/jsonrpc/method/shh_uninstallFilter.java @@ -8,9 +8,6 @@ import org.ethereum.facade.Ethereum; import java.util.List; -/* -TODO: done it when shh will be ready in -core -*/ public class shh_uninstallFilter extends JsonRpcServerMethod { public shh_uninstallFilter(Ethereum ethereum) {