cebe6ba7e7
minor formatting cleanups
2021-11-22 11:31:17 -07:00
88c76abd7f
Apply Danny's code review
2021-11-22 11:12:25 -07:00
859bbf4358
This reverts commit 4c726cdff39a10c5d096b294fb562cfc99c1f068.
2021-11-22 11:12:24 -07:00
3b20e3ea02
Apply suggestions from code review
...
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
2021-11-22 11:12:24 -07:00
b0fb861cf5
Make PROPOSER_SCORE_BOOST a percentage value
2021-11-22 11:12:24 -07:00
504d82cc1a
Add datatype to new parameters
2021-11-22 11:12:24 -07:00
47fa6d108a
Add parameter for score boost value
2021-11-22 11:12:24 -07:00
2d161b4244
Add proposer score boosting & related tests
2021-11-22 11:12:24 -07:00
3d4ece44df
port phase0 forkchocie changes to merge
2021-11-17 18:37:45 -07:00
eb00f8f735
cleanup forkchoice tests
2021-11-17 18:24:47 -07:00
d9e8306c5a
Refactoring
2021-11-13 18:38:53 +08:00
f643554aa5
Fix issue around on_attestation validation by skipping epoch scope
...
validation if attestation is from a block message
2021-11-13 18:28:05 +08:00
cd3d2ce692
working through test issues
2021-11-12 12:43:54 -07:00
15a6c48a46
Merge pull request #2518 from ethereum/fix-store-justified-checkpoint
...
Fix fork choice store checkpoints inconsistency issue
2021-08-23 23:41:11 +08:00
4c1156d504
rename eth1 and eth2 throughout specs and readme where reasonable
2021-08-18 17:13:24 -06:00
63ca480ea3
Add condition check in `on_tick` to ensure that `store.justified_checkpoint` is a descendant of `store.finalized_checkpoint`
2021-07-14 20:02:28 +08:00
e4593d2d0c
update with configs<>presets separation
2021-05-18 09:55:20 +02:00
64412be0d7
Minor update ToC
2020-12-07 11:10:19 +08:00
7589af8e8d
remove wip notice on phase 0 specs
2020-11-04 09:30:29 -06:00
6b44f63751
Merge pull request #2104 from ethereum/state_transition_patch
...
Make `state_transition` not return post-state
2020-11-03 14:57:29 -06:00
7fb9226ec6
Make `state_transition` not return post state; the given pre state should have been mutated to post state.
2020-10-15 15:58:26 +08:00
663af77737
Clean up unused variable for linter
2020-10-07 17:11:13 -07:00
d0cf4e7bad
Simplify fork choice spec
...
This change should be non-substantive as any blocks in `blocks` should be descendants (inclusive) of the `store.justified_checkpoint` (refer `get_filtered_block_tree`) so that in `get_head` all blocks considered as potential heads will have `slot > justified_slot`. Considering this condition universally applies, adding the `and ...` arm to the conditional is unnecessary overhead.
2020-10-07 16:52:51 -07:00
1e29563242
Pass `anchor_block` to `get_forkchoice_store`
2020-09-15 12:51:11 +08:00
b239f6108c
Merge branch 'dev' into hwwhww/strict-uint64
2020-06-25 17:18:16 +08:00
e61efc14a3
Merge pull request #1886 from ethereum/fix_store_target_checkpoint_state
...
Fix store_target_checkpoint_state
2020-06-22 11:38:40 -06:00
41ebd51aff
Merge branch 'dev' into hwwhww/strict-uint64
2020-06-18 02:49:09 +02:00
e955e6f6e1
Merge pull request #1884 from paulhauner/patch-25
...
Use parent_root for finalized chain check
2020-06-13 16:09:16 -05:00
fdb6f15867
unhandled exceptions do not modify forkchoice store
2020-06-13 15:59:04 -05:00
df9b5f18a4
Merge pull request #1885 from paulhauner/patch-26
...
Fork choice: minor formatting change
2020-06-13 15:51:03 -05:00
7ad1bb508d
Ensure parent is checked before store lookup
2020-06-13 16:04:16 +10:00
993ed5c2c6
Resetting branch to dev and adding single commit
2020-06-12 14:37:07 -07:00
a1a75a38fe
Tidy, add comment
2020-06-11 11:51:18 +10:00
1dc6b55617
rearrange fork choice condition for clarity
2020-06-10 09:40:34 -05:00
479c40450d
Friendly lint fix
2020-06-10 18:16:26 +08:00
29d968bb2e
Use parent_root for finalized chain check
2020-06-10 15:09:40 +10:00
378d249487
Avoid redundant call to get_ancestor
2020-06-10 11:02:10 +10:00
2a125e8497
Update fork-choice.md
2020-06-02 17:22:33 +10:00
c6aac16506
Reword fork choice comment
2020-06-02 17:16:25 +10:00
437b2ebb90
Update fork choice spec comment for clarity
...
I think this change more clearly specifies the intended behavior. Given the terseness of the spec's code representation, I think we should aim for as much clarity as possible.
2020-05-29 18:16:06 -07:00
2bf020d49d
Apply strict uint64 casting
2020-05-20 03:04:15 +08:00
b71a0ee6b9
Merge branch 'v012x' into ffg_lmd_vote_consistency
2020-05-05 13:40:27 -06:00
2dc5156651
Add message about delaying consideration
2020-04-30 16:27:02 +10:00
1a81c873af
Remove redundant check in fork choice
2020-04-26 16:24:16 +10:00
9acea51938
Simplified by re-using get_ancestor()
2020-04-25 14:17:28 -07:00
9bbac0d2cc
Added consistency check for FFG & LMD vote in validate_on_atttestation(), fixes #1636 , fixes #1456 , fixes #1408
2020-04-21 23:56:44 -07:00
1293320675
Merge branch 'dev' into phase1-tests
2020-03-12 07:12:41 -06:00
c894f5ecec
fork choice error note
2020-03-11 16:41:27 -06:00
47bbffa0d6
'get_checkpoint_store' -> 'get_forkchoice_store' typo
2020-03-11 15:03:14 -06:00
c91eee6bdf
revert fork choice store.blocks to store BeaconBlock
2020-03-10 13:20:57 -06:00
721f605a91
Merge branch 'dev' into phase1-tests
2020-02-22 12:10:35 -06:00
4c1fc9bffa
work through phase 1 tests
2020-02-22 12:06:31 -06:00
67a4d5e659
Merge branch 'dev' into master-copy
2020-01-24 13:49:22 -07:00
eed3f6053d
Merge pull request #1580 from ethereum/fork-choice-fix-1574
...
Fork choice fix issue 1574
2020-01-22 16:56:00 -07:00
b357e43aab
clarifying comment on call to get_ancestor in on_block
2020-01-22 14:31:23 -07:00
00d3fb4fe6
fix issue 1574 by ensuring that justified checkpoint in store updates when finalized updates if needbe
2020-01-20 18:50:50 -07:00
e98c1b4154
don't consider blocks with slots earlier than finalized in on_block fork choice (optimization)
2020-01-20 18:10:39 -07:00
f1697d03e7
fix corner case to properly handle skipped slots in get_ancestor
2020-01-20 17:49:09 -07:00
3c07b2c954
Make phase 0 fork choice more modular to more easily adopt for slight modifications in phase 1
2020-01-15 16:40:50 -07:00
6c74468142
forkchoice store on top of any state now
2020-01-14 01:02:02 +01:00
676e216beb
reorg specs by fork and move ssz out to own folder. make all of the build and link changes to support move
2020-01-10 11:55:13 -07:00
Danny Ryan
Aditya Asgaonkar
Aditya Asgaonkar
Hsiao-Wei Wang
protolambda
Hsiao-Wei Wang
Alex Stokes
Paul Hauner
Aditya Asgaonkar