Commit Graph

66 Commits

Author SHA1 Message Date
Pawan Dhananjay 78cc0a6e91
Change csc types to uint64 2024-08-30 12:25:26 -07:00
Barnabas Busa a5990f99ac
EIP-7594: PeerDAS explicit csc integer size (#3897)
* EIP-7594: PeerDAS explicit csc integer size

* add spec test for csc int size

* import uint8

* make linter happy

* add spec

* Update p2p-interface.md

* Update specs/_features/eip7594/das-core.md

Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>

* revert metadata name

* Update specs/_features/eip7594/das-core.md

Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>

* update tests

* make linter happy

* Make `DATA_COLUMN_SIDECAR_SUBNET_COUNT` in uint8

* add `int` casting for bypassing remerkeable type conversion

---------

Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2024-08-29 02:43:34 +08:00
Justin Traglia 4eee3b0c3b Remove matrix specific configuration value
This also removes references to the "extended matrix" in favor of just "matrix"
which I think is better. It's not an extended matrix, it's a matrix of extended
blobs. Technically it's just a matrix of cells/proofs.
2024-08-14 20:19:50 -05:00
fradamt 7a6770a732 fix headers
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
2024-08-07 16:52:06 +02:00
fradamt 376ab85406 Split peer sampling spec from das-core.md 2024-08-07 14:52:36 +02:00
George Kadianakis bb8f3caafc
Merge pull request #3836 from jtraglia/columns-cells-and-proofs
Update get_data_column_sidecars to take cells/proofs
2024-07-16 18:25:24 +03:00
Justin Traglia 5961e26931
Remove unnecessary comment 2024-07-15 15:09:01 -05:00
Justin Traglia 252b852a61
Rename column_index to cell_index in KZG spec (#3841)
* Rename column_index to cell_index in KZG spec

* Fix table of contents

* Replace list(set()) with set()

* Change coset_evals to cell_indices in some places

* Remove punctuation in table description

* Remove "row" from comments & improve docstring

* Replace unique with deduplicated
2024-07-15 19:41:33 +03:00
Justin Traglia 8da90b2702 Fix linter issues 2024-07-08 14:20:45 -05:00
Justin Traglia 1dbb68d3d7 Update get_data_column_sidecars to take cells/proofs 2024-07-08 14:07:53 -05:00
kevaundray a3a6c916b2
Remove proof parameter from `recover_cells_and_kzg_proofs` (#3819) 2024-06-27 14:17:14 -05:00
Hsiao-Wei Wang 0a49572799
Merge pull request #3782 from cskiraly/peer-das-sampling
PeerDAS sampling clarifications
2024-06-27 19:27:57 +08:00
Hsiao-Wei Wang 258c2c9020
Merge pull request #3794 from cskiraly/peer-das-reconstruction
EIP-7594: clarifying reconstruction and cross-seeding
2024-06-27 18:58:23 +08:00
Csaba Kiraly 1ad381dccb
adding get_extended_sample_count docsstring
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-06-27 10:28:21 +02:00
Csaba Kiraly 78b583d8b0
clarify use of get_extended_sample_count
Here we assume uniform random selection without replacement.
If other methods are used, the target false positive threshold
is the main rule to follow.

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-06-27 09:48:32 +02:00
Csaba Kiraly 17dfb9ae57
fix get_extended_sample_count proc signature
Co-authored-by: Pop Chunhapanya <haxx.pop@gmail.com>
2024-06-27 09:30:39 +02:00
Csaba Kiraly 4539265c55
moving part of text in custody section
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-06-25 10:36:53 +02:00
Hsiao-Wei Wang 1f87bbeac0
Merge branch 'dev' into pr3782 2024-06-25 16:21:00 +08:00
Hsiao-Wei Wang beedf852cb
Revert division change and add comments 2024-06-25 16:15:16 +08:00
Hsiao-Wei Wang fb020456cb
Add `get_extended_sample_count` unit tests 2024-06-19 02:18:29 +08:00
Justin Traglia d137553f96 Rename CellID to CellIndex 2024-06-11 07:41:52 -05:00
Justin Traglia 5ace424cd8
`recover_cells_and_kzg_proofs` & matrix refactor (#3788)
* Recover cells and proofs & matrix clean up

* Fix table of contents

* Update reference tests generator

* Update test format

* Remove unused imports

* Fix some minor nits

* Rename MatrixEntry's proof to kzg_proof

* Move RowIndex & ColumnIndex to das-core
2024-06-11 14:52:24 +03:00
Csaba Kiraly 6711acf3e2
clarifying reconstruction and cross-seeding
- when should a node reconstruct
- how to cross-seed for subscribed and unsubscribed topics

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-06-11 02:31:22 +02:00
Csaba Kiraly 2ab4f1e12e
get_extended_sample_count: use SAMPLES_PER_SLOT constant
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-06-10 11:16:06 +02:00
Csaba Kiraly 4c57399887
self-contained get_extended_sample_count
Importing scipy is not preferred. This is a self-contained
version. Eventually an import of math and use of math.comb
makes it simpler.
Solving other formatting issues as well.

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-06-04 09:41:29 +02:00
Csaba Kiraly 436e58e3f8
add get_extended_sample_count helper function
add LossyDAS sample count generation helper function

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-29 14:27:31 +02:00
Csaba Kiraly 5f3beca871
remove LossyDAS naming from spec
While the technique was introduced as LossyDAS, we don't need the name
in the specification itself.

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-29 11:08:52 +02:00
Csaba Kiraly a04cd87c38
fix the (source-view) formatting of the table
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-29 11:04:10 +02:00
Csaba Kiraly 4e1d566c43
improve candidate peer text
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-29 11:01:50 +02:00
Hsiao-Wei Wang 7b4d23c0ba
fix toc 2024-05-28 22:57:52 +08:00
Csaba Kiraly 8d332788b9
clarify the use of LossyDAS
Clarify that what matters is the false positive threshold, allowing
different sampling strategies as protocol compliant behavior.

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-28 13:54:27 +02:00
Csaba Kiraly b848ca6dc7
improved sampling description
- describe sample selection
- describe sample queries

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-28 13:54:27 +02:00
Hsiao-Wei Wang fdad206f3c
Apply @dankrad's suggestion 2024-05-07 20:26:56 +08:00
Hsiao-Wei Wang 950136c50d
Apply suggestions from code review
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
2024-05-07 18:30:28 +08:00
Hsiao-Wei Wang 9c1acbb5e5
Fix `get_custody_columns` 2024-05-06 17:25:47 +08:00
kevaundray e7b49dc670
chore: Add type casts reducing the diff for #3697 (#3734) 2024-04-29 08:14:55 -05:00
Justin Traglia b4188829b3 Rename compute_cells_and_proofs to compute_cells_and_kzg_proofs 2024-04-25 21:57:22 -05:00
Hsiao-Wei Wang e1d71216bb
Merge pull request #3715 from ethereum/das-test-vectors
Make `get_custody_columns` return sorted values and add `get_custody_columns` tests
2024-04-25 03:01:51 +08:00
Hsiao-Wei Wang 24899b7fba
Apply suggestions from @jtraglia 2024-04-24 19:04:40 +08:00
Hsiao-Wei Wang 57c14e5400
Add `get_custody_columns` tests 2024-04-23 20:21:33 +08:00
George Kadianakis 4fceca2b75
Merge pull request #3710 from kevaundray/kw/rm-field-elements-from-das-core
chore: use CELLS_PER_EXT_BLOB to compute the number of columns
2024-04-22 17:59:31 +03:00
Justin Traglia bcd0a09e68
Integrate new Coset/CosetEvals types (#3701)
* Add CellBytes type

* Use ByteVector, not Vector

* Fix tests

* Replace b"" with []

* Apply suggestions for bytes_to_cell

* Add/integrate new CosetEvals type

* Remove accidental new line

* Fix recover_all_cells

* Fix recover_matrix

* fix CosetEvals abstraction leak

* Introduce internal Coset type for `coset_for_cell()`

* Use CosetEvals in compute_kzg_proof_multi_impl()

* update test

* satisfy linter

* Fix two nits I noticed

---------

Co-authored-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Co-authored-by: George Kadianakis <desnacked@riseup.net>
2024-04-22 17:03:57 +03:00
Kevaundray Wedderburn 79d255b15a use CELLS_PER_EXT_BLOB in das-core 2024-04-22 14:08:44 +01:00
Kevaundray Wedderburn 3f2d498cee rename 2024-04-22 13:02:42 +01:00
Hsiao-Wei Wang e46c4c39fb workaround: add a new config `MAX_EXTENDED_MATRIX_SIZE` to avoid `class Container(List[c, a*b])` 2024-04-22 10:31:58 +01:00
Kevaundray Wedderburn 3ddd00e741 use recover_all_cells 2024-04-19 12:50:32 +01:00
Kevaundray Wedderburn 7e85c962f2 change CELLS_PER_BLOB in das-core.md 2024-04-18 17:40:51 +01:00
Justin Traglia 3dcf9ebe54 Use FIELD_ELEMENTS_PER_EXT_BLOB in NUMBER_OF_COLUMNS 2024-04-09 08:44:30 -05:00
Hsiao-Wei Wang 1acb1ff24f
minor arrange 2024-02-20 22:23:23 +08:00
Hsiao-Wei Wang bb33f9082c
Change List length of `DataColumn` from `MAX_BLOBS_PER_BLOCK` to `MAX_BLOB_COMMITMENTS_PER_BLOCK` 2024-02-20 22:06:09 +08:00