This also removes references to the "extended matrix" in favor of just "matrix"
which I think is better. It's not an extended matrix, it's a matrix of extended
blobs. Technically it's just a matrix of cells/proofs.
* chore: remove recover_data
* make it look closer to final code
* Improve comments
* Fix lint issue
* Fix tests & clean things up a bit
* Replace a couple uses of "monomial" with "coefficient"
* Revert "Replace a couple uses of "monomial" with "coefficient""
This reverts commit c9a1a757d1a09190eee78767b3d36b2a84066e42.
* Only replace "monomial" with "coefficient"
---------
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
Co-authored-by: Justin Traglia <jtraglia@pm.me>
* Rename column_index to cell_index in KZG spec
* Fix table of contents
* Replace list(set()) with set()
* Change coset_evals to cell_indices in some places
* Remove punctuation in table description
* Remove "row" from comments & improve docstring
* Replace unique with deduplicated
* restructure verify_cell_kzg_proof_batch a bit
* first draft of universal verification equation
* add one more empty line to make linter happy
* make linter happy
* more testcases for verify_cell_kzg_proof_batch
* verify_cell_kzg_proof_batch: derive coefficient via hash
* rename verify_cell_kzg_proof_batch_challenge -> compute_verify_cell_kzg_proof_batch_challenge
* verify_cell_kzg_proof_batch: editorial + some refactoring
* Improve documentation and variable naming.
* remove k_i from code and doc
---------
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
Here we assume uniform random selection without replacement.
If other methods are used, the target false positive threshold
is the main rule to follow.
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
* multi:
- Remove shift_polynomial_coeff
- Remove recover_shifted_data
- Remove recover_original_data
- Move `zero_poly_eval_brp ` under sanity check comment as its only used for sanity checking
* chore: remove sanity check -- this was doing a wasteful `compute_root_of_unity` operation
* chore: add previous sanity check as a unit test
* chore: copy values python was taking a reference, so it passes in our regular codepaths but not in isolated test
* chore: add coset_fft test
* Update specs/_features/eip7594/polynomial-commitments-sampling.md
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
* Update specs/_features/eip7594/polynomial-commitments-sampling.md
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
* chore: linter
* chore: asn (switch to bls_modular_inverse)
* chore: (ben) rename func to test_construct_vanishing_polynomial
* chore: (ben) rename `extended_evaluations_coeffs` to `extended_evaluation_times_zero_coeffs`
* chore: compute `roots_of_unity_extended` in recover_data method
* chore: add more comments explaining whats happening in recover_data
* chore: compute_zero_poly_coeff in recover_data
* chore: make lint
* chore: add doc comment to coset_fft_field
* chore: (ben) add code to generate the vanishing polynomial when all cells are missing
* chore: remove handling of edge case when constructing a vanishing polynomial
* chore: rename H(x) to Q_3(x)
* chore: remove trailing whitespace
* chore: add whitespace between comments
* chore: (asn) add assert that num missing cells is not 0
* chore: (justin) address comments
* chore: merge resolution
* chore: fixup remaining IDs -> indices
* chore: use indice nomenclature in tests
---------
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
Justin Traglia
Pawan Dhananjay
Barnabas Busa
Justin Traglia
Alex Stokes
fradamt
fradamt
Hsiao-Wei Wang
Benedikt Wagner
b-wagn
kevaundray
George Kadianakis
dapplion
Csaba Kiraly
Csaba Kiraly