Commit Graph

94 Commits

Author SHA1 Message Date
Danny Ryan 6dc306700b avoid overflow in slashing penalty calculation (#1286)
Change presentation to avoid uint64 overflow in slashing penalty calculation. (Factor out `EFFECTIVE_BALANCE_INCREMENT` from `validator.effective_balance`.)
2019-07-11 09:53:51 +01:00
Hsiao-Wei Wang b29c751cb7
Merge branch 'dev' into last-minute-cleanups-2 2019-07-01 09:25:06 +08:00
protolambda ab2001e237
Merge branch 'dev' into last-minute-cleanups 2019-07-01 01:17:18 +02:00
protolambda b7e8733812
fix usage of bls withdrawal byte in tests 2019-07-01 00:36:24 +02:00
Carl Beekhuizen 918192cdab
`compute_slot_epoch`->`compute_epoch_of_slot` 2019-06-30 23:35:07 +02:00
Carl Beekhuizen cb71409114
Merge in `dev` 2019-06-30 22:03:19 +02:00
Danny Ryan 83e961d5cc
Merge branch 'dev' into update-generators 2019-06-30 14:48:12 -05:00
Carl Beekhuizen 0fd1d38417
`Misc` function rename 2019-06-30 20:58:02 +02:00
Danny Ryan 4aa676bae7
fix mainnet attestation test 2019-06-30 13:52:35 -05:00
Danny Ryan 6d5e4da3e0
PR feedback 2019-06-30 12:42:24 -05:00
protolambda 8415e6c79d
mark incompatible mainnet tests 2019-06-30 18:42:54 +02:00
protolambda cb01f3ccd9
speed up remaining attestation tests by mocking slots 2019-06-30 18:40:43 +02:00
protolambda 4b93f5d921
disable some super-long tests, and fix a few attestation signatures 2019-06-30 18:15:36 +02:00
Justin Drake 0be2b8e620 Cleanup 2019-06-30 16:10:22 +01:00
Justin Drake 94404a5856 A few more cleanups 2019-06-30 14:11:46 +01:00
Justin Drake e8532ced79 WIP 2019-06-30 10:56:14 +01:00
Justin Drake d0acd81157 WIP 2019-06-30 10:02:18 +01:00
Danny Ryan 2f43f9c339
Merge pull request #1202 from ethereum/test_genesis
Add `test_genesis.py` and fix `is_genesis_trigger`
2019-06-29 23:31:32 -05:00
Danny Ryan 34ad123a46
Merge pull request #1206 from ethereum/cov-hunt
Test coverage improvements
2019-06-29 16:09:52 -05:00
protolambda 36dd977b85
fix finalize on double justification in 123 rule 2019-06-29 22:27:05 +02:00
protolambda 302b3afe2a
rename/fix roots in justification tests for consistency 2019-06-29 21:37:54 +02:00
protolambda e4eebef3a4
fix broken deposits test, now same error as others 2019-06-29 20:09:43 +02:00
Hsiao-Wei Wang d4755653ff
Merge branch 'deposit-root' into test_genesis 2019-06-30 01:33:29 +08:00
Danny Ryan 2857324016
Merge branch 'dev' into committee-roots 2019-06-29 11:21:13 -06:00
protolambda 5d633bfdf3
bugfix attestation creation so that it works on mainnet with multiple committees per slot, and improve bitfield index descriptions 2019-06-29 18:14:17 +02:00
Carl Beekhuizen 0c29c5125f
Finnish refactor 2019-06-29 17:10:12 +02:00
Carl Beekhuizen 4ed7af7bac
mock attestation refactor 2019-06-29 15:48:39 +02:00
Carl Beekhuizen 0680d8cc53
Makes justification ratios more marginal 2019-06-29 14:35:07 +02:00
Carl Beekhuizen 2eca6ef09d
Corrects justification comments 2019-06-29 13:10:09 +02:00
Carl Beekhuizen f9ca7c97c9
Fix 123 finalisation 2019-06-29 13:01:59 +02:00
Carl Beekhuizen b05bebf45c
Fix list slicing 2019-06-29 12:23:03 +02:00
Danny Ryan 129fd6297e
add shard to mock crosslink to separate attestations from eachother 2019-06-29 00:03:06 -06:00
Danny Ryan 022f1e7108
fix source/target 2019-06-28 23:59:20 -06:00
Danny Ryan bc5e947efc
aggregation_bitfield - bits 2019-06-28 23:38:14 -06:00
Danny Ryan 1885e285e3
fix source/target epochs in test_12 2019-06-28 23:28:36 -06:00
Danny Ryan f484b1e98c
some fixes to finality_12 2019-06-28 23:21:25 -06:00
protolambda cfbdee709b
finalization testing 2019-06-29 05:04:25 +02:00
protolambda efd9d173d7
update attester slashings processing tests 2019-06-29 03:19:57 +02:00
protolambda 518db42de7
fix attestation tests to work with checkpoints 2019-06-29 03:19:30 +02:00
protolambda d31f1b2353
Merge branch 'dev' into cov-hunt 2019-06-29 02:30:53 +02:00
protolambda 3a60f64b92
refactor finalization test helper func 2019-06-29 01:22:29 +02:00
dankrad be04eb2673
Change copy style, and remove deepcopy import
Update test_libs/pyspec/eth2spec/test/phase_0/block_processing/test_process_attestation.py

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2019-06-28 22:13:59 +02:00
dankrad 4dcb47e393
Update test_libs/pyspec/eth2spec/test/phase_0/block_processing/test_process_attestation.py
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2019-06-28 20:52:06 +01:00
protolambda 5f0e58364f
resolved merge conflicts, take attesters seq->set change from dev, take bits rework from bitlistvector PR 2019-06-28 18:17:13 +02:00
vbuterin c764202a57 Slashing penalty calculation change (#1217)
If the exit queue is very long, then a validator may take many months to exit. With the code as currently written, however, self-slashing is a potentially lucrative route to get one's money out faster, because one can exit in 36 days.

This PR changes it so that slashing can only extend your withdrawal time, not contract it. Also, instead of the slashed balances used to calculate one's slashing penalty being those in `[withdrawal - 54 days ... withdrawal - 18 days]`, we now run the penalization algorithm once every 36 days that a validator is slashed but not withdrawn, so that it covers the 36-day period where the validator was actually slashed.  It also moves the minimum slashing penalty to the `slash_validator` function so that it is only applied once.

We also simplify the `slashed_balances` logic to be per-epoch.
2019-06-28 14:35:26 +01:00
Justin Drake 196ac42025 Cleanup naming 2019-06-28 12:23:22 +01:00
Dankrad Feist 2622548ba7
Merge remote-tracking branch 'origin/dev' into dankrad-patch-8
# Conflicts:
#	specs/core/0_beacon-chain.md
2019-06-28 08:36:45 +01:00
Danny Ryan 140c69f2ec
Merge branch 'dev' into checkpoints 2019-06-27 21:02:48 -06:00
protolambda 384fa8854a
justification/finalization testing groundwork 2019-06-28 00:19:55 +02:00
Dankrad Feist 8ed638bb84
Linter fixes 2019-06-27 15:21:04 +01:00