Danny Ryan
b88ab250fa
Merge branch 'dev' into committee-roots
2019-06-28 12:07:50 -06:00
vbuterin
c764202a57
Slashing penalty calculation change ( #1217 )
...
If the exit queue is very long, then a validator may take many months to exit. With the code as currently written, however, self-slashing is a potentially lucrative route to get one's money out faster, because one can exit in 36 days.
This PR changes it so that slashing can only extend your withdrawal time, not contract it. Also, instead of the slashed balances used to calculate one's slashing penalty being those in `[withdrawal - 54 days ... withdrawal - 18 days]`, we now run the penalization algorithm once every 36 days that a validator is slashed but not withdrawn, so that it covers the 36-day period where the validator was actually slashed. It also moves the minimum slashing penalty to the `slash_validator` function so that it is only applied once.
We also simplify the `slashed_balances` logic to be per-epoch.
2019-06-28 14:35:26 +01:00
Carl Beekhuizen
0ba933e088
Merge pull request #1209 from ethereum/early_secret_test
...
Resolves issue in early_secret_reveal() testing
2019-06-28 11:58:40 +02:00
Danny Ryan
140c69f2ec
Merge branch 'dev' into checkpoints
2019-06-27 21:02:48 -06:00
Carl Beekhuizen
543729cad4
Merge pull request #1198 from ethereum/fork-choice-epoch
...
modify fork choice to utilize epochs properly
2019-06-27 19:14:19 +02:00
Justin Drake
bcfe383e25
WIP
2019-06-27 08:44:44 +01:00
Diederik Loerakker
d587c4fe61
Critical fix: introduce back total-value check ( #1220 )
...
This was dropped in a376b6607f
, as improvement in dust checking.
Now that dust-checking is done, we still need to check if the sender has the minimum value, as decrease balance just clips to 0.
See be86f966f8
for older dust-creation problem work around, which was dropped in the above.
The bug enabled you to transfer your full balance to someone else, and pay the same amount in fee, possibly to a puppet proposer to collect back funds.
Effectively enabling printing of money. Silly bug, good to fix and introduce tests for.
2019-06-26 20:21:17 +01:00
Danny Ryan
0827fbd7d5
Merge branch 'fork-choice-epoch' into checkpoints
2019-06-25 15:00:04 -06:00
Danny Ryan
c64289677f
fix gethead tests
2019-06-25 14:47:46 -06:00
Danny Ryan
228195d89d
get head tests
2019-06-25 11:48:55 -06:00
protolambda
3b5c7f243a
type hint uint input
2019-06-25 19:32:49 +02:00
Danny Ryan
ac06362716
Merge branch 'fork-choice-epoch' into checkpoints
2019-06-25 10:37:04 -06:00
Danny Ryan
846ca649aa
properly construct genesis latest block header in tests
2019-06-25 10:36:11 -06:00
Carl Beekhuizen
f29b693a9c
Merge dev -> early_spec_test
2019-06-25 17:11:04 +02:00
Danny Ryan
b8c0985e60
merge in fork choice. tests pass
2019-06-24 22:12:55 -06:00
Danny Ryan
bacd4b1e89
Merge branch 'fork-choice-epoch' into checkpoints
2019-06-24 21:26:28 -06:00
Danny Ryan
d9b97578c0
lint
2019-06-24 21:23:24 -06:00
Danny Ryan
751738f411
enhance fork choice testing
2019-06-24 21:01:15 -06:00
protolambda
a5b7564c5b
hash-tree-root tests
2019-06-25 02:37:05 +02:00
protolambda
5989e5cd23
use Bool as base name, make Bit an alias
2019-06-24 23:56:26 +02:00
protolambda
c73417b4ca
deserialize-basic detail, make subclass
2019-06-24 23:40:47 +02:00
protolambda
82ae180490
clean up list limit constants
2019-06-24 23:38:36 +02:00
Carl Beekhuizen
139d0f56f1
Finishes moving mask to hash()
2019-06-24 16:26:21 +02:00
Carl Beekhuizen
d9644f518b
mask is hash() in tests
...
Co-Authored-By: dankrad <dankrad@ethereum.org>
2019-06-24 16:08:13 +02:00
Justin Drake
181a2a876a
Cleanups
2019-06-22 22:49:53 +02:00
protolambda
da858f1aae
fix int encoding, fix list randomization size limit.
2019-06-22 21:49:42 +02:00
protolambda
9befe09f82
test merkleize chunks
2019-06-22 21:27:56 +02:00
protolambda
0249cf651e
fix lint, and update encoder to handle the few imported types well
2019-06-22 20:04:17 +02:00
Danny Ryan
8a732fbbcf
pass on checkpoints working in testing
2019-06-22 12:00:26 -06:00
protolambda
47034a6c8c
fix imports in helper test file
2019-06-22 19:59:53 +02:00
protolambda
e873bbd73b
support list casting
2019-06-22 19:59:15 +02:00
protolambda
dd5ad2e2c5
remove unnecessary (and now outdated) type hints, update List encoding for generators
2019-06-22 19:48:06 +02:00
protolambda
f95e7315b4
fix get_active_validator_indices typing usage
2019-06-22 18:34:33 +02:00
Diederik Loerakker
c86108de00
Merge pull request #1207 from ethereum/fix_make_lint
...
Fix `make lint`
2019-06-22 17:07:00 +02:00
Carl Beekhuizen
a5b22e13b8
Resolves make masker sign mask
2019-06-22 16:56:16 +02:00
Hsiao-Wei Wang
183fa3c776
Make linter happy
2019-06-21 23:09:11 -06:00
Danny Ryan
8f99741344
remove commented old code
2019-06-21 14:47:18 -06:00
Danny Ryan
c09e45c5fc
fix rule_4 underflow and split out genesis finality test
2019-06-21 14:45:15 -06:00
Danny Ryan
d463ada754
Merge branch 'dev' into list-rework
2019-06-21 14:18:45 -06:00
Danny Ryan
f12c32a690
Xdist tests for parallelism ( #1201 )
...
* add xdist parallelization
* reduce circleci cpus to 8
* reduce cpus to 4
* reduce circleci cpus to 2
* circleci back to 4 cpus
2019-06-21 14:18:28 -06:00
protolambda
d1fa3acb27
remove unused dependency
2019-06-21 21:27:26 +02:00
protolambda
80c40f5e09
merge dev, resolve minor merge conflicts
2019-06-21 21:22:23 +02:00
protolambda
b7b2fee635
uint add/sub type checking, fixes #1029
2019-06-21 21:12:27 +02:00
Carl Beekhuizen
0e59c6676a
Stop yielding from fork-choie tests
2019-06-21 13:00:42 +02:00
protolambda
6648b3c49e
remove old deposits test, there is no deposit index in deposit data anymore
2019-06-21 00:23:28 +02:00
protolambda
c20372409c
comment out old deposit test, re-introduced soon maybe, cc Justin
2019-06-20 22:52:16 +02:00
protolambda
f27c44b953
fix deposit negative index fail
2019-06-20 22:49:34 +02:00
protolambda
6338c5b880
fix custody bug, needs review from Carl
2019-06-20 22:49:03 +02:00
protolambda
d8f470bb4a
enable slicing of SSZ lists/vectors
2019-06-20 22:34:19 +02:00
protolambda
2d67717079
fix linting issues + make spec builder remove comments in container re-initialization part
2019-06-20 21:42:55 +02:00