d83ca352d5
Fix typing problem: `append` is invoked on a `ShardWork` instance
2021-06-16 13:33:56 +03:00
27889860f0
fix typo: sometimes `change()` invoked on `ShardWork` itself, should be invoked on its `status` field
2021-06-16 12:03:20 +03:00
cc20b80103
Fix linter, add more test helpers
2021-06-15 14:55:06 +06:00
2e87a6b44e
Apply review comments
2021-06-11 22:50:11 +06:00
7d617bc7c0
Fix timestamp passed to produce_execution_payload
2021-06-11 22:46:24 +06:00
95775e1b90
Add randao to execution payload
2021-06-11 16:05:19 +06:00
5140b59c57
add missing parenthesis
2021-06-08 21:51:26 +02:00
8f8b5ab648
Merge pull request #2475 from ralexstokes/discriminate-sync-comm-msg
...
Add `message.topic` to gossipsub `message-id` in Altair
2021-06-08 21:47:06 +02:00
a343680fd4
Add implementation note on message id fn
2021-06-08 14:29:08 -05:00
f60f13964c
Harden topic serialization
2021-06-08 14:15:57 -05:00
25a2e3463e
Update specs/altair/p2p-interface.md
...
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
2021-06-08 12:06:02 -07:00
d64b4e7d24
Add `message.topic` to gossipsub `message-id` in Altair
2021-06-08 13:44:06 -05:00
c7980d3cd0
Clarify p2p validation conditions for Altair sync committees
2021-06-08 13:34:16 -05:00
5d9d786499
Merge pull request #2462 from mkalinin/merge-transition-with-dynamic-ttd
...
Merge transition process with computed transition total difficulty
2021-06-08 09:55:10 -06:00
5228dc814f
Redefine initialize_beacon_state_from_eth1
2021-06-08 18:44:53 +06:00
6350e27366
Add difficulty field to PowBlock
2021-06-08 17:56:07 +06:00
038edb5b34
Rename SECONDS_SINCE_MERGE_FORK -> TARGET_SECONDS_TO_MERGE
2021-06-08 17:16:52 +06:00
3a6a565a8f
Replace fractional division with integer one
...
Co-authored-by: vbuterin <v@buterin.com>
2021-06-08 15:03:59 +06:00
64f217d3e1
update sync aggregate processing reference in validator doc
2021-06-08 01:05:50 +02:00
cfc66a3794
patch tests
2021-06-07 16:36:18 -06:00
09b6fb0e64
ensure consistency about sync committees vs aggregates in naming throughout
2021-06-07 16:17:46 -06:00
96334e3ee7
Switch to suggested td computation formula
2021-06-07 22:21:36 +06:00
30f2a07637
Merge pull request #2438 from ralexstokes/add-aggregate-pks-fn
...
Move BLS extensions to new file in Altair
2021-06-07 07:18:31 -06:00
335d7ce1dc
Merge pull request #2446 from ethereum/SyncCommitteeSignature-to-SyncCommitteeMessage
...
Rename `SyncCommitteeSignature` to `SyncCommitteeMessage` to avoid name conflicts
2021-06-07 07:06:14 -06:00
1d5c4ecffb
Merge pull request #2453 from ethereum/vbuterin-patch-11
...
Modify sync committee logic and parameters to reduce variance
2021-06-04 12:23:16 -06:00
44f6453ce3
Merge pull request #2452 from Nashatyrev/fix/no-committee-for-shard-case
...
[Sharding] Handle the case when committee count < active shards
2021-06-04 18:19:33 +02:00
f679a0a086
Merge pull request #2455 from ethereum/sharding-state
...
New union-based shard headers/commitments representation
2021-06-04 18:18:43 +02:00
0ae9a85b17
Adopt shard_blob gossip validation on top of PR #2455 : here the `compute_committee_index_from_shard` raises an error if no committee assigned to a shard
2021-06-04 18:48:09 +03:00
071abfa846
Revert beacon-chain changes as they are handled in PR #2455
2021-06-04 18:44:35 +03:00
116c1c0f3a
Merge remote-tracking branch 'EF/dev' into fix/no-committee-for-shard-case
...
# Conflicts:
# specs/sharding/p2p-interface.md
2021-06-04 18:43:12 +03:00
9050897cb2
fix committee work status and commitment references
2021-06-03 19:11:47 +02:00
d4f6459108
Define missing header_root
...
Co-authored-by: Anton Nashatyrev <Nashatyrev@users.noreply.github.com>
2021-06-03 18:00:51 +02:00
c0af420130
shard work status enum, prefix instead of suffix + move full committee balance init line
2021-06-03 17:32:35 +02:00
45d554aee8
Merge branch 'dev' into SyncCommitteeSignature-to-SyncCommitteeMessage
2021-06-03 22:13:53 +08:00
7f64757b51
Fix Optional[TransitionStore] issue to satisfy linter
2021-06-03 16:08:56 +06:00
6872c01682
Add an extra line between function def
2021-06-03 12:31:59 +06:00
b3f2635ce7
Merge pull request #2466 from terencechain/patch-123
...
Altair: missing `block_root` in `SyncCommitteeSignature`
2021-06-02 16:09:13 -06:00
45a71eb267
line length lint
2021-06-02 15:58:51 -06:00
65f48178b7
Include block_root in SyncCommitteeSignature
2021-06-02 14:41:24 -07:00
6604830729
Apply suggestions after the review
2021-06-02 15:00:01 +06:00
417dda8326
fix committee index assertion
2021-06-01 22:38:36 +02:00
d87e076ce3
Minor Altair cosmetic polishing
2021-06-01 17:05:12 +01:00
65f8d3d296
Merge branch 'dev' into SyncCommitteeSignature-to-SyncCommitteeMessage
2021-06-01 22:05:10 +08:00
db32c8b013
Fix linter errors
2021-06-01 17:44:58 +06:00
6226be9e1e
Implement TransitionStore and transition total difficulty computation
2021-06-01 16:28:30 +06:00
2545c3e2d0
update pending header weights after epoch transition, fix committee index loop, fix header processing status assert, add todos for Altair-like shard attestation rewards
2021-05-31 18:55:08 +02:00
5a235d0251
Review suggestions
...
Co-authored-by: Anton Nashatyrev <Nashatyrev@users.noreply.github.com>
2021-05-31 17:03:06 +02:00
fd4369dc7c
Add merge/fork.md with upgrade_to_merge definition
2021-05-31 19:30:54 +06:00
bb3d581b13
update shard processing naming and doc structure
2021-05-29 23:55:16 +02:00
31f48b7b3b
update sharding presets
2021-05-29 22:39:25 +02:00
3665dbea8b
name (slot, shard) union wrapper ShardWork
2021-05-29 21:28:00 +02:00
482b028b88
Merge pull request #2436 from terencechain/patch-122
...
Sharding p2p: minor fixes
2021-05-28 22:09:58 +02:00
72215412fa
For slow shard confirmation, assuming it is available via DAS, we could confirm the best pending header
2021-05-28 21:56:13 +02:00
38a0f4f211
update to wrap the union, clean up initialization and typing
2021-05-28 21:27:05 +02:00
e5521af1f8
new union-based shard headers/commitments representation
2021-05-28 20:18:29 +02:00
b0500c3de1
Update specs/altair/beacon-chain.md
2021-05-27 12:06:01 -07:00
4d5bc83af4
Re-org files
2021-05-27 11:59:15 -07:00
3cd842a94d
Update specs/altair/beacon-chain.md
2021-05-27 11:39:29 -07:00
a89ecced1c
Modify sync committee logic and parameters to reduce variance
...
Sync committee rewards as currently implemented significantly increase variance in proposer rewards: https://github.com/ethereum/eth2.0-specs/issues/2448
For example, if there are 200000 validators (6.4m ETH staked), then during each 1/4-eek (~54 hour) period there is a chance of 512/200000 that a validator will get accepted into the sync committee, so on average that will happen once every 200000/512 * 1/4 = 97.6 eeks, or close to two years. The payout of this "lottery" is 1/8 of that, or ~12.2 eeks (a bit less than four months) of revenue. This is much more severe than block proposing (a chance of 1/200000 per slot, or a lottery worth ~0.38 eeks of revenue once every ~3.05 eeks).
This PR makes three changes to cut make the sync committee lottery less drastic and bring variance closer in line with what is available from block proposing:
* Reduce the `SYNC_REWARD_WEIGHT` from 8 to 2
* Add a penalty for not participating in the sync committee, so that despite the first change the total net reward for participating vs not participating is only cut down by 2x
* Reduce the sync committee period from 1/4 eek to 1/8 eek (~27 hours)
With these three factors combined, the lottery reduces to ~1.5 eeks of revenue, on average occurring every ~48 eeks. Validators who are maximally unlucky (ie. never become part of a sync committee) only lose ~3.12% of their rewards instead of ~12.5%.
The compromises that this approach makes are:
* In the extreme case where >50% of proposers are operating efficiently, being in a sync committee becomes a net burden. However, this should be extremely rare, and in such cases validators would likely be suffering inactivity leak penalties anyway.
* Incentive to participate in a sync committee decreased by 2x (but this is IMO an improvement; sync committees are _not_ as important as proposals and deserve to have lower rewards)
* Minimum data syncing needed to maintain a light client increases by 2x (from 24 kB per 54 hours to 24 kB per 27 hours). A burden for on-chain light clients, but still insignificant for others.
2021-05-27 09:02:51 -06:00
d50a12cb18
Merge pull request #2449 from ethereum/fix-sharding-comments
...
add/update comments on shard blob/header/reference body field
2021-05-27 08:06:32 -06:00
414ef614cb
Handle the case when a shard may not have a committee at slot.
...
Block is invalid if contains ShardBlobHeader lacking committee
Reject Gossip ShardBlobHeader and ShardBlob messages which lacks committee
2021-05-27 15:13:13 +03:00
48f989070d
Remove naughty space
2021-05-27 15:30:44 +10:00
103d029a1a
Add clock disparity tolerance for sync subnets
2021-05-27 15:28:51 +10:00
1360860d1e
add/update comments on shard blob/header/reference body field
2021-05-27 03:57:59 +02:00
a08d23189e
Update specs/altair/validator.md
...
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2021-05-26 15:51:22 -07:00
a25bc832b9
Update section headers
2021-05-26 03:01:38 +08:00
0142978b60
Rename `SyncCommitteeSignature` to `SyncCommitteeMessage`
2021-05-26 02:36:54 +08:00
41ca149429
Explicitly define `bls.AggregatePKs`
2021-05-24 11:56:10 -07:00
71d0d45343
Align table
2021-05-24 06:57:09 -07:00
814c7696d9
shard_blob_header -> shard_header
2021-05-24 06:55:17 -07:00
4a5947d49e
Proto's suggestion
2021-05-24 06:54:38 -07:00
96352726bb
Sharding p2p: minor typo fixes
2021-05-22 10:31:10 -07:00
bca467c926
fmt
2021-05-21 14:36:43 -06:00
5bf01c4298
add resourceunavailable error code with more guidance
2021-05-21 14:24:58 -06:00
e50d8d4391
Merge branch 'dev' into config-rework
2021-05-20 23:31:49 +02:00
ff021da551
change line formatting, new refence as config var implicitly takes more space
2021-05-19 17:21:30 +02:00
291168e1e3
clarify config/preset separation, address review comments by @djrtwo
2021-05-19 17:15:34 +02:00
c03c72a543
Altair fork: add a link
2021-05-18 13:50:46 -07:00
248363ce21
Merge pull request #2419 from terencechain/patch-120
...
Fix `PARTICIPATION_FLAG_WEIGHTS` to use correct head weight
2021-05-18 11:27:36 -06:00
441992c779
Fix typing problem in `sharding.process_block`
2021-05-18 14:14:43 +03:00
ef8d6003d3
fix inactivity penalties markdown table
2021-05-18 10:07:35 +02:00
2c7a68406f
update config section markdown table header
2021-05-18 09:55:25 +02:00
e4593d2d0c
update with configs<>presets separation
2021-05-18 09:55:20 +02:00
c1f1adb4d1
Custody Game constant/preset/config separation
2021-05-18 09:33:07 +02:00
4941a97829
Sharding constant/preset/config separation
2021-05-18 09:33:05 +02:00
7d59016bb8
Merge constant/preset/config separation
2021-05-18 09:31:07 +02:00
7689ebb2bd
Altair constant/preset/config separation
2021-05-18 09:28:09 +02:00
b9ffd8f640
Phase0 constant/config/preset separation
2021-05-18 09:20:41 +02:00
a7344b3ee1
Fix `PARTICIPATION_FLAG_WEIGHTS` to use correct head weight
2021-05-17 21:35:43 -07:00
fcf37895ba
remove duplicate sharding config var, fix minimal-sharding-config fork epoch name
2021-05-18 00:48:59 +02:00
abda2dd5fa
Sharding: move `get_committee_count_per_slot` to the outside
2021-05-14 12:02:46 -07:00
c87333face
minor review from dankrad on release pr
2021-05-14 10:05:54 -06:00
110e6b38ee
remove resourceunavailable for more discussion
2021-05-14 08:07:08 -06:00
5984fd74b3
Merge pull request #2393 from Nashatyrev/cosmetics/blob-subnet-name
...
[Sharding] Network: Calculate {subnet_id} for shard_blob_ subnets
2021-05-14 14:49:09 +02:00
a1e64c1ceb
Merge pull request #2368 from Nashatyrev/fix/root-for-empty-shard-header
...
[Sharding] Calc the right root with respect to (slot, shard) for an empty PendingShardHeader
2021-05-14 14:44:56 +02:00
4cd9a6c710
Merge pull request #2385 from ethereum/execution-payload-testing
...
Execution payload tests
2021-05-14 06:40:40 -06:00
86792b9232
Merge pull request #2411 from ethereum/order-indices
...
ensure indices are ordered [source, target, head] everywhere
2021-05-14 14:38:26 +02:00
160b704f4a
ensure indices are ordered source, target, head everywhere
2021-05-14 06:19:29 -06:00
5dd29b6659
fix tests and minor copy edit
2021-05-14 06:15:48 -06:00
1310105174
Return non-duplicated sync committee subnets
2021-05-13 16:22:28 -07:00
ericsson
Mikhail Kalinin
protolambda
Alex Stokes
Danny Ryan
Anton Nashatyrev
Hsiao-Wei Wang
terence tsao
Justin
vbuterin
Paul Hauner