600f55ba7f
add basic execution-layer p2p beacon_block validations
2021-08-09 17:50:56 -06:00
93af122b2d
PR feedback from @ralexstokes and add single pubkey aggregate tests
2021-08-05 12:09:30 +08:00
56c92136f2
Merge branch 'dev' into altair-bls-tests
2021-08-05 11:18:41 +08:00
fc3e651817
samples -> samples_length
2021-08-04 23:25:25 +02:00
43a1617ffa
Ensure that the given PKs are valid PKs + fix typos
2021-08-04 21:25:37 +08:00
424f838747
Update specs/sharding/beacon-chain.md
...
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
2021-08-04 12:44:42 +02:00
b262854bb1
Rename the `eth2_*` functions to `eth_`
2021-08-03 21:51:02 +08:00
322f072703
sharding: remove outdated comment, timely shard attesters are marked in attestation-processing, no need for epoch processing additions
2021-07-31 13:22:26 +02:00
2d17c8c3c4
move back INITIAL_ACTIVE_SHARDS to preset, avoid changing mainnet config
2021-07-30 22:22:43 +02:00
add5810d71
remove unused pending attestation fields
2021-07-30 22:06:04 +02:00
ab78339350
fix variable name of summary field
2021-07-30 21:54:55 +02:00
f1982d4fc3
Replace underflow check with respective comment
2021-07-30 16:18:05 +06:00
d58ffc7dfc
Add genesis settings section
2021-07-30 16:10:33 +06:00
5d5a9e392b
Rename GAS_LIMIT_DIVISOR to GAS_LIMIT_DENOMINATOR
2021-07-30 12:43:54 +06:00
c311712bca
Apply suggestions from code review
...
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2021-07-30 12:36:02 +06:00
0daaafbc98
fix union value retrieval, thanks @terencechain
2021-07-28 22:00:23 +02:00
d47d2f92cc
shard fees: implement review suggestions from @nashatyrev
2021-07-27 14:48:21 +02:00
756eb90bfe
consider per-slot sample target adjustment, to avoid racing and ordering problems
2021-07-26 16:27:19 +02:00
789e10ea7c
Update toc
2021-07-26 20:09:57 +06:00
9a1a30c3d4
Rebase Merge spec with London
2021-07-26 19:55:35 +06:00
1a966d1e37
work in progress new sharding fee mechanism
2021-07-26 15:26:55 +02:00
35df4b2d4f
rephrase context enum for blocks_by requests
2021-07-23 07:54:26 -06:00
a7f58ef08a
fix comment + handle missing pending headers
2021-07-23 12:56:01 +02:00
f791fe7d1c
implement review suggestions
...
Co-authored-by: Anton Nashatyrev <anton.nashatyrev@gmail.com>
2021-07-23 12:56:01 +02:00
b25afc88fd
update networking spec with aggregate proposer/builder types, update TOCs
2021-07-23 12:56:00 +02:00
5034e2d7bc
update shard spec wording + fix shard slashings
2021-07-23 12:56:00 +02:00
5726cb9374
aggregate builder and proposer for simplified typing and optimized verification
2021-07-23 12:56:00 +02:00
2a105f4581
fix toc
2021-07-23 12:56:00 +02:00
b3d5858cc9
update data fee payment, todo
2021-07-23 12:55:59 +02:00
9e10f58299
update networking spec
2021-07-23 12:55:59 +02:00
4b25239617
builders make blobs, proposers make blocks
2021-07-23 12:55:59 +02:00
bc936768c7
global selection of shard proposers
2021-07-23 12:55:55 +02:00
06b8bb1a57
Simplify get_start_shard function
2021-07-23 12:45:03 +02:00
bf6ad465ce
remove old BeaconState extension
2021-07-22 20:01:50 +02:00
bb0848b6f6
carry over current and previous_sync_committee in Merge state upgrader, review from @djrtwo
2021-07-22 19:58:10 +02:00
3b34f16e5a
add base merge p2p spec
2021-07-22 11:09:36 -06:00
17fad2dea2
rebase The Merge onto Altair base functionality
2021-07-22 16:36:41 +02:00
f7a2a973ac
Update specs/altair/p2p-interface.md
...
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
2021-07-21 15:51:59 -06:00
02a9fc460e
require aggregation bits to have at least one participant in sync contributions
2021-07-21 11:10:09 -06:00
65f6aa1b33
Replace PyUnion with Optional
2021-07-20 17:37:52 +06:00
add00ad2e0
Replace get_pow_chain_head with get_pow_block_at_total_difficulty in validator.md
2021-07-17 12:33:06 +06:00
a4a050e97a
Enforce terminal PoW block to be on the cusp
2021-07-16 19:16:32 +06:00
63ca480ea3
Add condition check in `on_tick` to ensure that `store.justified_checkpoint` is a descendant of `store.finalized_checkpoint`
2021-07-14 20:02:28 +08:00
6d0deddbe5
modify target sync committee aggregators to more sound 16
2021-07-12 09:03:43 -06:00
8140a789c4
Merge pull request #2509 from terencechain/patch-124
...
Rename a few instances of `signature` to `message`
2021-07-08 10:09:12 -06:00
88bb7562aa
Update specs/altair/beacon-chain.md
2021-07-07 16:11:58 -06:00
6f31077afa
Update `get_next_sync_committee` notes
2021-07-07 10:42:52 -07:00
3a59c1b789
Rename a few instances of signature to message
2021-07-07 10:04:26 -07:00
c8d22b1d91
fix minor cosmetic typo
2021-07-07 13:44:22 +01:00
00afb341de
Merge pull request #2479 from mkalinin/randao_in_execution_payload
...
Add randao to execution payload
2021-06-23 08:30:21 -06:00
c61eeb8a27
optimize sync committee message gossip and caches
2021-06-22 12:31:02 -06:00
ac19aa3e2d
Accept polishing suggested by Justin
2021-06-22 14:23:26 +06:00
8107d0d582
Merge pull request #2485 from nisdas/patch-1
...
Make The Nature of Validator Sync Committee Assignments Clearer
2021-06-21 16:51:11 -05:00
fc1012b632
typo
2021-06-21 12:49:41 -06:00
a61aa7968d
clean up
2021-06-21 12:48:44 -06:00
199d6aee58
Merge remote-tracking branch 'origin/dev' into randao_in_execution_payload
2021-06-19 00:28:38 +06:00
878b15df6a
polish merge/beacon-chain.md ( #2472 )
...
Polish `merge/beacon-chain.md` with mostly non-substantive changes.
**Non-substantive changes**
* rename `MAX_EXECUTION_TRANSACTIONS` to `MAX_TRANSACTIONS_PER_PAYLOAD`
- rename "execution transaction" to just "transaction" as per discussion with Danny
* rename `compute_time_at_slot` to `compute_timestamp_at_slot`
- the function returns a Unix timestamp
- "timestamp" matches `execution_payload.timestamp`
* be explicit about `ExecutionEngine.execution_state` for clarity
* rename `ExecutionPayload.number` to `ExecutionPayload.block_number`
- more specific ("number" is pretty vague)
- consistent with `ExecutionPayload.block_hash`
* rename `new_block` to `on_payload`
- the `on_` prefix is consistent with other event handlers (e.g. see `on_tick`, `on_block`, `on_attestation` [here](https://github.com/ethereum/eth2.0-specs/blob/dev/specs/phase0/fork-choice.md#handlers ))
- the `_payload` suffix is more to the point given the function accepts an `execution_payload`
- avoids conflict with `on_block` which is already used in the fork choice
* rework the table of contents for consistency
* order `is_execution_enabled` after `is_transition_completed` and `is_transition_block`
- `is_execution_enabled` refers to `is_transition_completed` and `is_transition_block`
* rename "transition" to "merge"
- "transition" is a bit vague—we will have other transitions at future hard forks
- there is no need for two words to refer to the same concept
* add a bunch of inline comments, e.g. in `process_execution_payload`
* make the `process_execution_payload` signature consistent with the other `process_` functions in `process_block` which take as arguments `state` and `block.body`
* remove `TRANSITION_TOTAL_DIFFICULTY`
- to be put in `merge/fork-choice.md` where it is used
* various misc cleanups
**Substantive changes**
* reorder `ExecutionPayload` fields
- for consistency with yellow paper and Eth1
- same for `ExecutionPayloadHeader`
- added comments separating out the execution block header fields from the extra fields (cosmetic)
2021-06-18 11:09:30 +01:00
dadcb2a06a
Merge branch 'dev' into ericsson49/fix_reset_pending_shard_work
2021-06-17 18:54:29 +02:00
c68ce56407
Merge pull request #2483 from ericsson49/ericsson49/fix_append_in_process_shard_header
...
Fix typing problem: append is invoked on a ShardWork instance
2021-06-17 18:50:40 +02:00
6e86d8a696
Rename randao->random, other fixes as per review
2021-06-17 21:20:17 +06:00
67f1c2c2bd
Update validator.md
2021-06-17 23:05:23 +08:00
22b2a73615
convert `int` to `CommitteeIndex` when passing to `get_beacon_committee`
2021-06-16 19:07:24 +03:00
5b4f89875c
use `List[PendingShardHeader,...]` instead of `MutableSequence`, since `remerkleable.List` does not implement the latter
2021-06-16 14:06:17 +03:00
d83ca352d5
Fix typing problem: `append` is invoked on a `ShardWork` instance
2021-06-16 13:33:56 +03:00
27889860f0
fix typo: sometimes `change()` invoked on `ShardWork` itself, should be invoked on its `status` field
2021-06-16 12:03:20 +03:00
cc20b80103
Fix linter, add more test helpers
2021-06-15 14:55:06 +06:00
2e87a6b44e
Apply review comments
2021-06-11 22:50:11 +06:00
7d617bc7c0
Fix timestamp passed to produce_execution_payload
2021-06-11 22:46:24 +06:00
95775e1b90
Add randao to execution payload
2021-06-11 16:05:19 +06:00
5140b59c57
add missing parenthesis
2021-06-08 21:51:26 +02:00
8f8b5ab648
Merge pull request #2475 from ralexstokes/discriminate-sync-comm-msg
...
Add `message.topic` to gossipsub `message-id` in Altair
2021-06-08 21:47:06 +02:00
a343680fd4
Add implementation note on message id fn
2021-06-08 14:29:08 -05:00
f60f13964c
Harden topic serialization
2021-06-08 14:15:57 -05:00
25a2e3463e
Update specs/altair/p2p-interface.md
...
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
2021-06-08 12:06:02 -07:00
d64b4e7d24
Add `message.topic` to gossipsub `message-id` in Altair
2021-06-08 13:44:06 -05:00
c7980d3cd0
Clarify p2p validation conditions for Altair sync committees
2021-06-08 13:34:16 -05:00
5d9d786499
Merge pull request #2462 from mkalinin/merge-transition-with-dynamic-ttd
...
Merge transition process with computed transition total difficulty
2021-06-08 09:55:10 -06:00
5228dc814f
Redefine initialize_beacon_state_from_eth1
2021-06-08 18:44:53 +06:00
6350e27366
Add difficulty field to PowBlock
2021-06-08 17:56:07 +06:00
038edb5b34
Rename SECONDS_SINCE_MERGE_FORK -> TARGET_SECONDS_TO_MERGE
2021-06-08 17:16:52 +06:00
3a6a565a8f
Replace fractional division with integer one
...
Co-authored-by: vbuterin <v@buterin.com>
2021-06-08 15:03:59 +06:00
64f217d3e1
update sync aggregate processing reference in validator doc
2021-06-08 01:05:50 +02:00
cfc66a3794
patch tests
2021-06-07 16:36:18 -06:00
09b6fb0e64
ensure consistency about sync committees vs aggregates in naming throughout
2021-06-07 16:17:46 -06:00
96334e3ee7
Switch to suggested td computation formula
2021-06-07 22:21:36 +06:00
30f2a07637
Merge pull request #2438 from ralexstokes/add-aggregate-pks-fn
...
Move BLS extensions to new file in Altair
2021-06-07 07:18:31 -06:00
335d7ce1dc
Merge pull request #2446 from ethereum/SyncCommitteeSignature-to-SyncCommitteeMessage
...
Rename `SyncCommitteeSignature` to `SyncCommitteeMessage` to avoid name conflicts
2021-06-07 07:06:14 -06:00
1d5c4ecffb
Merge pull request #2453 from ethereum/vbuterin-patch-11
...
Modify sync committee logic and parameters to reduce variance
2021-06-04 12:23:16 -06:00
44f6453ce3
Merge pull request #2452 from Nashatyrev/fix/no-committee-for-shard-case
...
[Sharding] Handle the case when committee count < active shards
2021-06-04 18:19:33 +02:00
f679a0a086
Merge pull request #2455 from ethereum/sharding-state
...
New union-based shard headers/commitments representation
2021-06-04 18:18:43 +02:00
0ae9a85b17
Adopt shard_blob gossip validation on top of PR #2455 : here the `compute_committee_index_from_shard` raises an error if no committee assigned to a shard
2021-06-04 18:48:09 +03:00
071abfa846
Revert beacon-chain changes as they are handled in PR #2455
2021-06-04 18:44:35 +03:00
116c1c0f3a
Merge remote-tracking branch 'EF/dev' into fix/no-committee-for-shard-case
...
# Conflicts:
# specs/sharding/p2p-interface.md
2021-06-04 18:43:12 +03:00
9050897cb2
fix committee work status and commitment references
2021-06-03 19:11:47 +02:00
d4f6459108
Define missing header_root
...
Co-authored-by: Anton Nashatyrev <Nashatyrev@users.noreply.github.com>
2021-06-03 18:00:51 +02:00
c0af420130
shard work status enum, prefix instead of suffix + move full committee balance init line
2021-06-03 17:32:35 +02:00
45d554aee8
Merge branch 'dev' into SyncCommitteeSignature-to-SyncCommitteeMessage
2021-06-03 22:13:53 +08:00
7f64757b51
Fix Optional[TransitionStore] issue to satisfy linter
2021-06-03 16:08:56 +06:00
6872c01682
Add an extra line between function def
2021-06-03 12:31:59 +06:00
b3f2635ce7
Merge pull request #2466 from terencechain/patch-123
...
Altair: missing `block_root` in `SyncCommitteeSignature`
2021-06-02 16:09:13 -06:00
45a71eb267
line length lint
2021-06-02 15:58:51 -06:00
65f48178b7
Include block_root in SyncCommitteeSignature
2021-06-02 14:41:24 -07:00
6604830729
Apply suggestions after the review
2021-06-02 15:00:01 +06:00
417dda8326
fix committee index assertion
2021-06-01 22:38:36 +02:00
d87e076ce3
Minor Altair cosmetic polishing
2021-06-01 17:05:12 +01:00
65f8d3d296
Merge branch 'dev' into SyncCommitteeSignature-to-SyncCommitteeMessage
2021-06-01 22:05:10 +08:00
db32c8b013
Fix linter errors
2021-06-01 17:44:58 +06:00
6226be9e1e
Implement TransitionStore and transition total difficulty computation
2021-06-01 16:28:30 +06:00
2545c3e2d0
update pending header weights after epoch transition, fix committee index loop, fix header processing status assert, add todos for Altair-like shard attestation rewards
2021-05-31 18:55:08 +02:00
5a235d0251
Review suggestions
...
Co-authored-by: Anton Nashatyrev <Nashatyrev@users.noreply.github.com>
2021-05-31 17:03:06 +02:00
fd4369dc7c
Add merge/fork.md with upgrade_to_merge definition
2021-05-31 19:30:54 +06:00
bb3d581b13
update shard processing naming and doc structure
2021-05-29 23:55:16 +02:00
31f48b7b3b
update sharding presets
2021-05-29 22:39:25 +02:00
3665dbea8b
name (slot, shard) union wrapper ShardWork
2021-05-29 21:28:00 +02:00
482b028b88
Merge pull request #2436 from terencechain/patch-122
...
Sharding p2p: minor fixes
2021-05-28 22:09:58 +02:00
72215412fa
For slow shard confirmation, assuming it is available via DAS, we could confirm the best pending header
2021-05-28 21:56:13 +02:00
38a0f4f211
update to wrap the union, clean up initialization and typing
2021-05-28 21:27:05 +02:00
e5521af1f8
new union-based shard headers/commitments representation
2021-05-28 20:18:29 +02:00
b0500c3de1
Update specs/altair/beacon-chain.md
2021-05-27 12:06:01 -07:00
4d5bc83af4
Re-org files
2021-05-27 11:59:15 -07:00
3cd842a94d
Update specs/altair/beacon-chain.md
2021-05-27 11:39:29 -07:00
a89ecced1c
Modify sync committee logic and parameters to reduce variance
...
Sync committee rewards as currently implemented significantly increase variance in proposer rewards: https://github.com/ethereum/eth2.0-specs/issues/2448
For example, if there are 200000 validators (6.4m ETH staked), then during each 1/4-eek (~54 hour) period there is a chance of 512/200000 that a validator will get accepted into the sync committee, so on average that will happen once every 200000/512 * 1/4 = 97.6 eeks, or close to two years. The payout of this "lottery" is 1/8 of that, or ~12.2 eeks (a bit less than four months) of revenue. This is much more severe than block proposing (a chance of 1/200000 per slot, or a lottery worth ~0.38 eeks of revenue once every ~3.05 eeks).
This PR makes three changes to cut make the sync committee lottery less drastic and bring variance closer in line with what is available from block proposing:
* Reduce the `SYNC_REWARD_WEIGHT` from 8 to 2
* Add a penalty for not participating in the sync committee, so that despite the first change the total net reward for participating vs not participating is only cut down by 2x
* Reduce the sync committee period from 1/4 eek to 1/8 eek (~27 hours)
With these three factors combined, the lottery reduces to ~1.5 eeks of revenue, on average occurring every ~48 eeks. Validators who are maximally unlucky (ie. never become part of a sync committee) only lose ~3.12% of their rewards instead of ~12.5%.
The compromises that this approach makes are:
* In the extreme case where >50% of proposers are operating efficiently, being in a sync committee becomes a net burden. However, this should be extremely rare, and in such cases validators would likely be suffering inactivity leak penalties anyway.
* Incentive to participate in a sync committee decreased by 2x (but this is IMO an improvement; sync committees are _not_ as important as proposals and deserve to have lower rewards)
* Minimum data syncing needed to maintain a light client increases by 2x (from 24 kB per 54 hours to 24 kB per 27 hours). A burden for on-chain light clients, but still insignificant for others.
2021-05-27 09:02:51 -06:00
d50a12cb18
Merge pull request #2449 from ethereum/fix-sharding-comments
...
add/update comments on shard blob/header/reference body field
2021-05-27 08:06:32 -06:00
414ef614cb
Handle the case when a shard may not have a committee at slot.
...
Block is invalid if contains ShardBlobHeader lacking committee
Reject Gossip ShardBlobHeader and ShardBlob messages which lacks committee
2021-05-27 15:13:13 +03:00
48f989070d
Remove naughty space
2021-05-27 15:30:44 +10:00
103d029a1a
Add clock disparity tolerance for sync subnets
2021-05-27 15:28:51 +10:00
1360860d1e
add/update comments on shard blob/header/reference body field
2021-05-27 03:57:59 +02:00
a08d23189e
Update specs/altair/validator.md
...
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2021-05-26 15:51:22 -07:00
a25bc832b9
Update section headers
2021-05-26 03:01:38 +08:00
0142978b60
Rename `SyncCommitteeSignature` to `SyncCommitteeMessage`
2021-05-26 02:36:54 +08:00
41ca149429
Explicitly define `bls.AggregatePKs`
2021-05-24 11:56:10 -07:00
71d0d45343
Align table
2021-05-24 06:57:09 -07:00
814c7696d9
shard_blob_header -> shard_header
2021-05-24 06:55:17 -07:00
4a5947d49e
Proto's suggestion
2021-05-24 06:54:38 -07:00
96352726bb
Sharding p2p: minor typo fixes
2021-05-22 10:31:10 -07:00
bca467c926
fmt
2021-05-21 14:36:43 -06:00
5bf01c4298
add resourceunavailable error code with more guidance
2021-05-21 14:24:58 -06:00
e50d8d4391
Merge branch 'dev' into config-rework
2021-05-20 23:31:49 +02:00
ff021da551
change line formatting, new refence as config var implicitly takes more space
2021-05-19 17:21:30 +02:00
291168e1e3
clarify config/preset separation, address review comments by @djrtwo
2021-05-19 17:15:34 +02:00
c03c72a543
Altair fork: add a link
2021-05-18 13:50:46 -07:00
248363ce21
Merge pull request #2419 from terencechain/patch-120
...
Fix `PARTICIPATION_FLAG_WEIGHTS` to use correct head weight
2021-05-18 11:27:36 -06:00
441992c779
Fix typing problem in `sharding.process_block`
2021-05-18 14:14:43 +03:00
ef8d6003d3
fix inactivity penalties markdown table
2021-05-18 10:07:35 +02:00
2c7a68406f
update config section markdown table header
2021-05-18 09:55:25 +02:00
e4593d2d0c
update with configs<>presets separation
2021-05-18 09:55:20 +02:00
c1f1adb4d1
Custody Game constant/preset/config separation
2021-05-18 09:33:07 +02:00
4941a97829
Sharding constant/preset/config separation
2021-05-18 09:33:05 +02:00
7d59016bb8
Merge constant/preset/config separation
2021-05-18 09:31:07 +02:00
7689ebb2bd
Altair constant/preset/config separation
2021-05-18 09:28:09 +02:00
b9ffd8f640
Phase0 constant/config/preset separation
2021-05-18 09:20:41 +02:00
a7344b3ee1
Fix `PARTICIPATION_FLAG_WEIGHTS` to use correct head weight
2021-05-17 21:35:43 -07:00
fcf37895ba
remove duplicate sharding config var, fix minimal-sharding-config fork epoch name
2021-05-18 00:48:59 +02:00
abda2dd5fa
Sharding: move `get_committee_count_per_slot` to the outside
2021-05-14 12:02:46 -07:00
c87333face
minor review from dankrad on release pr
2021-05-14 10:05:54 -06:00
110e6b38ee
remove resourceunavailable for more discussion
2021-05-14 08:07:08 -06:00
5984fd74b3
Merge pull request #2393 from Nashatyrev/cosmetics/blob-subnet-name
...
[Sharding] Network: Calculate {subnet_id} for shard_blob_ subnets
2021-05-14 14:49:09 +02:00
a1e64c1ceb
Merge pull request #2368 from Nashatyrev/fix/root-for-empty-shard-header
...
[Sharding] Calc the right root with respect to (slot, shard) for an empty PendingShardHeader
2021-05-14 14:44:56 +02:00
4cd9a6c710
Merge pull request #2385 from ethereum/execution-payload-testing
...
Execution payload tests
2021-05-14 06:40:40 -06:00
86792b9232
Merge pull request #2411 from ethereum/order-indices
...
ensure indices are ordered [source, target, head] everywhere
2021-05-14 14:38:26 +02:00
160b704f4a
ensure indices are ordered source, target, head everywhere
2021-05-14 06:19:29 -06:00
5dd29b6659
fix tests and minor copy edit
2021-05-14 06:15:48 -06:00
1310105174
Return non-duplicated sync committee subnets
2021-05-13 16:22:28 -07:00
d3160ba23a
update ExecutionEngine protocol arg references
2021-05-14 01:07:22 +02:00
d38af7a158
Merge branch 'dev' into vbuterin-patch-11
2021-05-13 13:39:05 -06:00
699a3f837e
pr feedback
2021-05-13 13:38:43 -06:00
a52565aa81
add random altair fork tests for better translation coverage + pr review
2021-05-13 13:21:43 -06:00
a2c8e0e6c6
Merge branch 'dev' into translate-participation-test
2021-05-13 06:33:06 -06:00
4a91c93962
add epoch processing tests for inactivity udpates
2021-05-12 15:06:32 -06:00
24f6e1e99f
Merge branch 'dev' into vbuterin-patch-11
2021-05-12 12:42:46 -06:00
a469b467ff
Merge branch 'dev' into keep-inactivity-function
2021-05-12 12:27:15 -06:00
5188671816
Update specs/altair/beacon-chain.md
...
Co-authored-by: dankrad <dankrad@ethereum.org>
2021-05-12 12:18:35 -06:00
a0f86d19d3
Merge pull request #2407 from ethereum/ralexstokes-patch-1
...
Update validator guide with restricted sync committee computation
2021-05-12 12:18:06 -06:00
9a0be85b1e
Merge pull request #2406 from ethereum/sync-seed
...
remove sync committee seed and restrict period calculation boundaries
2021-05-12 12:17:42 -06:00
4286f85a68
Update validator guide with restricted sync committee computation
2021-05-12 11:05:41 -07:00
a8791f04c7
'get_sync_committee -> get_next_sync_committee
2021-05-12 09:44:13 -06:00
84830e8f26
Merge pull request #2131 from ethereum/bbr-ws
...
BlocksByRange under WS
2021-05-12 08:51:16 -06:00
1a7aa898ab
Merge branch 'dev' into sync-seed
2021-05-12 08:46:11 -06:00
dff12dd644
Merge pull request #2400 from ethereum/sync-committee-off-by-1
...
add logic for handling sync committee off by one issue
2021-05-12 08:45:05 -06:00
6371707779
Apply suggestions from code review
...
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2021-05-12 08:40:34 -06:00
f52f067b8e
add resourceunavailable error code
2021-05-12 08:36:27 -06:00
82b7a7be3b
Apply suggestions from code review
...
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Co-authored-by: Jacek Sieka <jacek@status.im>
2021-05-12 08:29:42 -06:00
8e07ece492
Minor rephrase
2021-05-12 14:11:33 +08:00
0390ab819a
Protocols pyspec support + execution payload tests cleanup
2021-05-12 02:40:23 +02:00
8bb0531f58
only give counter-weight penalty if leak. TMP
2021-05-11 16:23:31 -06:00
09cefa03f3
remov sync signature todo
2021-05-11 16:07:24 -06:00
468f42c545
Merge branch 'simplify-sync-committee-calc' into sync-seed
2021-05-11 16:03:19 -06:00
200c049778
fix seed calc issue
2021-05-11 15:55:33 -06:00
2747882776
use current_Epoch seed when calculating next_sync_committee
2021-05-11 15:18:18 -06:00
43ba615b75
Apply suggestions from code review
2021-05-11 14:13:22 -06:00
859a7d743e
Only allow sync committee period calculation at period boundaries
2021-05-11 12:42:21 -07:00
f328f77e65
clarify fork upgrade conditions
2021-05-11 10:58:45 -07:00
a9cc036184
remove timely_head penalty
2021-05-11 11:48:26 -06:00
488ceed4f9
add notes about repeatedly failing tos erve blocks as being disconncetable
2021-05-11 11:29:37 -06:00
554f5141d3
Replace the {shard}_{slot} with {subnet_id}. Add {subnet_id} calculation function
2021-05-11 20:16:58 +03:00
5792afca46
Merge branch 'dev' into bbr-ws
2021-05-11 09:51:57 -06:00
e31a2af87b
remove extra if
2021-05-11 08:15:04 -06:00
b1d0364105
Merge branch 'dev' into vbuterin-patch-11
2021-05-11 08:12:27 -06:00
3c609e02ea
pr feedback
2021-05-11 07:28:24 -06:00
a6b8574962
test
2021-05-10 16:18:42 -06:00
85198fabfa
lint
2021-05-10 13:26:43 -06:00
d8e2d19ecc
spelling
2021-05-10 13:01:31 -06:00
ff706e5c7a
add logic for handling sync committee off by one issue
2021-05-10 12:57:11 -06:00
1494fe6ace
add get_inactivity_penalty_deltas back in
2021-05-10 12:21:49 -06:00
cd78425570
lint
2021-05-10 10:30:47 -06:00
95e2aa6471
Merge branch 'dev' into dankrad-altair-review
2021-05-10 10:23:38 -06:00
1564f6217f
Merge pull request #2386 from Nashatyrev/fix/effective-balance-max-deviation
...
[Sharding] Fix the EFFECTIVE_BALANCE_MAX_DOWNWARD_DEVIATION constant calculation
2021-05-10 10:19:00 -06:00
f58ba8f5b2
define execution engine protocol
2021-05-10 16:11:12 +02:00
71eea1a0f1
Merge pull request #2382 from ethereum/vbuterin-patch-12
...
Reorganization of config params to put sync committee in one section
2021-05-10 07:48:17 -06:00
d239b7a59b
Merge pull request #2396 from terencechain/patch-117
...
Shard fees: `adjustment_quotient` to use `previous_epoch`
2021-05-10 07:44:40 -06:00
dd9fb06d25
Merge branch 'dev' into vbuterin-patch-12
2021-05-10 07:38:32 -06:00
2539d4e11d
Merge pull request #2380 from ethereum/merge-test-vectors
...
Merge test vectors: enable phase0 tests for Merge + start on new testing
2021-05-10 07:30:21 -06:00
e38f758d21
`adjustment_quotient` to use `previous_epoch`
2021-05-09 17:08:54 -07:00
b336b710e9
Update specs/altair/beacon-chain.md
...
Co-authored-by: vbuterin <v@buterin.com>
2021-05-07 16:48:16 -07:00
d1bedbfbec
Update inactivity penalty deltas processing
...
Two main changes:
1. Inactivity scores are modified to decrease slowly for inactive validators when we are not in a leak, and quickly for active validators
2. The inactivity penalties are applied even not during a leak (note that inactivity _scores_ decrease when outside of a leak)
This has the effect that the inactivity leak "overshoots" the target of finalizing again, and keeps leaking balances a bit more. For inactive validators, this PR sets post-leak recovery to happen 3x faster than the during-leak increase, so if a validator loses 3% during a leak, if they stay offline they should expect to lose another 1% until their score decreases back to zero.
2021-05-07 11:05:27 -07:00
04a9595415
Add notes about sync committee stability
2021-05-07 10:06:44 -07:00
86104ea361
Use stable sync committee indices when processing block rewards
2021-05-07 09:55:21 -07:00
bd376fa649
Fix the table of contents
2021-05-07 17:09:03 +03:00
22b7c393cc
Include {slot} param to shard_blob_ subnets
2021-05-07 16:52:44 +03:00
2fc68c451e
Update specs/altair/beacon-chain.md
...
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
2021-05-06 22:55:55 +01:00
ba2c717bf1
Remove PARTICIPATION_FLAGS
2021-05-06 22:55:17 +01:00
637cf0743c
Merge pull request #2376 from ralexstokes/adjust-sync-committee-subnet-count
...
Adjust subnet count to reflect smaller sync committees
2021-05-06 12:51:24 -06:00
b979ea144a
Merge pull request #2378 from ralexstokes/update-altair-sync-protocol
...
Updates to Altair light client sync protocol
2021-05-06 12:50:52 -06:00
13409dc1bc
Merge branch 'dev' into adjust-sync-comm-params
2021-05-06 12:43:11 -06:00
609172d790
Merge pull request #2370 from ralexstokes/simplify-sync-committee-aggregates
...
Simplify sync committee aggregates
2021-05-06 12:38:49 -06:00
4c73fec88e
convert `LightClientStore` to python object instead of SSZ object
...
this avoids the type overhead of having to define a max size for
the object's data and skips the overhead of serialization/consensus
for a type that does not need it
2021-05-06 10:52:48 -07:00
81a8c2748f
Integrate get_inactivity_penalty_deltas into reward computation for better readability
2021-05-06 13:03:26 +01:00
cf724daa7a
No inactivity penalty for untimely head
2021-05-06 12:42:05 +01:00
cbf9f85537
Remove duplicate inactivity leak
2021-05-06 12:28:18 +01:00
ea6c042918
Altair: carry-over prev epoch participation
2021-05-06 10:55:10 +10:00
76b5974d11
is_execution_enabled function + misc review fixes
...
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2021-05-06 02:23:13 +02:00
b041a9b0d6
Further flag_index revert
2021-05-05 22:22:32 +01:00
77524036f5
Revert "Flags to BitVector"
...
This reverts commit 786e611c71
2021-05-05 22:02:37 +01:00
55471bc5d4
Revert "BitVector -> Bitvector"
...
This reverts commit df6bd1b6c3
2021-05-05 21:58:03 +01:00
687641a79b
Remove extra variable
2021-05-05 21:55:36 +01:00
227d1007e6
Update toc
2021-05-05 20:09:14 +01:00
a382cf6d5c
Refactor participation flag list
2021-05-05 20:04:06 +01:00
2aef63be01
Fix back the EFFECTIVE_BALANCE_MAX_DOWNWARD_DEVIATION constant calculation
2021-05-05 20:17:09 +03:00
238a9b03fc
Correct confusing comments in "get_sync_committee_indices"
2021-05-05 18:09:36 +01:00
a2cf833437
Update specs/altair/beacon-chain.md
...
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2021-05-05 09:32:28 -07:00
ed4b8d5f18
`get_shard_proposer_index` to use `DOMAIN_SHARD_PROPOSER`
2021-05-05 07:40:23 -07:00
e2be7614cc
introduce merge fork version
2021-05-05 15:35:36 +02:00
ded6d5bad4
Merge pull request #2377 from ralexstokes/altair-whitespace
...
clean up whitespace on altair files
2021-05-05 20:44:15 +08:00
6a9b3671f0
Fix the type of `EPOCHS_PER_SYNC_COMMITTEE_PERIOD` and update the config files
2021-05-05 19:53:37 +08:00
d383a14213
Fix ToC
2021-05-05 19:47:26 +08:00
df6bd1b6c3
BitVector -> Bitvector
2021-05-05 12:26:37 +01:00
786e611c71
Flags to BitVector
2021-05-05 12:05:32 +01:00
3cc1256a72
update_pending_votes: search pending header by header.(root + slot + shard)
2021-05-05 13:31:19 +03:00
befe4c7db3
Revert "Search winning 'empty' PendingShardHeader index by the empty DataCommitment instead of zero Root"
...
This reverts commit dca6d337
2021-05-05 13:21:25 +03:00
ddc59422ba
Revert "Calc the right root with respect to (slot, shard) for an empty PendingShardHeader"
...
This reverts commit 2199b8e0
2021-05-05 13:21:15 +03:00
79fc41146d
Adjust is_transition_block call in fork-choice
2021-05-05 13:37:07 +06:00
b310482bce
Update specs/altair/beacon-chain.md
2021-05-04 17:19:51 -07:00
9dcdbafba3
Reorganization of config params to put sync committee in one section
...
This may be marginally "cleaner" than the previous approach, keeping constants with the same topic together.
2021-05-04 17:19:15 -07:00
a562f2aeb4
"toward" -> "closer to" for penalty adjustments
...
Makes it clearer that even the Altair values are not final
2021-05-04 17:05:15 -07:00
521cffc3e9
update execution-payload processing to isolate payload from block body
2021-05-05 00:17:10 +02:00
3b80324119
Compute `LIGHT_CLIENT_UPDATE_TIMEOUT` in lieu of maintaining a constant
2021-05-04 13:47:46 -07:00
7a168be862
allow fault tolerance equal to threshold, not just above
2021-05-04 13:25:34 -07:00
eae64fd18c
clean up whitespace on altair files
2021-05-04 12:43:21 -07:00
7d236561bd
adjust subnet count to reflect smaller sync committees
2021-05-04 12:41:19 -07:00
9c3d5982cf
add documentation about duplicate pubkeys
2021-05-04 12:20:48 -07:00
7b33c1119a
simplify sync committee pubkey aggregation in altair
2021-05-04 12:19:33 -07:00
0438f2f27c
whitespace
2021-05-04 12:19:33 -07:00
8558bd773d
Merge pull request #2367 from Nashatyrev/fix/unknown-shard-count-const
...
[Sharding] Fix unspecified SHARD_COUNT and DOMAIN_SHARD_HEADER constants
2021-05-04 21:13:29 +02:00
9980d2098d
Fix lint
2021-05-04 22:21:58 +08:00
80df9e6b0b
Merge branch 'dev' into altair-pass
2021-05-04 07:41:25 -06:00
053179cee9
comments and tests on altair
2021-05-04 07:39:22 -06:00
930ca61690
Fix lint (124 > 120 characters)
2021-05-02 20:47:57 -07:00
780121f9b0
Add backticks to the arguments in functional comments
2021-05-02 20:31:52 -07:00
68d6e4319a
Adjust sync committee size and duration
2021-05-01 16:30:23 -07:00
dca6d3370a
Search winning 'empty' PendingShardHeader index by the empty DataCommitment instead of zero Root
2021-04-30 15:21:51 +03:00
2199b8e0f0
Calc the right root with respect to (slot, shard) for an empty PendingShardHeader
2021-04-30 14:58:30 +03:00
99d50108d0
Replace unspecified SHARD_COUNT const with get_active_shard_count(previous_epoch)
2021-04-30 14:39:37 +03:00
637f232ab3
Need to specify MAX_SHARDS since we are filling the Vector of MAX_SHARDS length
2021-04-30 14:35:34 +03:00
36fd9195f3
Replace unspecified DOMAIN_SHARD_HEADER const with DOMAIN_SHARD_PROPOSER
2021-04-30 14:14:09 +03:00
86d8a10495
Replace unspecified SHARD_COUNT const with get_active_shard_count(previous_epoch)
2021-04-30 14:09:09 +03:00
c5986106ca
fix note about sharding beacon state extension
2021-04-29 15:39:57 +02:00
c3dfc2e085
Merge pull request #2362 from ethereum/sync-cleanup
...
Minor altair cleanups
2021-04-28 08:42:23 -06:00
e89fae86a6
Apply suggestions from code review
...
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2021-04-28 06:52:16 -06:00
9f74f1f9e5
minor sync committee cleanups
2021-04-27 15:06:45 -06:00
2628721f96
Merge pull request #2323 from ethereum/prepare_state
...
Simplify Altair "genesis"
2021-04-27 12:32:13 -06:00
c090d6aa21
Merge pull request #2352 from ralexstokes/add-altair-metadata-updates
...
Add `syncnets` data to Altair `MetaData`
2021-04-27 12:20:03 -06:00
ae429a38a0
add Modified comment
2021-04-27 12:11:15 -06:00
9bb3444c89
Add `syncnets` data to Altair `MetaData`.
2021-04-27 09:34:24 -07:00
e3c95e967c
use `committee_index` instead of `shard`
2021-04-27 17:09:16 +03:00
a0c30313fa
convert `shard` to `CommitteeIndex` using `compute_committee_index_from_shard`, based on @djrtwo comment
2021-04-27 17:07:56 +03:00
4d684bd8d9
convert `shard` to `CommitteeIndex` in `charge_confirmed_header_fees`
2021-04-27 15:44:25 +03:00
865a077aa3
convert `shard` and `index` to `CommitteeIndex` in `reset_pending_headers`
2021-04-27 14:14:25 +03:00
17bc3c1c72
convert `shard` to `CommitteeIndex` when passing to `get_beacon_committee`
2021-04-27 13:44:22 +03:00
f2c47debb9
Merge pull request #2355 from ericsson49/ericsson49/fix_upgrade_to_altair
...
Fix: `upgrade_to_altair` should use `phase0.get_current_epoch`
2021-04-26 20:34:33 +02:00
ac98da6c7d
Merge pull request #2359 from ericsson49/ericsson49/fix_pass_set_instead_of_sequence_to_get_total_balance
...
Fix: pass Set instead of Sequence to get_total_balance
2021-04-26 20:31:15 +02:00
fd9c96d41d
Merge pull request #2358 from ericsson49/ericsson49/fix_process_shard_header
...
More typos fixes in `sharding`
2021-04-26 20:27:07 +02:00
d99cfee853
typing problem fixed: `get_total_balance` expected second argument to be of `Set[ValidatorIndex]` type, however, `Sequence` is passed
2021-04-24 18:21:59 +03:00
6288252d44
fix typo: `process_confirmed_header_fees` called instead of `charge_confirmed_header_fees`
2021-04-24 17:46:55 +03:00
e05356893f
fix typo: `c` var name used instad of `header` in `process_pending_headers`
2021-04-24 17:38:09 +03:00
77bceeae69
fix typo: `SLOTS_IN_EPOCH` used instead of `SLOTS_PER_EPOCH`
2021-04-24 17:33:53 +03:00
6814efac2e
fix typo: `state` missed in `get_committee_count_per_slot` call
2021-04-24 17:32:59 +03:00
47e52a6361
fix typo: `get_shard_proposer_index` vs `get_shard_proposer`
2021-04-24 17:32:05 +03:00
ee360df689
missed `body_summary` attribute when accessing`ShardBlobBodySummary.beacon_block_root`
2021-04-24 00:12:28 +03:00
f55b327c51
fix typos in sharding
2021-04-23 18:47:25 +03:00
93378afcd0
Fix typing problem: `upgrade_to_altair` should use `phase0.get_current_epoch`
2021-04-23 18:21:29 +03:00
Danny Ryan
Hsiao-Wei Wang
protolambda
Mikhail Kalinin
Anton Nashatyrev
terence tsao
Justin
Nishant Das
ericsson
Alex Stokes
vbuterin
Paul Hauner
dankrad
Dankrad Feist
Michael Sproul