Commit Graph

2942 Commits

Author SHA1 Message Date
Danny Ryan 52a6cf7ba3
Merge pull request #1514 from ethereum/queue-fix-on-finality
Fix queue rate and only activate upon finality
2019-12-12 07:44:57 -07:00
Danny Ryan 199933cb26
fix tocs 2019-12-12 06:57:11 -07:00
Danny Ryan 86fb3acd59
minor changes to finality in activation queue 2019-12-12 06:53:56 -07:00
Danny Ryan 19ec01e4e9
add comment about activation queue sort order
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-12 06:43:37 -07:00
ethers 3d48a3e9eb
Fix dead link to use Internet Archive 2019-12-11 18:17:20 -08:00
protolambda 2405060a7e
Fixes #1486: disallow duplicate indices in indexed attestation 2019-12-12 01:45:59 +01:00
Danny Ryan e117b58ae2
add queue eligibility helper 2019-12-11 16:10:18 -07:00
Danny Ryan 6610aeea2f
fix activation queue to finality 2019-12-11 16:00:46 -07:00
Danny Ryan 40025c96dd
Merge pull request #1509 from ethereum/match-slot-target
ensure that epoch of attestation slot matches the target epoch
2019-12-10 13:42:32 -07:00
Danny Ryan 66652d0ebd
Merge pull request #1508 from ethereum/better-best
ensure the best better-justification is stored in fork choice
2019-12-10 13:41:45 -07:00
Danny Ryan 4636b3e824
Merge pull request #1510 from ethereum/genesis-slot-time
explicit use of GENESIS_SLOT in fork choice
2019-12-10 13:41:13 -07:00
Danny Ryan e4d710590a
add test for queue efficiency 2019-12-10 11:49:26 -07:00
Danny Ryan d126162ca8
fix activation queue efficiency 2019-12-10 11:25:55 -07:00
Martin Lundfall ca2b6a0e52 Use consistent header level for TOC generation 2019-12-10 18:29:50 +01:00
Martin Lundfall 12ff64ea1a Update ToC of specs to consistent use of doctoc 2019-12-10 18:29:40 +01:00
Danny Ryan 2c5c9cb71a
feedback from mikhail 2019-12-10 10:14:49 -07:00
Danny Ryan 8861ca0282
minor typo
Co-Authored-By: MrChico <martin.lundfall@protonmail.com>
2019-12-10 10:05:19 -07:00
Danny Ryan 9989f3ea9d
ensure fork choice functions when GENESIS_SLOT != 0 2019-12-09 19:02:16 -07:00
Danny Ryan 432257659e
add asserts to ensure that attestation slot must match the target epoch 2019-12-09 17:31:43 -07:00
Danny Ryan d4d17ecc4e
ensure the best better-justification is stored in fork choice 2019-12-09 16:47:43 -07:00
Danny Ryan 57aeed1473
Merge branch 'v09x' into filter-fc-justified 2019-12-08 12:17:28 -07:00
Danny Ryan e53a6daecc
clarify fliter block tree through two line usage
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-08 11:53:45 -07:00
Diederik Loerakker da17f4b3a8
Merge pull request #1505 from ethereum/v09x
backport V09x
2019-12-05 22:15:47 +01:00
Danny Ryan 7af6945f53
Merge pull request #1491 from ethereum/rm-signing-root
rm signing root (fixes #1487)
2019-12-05 13:16:39 -07:00
Danny Ryan dfcd6f6402
add tests for block filter in get_head 2019-12-04 16:53:55 -07:00
Danny Ryan e9dc2a1f03
Merge pull request #1492 from terencechain/patch-91
Remove duplicated attestation target root check
2019-12-04 11:49:08 -07:00
protolambda afb9a1d7c0
move signed envelopes 2019-12-03 21:34:48 +01:00
protolambda 103a66b2af
remove signing_root: see issue #1487 2019-12-03 21:10:19 +01:00
terence tsao 0f4faf11ab
Update 0_fork-choice.md 2019-12-03 17:25:56 +08:00
terence tsao 1113953a59
Update p2p-interface.md 2019-12-03 17:17:17 +08:00
Danny Ryan 2275cdfeb8
fix child filter in get_head 2019-11-27 13:26:44 -07:00
Danny Ryan 5aa9f96558
Update specs/core/0_fork-choice.md
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2019-11-27 13:11:30 -07:00
Danny Ryan 8021f34c06
fix existing fork choce tests with new filter 2019-11-25 15:44:22 -07:00
Danny Ryan 9004bcf1a5
WIP filter block tree 2019-11-25 15:06:33 -07:00
Danny Ryan 23abc11093
handle v0.9.2-dev conflict 2019-11-21 15:18:17 -07:00
Danny Ryan 3e96b43894
Merge pull request #1467 from ethereum/reduce-genesis-count
reduce genesis validator count for mainnet config
2019-11-18 13:30:04 -07:00
Danny Ryan 6ef79ac2a8
Merge pull request #1480 from ethereum/ssz-bytes-naming
Rename BytesN to ByteVector, rename Bytes to ByteList
2019-11-18 13:28:32 -07:00
Hsiao-Wei Wang 8fed220736
Update `AggregateAndProof` and rename `slot_signature` to `get_slot_signature`
1. Reorder the fields to fit the container name
2. Rename `AggregateAndProof.index: ValidatorIndex` to `AggregateAndProof.aggregator_index: ValidatorIndex`
    - Since we also have similar naming style like
`ProposerSlashing.proposer_index` or `VoluntaryExit.validator_index`
2019-11-18 21:35:12 +08:00
Diederik Loerakker b15669b7a5 Backport master (v0.9.1) to dev (#1482)
* p2p-interface: clarify that signing_root is used for block requests

* hash cleanups

* one more hash tree root gone for blocks - block hashes are always
signing roots!
* use simple serialize data types consistently

* Describe which finalized root/epoch to use

* remove custody_bits from attestation

* remove AttestationDataAndCustodyBit

* Specify inclusive range for genesis deposits

* add initial fork choice bounce prevention and tests

* PR feedback

* further test bounce attack

* wipe queued justified after epoch transition

* remove extra var

* minor fmt

* only allow attestatiosn to be considered from current and previous epoch

* use best_justified_checkpoint instead of queued_justified_checkpoints

* use helper for slots since epoch start

* be explicit about use of genesis epoch for previous epoch in fork choice on_block

* pr feedback

* add note aboutgenesis attestations

* cleanup get_eth1_vote

* make eth1_follow_distance clearer

* Update the expected proposer period

Since `SECONDS_PER_SLOT` is now `12`

* minor fix to comment in mainnet config

* Update 0_beacon-chain.md
2019-11-15 16:27:04 -05:00
protolambda 2c32274870
rename BytesN to ByteVector, rename Bytes to ByteList 2019-11-15 16:56:52 +01:00
Danny Ryan 89fa914e73
Merge pull request #1478 from ethereum/hash-type-fix
Avoid Hash <> hash() type and func confusion
2019-11-12 16:41:21 -07:00
Danny Ryan 1aad31df59
Merge pull request #1477 from ethereum/forkchoice-future-blocks
Forkchoice mods
2019-11-12 16:40:32 -07:00
Danny Ryan 117fb12888
add scheduling note to on_attestation 2019-11-12 16:24:33 -07:00
protolambda c061abdd75
Avoid Hash <> hash() type and func confusion, intro Root and change to non-roots to Bytes32 2019-11-12 21:29:58 +01:00
Danny Ryan e3a67fe52c
ensure not all validators switch at once 2019-11-12 12:00:30 -07:00
Danny Ryan 74253bdbaf
attestations for future blocks not valid in fork choice 2019-11-12 11:29:46 -07:00
Danny Ryan 29b073bcca
add random subnet subscriptions for phase 0 stability 2019-11-11 14:46:30 -07:00
Danny Ryan 32e6623915
clarify topic subscriptions for attestations 2019-11-11 14:27:46 -07:00
terence tsao 931ad45c53
Update 0_beacon-chain.md 2019-11-08 11:45:11 -07:00
Hsiao-Wei Wang a029db3410
Update the expected proposer period
Since `SECONDS_PER_SLOT` is now `12`
2019-11-08 19:05:14 +08:00
Diederik Loerakker f0999573f7
Merge pull request #1469 from ethereum/fix-eth1-distance
Clarify `previous_eth1_distance`
2019-11-07 20:37:36 +01:00
Danny Ryan c84dce7b32
make eth1_follow_distance clearer 2019-11-07 12:32:02 -07:00
Danny Ryan 5159c69632
cleanup get_eth1_vote 2019-11-07 12:15:56 -07:00
Danny Ryan e7f71886b0
Merge pull request #1466 from ethereum/decoy-flip-flop
Decoy flip flop resistance
2019-11-08 03:10:41 +08:00
Danny Ryan 9b21c0db93
add note aboutgenesis attestations 2019-11-07 12:06:23 -07:00
Danny Ryan f331b55b9e
Merge pull request #1465 from ethereum/bounce-attack
Bounce attack resistance
2019-11-08 02:56:46 +08:00
Danny Ryan bf78a71152
pr feedback 2019-11-07 11:51:53 -07:00
Danny Ryan 9ddae15e2e
reduce genesis validator count for mainnet config 2019-11-06 20:32:25 -07:00
Danny Ryan a28c027943
be explicit about use of genesis epoch for previous epoch in fork choice on_block 2019-11-06 17:26:06 -07:00
Danny Ryan e1d2823810
Merge branch 'bounce-attack' into decoy-flip-flop 2019-11-06 17:20:59 -07:00
Danny Ryan 09fd49ce89
use helper for slots since epoch start 2019-11-06 17:20:21 -07:00
Danny Ryan fc40bff2a8
use best_justified_checkpoint instead of queued_justified_checkpoints 2019-11-06 17:10:32 -07:00
Danny Ryan 4f42f63e4e
only allow attestatiosn to be considered from current and previous epoch 2019-11-05 13:01:58 -07:00
Danny Ryan 2616210637
minor fmt 2019-11-05 12:51:47 -07:00
Danny Ryan ba6637b4d9
remove extra var 2019-11-05 11:42:40 -07:00
Danny Ryan 79911a93b4
Merge pull request #1462 from ethereum/remove-custody
Remove custody_bits and AttestationDataAndCustodyBit
2019-11-06 02:03:50 +08:00
Danny Ryan e20e11e0b5
wipe queued justified after epoch transition 2019-11-05 11:02:58 -07:00
Danny Ryan 97d7cf5190
further test bounce attack 2019-11-05 10:58:45 -07:00
Danny Ryan 40a21dc3ad
PR feedback 2019-11-05 09:08:37 -07:00
Danny Ryan 405e218598
add initial fork choice bounce prevention and tests 2019-11-05 08:55:34 -07:00
Paul Hauner 1c99ab2c96
Specify inclusive range for genesis deposits 2019-11-04 10:55:14 +11:00
Danny Ryan 600265a311
remove AttestationDataAndCustodyBit 2019-11-01 21:12:32 -06:00
Danny Ryan 65b615a4d4
remove custody_bits from attestation 2019-11-01 21:02:53 -06:00
Jacek Sieka af5238ad9a
Describe which finalized root/epoch to use 2019-11-01 08:42:10 +01:00
terence tsao 2159df2d12
Update 0_beacon-chain.md 2019-10-31 21:31:08 -07:00
Jacek Sieka 1dc09e8567
hash cleanups
* one more hash tree root gone for blocks - block hashes are always
signing roots!
* use simple serialize data types consistently
2019-10-31 17:32:08 +01:00
Nathaniel Jensen 5dd0015912
Update link to current bls standard draft. 2019-10-30 10:29:42 +11:00
Jacek Sieka 351dcd4bb8
p2p-interface: clarify that signing_root is used for block requests 2019-10-29 08:49:03 +01:00
Danny Ryan 60a469b9c7
Merge pull request #1440 from ethereum/naive-aggregation
Naive aggregation strategy
2019-10-28 17:42:13 +08:00
Danny Ryan 09de5957d2
Merge pull request #1454 from ethereum/forkchoice-tests-fixed
Forkchoice tests fixed
2019-10-28 17:21:15 +08:00
Danny Ryan 04c20aeb28
add expicit ranges for valid attesation propogation range 2019-10-28 18:19:17 +09:00
Danny Ryan 3bb6aec3ab
Clarify committee_index subnets by defining and using "subnet" var
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-10-28 17:10:48 +08:00
Danny Ryan 43132a3082
[reopen] Eth2 shorthand standardized (#1452)
* Update README.md

* Update README.md

* Update p2p-interface.md

* Update simple-serialize.md

* Update README.md

* Update initialization.md

* Update README.md

* Update 0_beacon-chain-validator.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md
2019-10-28 15:53:10 +08:00
terence tsao 34ba645f7e
Update specs/core/0_fork-choice.md
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2019-10-28 08:48:22 +01:00
terence tsao bb5a721707
Update 0_fork-choice.md 2019-10-28 08:48:15 +01:00
Diederik Loerakker a6cecaf212
Merge pull request #1401 from ethereum/conversion-comments
add explicit comments for int_to_bytes and bytes_to_int
2019-10-28 08:33:34 +01:00
Diederik Loerakker 257fcd9c79
typo 2019-10-28 08:29:01 +01:00
Danny Ryan 913a231a16
Merge pull request #1410 from wemeetagain/patch-3
sync protocol: clarify committee type
2019-10-28 15:26:31 +08:00
Danny Ryan 6fc1feaa2a
rearrange some of the gossip info in response to hwwhww review 2019-10-28 16:15:26 +09:00
Danny Ryan e8fc84eadc
Update specs/networking/p2p-interface.md
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-10-28 15:00:55 +08:00
Danny Ryan 795105a1f4
Merge branch 'dev' into naive-aggregation 2019-10-28 15:58:49 +09:00
Danny Ryan 6570340e04
Merge branch 'master' into master-to-dev 2019-10-28 15:27:41 +09:00
Danny Ryan c547c5291d
Merge pull request #1447 from ethereum/early-committee-bias
Implement solution for #1446, based on suggested use of eth1 hash
2019-10-28 14:10:50 +08:00
Danny Ryan 810266fbf4
Merge pull request #1443 from ethereum/remove-transfers
Remove transfers from phase 0
2019-10-28 14:10:26 +08:00
Danny Ryan 364781b934
Merge pull request #1428 from ethereum/phase0-simplify
Remove Shards/Crosslinks from Phase 0
2019-10-28 14:07:39 +08:00
Hsiao-Wei Wang 2d59ca6d57
Update ToC 2019-10-28 12:43:29 +08:00
Justin 09339f2f17
Update 0_beacon-chain.md 2019-10-27 18:18:48 +00:00
protolambda e6e203ce85
randaomixes init now with eth1 hash repeat 2019-10-27 16:20:35 +01:00
Danny Ryan d6563bce2d
minor edits to p2p faq 2019-10-27 12:51:46 +09:00
Danny Ryan 6a62cfd3f5
gossip cleanup 2019-10-27 12:41:43 +09:00