Danny Ryan
b88ab250fa
Merge branch 'dev' into committee-roots
2019-06-28 12:07:50 -06:00
vbuterin
c764202a57
Slashing penalty calculation change ( #1217 )
...
If the exit queue is very long, then a validator may take many months to exit. With the code as currently written, however, self-slashing is a potentially lucrative route to get one's money out faster, because one can exit in 36 days.
This PR changes it so that slashing can only extend your withdrawal time, not contract it. Also, instead of the slashed balances used to calculate one's slashing penalty being those in `[withdrawal - 54 days ... withdrawal - 18 days]`, we now run the penalization algorithm once every 36 days that a validator is slashed but not withdrawn, so that it covers the 36-day period where the validator was actually slashed. It also moves the minimum slashing penalty to the `slash_validator` function so that it is only applied once.
We also simplify the `slashed_balances` logic to be per-epoch.
2019-06-28 14:35:26 +01:00
Carl Beekhuizen
0ba933e088
Merge pull request #1209 from ethereum/early_secret_test
...
Resolves issue in early_secret_reveal() testing
2019-06-28 11:58:40 +02:00
Danny Ryan
140c69f2ec
Merge branch 'dev' into checkpoints
2019-06-27 21:02:48 -06:00
Carl Beekhuizen
543729cad4
Merge pull request #1198 from ethereum/fork-choice-epoch
...
modify fork choice to utilize epochs properly
2019-06-27 19:14:19 +02:00
Justin Drake
bcfe383e25
WIP
2019-06-27 08:44:44 +01:00
Diederik Loerakker
d587c4fe61
Critical fix: introduce back total-value check ( #1220 )
...
This was dropped in a376b6607fe5e6406371f44254960e891ee5ee8d, as improvement in dust checking.
Now that dust-checking is done, we still need to check if the sender has the minimum value, as decrease balance just clips to 0.
See be86f966f87958856584b3f20c095abf910a3d0c for older dust-creation problem work around, which was dropped in the above.
The bug enabled you to transfer your full balance to someone else, and pay the same amount in fee, possibly to a puppet proposer to collect back funds.
Effectively enabling printing of money. Silly bug, good to fix and introduce tests for.
2019-06-26 20:21:17 +01:00
Danny Ryan
0827fbd7d5
Merge branch 'fork-choice-epoch' into checkpoints
2019-06-25 15:00:04 -06:00
Danny Ryan
c64289677f
fix gethead tests
2019-06-25 14:47:46 -06:00
Danny Ryan
228195d89d
get head tests
2019-06-25 11:48:55 -06:00
Danny Ryan
ac06362716
Merge branch 'fork-choice-epoch' into checkpoints
2019-06-25 10:37:04 -06:00
Danny Ryan
846ca649aa
properly construct genesis latest block header in tests
2019-06-25 10:36:11 -06:00
Carl Beekhuizen
f29b693a9c
Merge dev -> early_spec_test
2019-06-25 17:11:04 +02:00
Danny Ryan
b8c0985e60
merge in fork choice. tests pass
2019-06-24 22:12:55 -06:00
Danny Ryan
bacd4b1e89
Merge branch 'fork-choice-epoch' into checkpoints
2019-06-24 21:26:28 -06:00
Danny Ryan
d9b97578c0
lint
2019-06-24 21:23:24 -06:00
Danny Ryan
751738f411
enhance fork choice testing
2019-06-24 21:01:15 -06:00
protolambda
82ae180490
clean up list limit constants
2019-06-24 23:38:36 +02:00
Carl Beekhuizen
139d0f56f1
Finishes moving mask to hash()
2019-06-24 16:26:21 +02:00
Carl Beekhuizen
d9644f518b
mask is hash() in tests
...
Co-Authored-By: dankrad <dankrad@ethereum.org>
2019-06-24 16:08:13 +02:00
Justin Drake
181a2a876a
Cleanups
2019-06-22 22:49:53 +02:00
protolambda
0249cf651e
fix lint, and update encoder to handle the few imported types well
2019-06-22 20:04:17 +02:00
Danny Ryan
8a732fbbcf
pass on checkpoints working in testing
2019-06-22 12:00:26 -06:00
protolambda
47034a6c8c
fix imports in helper test file
2019-06-22 19:59:53 +02:00
protolambda
dd5ad2e2c5
remove unnecessary (and now outdated) type hints, update List encoding for generators
2019-06-22 19:48:06 +02:00
protolambda
f95e7315b4
fix get_active_validator_indices typing usage
2019-06-22 18:34:33 +02:00
Carl Beekhuizen
a5b22e13b8
Resolves make masker sign mask
2019-06-22 16:56:16 +02:00
Hsiao-Wei Wang
183fa3c776
Make linter happy
2019-06-21 23:09:11 -06:00
Danny Ryan
8f99741344
remove commented old code
2019-06-21 14:47:18 -06:00
Danny Ryan
c09e45c5fc
fix rule_4 underflow and split out genesis finality test
2019-06-21 14:45:15 -06:00
protolambda
80c40f5e09
merge dev, resolve minor merge conflicts
2019-06-21 21:22:23 +02:00
Carl Beekhuizen
0e59c6676a
Stop yielding from fork-choie tests
2019-06-21 13:00:42 +02:00
protolambda
6648b3c49e
remove old deposits test, there is no deposit index in deposit data anymore
2019-06-21 00:23:28 +02:00
protolambda
c20372409c
comment out old deposit test, re-introduced soon maybe, cc Justin
2019-06-20 22:52:16 +02:00
protolambda
f27c44b953
fix deposit negative index fail
2019-06-20 22:49:34 +02:00
protolambda
6338c5b880
fix custody bug, needs review from Carl
2019-06-20 22:49:03 +02:00
protolambda
224c98a094
last() method, no negative index lookups
2019-06-20 20:55:17 +02:00
protolambda
4e747fb887
fixes for class based ssz typing
2019-06-20 20:25:22 +02:00
Carl Beekhuizen
e0d814df32
Merge branch 'dev' into executable_fork_choice
...
* dev:
Increase historical length and cleanups (#1196 )
2019-06-19 22:43:14 +02:00
Danny Ryan
29dbe1b880
Increase historical length and cleanups ( #1196 )
...
* increase historical length and a few cleanups
2019-06-19 20:59:44 +01:00
Carl Beekhuizen
31a4700223
Merge conflicts on dev
2019-06-17 22:09:43 -04:00
Danny Ryan
d7ac601b9e
Merge branch 'dev' into v071backport
2019-06-17 13:42:27 -06:00
Carl Beekhuizen
9f2d06b2e7
Somehow I had indented with 5 spaces everywhere.
2019-06-16 16:02:56 -04:00
Carl Beekhuizen
f421850dc9
Fixes tests! Thanks @hwwhww!
2019-06-16 15:53:42 -04:00
Carl Beekhuizen
4deb311b71
Debugging 1st test
2019-06-16 12:17:31 -04:00
Carl Beekhuizen
5d10cd63c7
SSZ (partially) handles Dicts
2019-06-16 09:52:52 -04:00
Carl Beekhuizen
061ecf7d0a
Adds fork-choice tests
2019-06-15 19:13:56 -04:00
Justin Drake
ed748a7d76
Address Danny's comments
2019-06-15 15:09:50 +01:00
Danny Ryan
a6230425b8
Merge branch 'dev' into container-cleanup
2019-06-14 10:36:41 -06:00
Danny Ryan
f834f727fa
lint
2019-06-13 18:03:20 -06:00
