Commit Graph

2255 Commits

Author SHA1 Message Date
Justin Drake ed748a7d76 Address Danny's comments 2019-06-15 15:09:50 +01:00
Danny Ryan a6230425b8
Merge branch 'dev' into container-cleanup 2019-06-14 10:36:41 -06:00
Justin 67d2585ec0
Fix #1173
The bug is that it's possible to include a participating validator which has custody bit one *without* specifying that validator in `attestation.aggregation_bitfield`. In other words, we want to check that every bit in `custody_bitfield` is zero whenever the corresponding bit in `aggregation_bitfield` is zero. Well spotted @protolambda
2019-06-13 21:01:10 +01:00
protolambda aabd2b08ad
attestations: check shard, and check epoch earlier 2019-06-13 15:51:22 +02:00
Alex Stokes f095ab43bb Update 0_beacon-chain.md (#1170)
minor typo fix
2019-06-13 10:40:02 +01:00
Hsiao-Wei Wang 48e8164e28
Add phase1 type hinting checks and fix many bugs 2019-06-12 20:08:19 -04:00
Hsiao-Wei Wang 7a366828ba
Make phase0 pass 2019-06-12 14:54:00 -04:00
Danny Ryan 12293a91b4
Merge pull request #1152 from ethereum/deposit-contract-justin
Custom genesis trigger, and deposit contract cleanups
2019-06-12 10:54:11 -06:00
Justin Drake 6a83205420 Minor copy edit 2019-06-11 15:29:34 +01:00
Hsiao-Wei Wang 6f526add79
flake8 length 2019-06-11 00:45:00 -04:00
Hsiao-Wei Wang 9f454185f8
WIP!
1. Use custom types in SSZ declaration
2. Casting
2019-06-11 00:44:54 -04:00
Danny Ryan b56539a47d
add missing colon to v-guide 2019-06-10 15:14:42 -06:00
Justin Drake 05f1a44a38 Fix tests 2019-06-10 21:20:45 +01:00
Justin Drake dc56d87eef Revert a couple of renamings 2019-06-10 21:16:51 +01:00
Justin Drake b60314e892 Merge branch 'deposit-contract-justin' of github.com:ethereum/eth2.0-specs into deposit-contract-justin 2019-06-10 16:03:08 +01:00
Justin Drake ef91ee5698 Address Danny's comments 2019-06-10 15:55:08 +01:00
Justin 05a35c7228
Tweak inclusion delay rewards and set BASE_REWARD_FACTOR
Substantive changes:

1) Split the inclusion delay reward between attester and proposer to add up to at most one base reward. This is analogous to the reward logic in `slash_validator`, and makes the `BASE_REWARDS_PER_EPOCH` constant include proposer rewards.
2) Double `BASE_REWARD_FACTOR` to 2^6 (addressing item 4 in #1054). When the total effective balance is 2^17 ETH then maximum annual issuance is a bit below 2^21 ETH. Maximum annual issuance happens when a) all validators make perfect attestations (matching source, target, head, as well as consistent crosslink data), b) all attestations are included as fast as possible (in particular, no skip blocks), and c) there are no slashings.

```python
BASE_REWARD_FACTOR = 2**6
SLOTS_PER_EPOCH = 2**6
SECONDS_PER_SLOT = 6
BASE_REWARDS_PER_EPOCH = 5
GWEI_PER_ETH = 10**9
MAX_TOTAL_EFFECTIVE_BALANCE = 2**27 * GWEI_PER_ETH
TARGET_MAX_ISSUANCE = 2**21 * GWEI_PER_ETH

def integer_squareroot(n: int) -> int:
    """
    The largest integer ``x`` such that ``x**2`` is less than or equal to ``n``.
    """
    assert n >= 0
    x = n
    y = (x + 1) // 2
    while y < x:
        x = y
        y = (x + n // x) // 2
    return x

MAX_REWARDS_PER_EPOCH = MAX_TOTAL_EFFECTIVE_BALANCE * BASE_REWARD_FACTOR // integer_squareroot(MAX_TOTAL_EFFECTIVE_BALANCE) // BASE_REWARDS_PER_EPOCH
EPOCHS_PER_YEAR = 365.25*24*60*60 / (SECONDS_PER_SLOT * SLOTS_PER_EPOCH)
MAX_REWARDS_PER_YEAR = EPOCHS_PER_YEAR * MAX_REWARDS_PER_EPOCH * BASE_REWARDS_PER_EPOCH

print(MAX_REWARDS_PER_YEAR / TARGET_MAX_ISSUANCE)
```
2019-06-10 15:14:32 +01:00
Justin 9bb0f25f18
Update specs/core/0_beacon-chain.md
Co-Authored-By: NIC Lin <twedusuck@gmail.com>
2019-06-10 13:41:28 +01:00
Justin 36a6c1bf1f
Set MIN_ATTESTATION_INCLUSION_DELAY to 1
See item 7 of #1054. We should consider increasing the slot duration as well.
2019-06-09 21:30:42 +01:00
Justin Drake 565f61dfaa Cleanup containers 2019-06-09 20:41:21 +01:00
terence tsao 8b54c90fd6
Update 0_beacon-chain-validator.md 2019-06-09 12:09:54 -07:00
Justin Drake 4ee00c9cbd Address HW's comments 2019-06-09 11:03:38 +01:00
Hsiao-Wei Wang 11f2cd189a Fix the Vyper contract link (#1154) 2019-06-08 23:48:34 +01:00
Justin Drake d1e589f11f Remove eth2 genesis in favour of genesis trigger 2019-06-08 19:00:50 +01:00
Carl Beekhuizen 68fc0bf87d
Merge branch 'dev' into dankrad-patch-7
* dev:
  Update simple-serialize.md
2019-06-06 23:31:36 +02:00
terence tsao 84ce28a71d
Update simple-serialize.md 2019-06-06 09:45:20 -04:00
Carl Beekhuizen 35c03c5f3e
Adds review suggestions I missed 2019-06-06 11:45:22 +02:00
Carl Beekhuizen 58a137e81c
Merge branch 'dev' into dankrad-patch-7
* dev:
  Update 0_beacon-chain-validator.md
2019-06-06 10:43:13 +02:00
Carl Beekhuizen 60d9dc68c4
Apply suggestions from @djrtwo's code review 2019-06-05 21:49:30 +02:00
Carl Beekhuizen 38414c2e4e
Merge branch 'dev' into dankrad-patch-7
* dev:
  add  beaconblockheader back to toc
  Move crosslink above attestation data
  Change data structure to match beacon state order
  Reorganize data structures to mirror beacon state order
  Update 0_beacon-chain.md
2019-06-05 20:28:14 +02:00
terence tsao eefd306253
Update 0_beacon-chain-validator.md 2019-06-05 13:07:10 -04:00
Danny Ryan 1daff359ba
Merge pull request #1139 from terencechain/patch-76
Use get_total_balance for get_attestation_deltas
2019-06-05 10:14:28 -06:00
Danny Ryan 853c34eb60
add beaconblockheader back to toc 2019-06-05 09:50:15 -06:00
Carl Beekhuizen d761b6f041
Implements new SSZ types 2019-06-05 15:29:26 +02:00
Ivan Martinez c250296d8a
Move crosslink above attestation data 2019-06-05 15:07:50 +09:00
Ivan Martinez 65d2a50219
Change data structure to match beacon state order 2019-06-05 14:57:54 +09:00
Ivan Martinez e83500cef8
Reorganize data structures to mirror beacon state order 2019-06-05 14:52:09 +09:00
Danny Ryan e8b4c4c57f
Merge pull request #1077 from ethereum/ssz-impl-rework
SSZ implementation for exec. spec - Support for Python 3 typing.
2019-06-04 14:52:28 -06:00
protolambda 9bdb18245e
remove tautological type definition 2019-06-04 18:22:42 +02:00
Diederik Loerakker fe9c708d83
Fix whitespace
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2019-06-04 15:31:20 +02:00
Ivan Martinez 1b5370f8e2
Update 0beacon-chain-validator.md 2019-06-04 18:20:16 +09:00
Carl Beekhuizen d5f2f63b4a
Merge branch 'dev' into dankrad-patch-7
* dev:
  Update link to Prysmatic Labs implementation of SSZ (#1138)
2019-06-03 11:12:03 +02:00
Ivan Martinez e578c95837 Update link to Prysmatic Labs implementation of SSZ (#1138)
* Update link to go SSZ implementation

We have changed our SSZ implementation to it's own repo so this updates the link on the spec.

* Update simple-serialize.md
2019-06-03 13:33:59 +08:00
terence tsao 2246f1b934
Update 0_beacon-chain.md 2019-06-02 13:13:52 -07:00
protolambda e044305457
Merge branch 'dev' into ssz-impl-rework 2019-06-01 01:34:49 +02:00
Carl Beekhuizen 5155bc6c4f
Makes everything pass around 2019-05-30 22:57:18 +02:00
Danny Ryan f0314bec52
Merge branch 'dev' into JustinDrake-patch-13 2019-05-29 20:15:17 -06:00
Danny Ryan 2aea4b93d0
Merge pull request #1123 from ethereum/JustinDrake-patch-14
Avoid divisions by zero
2019-05-29 20:14:23 -06:00
Danny Ryan f4afb7c1b4
Merge pull request #1134 from terencechain/patch-75
Fix Test Formats Broken Links
2019-05-29 20:13:13 -06:00
Hsiao-Wei Wang 6ec59867ef
Fix linter errors 2019-05-30 09:53:46 +08:00
Justin 1c416541e1
Update 0_beacon-chain.md 2019-05-29 23:40:46 +03:00
terence tsao 12a7e26453
Update README.md 2019-05-28 20:57:18 -07:00
Danny Ryan 6286fb3fb5
Merge branch 'dev' into JustinDrake-patch-13 2019-05-28 18:15:33 -06:00
Danny Ryan c2f0f7e4d8
Merge pull request #1108 from ethereum/eth1_error
minor fix to how eth1 data is counted in validator guide
2019-05-28 16:09:04 -06:00
Danny Ryan 4183d8440b
Merge pull request #1069 from sigp/bn-vc-api-rfc
Beacon Node API for Validator
2019-05-28 16:07:51 -06:00
protolambda 6e8fb529d2
Merge branch 'ssz_static_format' into v06x-to-dev 2019-05-28 18:32:38 +02:00
protolambda 3781614f20
SSZ format update, to facilitate more efficient parsing 2019-05-28 18:28:37 +02:00
protolambda 25cc393180
Merge in fix of bls-setting doc, rm old comments 2019-05-28 18:04:16 +02:00
protolambda d036b5a87a
Remove some old comments about BLS setting. Description is shared in main readme now. 2019-05-28 18:02:09 +02:00
protolambda 8737984e19
introduce back assert, modified to allow valid but non-effective calls 2019-05-28 16:05:25 +02:00
protolambda 401dba3230
Merge branch 'bls-setting' into v06x-to-dev 2019-05-28 15:38:08 +02:00
protolambda 6ffd41650b
suggestion from hww, reduce into one bls_setting key 2019-05-28 15:35:00 +02:00
Carl Beekhuizen bfa45e06f0
merge dev -> d-p-7 2019-05-28 11:15:17 +02:00
Carl Beekhuizen fd05b6e364
Minor bugfixes 2019-05-28 09:58:51 +02:00
Luke Anderson c32328fdf2
Fixed swagger URL so that the version number isn't specified (defaults to latest). 2019-05-28 10:49:40 +10:00
Luke Anderson 56698602ab
Updated all absolute URLs to the eth2.0-specs repo so that they point to the master branch (instead of dev). 2019-05-28 10:48:41 +10:00
protolambda 0e9a047b1d
Merge branch 'dev' into ssz-impl-rework 2019-05-28 00:42:35 +02:00
protolambda f3088884b3
Minor adjustments + getting the beacon spec doc ready 2019-05-27 20:29:53 +02:00
Danny Ryan d3d8b36365
Merge branch 'dev' into v06x-to-dev 2019-05-27 11:09:52 -06:00
Danny Ryan 405b34225f
D be list instead of set in validator eth1 data counting 2019-05-27 09:37:30 -06:00
Danny Ryan 31c02ebcab
Merge pull request #1116 from ethereum/hwwhww/phase1_withdrawable
Clean up `process_penalties_and_exits` and fix ToC
2019-05-27 09:33:43 -06:00
Michael Sproul a82a6f9a1a
Sort attester slashing indices to avoid arbitrary ordering
Closes #1125
2019-05-27 17:36:20 +10:00
Luke Anderson fa177e0355
Bumped API version number to 0.2.0 2019-05-27 13:01:36 +10:00
Luke Anderson af798a3065
Minor updates.
- Fixed spelling (and made American English)
 - Clarified the schema for the new poc_bit field, and description.
2019-05-27 11:21:23 +10:00
Carl Beekhuizen f7f069d6b5
Bug fixes and cleanup of 2_shard-data-chains 2019-05-26 19:41:36 +02:00
Justin cdfb886c22
Avoid divisions by zero
Possible fix to avoid four cases of divisions by zero:

* `return state.validator_registry[index].effective_balance // adjusted_quotient // BASE_REWARDS_PER_EPOCH`
* `rewards[index] += get_base_reward(state, index) * attesting_balance // total_balance`
* `validator.effective_balance * min(total_penalties * 3, total_balance) // total_balance`
* `rewards[index] += base_reward * attesting_balance // committee_balance`

See also #1107.
2019-05-26 18:42:37 +03:00
Carl Beekhuizen a7dbbafc92
Integrates shard-data-chains 2019-05-26 14:14:48 +02:00
vbuterin 3b4d9b7a85
Class-ified the type definitions 2019-05-25 16:14:52 -04:00
Carl Beekhuizen f6ce817f24
merge dev->dankrad-patch-7 2019-05-25 15:57:28 +02:00
Carl Beekhuizen 3bfe81ed7b
Merge branch 'dev' into dankrad-patch-7
* dev:
  Fix typo in libp2p-standardization
  update version used in test generators to get SHA-256 hash
2019-05-25 15:13:45 +02:00
protolambda 81cb4a23b3
update some common usage of SSZ types, as a start 2019-05-25 00:10:06 +02:00
Luke Anderson edf0b9d05f
Addressed some of @djrtwo's suggestions.
- Rewording of specification goal paragraph
 - Clarify get duties description regarding chain reorgs.
 - Add epoch parameter to get duties, and new error 406
 - Block publishing action is clarified around validation, with a new status code 202
 - The validator pubkey and PoC bit are passed to produce attestation
 - Attestation publishing action is clarified around validation, new status code 202
 - Rewording of genesis_time, 'block' -> 'slot'
 - Update Crosslink to latest spec
 - Added missing signature field to IndexedAttestation
2019-05-25 07:59:35 +10:00
Justin d805fb5084
Simplify deposits 2019-05-25 00:35:17 +03:00
Danny Ryan 28b76bcd4c
a number of minor fixes in phsae 1 2019-05-24 11:59:22 -06:00
Diederik Loerakker b6b5787931
Update specs/test_formats/epoch_processing/README.md
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-05-24 12:24:42 -04:00
Carl Beekhuizen ac9564c2b7
Adds Insert-into-label functionality 2019-05-24 16:51:21 +02:00
Carl Beekhuizen d41bc67ec8
merge dev -> dankrad-patch-7 2019-05-24 14:56:10 +02:00
Diederik Loerakker 4690bcf682
Update specs/test_formats/operations/README.md
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2019-05-24 08:33:06 -04:00
Diederik Loerakker f52b2282b3
Update specs/test_formats/operations/README.md
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2019-05-24 08:32:54 -04:00
Age Manning 2cd188358b
Fix typo in libp2p-standardization 2019-05-24 21:24:35 +10:00
protolambda 4ccd304603
docs for sanity tests 2019-05-24 01:03:21 +02:00
protolambda 902059d6d8
fix operations readme 2019-05-24 00:13:49 +02:00
protolambda f98a8d534e
update epoch processing tests to conform to processing pattern, add docs for epoch sub-transition testing 2019-05-23 23:50:58 +02:00
Hsiao-Wei Wang 0f7abfa4ce
Update specs/core/1_custody-game.md
Co-Authored-By: Carl Beekhuizen <carl.beek@gmail.com>
2019-05-24 02:54:41 +08:00
Hsiao-Wei Wang 650c4244bd
Things are different after rebasing #1035 2019-05-24 01:35:51 +08:00
Danny Ryan 7b30c55cd4
minor copy edits to vc api 2019-05-23 13:10:34 -04:00
Danny Ryan 72e12679ae
Merge pull request #935 from AgeManning/libp2p
Add initial libp2p standardization
2019-05-23 09:33:55 -06:00
protolambda 6cd681e952
update docs on operation testing 2019-05-23 11:22:10 +02:00
Age Manning ae6d30fd62
Update with discv5 2019-05-23 11:48:04 +10:00
Danny Ryan c13421a9a7
type hinting for fork version
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-05-22 16:52:44 -04:00