41 Commits

Author SHA1 Message Date
Hsiao-Wei Wang
cebf78a83e
Apply PR feedback 2024-02-27 22:42:32 +09:00
terence tsao
59680c0470 remove: old warnings 2023-09-05 08:59:14 -07:00
Hsiao-Wei Wang
03a3e4082a
Fix p2p-interface.md ToC 2023-04-19 19:10:46 +08:00
Jacek Sieka
bab5e402df
Ignore subset aggregates (#2847)
* Ignore subset aggregates

When aggregates are propagated through the network, it is often the case
that a better aggregate has already been seen - in particular, this
happens when an aggregator has not been able to include itself in the
mesh and therefore publishes an aggregate with only its own
attestations.

This new ignore rule allows dropping all aggregates that are
(non-strict) subsets of aggregates that have already been seen on the
network. In particular, it does not mandate dropping aggregates where a
union of previous aggregates would cause it to become a subset).

The logic for allowing this is based on the premise that any aggregate
that has already been seen by a peer will also have been seen by its
neighbours - a subset aggregate (strict or not) brings no new value to
the aggregation algorithm, except in the extreme edge case where you
could combine several such sparse aggregates into a single, more dense
"combined" aggregate and thus use less block space.

Further, as a small benefit, computing the `hash_tree_root` of the full
aggregate is generally not done -however, `hash_tree_root(data)` is
already done for other purposes as this is used as index in the beacon
API.

* add subset ignore rule to sync contributions as well

* typo
2022-05-17 07:05:22 -06:00
Danny Ryan
4c1156d504
rename eth1 and eth2 throughout specs and readme where reasonable 2021-08-18 17:13:24 -06:00
Danny Ryan
f7a2a973ac
Update specs/altair/p2p-interface.md
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
2021-07-21 15:51:59 -06:00
Danny Ryan
02a9fc460e
require aggregation bits to have at least one participant in sync contributions 2021-07-21 11:10:09 -06:00
terence tsao
3a59c1b789
Rename a few instances of signature to message 2021-07-07 10:04:26 -07:00
Danny Ryan
c61eeb8a27
optimize sync committee message gossip and caches 2021-06-22 12:31:02 -06:00
protolambda
5140b59c57
add missing parenthesis 2021-06-08 21:51:26 +02:00
Diederik Loerakker
8f8b5ab648
Merge pull request #2475 from ralexstokes/discriminate-sync-comm-msg
Add `message.topic` to gossipsub `message-id` in Altair
2021-06-08 21:47:06 +02:00
Alex Stokes
a343680fd4
Add implementation note on message id fn 2021-06-08 14:29:08 -05:00
Alex Stokes
f60f13964c
Harden topic serialization 2021-06-08 14:15:57 -05:00
Alex Stokes
25a2e3463e
Update specs/altair/p2p-interface.md
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
2021-06-08 12:06:02 -07:00
Alex Stokes
d64b4e7d24
Add message.topic to gossipsub message-id in Altair 2021-06-08 13:44:06 -05:00
Alex Stokes
c7980d3cd0
Clarify p2p validation conditions for Altair sync committees 2021-06-08 13:34:16 -05:00
Hsiao-Wei Wang
65f8d3d296
Merge branch 'dev' into SyncCommitteeSignature-to-SyncCommitteeMessage 2021-06-01 22:05:10 +08:00
Paul Hauner
48f989070d
Remove naughty space 2021-05-27 15:30:44 +10:00
Paul Hauner
103d029a1a
Add clock disparity tolerance for sync subnets 2021-05-27 15:28:51 +10:00
Hsiao-Wei Wang
0142978b60
Rename SyncCommitteeSignature to SyncCommitteeMessage 2021-05-26 02:36:54 +08:00
Danny Ryan
85198fabfa
lint 2021-05-10 13:26:43 -06:00
Danny Ryan
d8e2d19ecc
spelling 2021-05-10 13:01:31 -06:00
Danny Ryan
ff706e5c7a
add logic for handling sync committee off by one issue 2021-05-10 12:57:11 -06:00
Alex Stokes
eae64fd18c
clean up whitespace on altair files 2021-05-04 12:43:21 -07:00
Danny Ryan
9f74f1f9e5
minor sync committee cleanups 2021-04-27 15:06:45 -06:00
Alex Stokes
9bb3444c89
Add syncnets data to Altair MetaData. 2021-04-27 09:34:24 -07:00
Alex Stokes
ebd16e1b79
add helper in p2p document to executable spec 2021-04-22 11:05:06 -07:00
Alex Stokes
3c07303c5c
Update specs/altair/p2p-interface.md
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
2021-04-22 10:34:16 -07:00
Alex Stokes
99b2cc2f3e
Clarify usage of field in data 2021-04-22 10:34:16 -07:00
Alex Stokes
f992a9ae65
Remove duplicate validation 2021-04-22 10:34:16 -07:00
Alex Stokes
360a1dd598
Respect subcommittees in gossip validations for Altair 2021-04-22 10:34:15 -07:00
Alex Stokes
a9e3ecabbd
demo spec comment feature 2021-04-21 18:49:51 -07:00
Alex Stokes
bf7c61ff30
Merge pull request #2299 from ralexstokes/update-altair-p2p
Fix language with sync committee selection proofs
2021-04-05 11:03:36 -07:00
Meredith Baxter
4a1126d916 Fix table formatting 2021-04-05 11:34:06 -04:00
Alex Stokes
9aaf548c37
Fix language with sync committee selection proofs 2021-04-02 18:37:30 -07:00
Danny Ryan
acfbd9375e
Merge pull request #2293 from ralexstokes/reorder-aggregation-conditions
Reorder Altair gossip validation conditions
2021-04-01 11:25:10 -06:00
Adrian Sutton
45c764618a
Fix missed rename from aggregate_and_proof to contribution_and_proof 2021-04-01 15:18:31 +10:00
Alex Stokes
b151adbd4e
Reorder Altair gossip validation conditions
Validate the `selection_proof` selects the incoming validator as an
aggregator before doing other checks like committee inclusion and
(relatively) expensive signature checks.
2021-03-30 16:18:14 -07:00
terence tsao
f73aa2f98d
Fix spelling: negotiatied -> negotiated 2021-03-28 17:06:12 -07:00
protolambda
0fe5e1ef6e
update of req-resp, v2 sync methods, gossip topics 2021-03-17 00:54:29 +01:00
Alex Stokes
893134d2ab
Add validator guide and initial P2P spec for Altair 2021-03-16 17:37:42 -06:00