21 Commits

Author SHA1 Message Date
protolambda
a62d0261ca
merge with dev, fixed now 2019-06-27 01:31:10 +02:00
Diederik Loerakker
d587c4fe61 Critical fix: introduce back total-value check (#1220)
This was dropped in a376b6607fe5e6406371f44254960e891ee5ee8d, as improvement in dust checking.
Now that dust-checking is done, we still need to check if the sender has the minimum value, as decrease balance just clips to 0.
See be86f966f87958856584b3f20c095abf910a3d0c for older dust-creation problem work around, which was dropped in the above.

The bug enabled you to transfer your full balance to someone else, and pay the same amount in fee, possibly to a puppet proposer to collect back funds.
Effectively enabling printing of money. Silly bug, good to fix and introduce tests for.
2019-06-26 20:21:17 +01:00
protolambda
f95e7315b4
fix get_active_validator_indices typing usage 2019-06-22 18:34:33 +02:00
Hsiao-Wei Wang
8828dad786
minor updates 2019-06-21 17:07:44 -06:00
Hsiao-Wei Wang
e7c595d1d6
Fix test_process_deposit.py 2019-06-21 16:33:24 -06:00
protolambda
6648b3c49e
remove old deposits test, there is no deposit index in deposit data anymore 2019-06-21 00:23:28 +02:00
protolambda
c20372409c
comment out old deposit test, re-introduced soon maybe, cc Justin 2019-06-20 22:52:16 +02:00
protolambda
f27c44b953
fix deposit negative index fail 2019-06-20 22:49:34 +02:00
protolambda
224c98a094
last() method, no negative index lookups 2019-06-20 20:55:17 +02:00
Danny Ryan
d7ac601b9e
Merge branch 'dev' into v071backport 2019-06-17 13:42:27 -06:00
Danny Ryan
a6230425b8
Merge branch 'dev' into container-cleanup 2019-06-14 10:36:41 -06:00
Danny Ryan
c391017a05
address #1146 by inserting state root and re-signing blocks in tests 2019-06-13 17:57:29 -06:00
protolambda
2d636ddf5a
BLS withdrawal byte is formatted as int now, but still one byte. Justin changed spec, now fix tests + configs 2019-06-11 17:27:34 +02:00
protolambda
e86771250b
Fix tests to use new constant name 2019-06-11 17:16:02 +02:00
Justin Drake
05f1a44a38 Fix tests 2019-06-10 21:20:45 +01:00
Justin Drake
dc56d87eef Revert a couple of renamings 2019-06-10 21:16:51 +01:00
Justin Drake
565f61dfaa Cleanup containers 2019-06-09 20:41:21 +01:00
Carl Beekhuizen
67471a8d6e
Rework of phases decorator 2019-06-06 23:30:40 +02:00
Carl Beekhuizen
956c476d81
Move over to parameterised decorators for phases 2019-06-06 16:23:30 +02:00
Carl Beekhuizen
60d9dc68c4
Apply suggestions from @djrtwo's code review 2019-06-05 21:49:30 +02:00
Carl Beekhuizen
e498ff7e94
Separates tests into phases 2019-06-05 21:28:30 +02:00