Danny Ryan
e955e6f6e1
Merge pull request #1884 from paulhauner/patch-25
...
Use parent_root for finalized chain check
2020-06-13 16:09:16 -05:00
Danny Ryan
fdb6f15867
unhandled exceptions do not modify forkchoice store
2020-06-13 15:59:04 -05:00
Danny Ryan
df9b5f18a4
Merge pull request #1885 from paulhauner/patch-26
...
Fork choice: minor formatting change
2020-06-13 15:51:03 -05:00
Paul Hauner
7ad1bb508d
Ensure parent is checked before store lookup
2020-06-13 16:04:16 +10:00
Paul Hauner
a1a75a38fe
Tidy, add comment
2020-06-11 11:51:18 +10:00
Danny Ryan
1dc6b55617
rearrange fork choice condition for clarity
2020-06-10 09:40:34 -05:00
Hsiao-Wei Wang
479c40450d
Friendly lint fix
2020-06-10 18:16:26 +08:00
Paul Hauner
29d968bb2e
Use parent_root for finalized chain check
2020-06-10 15:09:40 +10:00
Paul Hauner
378d249487
Avoid redundant call to get_ancestor
2020-06-10 11:02:10 +10:00
Paul Hauner
2a125e8497
Update fork-choice.md
2020-06-02 17:22:33 +10:00
Paul Hauner
c6aac16506
Reword fork choice comment
2020-06-02 17:16:25 +10:00
Alex Stokes
437b2ebb90
Update fork choice spec comment for clarity
...
I think this change more clearly specifies the intended behavior. Given the terseness of the spec's code representation, I think we should aim for as much clarity as possible.
2020-05-29 18:16:06 -07:00
Danny Ryan
b71a0ee6b9
Merge branch 'v012x' into ffg_lmd_vote_consistency
2020-05-05 13:40:27 -06:00
Paul Hauner
2dc5156651
Add message about delaying consideration
2020-04-30 16:27:02 +10:00
Paul Hauner
1a81c873af
Remove redundant check in fork choice
2020-04-26 16:24:16 +10:00
Aditya Asgaonkar
9acea51938
Simplified by re-using get_ancestor()
2020-04-25 14:17:28 -07:00
Aditya Asgaonkar
9bbac0d2cc
Added consistency check for FFG & LMD vote in validate_on_atttestation(), fixes #1636 , fixes #1456 , fixes #1408
2020-04-21 23:56:44 -07:00
Danny Ryan
1293320675
Merge branch 'dev' into phase1-tests
2020-03-12 07:12:41 -06:00
Danny Ryan
c894f5ecec
fork choice error note
2020-03-11 16:41:27 -06:00
Danny Ryan
47bbffa0d6
'get_checkpoint_store' -> 'get_forkchoice_store' typo
2020-03-11 15:03:14 -06:00
Danny Ryan
c91eee6bdf
revert fork choice store.blocks to store BeaconBlock
2020-03-10 13:20:57 -06:00
Danny Ryan
721f605a91
Merge branch 'dev' into phase1-tests
2020-02-22 12:10:35 -06:00
Danny Ryan
4c1fc9bffa
work through phase 1 tests
2020-02-22 12:06:31 -06:00
Danny Ryan
67a4d5e659
Merge branch 'dev' into master-copy
2020-01-24 13:49:22 -07:00
Danny Ryan
eed3f6053d
Merge pull request #1580 from ethereum/fork-choice-fix-1574
...
Fork choice fix issue 1574
2020-01-22 16:56:00 -07:00
Danny Ryan
b357e43aab
clarifying comment on call to get_ancestor in on_block
2020-01-22 14:31:23 -07:00
Danny Ryan
00d3fb4fe6
fix issue 1574 by ensuring that justified checkpoint in store updates when finalized updates if needbe
2020-01-20 18:50:50 -07:00
Danny Ryan
e98c1b4154
don't consider blocks with slots earlier than finalized in on_block fork choice (optimization)
2020-01-20 18:10:39 -07:00
Danny Ryan
f1697d03e7
fix corner case to properly handle skipped slots in get_ancestor
2020-01-20 17:49:09 -07:00
Danny Ryan
3c07b2c954
Make phase 0 fork choice more modular to more easily adopt for slight modifications in phase 1
2020-01-15 16:40:50 -07:00
protolambda
6c74468142
forkchoice store on top of any state now
2020-01-14 01:02:02 +01:00
Danny Ryan
676e216beb
reorg specs by fork and move ssz out to own folder. make all of the build and link changes to support move
2020-01-10 11:55:13 -07:00