dapplion
83e5930b5c
doctoc
2023-10-27 20:08:40 +03:00
dapplion
f2649f65ba
fix unit tests
2023-10-27 20:03:06 +03:00
Lion - dapplion
8712451c43
Update specs/deneb/p2p-interface.md
...
Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
2023-10-27 18:09:01 +03:00
dapplion
caa79a5a02
build tree
2023-10-27 18:08:20 +03:00
dapplion
c2a64a18f0
pass lint
2023-10-27 17:20:58 +03:00
dapplion
3dbe54e4b8
doctoc
2023-10-27 16:16:10 +03:00
dapplion
a4a29a164f
List typo
2023-10-27 16:15:25 +03:00
dapplion
29bbdf4393
compute KZG_COMMITMENT_INCLUSION_PROOF_DEPTH
2023-10-27 16:14:17 +03:00
dapplion
e8bccecba5
remove verify_blob_sidecar_signature
2023-10-27 15:47:33 +03:00
dapplion
530efa88aa
Add blob sidecar inclusion proof
2023-10-27 12:10:29 +03:00
Hsiao-Wei Wang
d8440f8bb4
Merge branch 'dev' into pr3034
2023-10-26 23:51:35 +08:00
Michael Sproul
3f1bc20512
Clarifications for proposer boost reorgs
2023-10-26 17:44:59 +11:00
Nishant Das
1a53dbbf96
Update p2p-interface.md
2023-10-25 22:05:57 +08:00
Hsiao-Wei Wang
22215b8fe4
Fix `parent_state_advanced` side effect and reorder the conditions
2023-10-25 01:34:57 +08:00
danny
ce387d65c9
shift wehre warning is in comments
2023-10-23 09:15:06 -06:00
danny
16498c60aa
Update fork-choice.md
2023-10-20 12:06:47 -06:00
Hsiao-Wei Wang
0f61819e5c
Update other specs accordingly and re-order "Proposer head and reorg helpers" section
2023-10-20 14:41:51 +08:00
danny
991d6d5609
add note about not invalidating valid and available blocks
2023-10-19 20:58:20 -06:00
Hsiao-Wei Wang
651db2f858
Refactoring
2023-10-19 19:18:29 +08:00
danny
a2d021da48
re-order conditions
2023-10-18 10:38:43 -06:00
Enrico Del Fante
27ad39b73a
Add new gossip rule to `REJECT` sidecars with index >= MAX_BLOBS_PER_BLOCK
2023-10-18 11:54:47 +02:00
Hsiao-Wei Wang
8d91941818
Merge branch 'dev' into official-kzg
2023-10-18 00:16:01 +08:00
Hsiao-Wei Wang
3cab9ed44d
Remove the "TBD" note
2023-10-18 00:08:15 +08:00
Hsiao-Wei Wang
65e1371980
Fix tests
2023-10-16 21:31:07 +08:00
shuoer86
bae3384071
Fix typos
2023-10-16 21:16:26 +08:00
Hsiao-Wei Wang
9257ad28ac
Rename `KZG_SETUP_LAGRANGE` to `KZG_SETUP_G1_LAGRANGE` and `KZG_SETUP_G2` to `KZG_SETUP_G2_MONOMIAL`
2023-10-16 17:41:46 +08:00
Hsiao-Wei Wang
01fa0fe64a
Replace `ROOTS_OF_UNITY` with runtime-computed `compute_roots_of_unity(FIELD_ELEMENTS_PER_BLOB)`
2023-10-16 17:38:09 +08:00
Hsiao-Wei Wang
d74932bec9
Merge branch 'dev' into pr3442
2023-10-16 17:22:31 +08:00
Hsiao-Wei Wang
c5785899f7
Use official KZG ceremony output `trusted_setup_4096.json` trusted setups
2023-10-12 19:54:18 +08:00
Lion - dapplion
8acb254511
Use add_validator_to_registry in whisk ( #3486 )
2023-10-10 15:09:21 +03:00
joethechicken
28e3c807e2
Update validator.md ( #3509 )
2023-09-20 12:53:50 +01:00
Hsiao-Wei Wang
264dfadfe0
Merge branch 'dev' into pr3499
2023-09-18 18:07:39 +08:00
Hsiao-Wei Wang
26d3fa3efd
Apply suggestions from code review
...
Co-authored-by: danny <dannyjryan@gmail.com>
2023-09-15 22:02:34 +08:00
Hsiao-Wei Wang
d26dac9121
Merge pull request #3493 from mxinden/patch-1
...
fix(sepcs/p2p): link to libp2p Yamux specification
2023-09-15 16:00:27 +08:00
Hsiao-Wei Wang
468ae9aae4
Update the link of `EIP-7044`
2023-09-15 11:04:08 +08:00
Hsiao-Wei Wang
e5e50e3e40
Add EIP-7514 into Deneb
2023-09-15 10:49:06 +08:00
Max Inden
909388ba8d
fix(sepcs/p2p): link to libp2p Yamux specification
...
Previously the specification would link to the Hashicorp Yamux specification.
https://github.com/hashicorp/yamux/blob/master/spec.md
Since adoption by libp2p, there have been multiple refinements to the original specification. The improved specification can be found in the libp2p specification repository.
https://github.com/libp2p/specs/blob/master/yamux/README.md
2023-09-14 17:08:44 +02:00
Lion - dapplion
0efd778594
Update beacon_chain.md
2023-09-14 16:31:42 +02:00
dapplion
19bf51dd93
Rename eip7668 to eip7514
2023-09-14 13:44:32 +02:00
Hsiao-Wei Wang
417b95c3e6
Add basic activation churn limit tests
2023-09-13 17:14:26 +08:00
dapplion
298a6304de
review PR
2023-09-13 11:00:22 +02:00
Hsiao-Wei Wang
fd37ffcb61
Add _features/eip7668 and make linter happy
2023-09-12 21:37:09 +08:00
dapplion
e6f7c99b77
Add limit inbound churn
2023-09-12 12:52:08 +02:00
dapplion
4eca8e4292
Add CRS files
2023-09-12 10:23:31 +02:00
Michael Sproul
45a3615816
Allow honest validators to reorg late blocks
2023-09-12 15:27:10 +10:00
Hsiao-Wei Wang
c5c7233e49
Merge pull request #3352 from michaelsproul/boost-first-block
...
Apply proposer boost to first block in case of equivocation
2023-09-12 10:56:58 +08:00
terence tsao
59680c0470
remove: old warnings
2023-09-05 08:59:14 -07:00
Lion - dapplion
eef61448a9
Whisk: don't mutate candidates during cooldown ( #3483 )
2023-08-20 14:46:22 +03:00
Lion - dapplion
0b751fc259
Whisk move non-preset values to config ( #3482 )
2023-08-20 14:42:12 +03:00
zhiqiangxu
6f57e2bd26
"can slashable" => "can be slashable"
2023-08-09 11:13:39 +08:00
Hsiao-Wei Wang
fa1015ca03
Update Capella FC too
2023-08-04 21:58:07 +08:00
Hsiao-Wei Wang
63c39dbaff
Merge branch 'dev' into pr3352
2023-08-04 14:45:47 +08:00
Hsiao-Wei Wang
56d6d1a51e
Merge pull request #3463 from ethereum/deneb-fc-tests-take-2
...
Deneb fork choice tests - take 2
2023-08-03 21:40:24 +08:00
Hsiao-Wei Wang
e79caff2f7
Clean up `is_data_available`. Remove the stub `retrieve_blobs_and_proofs` responses.
2023-07-25 23:32:55 +08:00
Hsiao-Wei Wang
01c358c873
Rename "data gas" to "blob gas"
2023-07-25 13:28:34 +08:00
Danny Ryan
726b453332
Merge pull request #3446 from ppopth/on-reused-index
...
EIP-6914: Update the equivocating indices in the fork-choice store
2023-07-24 13:40:45 -06:00
dapplion
211376e35c
Update curdleproofs usage
2023-07-24 20:15:46 +02:00
Suphanat Chunhapanya
d8b023c5d8
Explain more on on_reused_index
2023-07-18 19:55:18 +07:00
Justin Traglia
16b1afb1ef
Add punctuation to docstring
2023-07-15 17:53:10 +02:00
Justin Traglia
fafd48f06a
Fix comment
2023-07-15 17:30:08 +02:00
Justin Traglia
3f3d4123f6
Unmark validators field as modified
2023-07-15 17:09:06 +02:00
Justin Traglia
86a147a740
Link to dev branch instead of master
2023-07-15 14:13:07 +02:00
Justin Traglia
4ddaff5a77
Fix links to curdleproofs.pie repo
2023-07-15 13:58:04 +02:00
Hsiao-Wei Wang
71c25f8664
Merge branch 'dev' into pr3442
2023-07-14 22:25:39 +08:00
Suphanat Chunhapanya
3ed0619951
Update the equivocating indices in the store
...
Since we sometimes reuse the slashed validator index, we need to remove
it from the list of equivocating indices in the fork-choice store.
2023-07-11 21:49:24 +07:00
dapplion
7f9a0264ce
Update specs with state.whisk_trackers
2023-07-05 17:18:54 +02:00
dapplion
91ff707887
Fix test lint issues
2023-07-05 17:18:52 +02:00
dapplion
4ce2b02b44
Add whisk tests
2023-07-05 17:18:34 +02:00
Hsiao-Wei Wang
7b771ccb13
Merge branch 'dev' into eip7002
2023-06-26 18:07:48 +08:00
Danny Ryan
fa649e5430
Update specs/deneb/beacon-chain.md
2023-06-22 10:02:23 -06:00
Danny Ryan
ad4f1def32
Apply suggestions from code review
2023-06-22 10:01:49 -06:00
Alex Stokes
2660af0539
move 4788 feature to deneb specs
2023-06-22 09:00:50 -06:00
Alex Stokes
57a75d033f
formatting
2023-06-21 11:40:54 -06:00
Danny Ryan
95f36d99cf
Merge pull request #3360 from ethereum/att-slot-range
...
EIP-7045: Increase max attestation inclusion slot
2023-06-21 08:30:26 -06:00
djrtwo
ecefe2d147
pr review
2023-06-20 15:50:20 -06:00
djrtwo
668568ea22
spelling
2023-06-19 12:05:49 -06:00
djrtwo
919052081b
toc
2023-06-19 08:33:05 -06:00
Lion - dapplion
c90d724392
Whisk: add preset files ( #3424 )
...
* Add Whisk preset files
* Use N=8 for minimal preset
* Update spec_object var location
2023-06-19 17:10:15 +03:00
Lion - dapplion
cc4c810b8f
Whisk: complete TODO items in fork logic ( #3427 )
...
* Complete TODO items in fork logic
* Simpler underflow protection
* Add saturating_sub
2023-06-19 17:08:51 +03:00
Roberto Saltini
5e3c0107ef
Review change
...
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2023-06-18 19:07:35 +10:00
Hsiao-Wei Wang
59fd2a6400
Merge branch 'dev' into eip7002
2023-06-18 16:40:17 +08:00
Roberto Saltini
911968413f
Merge branch 'ethereum:dev' into fork-choice-changes-for-confirmaton-rule
2023-06-17 15:14:06 +10:00
Hsiao-Wei Wang
781cd83f09
fix typo
2023-06-16 17:21:34 +08:00
Hsiao-Wei Wang
66eca39533
Merge branch 'dev' into pr3311
2023-06-16 16:24:55 +08:00
Lion - dapplion
834f6f70e7
Whisk: assert zeroed values during selection gap ( #3425 )
...
* Assert zeroed values during selection gap
* Update comment
2023-06-15 14:33:28 +03:00
Roberto Saltini
7c023cc3cf
Fork choice changes to enable confirmation rule execution via beacon APIs
2023-06-15 11:07:30 +10:00
djrtwo
ec4bdae2d4
build EIP 7045 into Deneb fork
2023-06-14 15:03:28 -06:00
Lion - dapplion
65a28b6d69
Whisk: Move validator whisk trackers and commitments to state ( #3407 )
...
* Move validator whisk trackers and commitments to state
* Move comment
2023-06-14 18:58:57 +03:00
Lion - dapplion
0ab160bc28
Add initialize_beacon_state_from_eth1 ( #3428 )
2023-06-14 18:55:07 +03:00
Lion - dapplion
7b132c20d1
Fix typos in get_shuffle_indices ( #3426 )
2023-06-14 18:52:22 +03:00
djrtwo
559b89c447
Merge branch 'dev' into att-slot-range
2023-06-14 09:35:30 -06:00
Danny Ryan
14212958d3
Merge pull request #3288 from dapplion/voluntary_exit-domain
...
EIP-7044: Lock voluntary exit domain on capella
2023-06-14 09:26:33 -06:00
Hsiao-Wei Wang
420f8baf67
Rework tests. Move all `process_voluntary_exit` tests to Deneb
2023-06-14 23:04:46 +08:00
Lion - dapplion
12fabf5854
Update specs/deneb/beacon-chain.md
...
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
2023-06-14 16:47:17 +03:00
Hsiao-Wei Wang
19edc2d1ec
Merge branch 'dev' into eip7002
2023-06-13 19:35:02 +08:00
Hsiao-Wei Wang
210c4827bc
Move `BLOB_SIDECAR_SUBNET_COUNT` to networking config
2023-06-12 23:57:21 +08:00
gajinder
512d2ca516
Update blob side car subnet count to 6 in line with max blobs limit update
2023-06-12 20:24:22 +05:30
Hsiao-Wei Wang
99f294cdd8
Add link to EIP PR7044. Need to change it to eips.ethereum.org path once the EIP is merged
2023-06-12 16:02:28 +08:00
Hsiao-Wei Wang
4f839b7b79
Merge branch 'dev' into pr3288-comment
2023-06-12 15:51:52 +08:00
Paul Harris
5576d0e685
Moved configuration into network preset instead of constants. ( #3394 )
...
* Moved configuration into network preset instead of constants.
Now that `MAX_CHUNK_SIZE` and `GOSSIP_MAX_SIZE` are in configuration, we no longer need separate constants to represent them in the spec when they change in Bellatrix.
I've changed the usage, and put the values into the presets, but I'm not sure if I've updated the descriptions in the best way...
This is following on from the work in #3375 where a number of constants got moved into configuration, so we no longer need these constants to be separately represented, they can simply be updated in presets.
* Update presets/minimal/bellatrix.yaml
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
* Update presets/mainnet/bellatrix.yaml
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
* Moved preset items into the correct section and updated TOC.
It looked like the items listed in configuration about the max size and chunk size were no longer needed since we're updating preset values now and the preset changes seem to only be listed in the changes at the top.
* review feedback
* hopefully correct this time! Moved the 2 fields from configs into presets completely as suggested.
* WIP - changing back to being in config and updating the phase 0 value... I think this should be close but want to see what's outstanding.
* fix intellij's formatting of table.
* more fixes
---------
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2023-06-09 23:12:38 +08:00
Hsiao-Wei Wang
45f3432019
Update `MAX_BLOBS_PER_BLOCK` to `6` and add Deneb networking configs to yaml files ( #3410 )
2023-06-09 23:10:00 +08:00
Danny Ryan
05790d380b
Merge pull request #3406 from ethereum/deneb-4844-clean
...
specially mark EIP4844 changes
2023-06-09 08:46:48 -06:00
Lion - dapplion
efd2429b3f
Move whisk_opening_proof to block body ( #3408 )
2023-06-09 11:28:06 +03:00
Hsiao-Wei Wang
76214c7cae
Merge pull request #3162 from dapplion/eip4844-dedup-range
...
De-duplicate range references in BlobSidecarsByRange
2023-06-09 00:54:27 +08:00
Lion - dapplion
241e52a202
Whisk (SSLE) with Curdleproofs - rebased ( #3342 )
...
* Introduce consensus code for Whisk
* polish, simplify, clean up (~100 fewer lines)
@asn-d6: As discussed, I fixed a few bugs along the way but likely also introduced some bugs :)
* minor cleanups and fixes
* simplify is_k_commitment_unique
* Update beacon-chain.md
* Update beacon-chain.md
* Initialize `k` in `get_validator_from_deposit()`
* minor cleanups
* Update beacon-chain.md
* Create beacon-chain.md
This PR changes the Whisk tracker format to be of the form `(r * pubkey, r * BLS_GT_GENERATOR)` instead of `(r * k * BLS_G1_GENERATOR, r * BLS_G1_GENERATOR)`. This allows for non-interactive tracker registrations from validator pubkeys, removing ~50 lines the code. It also significantly reduces the amount of state overhead. This PR also removes permutation commitments, though those can be easily readded if deemed necessary.
* A couple of fixes to the no-registration simplification
@asn-d6: Readded a consistency check for `IsValidWhiskOpeningProof` (involving `pubkey` instead of `k_commitment`).
* remove unused helpers
* use Mary's suggested tracker
* Update beacon-chain.md
* Revert G_t element optimization
This needs its own ethresearch post, and some additional analysis to see if we can do the shuffle ZKP in the allowed
timeframe.
This reverts commit 8517acabfc1dbb1a35789e6170b5db0bb2c19c9a.
* Implement new shuffling strategy
Ditch the Feistel logic and instead have each shuffler pick the row they shuffle using their RANDAO reveal.
* Curdleproofs edits
* working whisk eth2spec
* working whisk dummy test
* add more boilerplate set up code
* rebase constants
* Implement even newer and simplified shuffling strategy
This commit further simplifies 0faef30fc131d1b471b63a7f16772eeeef548ef8 by removing the entire squareshuffle.
The latest version of https://eprint.iacr.org/2022/560 proposes that each shuffler picks random indices from the entire
candidate set instead of organizing validators into a square.
* Move to _features
* remove dummy test
* Run doctoc
* Change Whisk's previous fork to Capella instead of Bellatrix. Make linter happier.
* Fix lint
* Fix pylint
* Fix mypy issues
* Clean-up get_beacon_proposer_index
* Fix doc headers
* Fix capella link
* Update apply_deposit
* Rename process_shuffled_trackers
---------
Co-authored-by: George Kadianakis <desnacked@riseup.net>
Co-authored-by: Justin <drakefjustin@gmail.com>
Co-authored-by: Nalin Bhardwaj <nalinbhardwaj@nibnalin.me>
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2023-06-08 15:35:03 +08:00
Hsiao-Wei Wang
b7e21d6caf
PR feedback and make the marks italic
2023-06-08 15:05:46 +08:00
Hsiao-Wei Wang
bab93e8d44
specially mark EIP7044 changes
2023-06-07 18:54:04 +08:00
Hsiao-Wei Wang
5f241bb7a4
Merge branch 'deneb-4844-clean' into pr3288-comment
2023-06-07 18:38:20 +08:00
Hsiao-Wei Wang
a547d47264
specially mark the EIP4844 changes
2023-06-07 17:48:26 +08:00
Mikhail Kalinin
f5e00848d0
Remove assert from is_data_available
2023-06-07 11:59:51 +06:00
Hsiao-Wei Wang
468b5be7b8
Merge pull request #3368 from ethereum/ralexstokes-patch-3
...
Remove extraneous length check from deneb forkchoice
2023-06-02 01:54:47 +08:00
Hsiao-Wei Wang
c9b84ecc1a
Use `verify_blob_kzg_proof_batch` directly in `is_data_available` and remove `validate_blob` wrapper
2023-06-01 23:40:46 +08:00
Hsiao-Wei Wang
69ce4bb531
Merge branch 'dev' into excess_data_gas-type
2023-06-01 23:15:02 +08:00
Hsiao-Wei Wang
a965ca7ac4
Merge pull request #3391 from ethereum/data_gas_used
...
Add `data_gas_used` field to `ExecutionPayload`
2023-06-01 23:09:46 +08:00
Hsiao-Wei Wang
60721b9d8a
switch order
2023-06-01 22:39:01 +08:00
Hsiao-Wei Wang
2a53d484b8
Remove EIP7002 light client specs
2023-06-01 18:41:09 +08:00
Hsiao-Wei Wang
b8949677fd
Merge branch 'dev' into eip7002
2023-06-01 18:37:31 +08:00
Hsiao-Wei Wang
aeca477398
Merge branch 'dev' into att-slot-range
2023-06-01 18:20:24 +08:00
Hsiao-Wei Wang
0d4b07f63c
Merge pull request #3389 from ethereum/fork-settings
...
Turn off light client tests for feature specs
2023-06-01 14:59:27 +08:00
Hsiao-Wei Wang
653e03e702
Fix ToC
2023-05-30 21:12:47 +08:00
Hsiao-Wei Wang
be33c4008a
Merge branch 'dev' into pr3288
2023-05-30 21:08:12 +08:00
Hsiao-Wei Wang
f6fe8e2729
Change `ExecutionPayload.excess_data_gas` type from `uint256` to `uint64`
2023-05-30 20:36:58 +08:00
Hsiao-Wei Wang
296efec256
Add `data_gas_used` field to `ExecutionPayload`
2023-05-30 00:39:13 +08:00
Hsiao-Wei Wang
30da14e9b4
Create `LIGHT_CLIENT_TESTING_FORKS` to limit the light client tests
2023-05-25 13:49:41 +08:00
Hsiao-Wei Wang
a10affa245
Fix preset table
2023-05-24 21:15:01 +08:00
djrtwo
9bc27bad30
a couple of minor cleanups
2023-05-24 05:41:42 -06:00
Hsiao-Wei Wang
e9cc8dcc05
PR feedback of Danny + verify `MAX_BLOBS_PER_BLOCK` size in unittest
2023-05-24 16:32:39 +08:00
Hsiao-Wei Wang
f0a4281afd
Add tests. Add validation in the p2p beacon block gossiping
2023-05-24 16:11:32 +08:00
Hsiao-Wei Wang
a05b689b4c
Merge branch 'dev' into pr3338
2023-05-24 15:38:55 +08:00
Hsiao-Wei Wang
7a827638e6
Ensure `verify_and_notify_new_payload` returns bool
2023-05-24 12:56:10 +08:00
Hsiao-Wei Wang
ec1ee74edb
Fix typo
...
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
2023-05-24 12:17:07 +08:00
Hsiao-Wei Wang
53a9221d1a
Fix ToC
2023-05-24 11:55:22 +08:00
Hsiao-Wei Wang
212a314287
Fix ToC and remove `validate_blobs_and_kzg_commitments`
2023-05-24 11:27:26 +08:00
Hsiao-Wei Wang
6b5513b43a
Merge branch 'dev' into engine-versioned-hashes
2023-05-24 11:19:56 +08:00
Hsiao-Wei Wang
289d8147be
Move `verify_and_notify_new_payload` to Bellatrix
2023-05-24 11:12:03 +08:00
Hsiao-Wei Wang
0a90b58080
Merge branch 'engine-versioned-hashes-explicit' into engine-versioned-hashes
2023-05-24 10:40:36 +08:00
Hsiao-Wei Wang
738b9818b3
Merge pull request #3375 from ethereum/networking-configs
...
Add networking configs to config files
2023-05-24 10:38:35 +08:00
Hsiao-Wei Wang
d018635c96
Merge pull request #3350 from ethereum/remove-is_execution_enabled
...
Remove `is_execution_enabled` condition since Capella
2023-05-24 10:36:34 +08:00
Hsiao-Wei Wang
ee09c34261
Merge pull request #3232 from ethereum/capella-fc-cleanup
...
Remove `is_merge_transition_block` check since Capella
2023-05-24 10:36:14 +08:00
djrtwo
68ce45b305
move epoch subscription length to config
2023-05-23 13:56:09 -06:00
Hsiao-Wei Wang
dd5e6f813f
Add `make_function_abstract` to make it more general
2023-05-24 01:59:02 +08:00
Hsiao-Wei Wang
0754b94948
Merge branch 'dev' into remove-is_execution_enabled
2023-05-24 00:01:23 +08:00
Hsiao-Wei Wang
7ec5efb106
Add `### Block processing` back
2023-05-23 23:55:35 +08:00
Hsiao-Wei Wang
2192882faa
Merge pull request #3354 from g11tech/kzg-big-endian
...
Update the endianness of the polynomial commitments to be big endian
2023-05-23 23:43:19 +08:00
Hsiao-Wei Wang
73df1935b1
Use `verify_and_notify_new_payload` approach
2023-05-23 23:37:42 +08:00
Hsiao-Wei Wang
2eab6bfdaa
Merge branch 'dev' into engine-versioned-hashes
2023-05-23 15:21:00 +08:00
Hsiao-Wei Wang
3247bcf8f7
PR feedback from @ppopth
2023-05-23 15:16:12 +08:00
Danny Ryan
fa4a103712
Apply suggestions from code review
...
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2023-05-22 08:07:43 -06:00
djrtwo
3550821577
Merge remote-tracking branch 'origin' into att-slot-range
2023-05-22 08:06:57 -06:00
gajinder
feb1968e43
add comment
2023-05-22 18:44:12 +05:30