e2a320ef32
Partial fix for #1701
...
Clarify that state transitions with `uint64` overflows are invalid.
2020-04-21 08:59:53 +01:00
508811d641
Fix #1735—remove redundant check
...
As per #1735 the check `if not len(indices) <= MAX_VALIDATORS_PER_COMMITTEE: return False` is redundant. As such this PR should be purely cosmetic.
2020-04-21 08:50:42 +01:00
4915014a19
simplify block range request description
...
There's room for ambiguity as to what `count` means - this clarifies
that it always relates to the slot, and not the number of blocks in the
response which allows clients to request ranges epoch by epoch (for
example) without worrying about overlaps caused by empty slots.
2020-04-20 20:03:15 +02:00
6fdee75475
Fix phase0 types
2020-04-17 23:55:25 +08:00
e58cfedb68
clarify ssz_snappy for gossip
2020-04-16 11:12:24 -06:00
4a94200c0b
Merge pull request #1712 from ethereum/hwwhww/inactivity_penalty_quotient_bug
...
Fix `INACTIVITY_PENALTY_QUOTIENT`
2020-04-14 11:53:43 -06:00
b2f6325db3
Fix `compute_committee`
2020-04-09 17:50:23 +08:00
890c27d091
The input parameter `index` in `compute_shuffled_index` is the position of the given list, not `ValidatorIndex`
2020-04-09 17:33:14 +08:00
c10e59bdf7
Fix `INACTIVITY_PENALTY_QUOTIENT`
...
The amount of inactivity penalty was adjusted to half since we were applying penalty for missing FFG target and source. But now we only apply it for missing target, so `INACTIVITY_PENALTY_QUOTIENT` should be `2**24`.
2020-04-08 10:32:16 +08:00
2a36f366ef
Merge pull request #1710 from paulhauner/patch-20
...
Tighten aggregate attn propogation condition
2020-04-07 18:56:04 -06:00
26492651b6
Merge pull request #1706 from paulhauner/patch-19
...
Redefine attestation propogation condition
2020-04-07 18:55:41 -06:00
c96a3366fa
Tighten aggregate attn propogation condition
2020-04-07 16:07:41 +10:00
616385a094
Fix spelling mistake
2020-04-07 07:45:15 +10:00
021cb98dbb
Use epoch for attestation subnet seen-ness.
2020-04-07 07:05:51 +10:00
bdf087d7f3
add notes about how to handle peer discovery and gossip topics prior to genesis
2020-04-06 09:57:23 -06:00
7d4b97240b
Redefine attestation propogation condition
2020-04-06 17:46:33 +10:00
c3e5ddaabc
Merge branch 'dev' into phase1-tests
2020-04-03 09:54:34 -06:00
2daa26442b
Tighten restriction on a "seen" attestation
...
Declares that only a verified block can stop an attestation from being propagated.
This achieves two things:
1. Ensures that clients don't need to scan invalid blocks for attestations and then modify their state based upon them.
1. Disallows "muting" attestations by sending around a junk block with that attestation in it.
2020-03-30 10:44:46 +11:00
073f78efa1
Merge branch 'dev' into phase1-tests
2020-03-29 17:04:25 -06:00
d42e08a6e1
verify proposer sig before proposer shuffling in p2p block gossip conditions
2020-03-26 11:43:32 -06:00
c46fe86839
Merge branch 'v011x' into publish-vs-subscribe
2020-03-26 10:48:23 -06:00
a83e7a5ecc
proto PR feedback
2020-03-26 10:46:06 -06:00
050b42806d
Merge pull request #1684 from ethereum/enr-ping
...
MetaData and Ping
2020-03-26 10:40:46 -06:00
ee45cf77ef
proto feedback on MetaData
2020-03-26 07:47:20 -06:00
7af6a3afa4
do not require non-aggregating validators to subscribe to attestation subnet for beacon committee duties
2020-03-25 15:56:26 -06:00
d5a9af6469
update ping protocol to use MetaData
2020-03-25 12:08:27 -06:00
b8d25dc5b4
Merge pull request #1682 from ethereum/reward-acc-bug
...
Attestation reward bug
2020-03-24 19:36:23 -06:00
88fddf2379
Remove unneccessary clock disparity check
...
There is no need to mention clock disparity when comparing two static slot values (assuming the clock disparity is less than a slot, even then I don't think that's the intention).
2020-03-24 08:13:36 -06:00
1c49f99094
Fix bug in attestation reward calculation
2020-03-24 07:40:58 -06:00
f227e026fa
Draft PING and ENR rpc protocol
2020-03-24 15:10:47 +11:00
cf20a7ae3e
Shift some ENR fields to MAY
2020-03-24 15:07:43 +11:00
2978f21a39
minor edit to validator get_attestation_signature
2020-03-19 15:17:06 -06:00
759af67345
Normalize attestation signature getter name
2020-03-19 15:13:59 -06:00
2b8c32a347
Merge pull request #1664 from ethereum/div-zero-total-balance
...
avoid div by zero in extreme balance case
2020-03-19 08:50:09 -06:00
0a9b306d60
PR feedback from @hwwhww
2020-03-18 09:55:09 -06:00
e6998a61cd
remove IK handshake from noise spec (removed in core libp2p specs)
2020-03-17 10:54:48 -06:00
e2ef4365e2
min total balance is now EFFECTIVE_BALANCE_INCREMENT. update testing
2020-03-16 11:19:21 -06:00
5315f3db35
clarify proposer_index must be from expected shuffling when validating block gossip
2020-03-13 12:00:34 -06:00
1293320675
Merge branch 'dev' into phase1-tests
2020-03-12 07:12:41 -06:00
c894f5ecec
fork choice error note
2020-03-11 16:41:27 -06:00
a612df1119
minor typos and clarifications in fork choice
2020-03-11 16:11:42 -06:00
47bbffa0d6
'get_checkpoint_store' -> 'get_forkchoice_store' typo
2020-03-11 15:03:14 -06:00
81dc71c312
Merge pull request #1652 from ethereum/gossip-topics-with-fork-digest
...
Gossip topics with fork digest
2020-03-11 13:32:25 -06:00
4bcdf91e8b
Apply suggestions from code review
...
PR feedback
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2020-03-11 13:24:30 -06:00
36e48fba99
enforce must match target to match head to avoid perverse incentive path
2020-03-11 12:51:05 -06:00
0881e21dc5
cleanup gossip topic fork digest based on PR feedback
2020-03-11 12:02:31 -06:00
baee673124
add note about preparing for subnet backbone for forks
2020-03-10 17:29:39 -06:00
e2918c6364
Merge pull request #1626 from ethereum/proposer-index
...
add proposer index to BeaconBlock
2020-03-10 15:10:07 -06:00
fccd3ab1ce
clarify hex-encoded bytes string representation for fork digest in gossip topic
...
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2020-03-10 15:04:44 -06:00
415544bf03
modify gossip topics to use ForkDigest
2020-03-10 14:44:35 -06:00
b25ca8e32c
Merge branch 'gossip-topic' of https://github.com/status-im/eth2.0-specs into status-im-gossip-topic
2020-03-10 14:02:44 -06:00
ab24e7cab7
Merge pull request #1651 from ethereum/revert-forkchoice-header
...
revert fork choice store.blocks to BeaconBlock
2020-03-10 20:25:18 +01:00
3b7704a78f
Merge pull request #1649 from ethereum/eth1-voting-period-in-epochs
...
Eth1 voting period in epochs [updated for configs/phase1/tests compat.]
2020-03-10 13:24:03 -06:00
1c9ca3c168
Merge pull request #1635 from ethereum/rewards-overflow
...
handle rewards overflow
2020-03-10 13:23:21 -06:00
c91eee6bdf
revert fork choice store.blocks to store BeaconBlock
2020-03-10 13:20:57 -06:00
0d01299d17
Merge pull request #1648 from sgryphon/feature/clarify-store-signed-block
...
Put back in a requirement to store recent signed blocks
2020-03-10 13:13:33 -06:00
1579072e15
add note about total balance overflowing
2020-03-10 13:12:17 -06:00
d6eedd95c0
fix wording to be clear it is about serving blocks
...
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2020-03-10 13:04:28 -06:00
bd5231a975
Merge pull request #1614 from ethereum/eth2-enr
...
add eth2 key/value ENR to phase 0 p2p
2020-03-10 13:02:32 -06:00
1818f349ad
add ForkDigest type, clarify how genesis_validators_root is mixed into domains for chain isolation in p2p faq
2020-03-10 11:59:34 -06:00
55d436db51
simplify description of voting period time
2020-03-10 18:55:59 +01:00
2d7a292d36
eth1 vote period constant in epochs: update configs, phase1, tests
2020-03-10 18:36:53 +01:00
882b9ee035
Merge branch 'dev' into rewards-overflow
2020-03-11 00:41:17 +08:00
da5720f9d1
Put back in a requirement to store recent signed blocks that was removed when SignedBeaconBlock was introduced (prior to that the signature was in BeaconBlock, which was recorded in Store).
2020-03-10 21:31:03 +10:00
6230a22976
Merge pull request #1606 from ethereum/rpc-snappy-lengths
...
RPC chunks with streaming SSZ decoding, snappy frames, and stricter DOS limits where possible.
2020-03-09 11:04:12 -06:00
7e04989e29
add genesis_validators_root to beaconstate and utilize in sig domain separation as well as fork separation
2020-03-05 09:21:32 -07:00
37b1fed8ff
update eth2 ENR field to use ENRForkID
2020-03-04 14:16:30 -07:00
5dae252f56
add eth2 key/value ENR to phase 0 p2p
2020-03-04 12:33:23 -07:00
f082aa6ca9
use EFFECTIVE_BALANCE_INCREMENT to normalize reward calculations
2020-03-03 15:34:02 -07:00
33e7680836
make hysteresis calculations configurable
2020-03-03 10:58:47 -07:00
2d4ec7d52f
add REWARD_OVERFLOW_INCREMENT to avoid overflow in rewards calculation
2020-03-03 10:23:08 -07:00
0122081d05
hysteresis to -0.25/+1.25
2020-03-02 15:55:01 -07:00
38323d8186
Add faq
2020-03-01 17:17:29 +01:00
bb82a051ff
clean up, add invalid input handling
2020-02-27 19:39:34 +00:00
4d72dcf3ab
@hwwhww feedback
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2020-02-27 12:00:55 -06:00
721f605a91
Merge branch 'dev' into phase1-tests
2020-02-22 12:10:35 -06:00
4c1fc9bffa
work through phase 1 tests
2020-02-22 12:06:31 -06:00
934c037a8a
Correct the duration of HISTORICAL_ROOTS_LIMIT
...
The duration of HISTORICAL_ROOTS_LIMIT is:
SECONDS_PER_SLOT * SLOTS_PER_HISTORICAL_ROOT * HISTORICAL_ROOTS_LIMIT
which is
12s * 2^13 * 2^24 = 1.65e12s = 52,262 years
2020-02-22 09:22:52 -06:00
3bb8e0d962
cleanup attester slashing conditon code snippet
...
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2020-02-22 09:22:52 -06:00
f671b86776
add DoS prevention validation conditions to voluntary_exit, proposer_slashing, and attester_slashing gossipsub channels
2020-02-22 09:22:52 -06:00
7329cc0933
pr feedback
...
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2020-02-22 09:22:51 -06:00
3404f1e078
add lower bound condition on block gossip
2020-02-22 09:22:51 -06:00
581257e269
reorder gossip conditions to put cheap checks before signature verifications
2020-02-22 09:22:51 -06:00
f7181adece
reverse params in get_aggregate_and_proof to match ssz type
2020-02-22 09:22:51 -06:00
d2e08c0cdf
subnet validation PR feedback
2020-02-22 09:22:51 -06:00
dde69cb8e2
add explicit instrucutions for construction of signed_aggregate_and_proof. add DOMAIN_SELECTION_PROOF and DOMAIN_AGGREGATE_AND_PROOF
2020-02-22 09:22:51 -06:00
5ee1f9b545
fix up some p2p validation conditions based on PR feedback
2020-02-22 09:22:50 -06:00
fd633d2467
add clarifying note to signedaggregateandproof in vaidator guide and fix tocs
2020-02-22 09:22:50 -06:00
343168908c
prevent multiple beacon blocks from same proposer in a given slot
2020-02-22 09:22:50 -06:00
8da7a84eb7
create SignedAggregateAndProof to prevent DoS attacks
2020-02-22 09:22:50 -06:00
047936eb2d
Add no repeat attestation condition for committee_index_beacon_attestation gossip channel
2020-02-22 09:22:50 -06:00
0a849acdce
fix validator guide to show that block slashing is per slot rather than per epoch
2020-02-22 09:22:49 -06:00
61f661b3ec
Update specs/phase0/p2p-interface.md
...
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2020-02-20 08:23:09 +01:00
a02aac43c2
adjust hysteresis to avoid initial over-deposit incentive
2020-02-18 12:36:20 -06:00
757f5a31dd
add proposer index and add/modify tests
2020-02-18 11:38:17 -06:00
cfcb7b2f01
Measure eth1 voting period in epochs instead of slots
2020-02-18 16:12:43 +03:00
52b45ab9de
Add fork version to topic
...
Gossipsub peers are separate from the ETH2 RPC protocol, and thus cannot
rely on the application-level `Status` negotiation to establish if
they're on the same network.
Segregating gossipsub topics by fork version decouples RPC from gossip
further and allows peers to more easily listen only to the traffic of
the network they're interested in, without further negotiation.
2020-02-17 10:03:32 +01:00
8620adcdf1
Correct the duration of HISTORICAL_ROOTS_LIMIT
...
The duration of HISTORICAL_ROOTS_LIMIT is:
SECONDS_PER_SLOT * SLOTS_PER_HISTORICAL_ROOT * HISTORICAL_ROOTS_LIMIT
which is
12s * 2^13 * 2^24 = 1.65e12s = 52,262 years
2020-02-14 14:29:45 +00:00
40b4931f01
cleanup attester slashing conditon code snippet
...
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2020-02-13 11:17:19 -07:00
a7ef70eb9b
add DoS prevention validation conditions to voluntary_exit, proposer_slashing, and attester_slashing gossipsub channels
2020-02-12 15:56:03 -07:00
f441fadfff
pr feedback
...
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2020-02-12 15:50:22 -07:00
f8b72f5057
add lower bound condition on block gossip
2020-02-12 12:07:57 -07:00
a9fae27379
Merge pull request #1615 from ethereum/subnet-validations
...
Add subnet validations for DoS resistance
2020-02-12 12:02:28 -07:00
714a7de8a2
reorder gossip conditions to put cheap checks before signature verifications
2020-02-12 11:59:00 -07:00
90476388fe
reverse params in get_aggregate_and_proof to match ssz type
2020-02-11 15:54:18 -07:00
bf8252aeb6
subnet validation PR feedback
2020-02-11 15:46:30 -07:00
eec57f29b7
add explicit instrucutions for construction of signed_aggregate_and_proof. add DOMAIN_SELECTION_PROOF and DOMAIN_AGGREGATE_AND_PROOF
2020-02-11 15:45:51 -07:00
8d16d428e0
fix up some p2p validation conditions based on PR feedback
2020-02-10 21:35:39 -07:00
3d111f7bdd
Merge pull request #1612 from ethereum/v-guide-per-slot-slash
...
[validator guide] beacon block is per-slot slashing
2020-02-10 19:42:01 -07:00
8a2a689c80
add clarifying note to signedaggregateandproof in vaidator guide and fix tocs
2020-02-10 19:36:08 -07:00
1ca4e3538c
prevent multiple beacon blocks from same proposer in a given slot
2020-02-10 19:28:37 -07:00
118a755bbb
create SignedAggregateAndProof to prevent DoS attacks
2020-02-10 19:18:14 -07:00
c1a51a9358
Add no repeat attestation condition for committee_index_beacon_attestation gossip channel
2020-02-10 18:53:26 -07:00
d5f1402d0d
Merge pull request #1604 from status-im/fewer-head-block-roots
...
drop `head_block_root` from BeaconBlocksByRange
2020-02-08 18:24:54 -06:00
43cacc3fe9
fix validator guide to show that block slashing is per slot rather than per epoch
2020-02-08 16:58:05 -07:00
6188f350f6
it's just a number
2020-02-07 19:03:33 +01:00
97d931b705
rephrase fork choice requirement
2020-02-07 19:03:09 +01:00
b398e42439
another typo in pubsub channel name
2020-02-06 16:41:53 -08:00
7aeeb372a7
[validator-guide] typo fix
2020-02-06 16:03:40 -08:00
03f53e9928
Merge pull request #1607 from AgeManning/noise-specification
...
Add libp2p-noise specification
2020-02-06 12:05:49 -06:00
9355a6ebca
Noise libp2p specification
2020-02-05 14:33:00 +11:00
93249aadda
Proposal to focus on length-encoding SSZ contents, enable streaming of chunk contents, and put stricter DOS limits in place
2020-02-04 13:56:32 +01:00
74c75fd6f1
Remove extraneous word
2020-02-02 22:08:11 +00:00
c943b5832e
drop `head_block_root` from BeaconBlocksByRange
...
This change simplifies the protocol and removes a race condition between
block request and response. In the case of honest server, this helps
serve the canonical / fork-chosen chain better while dishonest or broken
servers still need to be handled the same way.
Might as well get started on versions and upgrade it to 2, since the
change is backwards incompatible.
2020-01-31 22:04:48 +01:00
51f2974678
Update validator.md
...
Minor edit
2020-01-29 13:51:38 +00:00
67a4d5e659
Merge branch 'dev' into master-copy
2020-01-24 13:49:22 -07:00
d4ae00819a
Fix for increased seconds per slot
2020-01-23 13:08:52 -07:00
86b699bfd1
Merge branch 'dev' into phase1rebase
2020-01-23 19:24:03 +01:00
de1bb7bde1
Update for renamed constant
2020-01-23 09:55:04 -07:00
a13271af41
Fix BLS API description
2020-01-23 09:52:40 -07:00
f8250b6a1a
Correct typo in heading level
2020-01-23 09:51:58 -07:00
14cfc66c33
Fix p2p interface indentation
2020-01-23 09:51:38 -07:00
eed3f6053d
Merge pull request #1580 from ethereum/fork-choice-fix-1574
...
Fork choice fix issue 1574
2020-01-22 16:56:00 -07:00
d672c47aba
Merge pull request #1579 from ethereum/epochs-in-fork-choice
...
Properly handle skip slots in fork choice
2020-01-22 16:55:15 -07:00
9f5f501e5b
Merge pull request #1586 from ethereum/fix-default-compute-domain
...
fix default value in compute_domain
2020-01-23 00:29:28 +01:00
ebac603745
Update for renamed constant
2020-01-22 22:23:36 +00:00
fe103394db
Merge pull request #1583 from sigp/kirk-baird-patch-02
...
Update BLS Link
2020-01-22 14:57:36 -07:00
b357e43aab
clarifying comment on call to get_ancestor in on_block
2020-01-22 14:31:23 -07:00
e821476c07
explicitly use Optiona type for fork_version in compute_domain
...
Co-Authored-By: Carl Beekhuizen <carl@ethereum.org>
2020-01-22 11:38:50 -07:00
cf18b040b4
fix default value in compute_domain
2020-01-22 07:24:15 -07:00
601701241c
Update link
...
Signed-off-by: Kirk Baird <baird.k@outlook.com>
2020-01-22 11:04:45 +11:00
2015433fa1
revert exit queue epoch issue introduced in v0.10.0. add test to catch subtlety
2020-01-20 20:03:38 -07:00
00d3fb4fe6
fix issue 1574 by ensuring that justified checkpoint in store updates when finalized updates if needbe
2020-01-20 18:50:50 -07:00
e98c1b4154
don't consider blocks with slots earlier than finalized in on_block fork choice (optimization)
2020-01-20 18:10:39 -07:00
f1697d03e7
fix corner case to properly handle skipped slots in get_ancestor
2020-01-20 17:49:09 -07:00
3c07b2c954
Make phase 0 fork choice more modular to more easily adopt for slight modifications in phase 1
2020-01-15 16:40:50 -07:00
08621a7973
Merge pull request #1567 from ethereum/fix_bls_api
...
[Minor] fix BLS API description
2020-01-15 14:21:15 -07:00
1756348e8d
Merge pull request #1569 from ChihChengLiang/minor-fix-indentation
...
[Minor] Fix p2p interface table level
2020-01-15 14:19:42 -07:00
6c74468142
forkchoice store on top of any state now
2020-01-14 01:02:02 +01:00
4732c7beb1
merge in dev (v0.10) and fix reorg/lint issues
2020-01-13 18:55:21 +01:00
065b4ef856
Fix p2p interface indentation
2020-01-13 20:42:23 +08:00
b001f250db
Correct typo in heading level
2020-01-13 09:34:34 +00:00
efbea8c53c
Fix BLS API description
2020-01-13 12:49:03 +08:00
676e216beb
reorg specs by fork and move ssz out to own folder. make all of the build and link changes to support move
2020-01-10 11:55:13 -07:00
Justin
Jacek Sieka
Hsiao-Wei Wang
Danny Ryan
Paul Hauner
Michael Sproul
Age Manning
Diederik Loerakker
Sly Gryphon
Ben Edgington
Anton Nashatyrev
Alex Stokes
Jim McDonald
Herman Junge
Chih Cheng Liang
Kirk Baird