17f656cefe
Merge branch 'dev' into v012x
2020-05-11 10:41:35 -06:00
fcf003859d
remove duplicate response diagram
2020-05-11 17:01:18 +02:00
b4bc2038e1
clarify that clients MAY stop block requests if fork choice changes
2020-05-11 08:39:30 -06:00
7d4d3e43ef
remove aggregate clarifiyng text that is not longer valid
...
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
2020-05-11 08:38:22 -06:00
b3dd99f4f4
Loosen restrictions for aggregate propogation
2020-05-11 08:28:21 -06:00
3fb4c43fae
Merge pull request #1794 from ethereum/2x-attester-slashings
...
MAX_ATTESTER_SLASHINGS == 2 and add multiple slashings per block tests
2020-05-11 08:12:23 -06:00
a8e3fe7551
Update p2p reqresp with explicit handling of reqresp size bounds
2020-05-09 21:44:28 +02:00
cdd0ed0f7b
Update to IETF BLS draft-irtf-cfrg-bls-signature-02
2020-05-09 11:48:48 +08:00
fdcc6d65bc
gossipsub v1.1 and extended validators for gossip conditions
2020-05-08 12:00:05 -06:00
01eaf6cc99
Clarify the response of BlocksByRange to address #1765
2020-05-08 11:09:12 -06:00
7a130606ac
hww feedback
2020-05-08 10:51:41 -06:00
1137e0332d
move MAX_ATTESTER_SLASHINGS to 2, add multiple slashings per block tests
2020-05-08 10:43:11 -06:00
08652f543b
Merge branch 'v012x' into empty-bits-case
2020-05-07 10:17:26 -06:00
7625728fb8
Merge pull request #1742 from ethereum/ffg_lmd_vote_consistency
...
Added FFG-LMD vote consistency checks
2020-05-07 09:36:52 -06:00
4f401133e1
address PR feedback from @protolambda
2020-05-05 15:37:14 -06:00
b71a0ee6b9
Merge branch 'v012x' into ffg_lmd_vote_consistency
2020-05-05 13:40:27 -06:00
38f29ba0a8
remove PERSISTENT_COMMITTEE_PERIOD in favor of SHARD_COMMITTEE_PERIOD
2020-05-05 11:44:53 -06:00
b2c36112f6
Merge branch 'dev' into v012x
2020-05-05 09:44:27 -06:00
3f250f7dd3
PR feedback
2020-05-04 21:05:10 -06:00
c2c27791c5
Merge branch 'dev' into rewards-rework
2020-05-01 10:52:19 -06:00
09cae4b3cc
Handle empty-aggregation-bits case, and add tests. See #1713
2020-05-01 15:17:41 +02:00
4b4fc32f9c
Merge pull request #1755 from paulhauner/patch-23
...
Fork choice: Remove redundant check in validate_on_attestation
2020-04-30 11:06:29 -06:00
2dc5156651
Add message about delaying consideration
2020-04-30 16:27:02 +10:00
6a40f71a31
add note about beacon committees not going into attnets
2020-04-29 20:29:48 -06:00
cd27e5e045
add tests for source, target, head
2020-04-29 10:23:12 -06:00
5f18dd778c
add baseline get_target_deltas tests
2020-04-28 19:26:14 -06:00
4a086fba5c
Merge branch 'dev' into rewards-rework
2020-04-28 17:24:45 -06:00
87586837c3
remove interop from phase 0 p2p specs
2020-04-27 17:39:39 -06:00
d128400da5
remove interop from header and gossip sections in network spec
2020-04-27 17:39:31 -06:00
553a33cd2d
Merge pull request #1766 from ethereum/dev
...
backport dev to v012x
2020-04-27 17:35:28 -06:00
9d39c292e0
Merge pull request #1763 from ethereum/master
...
Backport v0.11.2 hotfixes from master to dev
2020-04-28 00:18:52 +02:00
dae623b097
Merge pull request #1756 from byz-f/q9-genesis-eth1
...
genesis: clarify that eth1 timestamp can be less than min genesis time
2020-04-27 10:15:18 -06:00
2dbc333270
Make `compute_new_state_root` a pure function
2020-04-27 22:18:43 +08:00
4d980aec71
Fix validator guide
...
1. Avoid negative computation in `is_candidate_block`
2. Fix `get_block_signature`: avoid extra casting; it's simpler to use BeaconBlock instead of
BeaconHeader
2020-04-27 21:47:24 +08:00
c841aa102b
genesis: clarify that eth1 timestamp can be less than min genesis time
2020-04-26 10:09:22 +02:00
1a81c873af
Remove redundant check in fork choice
2020-04-26 16:24:16 +10:00
9acea51938
Simplified by re-using get_ancestor()
2020-04-25 14:17:28 -07:00
0c67aaa68e
Include fork digest in example gossip topic name
2020-04-25 00:05:37 +02:00
fde9b410f0
Merge pull request #1752 from ethereum/dev
...
sync v0.11.2 to `v012x`
2020-04-24 11:36:17 -06:00
bf806b9efa
Require "seen" aggregates to be valid
2020-04-24 15:01:18 +10:00
7612667bbe
minor feedback and fixes on rewards/penalites proposal
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2020-04-23 11:13:09 -06:00
fe13bab338
rework rewards/penalties to be more granular
2020-04-23 10:26:34 -06:00
11d164748c
add 'valid' when de-deduplication of attestations on gossip subnets
2020-04-22 14:45:01 -06:00
d8662d49ea
Merge pull request #1730 from ethereum/bootnode-enr
...
add note about distributing bootnode ENRs prior to genesis
2020-04-22 14:38:38 -06:00
3d4122a2f6
add note about distributing bootnode ENRs prior to genesis
2020-04-22 14:33:57 -06:00
9bbac0d2cc
Added consistency check for FFG & LMD vote in validate_on_atttestation(), fixes #1636 , fixes #1456 , fixes #1408
2020-04-21 23:56:44 -07:00
5929aac799
Cosmetic changes from #1737
2020-04-22 11:40:10 +08:00
a6b2679cb0
Merge pull request #1739 from ethereum/JustinDrake-patch-4
...
Partial fix for #1701
2020-04-21 08:44:22 -06:00
3436021e72
Update beacon-chain.md
2020-04-21 15:34:55 +01:00
ebf888bcf7
Merge pull request #1736 from status-im/rannge-req
...
simplify block range request description
2020-04-21 08:21:57 -06:00
e2a320ef32
Partial fix for #1701
...
Clarify that state transitions with `uint64` overflows are invalid.
2020-04-21 08:59:53 +01:00
508811d641
Fix #1735—remove redundant check
...
As per #1735 the check `if not len(indices) <= MAX_VALIDATORS_PER_COMMITTEE: return False` is redundant. As such this PR should be purely cosmetic.
2020-04-21 08:50:42 +01:00
4915014a19
simplify block range request description
...
There's room for ambiguity as to what `count` means - this clarifies
that it always relates to the slot, and not the number of blocks in the
response which allows clients to request ranges epoch by epoch (for
example) without worrying about overlaps caused by empty slots.
2020-04-20 20:03:15 +02:00
6fdee75475
Fix phase0 types
2020-04-17 23:55:25 +08:00
e58cfedb68
clarify ssz_snappy for gossip
2020-04-16 11:12:24 -06:00
4a94200c0b
Merge pull request #1712 from ethereum/hwwhww/inactivity_penalty_quotient_bug
...
Fix `INACTIVITY_PENALTY_QUOTIENT`
2020-04-14 11:53:43 -06:00
b2f6325db3
Fix `compute_committee`
2020-04-09 17:50:23 +08:00
890c27d091
The input parameter `index` in `compute_shuffled_index` is the position of the given list, not `ValidatorIndex`
2020-04-09 17:33:14 +08:00
c10e59bdf7
Fix `INACTIVITY_PENALTY_QUOTIENT`
...
The amount of inactivity penalty was adjusted to half since we were applying penalty for missing FFG target and source. But now we only apply it for missing target, so `INACTIVITY_PENALTY_QUOTIENT` should be `2**24`.
2020-04-08 10:32:16 +08:00
2a36f366ef
Merge pull request #1710 from paulhauner/patch-20
...
Tighten aggregate attn propogation condition
2020-04-07 18:56:04 -06:00
26492651b6
Merge pull request #1706 from paulhauner/patch-19
...
Redefine attestation propogation condition
2020-04-07 18:55:41 -06:00
c96a3366fa
Tighten aggregate attn propogation condition
2020-04-07 16:07:41 +10:00
616385a094
Fix spelling mistake
2020-04-07 07:45:15 +10:00
021cb98dbb
Use epoch for attestation subnet seen-ness.
2020-04-07 07:05:51 +10:00
bdf087d7f3
add notes about how to handle peer discovery and gossip topics prior to genesis
2020-04-06 09:57:23 -06:00
7d4b97240b
Redefine attestation propogation condition
2020-04-06 17:46:33 +10:00
c3e5ddaabc
Merge branch 'dev' into phase1-tests
2020-04-03 09:54:34 -06:00
2daa26442b
Tighten restriction on a "seen" attestation
...
Declares that only a verified block can stop an attestation from being propagated.
This achieves two things:
1. Ensures that clients don't need to scan invalid blocks for attestations and then modify their state based upon them.
1. Disallows "muting" attestations by sending around a junk block with that attestation in it.
2020-03-30 10:44:46 +11:00
073f78efa1
Merge branch 'dev' into phase1-tests
2020-03-29 17:04:25 -06:00
d42e08a6e1
verify proposer sig before proposer shuffling in p2p block gossip conditions
2020-03-26 11:43:32 -06:00
c46fe86839
Merge branch 'v011x' into publish-vs-subscribe
2020-03-26 10:48:23 -06:00
a83e7a5ecc
proto PR feedback
2020-03-26 10:46:06 -06:00
050b42806d
Merge pull request #1684 from ethereum/enr-ping
...
MetaData and Ping
2020-03-26 10:40:46 -06:00
ee45cf77ef
proto feedback on MetaData
2020-03-26 07:47:20 -06:00
7af6a3afa4
do not require non-aggregating validators to subscribe to attestation subnet for beacon committee duties
2020-03-25 15:56:26 -06:00
d5a9af6469
update ping protocol to use MetaData
2020-03-25 12:08:27 -06:00
b8d25dc5b4
Merge pull request #1682 from ethereum/reward-acc-bug
...
Attestation reward bug
2020-03-24 19:36:23 -06:00
88fddf2379
Remove unneccessary clock disparity check
...
There is no need to mention clock disparity when comparing two static slot values (assuming the clock disparity is less than a slot, even then I don't think that's the intention).
2020-03-24 08:13:36 -06:00
1c49f99094
Fix bug in attestation reward calculation
2020-03-24 07:40:58 -06:00
f227e026fa
Draft PING and ENR rpc protocol
2020-03-24 15:10:47 +11:00
cf20a7ae3e
Shift some ENR fields to MAY
2020-03-24 15:07:43 +11:00
2978f21a39
minor edit to validator get_attestation_signature
2020-03-19 15:17:06 -06:00
759af67345
Normalize attestation signature getter name
2020-03-19 15:13:59 -06:00
2b8c32a347
Merge pull request #1664 from ethereum/div-zero-total-balance
...
avoid div by zero in extreme balance case
2020-03-19 08:50:09 -06:00
0a9b306d60
PR feedback from @hwwhww
2020-03-18 09:55:09 -06:00
e6998a61cd
remove IK handshake from noise spec (removed in core libp2p specs)
2020-03-17 10:54:48 -06:00
e2ef4365e2
min total balance is now EFFECTIVE_BALANCE_INCREMENT. update testing
2020-03-16 11:19:21 -06:00
5315f3db35
clarify proposer_index must be from expected shuffling when validating block gossip
2020-03-13 12:00:34 -06:00
1293320675
Merge branch 'dev' into phase1-tests
2020-03-12 07:12:41 -06:00
c894f5ecec
fork choice error note
2020-03-11 16:41:27 -06:00
a612df1119
minor typos and clarifications in fork choice
2020-03-11 16:11:42 -06:00
47bbffa0d6
'get_checkpoint_store' -> 'get_forkchoice_store' typo
2020-03-11 15:03:14 -06:00
81dc71c312
Merge pull request #1652 from ethereum/gossip-topics-with-fork-digest
...
Gossip topics with fork digest
2020-03-11 13:32:25 -06:00
4bcdf91e8b
Apply suggestions from code review
...
PR feedback
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2020-03-11 13:24:30 -06:00
36e48fba99
enforce must match target to match head to avoid perverse incentive path
2020-03-11 12:51:05 -06:00
0881e21dc5
cleanup gossip topic fork digest based on PR feedback
2020-03-11 12:02:31 -06:00
baee673124
add note about preparing for subnet backbone for forks
2020-03-10 17:29:39 -06:00
e2918c6364
Merge pull request #1626 from ethereum/proposer-index
...
add proposer index to BeaconBlock
2020-03-10 15:10:07 -06:00
fccd3ab1ce
clarify hex-encoded bytes string representation for fork digest in gossip topic
...
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2020-03-10 15:04:44 -06:00
415544bf03
modify gossip topics to use ForkDigest
2020-03-10 14:44:35 -06:00
Danny Ryan
protolambda
Paul Hauner
Hsiao-Wei Wang
Raw Pong Ghmoa
Aditya Asgaonkar
Justin
Jacek Sieka
Michael Sproul
Age Manning