status-im
/
eth2.0-specs
mirror of https://github.com/status-im/eth2.0-specs.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
3,163 Commits 49 Branches 0 Tags 29 MiB
Commit Graph

1654 Commits

Author SHA1 Message Date
Diederik Loerakker d587c4fe61 Critical fix: introduce back total-value check (#1220) 
This was dropped in a376b6607f, as improvement in dust checking.
Now that dust-checking is done, we still need to check if the sender has the minimum value, as decrease balance just clips to 0.
See be86f966f8 for older dust-creation problem work around, which was dropped in the above.

The bug enabled you to transfer your full balance to someone else, and pay the same amount in fee, possibly to a puppet proposer to collect back funds.
Effectively enabling printing of money. Silly bug, good to fix and introduce tests for.
 2019-06-26 20:21:17 +01:00
Alex Stokes 4986311d5b
Update 0_beacon-chain.md 
fix typo w/ refactor
 2019-06-25 10:24:14 -06:00
Danny Ryan df2a9e1b54
Merge pull request #1180 from ethereum/list-rework 
pyspec-SSZ: lists-rework (enable static generalized indices) + fully python class based now.
 2019-06-25 07:38:50 -06:00
JSON 20602bc92b phase 0 doc standardization b4 spec freeze (#1212) 2019-06-25 14:32:56 +01:00
Alex Stokes 37b1872634 Remove duplicate custom type definitions (#1214) 
Seems to be an accidental duplication of the type defs
 2019-06-25 14:30:59 +01:00
protolambda 054a157953
get rid of TypingList, add MutableSequence 2019-06-25 02:58:10 +02:00
Diederik Loerakker 45dbf5a107
Remove old Deltas reference 
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
 2019-06-25 02:41:02 +02:00
Alex Stokes 82167ff0a3
Clarify comment on phase 0 transfers 
The comment seems to imply conjunction over each case, but the code implies disjunction; at the very least it is ambiguous.

This PR makes the comment less ambiguous.
 2019-06-24 15:40:37 -07:00
protolambda 9fb5806764
be explicit about input for balance sum 2019-06-25 00:24:13 +02:00
protolambda 8b88c3f43c
Merge remote-tracking branch 'origin' into list-rework 2019-06-24 23:58:00 +02:00
protolambda 5989e5cd23
use Bool as base name, make Bit an alias 2019-06-24 23:56:26 +02:00
protolambda 82ae180490
clean up list limit constants 2019-06-24 23:38:36 +02:00
protolambda 1408a1ee0d
undo tuple wrapping 2019-06-23 00:17:54 +02:00
protolambda f95e7315b4
fix get_active_validator_indices typing usage 2019-06-22 18:34:33 +02:00
protolambda 00aae07d46
type annotation clean up 2019-06-22 18:12:42 +02:00
Diederik Loerakker b007d5aa92 Add note on default zero-values, and be explicit with state-root (#1208) 
* Add note on default zero-values, and be explicit with state-root
 2019-06-22 17:38:30 +02:00
protolambda 16093eb8ce
Merge branch 'dev' into list-rework 2019-06-22 17:11:59 +02:00
Diederik Loerakker c86108de00
Merge pull request #1207 from ethereum/fix_make_lint 
Fix `make lint`
 2019-06-22 17:07:00 +02:00
Justin Drake 1e1a3e5311 Avoid substraction in comparison 2019-06-22 07:34:02 +02:00
Justin Drake 613380bff4 Shorter in-line comments 2019-06-22 07:29:25 +02:00
Hsiao-Wei Wang 183fa3c776
Make linter happy 2019-06-21 23:09:11 -06:00
protolambda 0b0e9a51d7
Merge branch 'dev' into list-rework 2019-06-21 23:44:01 +02:00
Hsiao-Wei Wang f55499c0ba Fix Gwei value table (#1203) 2019-06-21 14:30:22 -06:00
protolambda 80c40f5e09
merge dev, resolve minor merge conflicts 2019-06-21 21:22:23 +02:00
Danny Ryan acbccbc2a8
minor typo 2019-06-21 11:18:24 -06:00
Justin Drake b46e047baa Minor simplification from #1198 2019-06-21 12:57:30 +01:00
Carl Beekhuizen 0e59c6676a
Stop yielding from fork-choie tests 2019-06-21 13:00:42 +02:00
Carl Beekhuizen f90469ea25
Move block timing assertion 1st 2019-06-21 12:19:08 +02:00
Carl Beekhuizen e88a96c45e
Apply suggestions from @drjtwo's code review 
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
 2019-06-21 12:13:22 +02:00
Hsiao-Wei Wang e99c864ed1
Deltas = NewType('Deltas', TypingList[Gwei]) 2019-06-20 17:17:12 -06:00
protolambda 3d8466fd6e
make Bit check not use "is", and remove duplicate line 2019-06-20 23:04:19 +02:00
protolambda 2d67717079
fix linting issues + make spec builder remove comments in container re-initialization part 2019-06-20 21:42:55 +02:00
Carl Beekhuizen c26fffc154
Moves copy into SSZ container 2019-06-20 20:55:28 +02:00
Carl Beekhuizen 5f8edd6b55
Genesis block store uses genesis time 
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
 2019-06-20 20:50:17 +02:00
protolambda f157745248
resolve some remaining list-rework rebase details 2019-06-20 20:42:19 +02:00
protolambda 4e747fb887
fixes for class based ssz typing 2019-06-20 20:25:22 +02:00
protolambda 5048b9e87a temporary fix for phase-1 spec typing 2019-06-20 20:20:45 +02:00
protolambda 4b4bf87e47 update shard doc, use new types, avoid List 2019-06-20 20:15:56 +02:00
protolambda 8344d50ae5
update beacon chain doc, use new types, avoid List 2019-06-20 20:15:48 +02:00
protolambda 4aefc078e9
list-rework type fixes 2019-06-20 20:11:39 +02:00
vbuterin 4c2adcc5e6 Update 0_beacon-chain.md 2019-06-20 20:05:57 +02:00
protolambda b89183ae69
Update spec for new SSZ with list max length 2019-06-20 20:05:34 +02:00
protolambda 97025c51ac
start updating virtual sizes of lists 2019-06-20 20:03:11 +02:00
Justin Drake d73aa31ef6 Cleanups 2019-06-20 11:58:05 +01:00
Carl Beekhuizen e0d814df32
Merge branch 'dev' into executable_fork_choice 
* dev:
  Increase historical length and cleanups (#1196)
 2019-06-19 22:43:14 +02:00
Danny Ryan 29dbe1b880 Increase historical length and cleanups (#1196) 
* increase historical length and a few cleanups
 2019-06-19 20:59:44 +01:00
Carl Beekhuizen 3418c3506f
Merge dev and resolve conflicts (please let the CI tests pass with the new dev) 2019-06-19 20:27:54 +02:00
Carl Beekhuizen 61a51417ed
Unbreak things again 2019-06-18 23:00:30 +02:00
protolambda 060041945c
remove unnecessary cast 2019-06-18 22:00:22 +02:00
protolambda 346e61dfeb
make epoch pattern similar to exit-epoch loop 2019-06-18 21:59:16 +02:00