Commit Graph

6647 Commits

Author SHA1 Message Date
Danny Ryan 3161846aed
Apply suggestions from code review 2021-07-07 10:29:14 -06:00
Danny Ryan bdbee43a36
Merge pull request #2508 from ethereum/JustinDrake-patch-7
fix minor cosmetic typo
2021-07-07 09:39:08 -06:00
Justin c8d22b1d91
fix minor cosmetic typo 2021-07-07 13:44:22 +01:00
Alex Stokes fdcb0780d2
add randomized testing for sync aggregate block processing 2021-07-06 18:13:33 -07:00
Alex Stokes ac8b4000d3
remove unnecessary assert 2021-07-06 17:28:55 -07:00
Danny Ryan 153e1b34dd
Merge pull request #2504 from ralexstokes/add-altair-process-sync-aggregate-tests
add more Altair tests for `process_sync_aggregate`
2021-07-02 15:55:22 -06:00
Danny Ryan 8ad73d75a6
Merge pull request #2505 from ethereum/test_get_sync_subcommittee_pubkeys
Add Altair networking helper tests
2021-07-02 15:33:49 -06:00
Danny Ryan 1865cdb4fc
add comment 2021-07-02 15:28:05 -06:00
Alex Stokes 2d4ff72b2d
Update tests/core/pyspec/eth2spec/test/altair/block_processing/test_process_sync_aggregate.py
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2021-07-02 08:38:03 -07:00
Danny Ryan 3d7471a52c
Merge pull request #2502 from ethereum/sc-update-tests
add more process_sync_committee_updates tests
2021-07-02 09:33:35 -06:00
Danny Ryan cdc3e6756f
Merge pull request #2503 from ethereum/flag-updates-tests
add more test_process_participation_flag_updates tests
2021-07-02 09:25:43 -06:00
Danny Ryan e95d71f85d
pr feedback 2021-07-02 09:25:08 -06:00
Hsiao-Wei Wang 7bde1729b1
Add Altair networking helper tests 2021-07-02 14:42:02 +08:00
Alex Stokes f9b4d7f287
add test for sync aggregate with proposer in sync committee 2021-07-01 17:36:30 -07:00
Alex Stokes 49c433746d
sync aggregate test with proposer in the committee 2021-07-01 17:35:48 -07:00
Alex Stokes faf1ba1f4f
clean up test
this test does not need to collect the intermediate blocks it produces
2021-07-01 17:30:40 -07:00
Alex Stokes b3a879c990
add tests for duplicated sync committee members with various amounts of participation 2021-07-01 17:30:40 -07:00
Alex Stokes 21aaab5a1e
add test for sync aggregate with bad domain in signature 2021-07-01 17:30:40 -07:00
Alex Stokes 2aa5bf8384
assert active validator set is larger than sync committee size
ensure set is larger, rather than just equal to
2021-07-01 16:35:03 -07:00
Danny Ryan 927b26636e
add more test_process_participation_flag_updates tests 2021-07-01 13:12:15 -06:00
Danny Ryan 0ed032d392
add more process_sync_committee_updates tests 2021-07-01 12:53:12 -06:00
Alex Stokes 060ba633eb
Merge pull request #2499 from ethereum/altair-validator-tests
Add some Altair validator guide tests
2021-07-01 10:56:59 -07:00
Hsiao-Wei Wang bb327d274e
Add more Altair validator guide unit tests
Add `test_get_sync_committee_message`

Add `test_get_sync_committee_selection_proof`

Add `always_bls` deco

Add `test_is_sync_committee_aggregator`

Add `test_get_contribution_and_proof` and `test_get_contribution_and_proof_signature` + fixes
2021-07-01 22:49:23 +08:00
Hsiao-Wei Wang 27763bdd86
clean up 2021-06-30 05:40:26 +08:00
Hsiao-Wei Wang 29a93f6285
Move more unit tests to test vectors 2021-06-30 04:55:41 +08:00
Alex Stokes 4f905551c0
Merge pull request #2497 from ethereum/union-debug-utils
encode, decode and randomize ssz Union types
2021-06-24 09:37:49 -07:00
Alex Stokes 44a3113ce1
fix spacing for linter 2021-06-24 09:24:58 -07:00
protolambda dbf7fbd3d0
encode, decode and randomize ssz Union types 2021-06-24 17:13:36 +02:00
Danny Ryan 85901cdfa7
Merge pull request #2494 from ethereum/bump-version
bump VERSION.txt to 1.1.0-alpha.8
2021-06-23 08:51:31 -06:00
Danny Ryan 989c9620c7
bump VERSION.txt to 1.1.0-alpha.8 2021-06-23 08:32:52 -06:00
Danny Ryan 00afb341de
Merge pull request #2479 from mkalinin/randao_in_execution_payload
Add randao to execution payload
2021-06-23 08:30:21 -06:00
Danny Ryan d774fb6b00
Merge pull request #2491 from ethereum/sync-committee-gossip
optimize sync committee message gossip and caches
2021-06-23 08:15:00 -06:00
Danny Ryan f2bd21b434
Merge pull request #2492 from ethereum/vbuterin-patch-11
Update merge description to signal more progress
2021-06-22 17:16:51 -06:00
vbuterin e8136cb62c
Update merge description to signal more progress 2021-06-22 18:15:56 -05:00
Hsiao-Wei Wang f55afefe90
Move more tests from unittests to testgen tests
- `test_on_block_before_finalized`
- `test_on_block_finalized_skip_slots`
- `test_on_block_finalized_skip_slots_not_in_skip_chain`
2021-06-23 04:58:27 +08:00
Hsiao-Wei Wang 69a645aa8b
Apply PR feedback 2021-06-23 04:50:13 +08:00
Danny Ryan c61eeb8a27
optimize sync committee message gossip and caches 2021-06-22 12:31:02 -06:00
Hsiao-Wei Wang 88be6cdf60
Apply Danny's suggestions from code review
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
2021-06-22 20:55:52 +08:00
Hsiao-Wei Wang 83598af188
Add `test_new_justified_is_later_than_store_justified` and fix test
cases

- Fix `on_tick` calls
- Refactor test cases
2021-06-22 20:04:47 +08:00
Mikhail Kalinin e5c01061af Add couple of cosmetic fixes 2021-06-22 14:26:38 +06:00
Mikhail Kalinin ac19aa3e2d Accept polishing suggested by Justin 2021-06-22 14:23:26 +06:00
Danny Ryan 8107d0d582
Merge pull request #2485 from nisdas/patch-1
Make The Nature of Validator Sync Committee Assignments Clearer
2021-06-21 16:51:11 -05:00
Danny Ryan fc1012b632
typo 2021-06-21 12:49:41 -06:00
Danny Ryan a61aa7968d
clean up 2021-06-21 12:48:44 -06:00
Mikhail Kalinin 199d6aee58 Merge remote-tracking branch 'origin/dev' into randao_in_execution_payload 2021-06-19 00:28:38 +06:00
Hsiao-Wei Wang 7a9ae57335
Minor formatting. `True` -> `true`, `False` -> `false` 2021-06-19 02:13:02 +08:00
Hsiao-Wei Wang 2445fe5a76
Add new test cases
- `test_new_finalized_slot_is_not_justified_checkpoint_ancestor`
- `test_new_finalized_slot_is_justified_checkpoint_ancestor`
2021-06-19 02:03:37 +08:00
Hsiao-Wei Wang fb2465db45
Rework `on_block` unit tests 2021-06-19 02:03:33 +08:00
Justin 878b15df6a
polish merge/beacon-chain.md (#2472)
Polish `merge/beacon-chain.md` with mostly non-substantive changes.

**Non-substantive changes**

* rename `MAX_EXECUTION_TRANSACTIONS` to `MAX_TRANSACTIONS_PER_PAYLOAD`
	- rename "execution transaction" to just "transaction" as per discussion with Danny
* rename `compute_time_at_slot` to `compute_timestamp_at_slot`
	- the function returns a Unix timestamp
	- "timestamp" matches `execution_payload.timestamp`
* be explicit about `ExecutionEngine.execution_state` for clarity
* rename `ExecutionPayload.number` to `ExecutionPayload.block_number`
	- more specific ("number" is pretty vague)
	- consistent with `ExecutionPayload.block_hash`
* rename `new_block` to `on_payload`
	- the `on_` prefix is consistent with other event handlers (e.g. see `on_tick`, `on_block`, `on_attestation` [here](https://github.com/ethereum/eth2.0-specs/blob/dev/specs/phase0/fork-choice.md#handlers))
	- the `_payload` suffix is more to the point given the function accepts an `execution_payload`
	- avoids conflict with `on_block` which is already used in the fork choice
* rework the table of contents for consistency
* order `is_execution_enabled` after `is_transition_completed` and `is_transition_block`
	- `is_execution_enabled` refers to `is_transition_completed` and `is_transition_block`
* rename "transition" to "merge"
	- "transition" is a bit vague—we will have other transitions at future hard forks
	- there is no need for two words to refer to the same concept
* add a bunch of inline comments, e.g. in `process_execution_payload`
* make the `process_execution_payload` signature consistent with the other `process_` functions in `process_block` which take as arguments `state` and `block.body`
* remove `TRANSITION_TOTAL_DIFFICULTY`
	- to be put in `merge/fork-choice.md` where it is used 
* various misc cleanups

**Substantive changes**

* reorder `ExecutionPayload` fields
	- for consistency with yellow paper and Eth1
	- same for `ExecutionPayloadHeader`
	- added comments separating out the execution block header fields from the extra fields (cosmetic)
2021-06-18 11:09:30 +01:00
Diederik Loerakker 903b363c2d
Merge pull request #2484 from ericsson49/ericsson49/fix_reset_pending_shard_work
Fix typing problem in `reset_pending_shard_work`
2021-06-17 19:05:05 +02:00