Commit Graph

606 Commits

Author SHA1 Message Date
dapplion 38f269ca12 Update spec with @mkalinin suggestions 2024-03-05 20:58:05 +08:00
dapplion accee2b8be Merge remote-tracking branch 'upstream/dev' into attestation-index 2024-03-05 17:19:49 +08:00
Mikhail Kalinin 3e2650811e
Introduce UINT64_MAX_SQRT 2024-02-16 13:39:46 +06:00
Hsiao-Wei Wang e3d91d8e2a
Rename `MAX_UINT_64` -> `UINT64_MAX` 2024-02-15 15:00:56 +08:00
Hsiao-Wei Wang 7076fb2b75
Handle `integer_squareroot` bound case 2024-02-14 17:18:05 +08:00
danny a35d783b1c
Merge pull request #3543 from etan-status/gv-finstore
Use fork choice to determine `finalized_checkpoint` in gossip validation
2024-01-16 09:06:32 -07:00
danny 8983893009
Merge pull request #3552 from etan-status/gv-alignaggregate
Align gossip validation for aggregates with single attestations
2024-01-16 08:59:02 -07:00
Hsiao-Wei Wang be8b30a593
Merge branch 'dev' into fork-choice-changes-for-confirmaton-rule 2024-01-09 02:06:12 +08:00
dapplion e8e00f332a move attestation index outside signed message 2023-12-05 14:16:07 +02:00
danny d343b6f1d9
Apply suggestions from code review 2023-12-04 07:47:12 -07:00
Enrico Del Fante ba09761ec3
remove gossip failure rules 2023-12-01 18:36:25 +01:00
Enrico Del Fante dad09f64b3
Update specs/phase0/p2p-interface.md
Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
2023-12-01 08:28:29 +01:00
Enrico Del Fante c661e20e60
simplify and add a new rule 2023-11-30 16:11:33 +01:00
Enrico Del Fante 662c6ebc38
remove the last consider 2023-11-30 15:20:35 +01:00
Enrico Del Fante 4c5e5c886f
Update specs/phase0/p2p-interface.md
Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
2023-11-30 15:20:35 +01:00
Enrico Del Fante 6bbdeb88e0
Update specs/phase0/p2p-interface.md
Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
2023-11-30 15:20:34 +01:00
Enrico Del Fante c46c4ec7cb
fix typo 2023-11-30 15:20:34 +01:00
Enrico Del Fante e664d407ca
Specify RPC byRoot blocks-sidecars elegibility 2023-11-30 15:20:34 +01:00
Etan Kissling 321870cbe9
Align gossip validation for aggregates with single attestations
A couple gossip validation rules are only specced out for single
un-aggregated attestations, but are also checked by implementations
for aggregates. This adds a copy of the missing gossip validation rules
to the aggregated attestation docs.
2023-11-19 23:12:11 -08:00
Etan Kissling e30e8af58f
Use fork choice to determine `finalized_checkpoint` in gossip validation
Update gossip validation rules to use the highest `finalized_checkpoint`
across _all_ branches (`store.finalized_checkpoint`), instead of the one
on the currently selected branch (`state.finalized_checkpoint`) when
deciding whether to ignore a block / blob because they are already
finalized.
2023-11-06 12:20:11 +01:00
Hsiao-Wei Wang d8440f8bb4
Merge branch 'dev' into pr3034 2023-10-26 23:51:35 +08:00
Michael Sproul 3f1bc20512
Clarifications for proposer boost reorgs 2023-10-26 17:44:59 +11:00
Hsiao-Wei Wang 0f61819e5c
Update other specs accordingly and re-order "Proposer head and reorg helpers" section 2023-10-20 14:41:51 +08:00
Hsiao-Wei Wang 651db2f858
Refactoring 2023-10-19 19:18:29 +08:00
Max Inden 909388ba8d
fix(sepcs/p2p): link to libp2p Yamux specification
Previously the specification would link to the Hashicorp Yamux specification.

https://github.com/hashicorp/yamux/blob/master/spec.md

Since adoption by libp2p, there have been multiple refinements to the original specification. The improved specification can be found in the libp2p specification repository.

https://github.com/libp2p/specs/blob/master/yamux/README.md
2023-09-14 17:08:44 +02:00
Michael Sproul 45a3615816
Allow honest validators to reorg late blocks 2023-09-12 15:27:10 +10:00
Hsiao-Wei Wang c5c7233e49
Merge pull request #3352 from michaelsproul/boost-first-block
Apply proposer boost to first block in case of equivocation
2023-09-12 10:56:58 +08:00
zhiqiangxu 6f57e2bd26 "can slashable" => "can be slashable" 2023-08-09 11:13:39 +08:00
Hsiao-Wei Wang 63c39dbaff
Merge branch 'dev' into pr3352 2023-08-04 14:45:47 +08:00
Lion - dapplion cc4c810b8f
Whisk: complete TODO items in fork logic (#3427)
* Complete TODO items in fork logic

* Simpler underflow protection

* Add saturating_sub
2023-06-19 17:08:51 +03:00
Roberto Saltini 5e3c0107ef
Review change
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2023-06-18 19:07:35 +10:00
Roberto Saltini 911968413f
Merge branch 'ethereum:dev' into fork-choice-changes-for-confirmaton-rule 2023-06-17 15:14:06 +10:00
Hsiao-Wei Wang 781cd83f09
fix typo 2023-06-16 17:21:34 +08:00
Hsiao-Wei Wang 66eca39533
Merge branch 'dev' into pr3311 2023-06-16 16:24:55 +08:00
Roberto Saltini 7c023cc3cf Fork choice changes to enable confirmation rule execution via beacon APIs 2023-06-15 11:07:30 +10:00
Paul Harris 5576d0e685
Moved configuration into network preset instead of constants. (#3394)
* Moved configuration into network preset instead of constants.

Now that `MAX_CHUNK_SIZE` and `GOSSIP_MAX_SIZE` are in configuration, we no longer need separate constants to represent them in the spec when they change in Bellatrix.

I've changed the usage, and put the values into the presets, but I'm not sure if I've updated the descriptions in the best way...

This is following on from the work in #3375 where a number of constants got moved into configuration, so we no longer need these constants to be separately represented, they can simply be updated in presets.

* Update presets/minimal/bellatrix.yaml

Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>

* Update presets/mainnet/bellatrix.yaml

Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>

* Moved preset items into the correct section and updated TOC.

It looked like the items listed in configuration about the max size and chunk size were no longer needed since we're updating preset values now and the preset changes seem to only be listed in the changes at the top.

* review feedback

* hopefully correct this time!  Moved the 2 fields from configs into presets completely as suggested.

* WIP - changing back to being in config and updating the phase 0 value... I think this should be close but want to see what's outstanding.

* fix intellij's formatting of table.

* more fixes

---------

Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
2023-06-09 23:12:38 +08:00
djrtwo 68ce45b305 move epoch subscription length to config 2023-05-23 13:56:09 -06:00
Hsiao-Wei Wang f87e1436bf
Add networking configs to config files 2023-05-19 22:39:18 +08:00
Michael Sproul 69d8c96de4
Apply proposer boost to first block in case of equivocation 2023-05-11 13:16:52 +10:00
Danny Ryan 363209d650
Merge pull request #3312 from AgeManning/attnets-revamp
Attnet revamp: Subnet backbone structure based on beacon nodes
2023-05-10 08:22:02 -06:00
dapplion 680b026d59 Add add_validator_to_registry fn 2023-05-09 19:18:42 +09:00
Hsiao-Wei Wang 5cb2733ed5
Add custom types `NodeID` and `SubnetID` and constant `NODE_ID_BITS` 2023-05-04 18:50:13 +08:00
Hsiao-Wei Wang 79b8a9abec
Apply suggestions from code review 2023-05-04 18:09:01 +08:00
Hsiao-Wei Wang a044c0c805
Merge branch 'dev' into pr3308 2023-05-01 16:31:45 +08:00
Hsiao-Wei Wang 745d529598
Add `compute_subscribed_subnets` unittests and fix typing errors 2023-04-25 12:57:49 +08:00
Ben Edgington b7f3d37a52 Move is_previous_epoch_justified 2023-04-21 09:16:51 +01:00
Hsiao-Wei Wang 03a3e4082a
Fix p2p-interface.md ToC 2023-04-19 19:10:46 +08:00
Roberto Saltini ffb84598cf Fixed doc in get_checkpoint_block 2023-04-18 16:03:10 +10:00
Roberto Saltini c985605973 Fix copy and past error 2023-04-18 13:49:08 +10:00
Roberto Saltini 36fcb81b88 Break long statement into two statements 2023-04-18 13:26:16 +10:00