Commit Graph

5341 Commits

Author SHA1 Message Date
Jacek Sieka 6f7652d330
process_attestation: Validate epoch before using it
`data.target.epoch` is used to count the active validator set.

Because `get_committee_count_per_slot` is extremely inefficient the way
the spec is written, clients cache it, or the underlying active
validator set.

Performing the checks in the given order leads to a (very unlikely)
security issue where the a cold and above all, distant value may get
used which may be costly - reordering the checks brings the value into a
more reasonable range before using it.
2020-07-24 07:26:37 +02:00
protolambda 951c552ecc
remove second hash cache, type as Bytes32 2020-07-24 02:11:48 +02:00
terence tsao 1d2a47566c
Update sharding FAQs link 2020-07-23 16:35:21 -07:00
protolambda 230e5ce345
remove outdated hash cache, use less memory 2020-07-24 01:19:50 +02:00
protolambda e9d887be4d
Enable BLS in finality tests, use Milagro 2020-07-24 01:19:14 +02:00
Hsiao-Wei Wang 64aed78d6a
Only one test format for finality tests. No extra `finality.md` here 2020-07-24 05:25:17 +08:00
Danny Ryan 1b407368cf
Merge pull request #1988 from ethereum/eth1-deposit-id
add deposit chain id and network id to config
2020-07-23 15:16:32 -06:00
Danny Ryan 607041225f
split config vs constants in deposit-contract spec 2020-07-23 15:05:25 -06:00
Hsiao-Wei Wang b4c91efdbc
Add __init__.py 2020-07-24 04:25:53 +08:00
Hsiao-Wei Wang de15960185
Add finality tests to test vectors 2020-07-24 04:23:26 +08:00
Hsiao-Wei Wang bdde2e5889
Reorg test dir 2020-07-24 03:54:45 +08:00
Danny Ryan 4c3f866a0f
add links for network and chain id 2020-07-23 12:25:44 -06:00
Hsiao-Wei Wang e7f070d525
Use `hash_tree_root` to generate `ShardBlockHeader.body_root`
Include the mix-in length to the proof.
2020-07-24 02:09:25 +08:00
Danny Ryan 9193a23f8e
add chain id and netowrk id to config 2020-07-23 12:05:22 -06:00
Hsiao-Wei Wang 819bb6d21d
Use Milagro BLS in CI 2020-07-24 02:00:52 +08:00
Diederik Loerakker 247da83e62
Merge pull request #1985 from ethereum/non-viable-gossip
add that current block is in the same chain as finalized ancestor
2020-07-23 19:18:53 +02:00
Danny Ryan 3cf6832198
Apply suggestions from code review
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
2020-07-23 10:46:31 -06:00
Diederik Loerakker b6eeec52e2
Merge pull request #1986 from ethereum/bump-0.12.2
bump VERSION.txt to 0.12.2
2020-07-23 18:39:25 +02:00
Danny Ryan b3e49ff0d3
add finalized ancestor checks to attestation gossip 2020-07-23 10:39:04 -06:00
Danny Ryan 0692ac0172
bump VERSION.txt to 0.12.2 2020-07-23 10:28:02 -06:00
Danny Ryan fb13f67cca
add that current block is in the same chain as finalized ancestor 2020-07-23 10:13:42 -06:00
Diederik Loerakker 24fd99e034
Merge pull request #1982 from ethereum/remove-ssz-req-resp
remove 'ssz' format from req/resp
2020-07-23 18:09:07 +02:00
Danny Ryan 289564aec0
pr feedback 2020-07-23 10:03:43 -06:00
Danny Ryan a64b8eba6e
remove 'ssz' format from req/resp. now only ssz_snappy 2020-07-23 09:37:16 -06:00
Hsiao-Wei Wang cd8bb3d85a
Update v-guide: Shard head root 2020-07-22 23:39:18 +08:00
Hsiao-Wei Wang 33e56b5742
Apply Terence's suggestion: refactor on_shard_block interface 2020-07-22 22:48:52 +08:00
Danny Ryan 435f70208b
Merge pull request #1958 from ethereum/gossip-params
Match gossip v1.1 D_low, extend gossip_history param, add FAQ section
2020-07-21 18:18:25 -06:00
Danny Ryan 50cd0b2b31
Update specs/phase0/p2p-interface.md
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
2020-07-21 17:49:39 -06:00
Danny Ryan edcce7bfef
format 2020-07-21 17:00:11 -06:00
Danny Ryan ec7be11c06
mod gossip params and rename to reflect spec names 2020-07-21 16:45:25 -06:00
Danny Ryan 4c1a28e547
Merge pull request #1976 from ethereum/fix-bls-test-name
Rename `aggregate_na_pubkeys` to `aggregate_na_signatures` and add comments
2020-07-21 10:18:23 -06:00
Hsiao-Wei Wang f7c7c63855
Merge pull request #1935 from ethereum/hwwhww/new_int_to_bytes_dev
generic `uint_to_bytes`
2020-07-21 23:15:17 +08:00
Hsiao-Wei Wang 302607eac5
Rename `aggregate_na_pubkeys` to `aggregate_na_signatures` and add comments 2020-07-21 21:10:27 +08:00
Hsiao-Wei Wang c981fc4411
Apply mkalinin's suggestion 2020-07-20 16:47:21 +08:00
Hsiao-Wei Wang 74aa027e38
Apply suggestions from @mkalinin
Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
2020-07-20 16:37:43 +08:00
Hsiao-Wei Wang 4dcf5e2498
Add test case of different shards 2020-07-17 14:24:11 +08:00
Hsiao-Wei Wang 0b81c967fa
Add notes 2020-07-17 00:46:25 +08:00
Hsiao-Wei Wang 8fb96f1860
Enable more phase 0 tests to be compatible with phase 1 2020-07-17 00:10:04 +08:00
Hsiao-Wei Wang cf42fd4828
Rename `PHASE_1_GENESIS_SLOT` to `PHASE_1_FORK_SLOT` and set it to `Slot(0)` for testing. 2020-07-16 23:58:47 +08:00
Hsiao-Wei Wang 8e82ca5d1a
Merge branch 'dev' into hwwhww/new_int_to_bytes_dev 2020-07-16 01:36:19 +08:00
Danny Ryan 6a7a47dd5f
Merge pull request #1746 from ethereum/hwwhww/strict-uint64
Apply strict uint64 casting
2020-07-15 11:09:55 -06:00
Hsiao-Wei Wang 6e3a7ad8f2
Merge branch 'dev' into hwwhww/strict-uint64-2 2020-07-15 23:02:51 +08:00
Hsiao-Wei Wang f6b1fe6172
Refactor tests and avoiding passing `shart_store` to helper functions 2020-07-15 19:07:39 +08:00
Hsiao-Wei Wang 2da331a345
Rename `test_on_shard_head.py` to `test_on_shard_block.py` 2020-07-15 19:01:20 +08:00
Hsiao-Wei Wang 43ef9aa294
Make ShardLatestMessage per shard per validator
1. Add `ShardLatestMessage` dataclass
2. To make it compatible with phase 0 tests and APIs, add `Store.shard_stores: Dict[Shard, ShardStore]`
3. Update `get_forkchoice_store` and `update_latest_messages`
2020-07-14 17:44:01 +08:00
Hsiao-Wei Wang bb3c360734
Handle the dependencies order of dataclass objects 2020-07-14 17:41:33 +08:00
Hsiao-Wei Wang 60f4bd2288
The AttesterSlashing tests for phase1 can be enabled now after #1889 2020-07-09 21:59:01 +08:00
Danny Ryan 7b43a3d772
Merge pull request #1956 from ethereum/queue-att
add queueing possibility to p2p messages in gossip
2020-07-08 10:53:19 -06:00
Danny Ryan 22b72180f7
Merge pull request #1962 from mkalinin/patch-1
Fix epoch_boundary_block_root computation
2020-07-08 10:52:57 -06:00
Diederik Loerakker 0b04dfd815
Merge pull request #1961 from ericsson49/fix_get_custody_period_for_validator_return_type
change `get_custody_period_for_validator()` return type to `uint64`
2020-07-08 18:42:37 +02:00