danny
a2d021da48
re-order conditions
2023-10-18 10:38:43 -06:00
Enrico Del Fante
27ad39b73a
Add new gossip rule to `REJECT` sidecars with index >= MAX_BLOBS_PER_BLOCK
2023-10-18 11:54:47 +02:00
djrtwo
ecefe2d147
pr review
2023-06-20 15:50:20 -06:00
djrtwo
ec4bdae2d4
build EIP 7045 into Deneb fork
2023-06-14 15:03:28 -06:00
Hsiao-Wei Wang
210c4827bc
Move `BLOB_SIDECAR_SUBNET_COUNT` to networking config
2023-06-12 23:57:21 +08:00
Danny Ryan
05790d380b
Merge pull request #3406 from ethereum/deneb-4844-clean
...
specially mark EIP4844 changes
2023-06-09 08:46:48 -06:00
Hsiao-Wei Wang
76214c7cae
Merge pull request #3162 from dapplion/eip4844-dedup-range
...
De-duplicate range references in BlobSidecarsByRange
2023-06-09 00:54:27 +08:00
Hsiao-Wei Wang
b7e21d6caf
PR feedback and make the marks italic
2023-06-08 15:05:46 +08:00
Hsiao-Wei Wang
a547d47264
specially mark the EIP4844 changes
2023-06-07 17:48:26 +08:00
Hsiao-Wei Wang
468b5be7b8
Merge pull request #3368 from ethereum/ralexstokes-patch-3
...
Remove extraneous length check from deneb forkchoice
2023-06-02 01:54:47 +08:00
Hsiao-Wei Wang
c9b84ecc1a
Use `verify_blob_kzg_proof_batch` directly in `is_data_available` and remove `validate_blob` wrapper
2023-06-01 23:40:46 +08:00
Hsiao-Wei Wang
f0a4281afd
Add tests. Add validation in the p2p beacon block gossiping
2023-05-24 16:11:32 +08:00
gajinder
8ccc2570d1
apply feedback
2023-05-20 19:35:22 +05:30
gajinder
a75292beeb
restore the 4844 max limit to 4
2023-05-20 19:08:21 +05:30
gajinder
1aad9b5fa0
adding a fixed theoretical limit for commitments in a block
2023-05-20 19:06:51 +05:30
Alex Stokes
7097dcf27a
Clarify blob subnets
2023-05-18 15:27:47 -06:00
Suphanat Chunhapanya
2f218f8336
Specify the number of sidecar subnets
...
Previously the number of subnets is equal to MAX_BLOBS_PER_BLOCK which
specifies the number of blobs per block. This commit now makes the
number of subnets equal to BLOB_SIDECAR_SUBNET_COUNT instead.
The advantage of doing this is that we can change MAX_BLOBS_PER_BLOCK
without worrying about the p2p network structure and the number of subnets.
2023-05-18 21:33:45 +07:00
terencechain
db2e613aac
Nitpick: blob -> blob sidecar
2023-05-17 11:08:33 -07:00
Hsiao-Wei Wang
03a3e4082a
Fix p2p-interface.md ToC
2023-04-19 19:10:46 +08:00
Suphanat Chunhapanya
912c9b37a1
Fix typos
2023-04-04 13:33:42 +07:00
Danny Ryan
5977f36fef
minor nits from code review
2023-03-15 10:54:49 -06:00
dankrad
3141806100
Merge branch 'dev' into deneb-crypto-coverage
2023-03-14 22:45:06 +00:00
Dankrad Feist
ff7a6c5d0e
Add description when to use verify_sidecar_signature
2023-03-14 22:14:31 +00:00
Danny Ryan
f7837e84e5
Merge pull request #3275 from tbenr/patch-1
...
Add `blob_sidecar` gossip rule for parent slot
2023-03-14 12:15:38 -06:00
Dankrad Feist
cc284b2b60
Toc
2023-03-12 23:11:40 +00:00
Dankrad Feist
96ad61bcec
Add tests for blob sidecar signature
2023-03-12 23:05:01 +00:00
dapplion
21cf61ea8f
De-duplicate range references in BlobSidecarsByRange
2023-03-10 11:10:33 +08:00
Danny Ryan
7538e9a4f3
Merge branch 'dev' into 4844-remove-empty-container
2023-03-01 08:58:42 -07:00
terencechain
a236770b07
EIP4844: Use `MAX_REQUEST_BLOB_SIDECARS`
2023-02-28 15:17:40 -08:00
Enrico Del Fante
0879c46a34
Add `blob_sidecar` gossip rule for parent slot
...
Similarly to the check we do on Block gossip, we should check slot consistency with the parent block, so we can independently reject wrong block and blobb_sidecar when the rule is violated.
2023-02-27 20:12:31 +01:00
djrtwo
5474b34466
Merge branch 'henridf-max-request-blobs' into dev
2023-02-27 09:19:23 -07:00
Danny Ryan
a26556147c
Merge pull request #3268 from henridf/block-blobc
...
Minor typo/pasta fixes in blob_sidecar_{index} validation
2023-02-27 09:12:40 -07:00
Henri DF
970da9efd2
Clean up max request blobs constants
...
The spec currently defines `MAX_REQUEST_BLOB_SIDECARS` as the "maximum
number of blob sidecars in a single request", but then later in the
RPC description defines the max is `MAX_REQUEST_BLOB_SIDECARS *
MAX_BLOBS_PER_BLOCK`.
Clean this up by defining `MAX_REQUEST_BLOB_SIDECARS` to be the actual max.
2023-02-22 17:20:44 +01:00
Henri DF
d8111d7d3b
Refer to "sidecar" consistently
2023-02-22 16:51:56 +01:00
Henri DF
837233a1be
Fix reference to block->sidecar
...
(This was probably a cut-n-paste from block validation)
2023-02-22 16:50:56 +01:00
kasey
9391f3ccfc
fix MAX_REQUEST_BLOBS_SIDECARS typo
2023-02-21 21:48:21 -06:00
Age Manning
95401cf6e4
Clarify context bytes in the RPC methods in 4844
2023-02-21 01:10:40 +08:00
Jacek Sieka
ac0ec660d3
add parent validation requirement
...
sama as block
2023-02-20 16:35:52 +01:00
Jacek Sieka
4e2a9920f1
Update specs/deneb/p2p-interface.md
...
Co-authored-by: g11tech <develop@g11tech.io>
2023-02-20 12:15:53 +01:00
Jacek Sieka
54d2559eb5
remove producer reorg on multi-blob
...
* also, use root/index for uniqueness
2023-02-18 17:45:16 +01:00
Danny Ryan
9dd7d2ba2f
fix Blob pluralization in a few places
2023-02-17 11:59:56 -07:00
Jacek Sieka
5fe857b209
fixes
2023-02-16 09:20:40 +01:00
Jacek Sieka
24a19bb886
fixes
...
* fight the test suite
* clarify who orphans the block
* must supply all blobs of a block in range request
2023-02-16 09:12:34 +01:00
Jacek Sieka
639ff9b2b0
Update specs/deneb/p2p-interface.md
...
Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>
2023-02-16 08:30:40 +01:00
Jacek Sieka
c39fda19c6
Apply suggestions from code review
...
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>
2023-02-16 08:18:52 +01:00
Jacek Sieka
da34af97d4
simplify blob verification, range request
...
* validate blobs using raw types
* remove `BlobSidecars` and send flattened list of `BlobSidecar`
instances instead
2023-02-15 08:51:57 +01:00
Jacek Sieka
3a37c3c497
Allow clients to orphan blocks from spammy proposers
...
Proposers that spam the blob topic with multiple blob versions, some of
which are invalid, MAY see their block orphaned.
2023-02-15 08:00:39 +01:00
Jacek Sieka
58207c1c05
Upper limit on indices
2023-02-14 14:18:29 +01:00
Jacek Sieka
c8719f8524
Apply suggestions from code review
...
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
2023-02-14 13:32:18 +01:00
Jacek Sieka
8bc19d99ae
fixes
...
* expand sidecar gossip conditions
* editing
* add spec text for `BlobSidecar` signatures
2023-02-10 11:16:51 +01:00
Jacek Sieka
20278d4841
Merge remote-tracking branch 'origin/dev' into back-to-the-decoupled-future
...
Deneb merge
2023-02-10 10:44:31 +01:00
Age Manning
368e70d9be
Remove sending empty blobs sidecar responses
2023-02-10 10:45:07 +08:00
Paul Harris
078e1cc871
fix references to eip4844
2023-02-08 09:22:28 +10:00
Paul Harris
0bf006cc06
Merge remote-tracking branch 'upstream/dev' into 3207
2023-02-02 16:34:34 +10:00
Paul Harris
317facbd64
Replaced EIP4844 references with Deneb
...
Fixes #3207
2023-01-23 15:08:34 +01:00