56 Commits

Author SHA1 Message Date
kevaundray
a3a6c916b2
Remove proof parameter from recover_cells_and_kzg_proofs (#3819) 2024-06-27 14:17:14 -05:00
Hsiao-Wei Wang
0a49572799
Merge pull request #3782 from cskiraly/peer-das-sampling
PeerDAS sampling clarifications
2024-06-27 19:27:57 +08:00
Hsiao-Wei Wang
258c2c9020
Merge pull request #3794 from cskiraly/peer-das-reconstruction
EIP-7594: clarifying reconstruction and cross-seeding
2024-06-27 18:58:23 +08:00
Csaba Kiraly
1ad381dccb
adding get_extended_sample_count docsstring
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-06-27 10:28:21 +02:00
Csaba Kiraly
78b583d8b0
clarify use of get_extended_sample_count
Here we assume uniform random selection without replacement.
If other methods are used, the target false positive threshold
is the main rule to follow.

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-06-27 09:48:32 +02:00
Csaba Kiraly
17dfb9ae57
fix get_extended_sample_count proc signature
Co-authored-by: Pop Chunhapanya <haxx.pop@gmail.com>
2024-06-27 09:30:39 +02:00
Csaba Kiraly
4539265c55
moving part of text in custody section
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-06-25 10:36:53 +02:00
Hsiao-Wei Wang
1f87bbeac0
Merge branch 'dev' into pr3782 2024-06-25 16:21:00 +08:00
Hsiao-Wei Wang
beedf852cb
Revert division change and add comments 2024-06-25 16:15:16 +08:00
Hsiao-Wei Wang
fb020456cb
Add get_extended_sample_count unit tests 2024-06-19 02:18:29 +08:00
Justin Traglia
d137553f96 Rename CellID to CellIndex 2024-06-11 07:41:52 -05:00
Justin Traglia
5ace424cd8
recover_cells_and_kzg_proofs & matrix refactor (#3788)
* Recover cells and proofs & matrix clean up

* Fix table of contents

* Update reference tests generator

* Update test format

* Remove unused imports

* Fix some minor nits

* Rename MatrixEntry's proof to kzg_proof

* Move RowIndex & ColumnIndex to das-core
2024-06-11 14:52:24 +03:00
Csaba Kiraly
6711acf3e2
clarifying reconstruction and cross-seeding
- when should a node reconstruct
- how to cross-seed for subscribed and unsubscribed topics

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-06-11 02:31:22 +02:00
Csaba Kiraly
2ab4f1e12e
get_extended_sample_count: use SAMPLES_PER_SLOT constant
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-06-10 11:16:06 +02:00
Csaba Kiraly
4c57399887
self-contained get_extended_sample_count
Importing scipy is not preferred. This is a self-contained
version. Eventually an import of math and use of math.comb
makes it simpler.
Solving other formatting issues as well.

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-06-04 09:41:29 +02:00
Csaba Kiraly
436e58e3f8
add get_extended_sample_count helper function
add LossyDAS sample count generation helper function

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-29 14:27:31 +02:00
Csaba Kiraly
5f3beca871
remove LossyDAS naming from spec
While the technique was introduced as LossyDAS, we don't need the name
in the specification itself.

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-29 11:08:52 +02:00
Csaba Kiraly
a04cd87c38
fix the (source-view) formatting of the table
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-29 11:04:10 +02:00
Csaba Kiraly
4e1d566c43
improve candidate peer text
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-29 11:01:50 +02:00
Hsiao-Wei Wang
7b4d23c0ba
fix toc 2024-05-28 22:57:52 +08:00
Csaba Kiraly
8d332788b9
clarify the use of LossyDAS
Clarify that what matters is the false positive threshold, allowing
different sampling strategies as protocol compliant behavior.

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-28 13:54:27 +02:00
Csaba Kiraly
b848ca6dc7
improved sampling description
- describe sample selection
- describe sample queries

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
2024-05-28 13:54:27 +02:00
Hsiao-Wei Wang
fdad206f3c
Apply @dankrad's suggestion 2024-05-07 20:26:56 +08:00
Hsiao-Wei Wang
950136c50d
Apply suggestions from code review
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
2024-05-07 18:30:28 +08:00
Hsiao-Wei Wang
9c1acbb5e5
Fix get_custody_columns 2024-05-06 17:25:47 +08:00
kevaundray
e7b49dc670
chore: Add type casts reducing the diff for #3697 (#3734) 2024-04-29 08:14:55 -05:00
Justin Traglia
b4188829b3 Rename compute_cells_and_proofs to compute_cells_and_kzg_proofs 2024-04-25 21:57:22 -05:00
Hsiao-Wei Wang
e1d71216bb
Merge pull request #3715 from ethereum/das-test-vectors
Make `get_custody_columns` return sorted values and add `get_custody_columns` tests
2024-04-25 03:01:51 +08:00
Hsiao-Wei Wang
24899b7fba
Apply suggestions from @jtraglia 2024-04-24 19:04:40 +08:00
Hsiao-Wei Wang
57c14e5400
Add get_custody_columns tests 2024-04-23 20:21:33 +08:00
George Kadianakis
4fceca2b75
Merge pull request #3710 from kevaundray/kw/rm-field-elements-from-das-core
chore: use CELLS_PER_EXT_BLOB to compute the number of columns
2024-04-22 17:59:31 +03:00
Justin Traglia
bcd0a09e68
Integrate new Coset/CosetEvals types (#3701)
* Add CellBytes type

* Use ByteVector, not Vector

* Fix tests

* Replace b"" with []

* Apply suggestions for bytes_to_cell

* Add/integrate new CosetEvals type

* Remove accidental new line

* Fix recover_all_cells

* Fix recover_matrix

* fix CosetEvals abstraction leak

* Introduce internal Coset type for `coset_for_cell()`

* Use CosetEvals in compute_kzg_proof_multi_impl()

* update test

* satisfy linter

* Fix two nits I noticed

---------

Co-authored-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Co-authored-by: George Kadianakis <desnacked@riseup.net>
2024-04-22 17:03:57 +03:00
Kevaundray Wedderburn
79d255b15a use CELLS_PER_EXT_BLOB in das-core 2024-04-22 14:08:44 +01:00
Kevaundray Wedderburn
3f2d498cee rename 2024-04-22 13:02:42 +01:00
Hsiao-Wei Wang
e46c4c39fb workaround: add a new config MAX_EXTENDED_MATRIX_SIZE to avoid class Container(List[c, a*b]) 2024-04-22 10:31:58 +01:00
Kevaundray Wedderburn
3ddd00e741 use recover_all_cells 2024-04-19 12:50:32 +01:00
Kevaundray Wedderburn
7e85c962f2 change CELLS_PER_BLOB in das-core.md 2024-04-18 17:40:51 +01:00
Justin Traglia
3dcf9ebe54 Use FIELD_ELEMENTS_PER_EXT_BLOB in NUMBER_OF_COLUMNS 2024-04-09 08:44:30 -05:00
Hsiao-Wei Wang
1acb1ff24f
minor arrange 2024-02-20 22:23:23 +08:00
Hsiao-Wei Wang
bb33f9082c
Change List length of DataColumn from MAX_BLOBS_PER_BLOCK to MAX_BLOB_COMMITMENTS_PER_BLOCK 2024-02-20 22:06:09 +08:00
Hsiao-Wei Wang
8150f76e1c
Apply @cskiraly's suggestion 2024-02-20 22:02:10 +08:00
Hsiao-Wei Wang
e7c0d5ff3c
Update specs/_features/eip7594/das-core.md
Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>
2024-02-02 16:27:56 +08:00
Hsiao-Wei Wang
91dbbb365c
Implement compute_extended_matrix 2024-02-02 02:26:28 +08:00
Hsiao-Wei Wang
c47d5f3578
Add recover_matrix and remove unused FlatExtendedMatrix type 2024-02-02 01:45:02 +08:00
Hsiao-Wei Wang
428c166283
Apply suggestions from code review
Co-authored-by: g11tech <develop@g11tech.io>
Co-authored-by: Pop Chunhapanya <haxx.pop@gmail.com>
2024-02-01 21:17:42 +08:00
Hsiao-Wei Wang
547460cd84
Apply PR feedback 2024-01-31 22:30:35 +08:00
Hsiao-Wei Wang
170dae5609
Apply suggestions from code review
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
Co-authored-by: Pop Chunhapanya <haxx.pop@gmail.com>
2024-01-29 17:34:47 +08:00
Hsiao-Wei Wang
b2a4657da5
Merge branch 'peer-das-req-subnet-count' into peer-das 2024-01-29 17:23:33 +08:00
Hsiao-Wei Wang
edeef070d8
toc 2024-01-28 22:47:49 +08:00
Hsiao-Wei Wang
4477cc6952
Fix column computation 2024-01-20 14:43:35 +08:00