88be6cdf60
Apply Danny's suggestions from code review
...
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
2021-06-22 20:55:52 +08:00
83598af188
Add `test_new_justified_is_later_than_store_justified` and fix test
...
cases
- Fix `on_tick` calls
- Refactor test cases
2021-06-22 20:04:47 +08:00
e5c01061af
Add couple of cosmetic fixes
2021-06-22 14:26:38 +06:00
ac19aa3e2d
Accept polishing suggested by Justin
2021-06-22 14:23:26 +06:00
8107d0d582
Merge pull request #2485 from nisdas/patch-1
...
Make The Nature of Validator Sync Committee Assignments Clearer
2021-06-21 16:51:11 -05:00
fc1012b632
typo
2021-06-21 12:49:41 -06:00
a61aa7968d
clean up
2021-06-21 12:48:44 -06:00
199d6aee58
Merge remote-tracking branch 'origin/dev' into randao_in_execution_payload
2021-06-19 00:28:38 +06:00
7a9ae57335
Minor formatting. `True` -> `true`, `False` -> `false`
2021-06-19 02:13:02 +08:00
2445fe5a76
Add new test cases
...
- `test_new_finalized_slot_is_not_justified_checkpoint_ancestor`
- `test_new_finalized_slot_is_justified_checkpoint_ancestor`
2021-06-19 02:03:37 +08:00
fb2465db45
Rework `on_block` unit tests
2021-06-19 02:03:33 +08:00
878b15df6a
polish merge/beacon-chain.md ( #2472 )
...
Polish `merge/beacon-chain.md` with mostly non-substantive changes.
**Non-substantive changes**
* rename `MAX_EXECUTION_TRANSACTIONS` to `MAX_TRANSACTIONS_PER_PAYLOAD`
- rename "execution transaction" to just "transaction" as per discussion with Danny
* rename `compute_time_at_slot` to `compute_timestamp_at_slot`
- the function returns a Unix timestamp
- "timestamp" matches `execution_payload.timestamp`
* be explicit about `ExecutionEngine.execution_state` for clarity
* rename `ExecutionPayload.number` to `ExecutionPayload.block_number`
- more specific ("number" is pretty vague)
- consistent with `ExecutionPayload.block_hash`
* rename `new_block` to `on_payload`
- the `on_` prefix is consistent with other event handlers (e.g. see `on_tick`, `on_block`, `on_attestation` [here](https://github.com/ethereum/eth2.0-specs/blob/dev/specs/phase0/fork-choice.md#handlers ))
- the `_payload` suffix is more to the point given the function accepts an `execution_payload`
- avoids conflict with `on_block` which is already used in the fork choice
* rework the table of contents for consistency
* order `is_execution_enabled` after `is_transition_completed` and `is_transition_block`
- `is_execution_enabled` refers to `is_transition_completed` and `is_transition_block`
* rename "transition" to "merge"
- "transition" is a bit vague—we will have other transitions at future hard forks
- there is no need for two words to refer to the same concept
* add a bunch of inline comments, e.g. in `process_execution_payload`
* make the `process_execution_payload` signature consistent with the other `process_` functions in `process_block` which take as arguments `state` and `block.body`
* remove `TRANSITION_TOTAL_DIFFICULTY`
- to be put in `merge/fork-choice.md` where it is used
* various misc cleanups
**Substantive changes**
* reorder `ExecutionPayload` fields
- for consistency with yellow paper and Eth1
- same for `ExecutionPayloadHeader`
- added comments separating out the execution block header fields from the extra fields (cosmetic)
2021-06-18 11:09:30 +01:00
903b363c2d
Merge pull request #2484 from ericsson49/ericsson49/fix_reset_pending_shard_work
...
Fix typing problem in `reset_pending_shard_work`
2021-06-17 19:05:05 +02:00
dadcb2a06a
Merge branch 'dev' into ericsson49/fix_reset_pending_shard_work
2021-06-17 18:54:29 +02:00
c68ce56407
Merge pull request #2483 from ericsson49/ericsson49/fix_append_in_process_shard_header
...
Fix typing problem: append is invoked on a ShardWork instance
2021-06-17 18:50:40 +02:00
691b15a2ed
Merge pull request #2482 from ericsson49/ericsson49/fix_shard_work_status_chage
...
Fix typo: `change()` should be invoked on `ShardWork.status`
2021-06-17 18:49:08 +02:00
6e86d8a696
Rename randao->random, other fixes as per review
2021-06-17 21:20:17 +06:00
67f1c2c2bd
Update validator.md
2021-06-17 23:05:23 +08:00
22b2a73615
convert `int` to `CommitteeIndex` when passing to `get_beacon_committee`
2021-06-16 19:07:24 +03:00
5b4f89875c
use `List[PendingShardHeader,...]` instead of `MutableSequence`, since `remerkleable.List` does not implement the latter
2021-06-16 14:06:17 +03:00
d83ca352d5
Fix typing problem: `append` is invoked on a `ShardWork` instance
2021-06-16 13:33:56 +03:00
27889860f0
fix typo: sometimes `change()` invoked on `ShardWork` itself, should be invoked on its `status` field
2021-06-16 12:03:20 +03:00
42eae81013
WIP. Rework on_block tests
2021-06-15 21:52:25 +08:00
cc20b80103
Fix linter, add more test helpers
2021-06-15 14:55:06 +06:00
a63916a6ec
Merge pull request #2478 from ethereum/attester-proposer-slashing
...
Add a few missing slashing tests
2021-06-14 15:09:02 -06:00
5c1cb153aa
Merge branch 'dev' into attester-proposer-slashing
2021-06-14 15:08:10 -06:00
2e87a6b44e
Apply review comments
2021-06-11 22:50:11 +06:00
7d617bc7c0
Fix timestamp passed to produce_execution_payload
2021-06-11 22:46:24 +06:00
95775e1b90
Add randao to execution payload
2021-06-11 16:05:19 +06:00
973a874105
Merge pull request #2477 from ethereum/fix-proposer-slashing-test
...
fix mismatched proposer test names
2021-06-10 10:04:38 -06:00
a5762cbad8
add attestesr slashing for proposer, and some future slashing tests woo
2021-06-09 16:56:32 -06:00
1ade07d705
fix mismatched proposer test names
2021-06-09 16:31:20 -06:00
a553e3b18e
Merge pull request #2476 from ethereum/fix-msg-id-parenthesis
...
add missing parenthesis
2021-06-08 12:53:56 -07:00
5140b59c57
add missing parenthesis
2021-06-08 21:51:26 +02:00
8f8b5ab648
Merge pull request #2475 from ralexstokes/discriminate-sync-comm-msg
...
Add `message.topic` to gossipsub `message-id` in Altair
2021-06-08 21:47:06 +02:00
a343680fd4
Add implementation note on message id fn
2021-06-08 14:29:08 -05:00
f60f13964c
Harden topic serialization
2021-06-08 14:15:57 -05:00
25a2e3463e
Update specs/altair/p2p-interface.md
...
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
2021-06-08 12:06:02 -07:00
db2339e1c9
Merge pull request #2474 from ralexstokes/clarify-altair-p2p-conditions
...
Clarify p2p validation conditions for Altair sync committees
2021-06-08 12:47:06 -06:00
d64b4e7d24
Add `message.topic` to gossipsub `message-id` in Altair
2021-06-08 13:44:06 -05:00
c7980d3cd0
Clarify p2p validation conditions for Altair sync committees
2021-06-08 13:34:16 -05:00
5d9d786499
Merge pull request #2462 from mkalinin/merge-transition-with-dynamic-ttd
...
Merge transition process with computed transition total difficulty
2021-06-08 09:55:10 -06:00
761c77f9a0
Merge pull request #2470 from ethereum/bump-version
...
bump VERSION.txt to v1.1.0-alpha.7
2021-06-08 08:31:47 -06:00
5228dc814f
Redefine initialize_beacon_state_from_eth1
2021-06-08 18:44:53 +06:00
6350e27366
Add difficulty field to PowBlock
2021-06-08 17:56:07 +06:00
038edb5b34
Rename SECONDS_SINCE_MERGE_FORK -> TARGET_SECONDS_TO_MERGE
2021-06-08 17:16:52 +06:00
3a6a565a8f
Replace fractional division with integer one
...
Co-authored-by: vbuterin <v@buterin.com>
2021-06-08 15:03:59 +06:00
6258dc64f7
bump VERSION.txt to v1.1.0-alpha.7
2021-06-07 17:41:37 -06:00
c821e3fced
Merge pull request #2469 from ethereum/sync-consistency
...
Sync Committee vs Aggregate naming consistencies
2021-06-08 01:30:28 +02:00
64f217d3e1
update sync aggregate processing reference in validator doc
2021-06-08 01:05:50 +02:00
Hsiao-Wei Wang
Mikhail Kalinin
Danny Ryan
Justin
Diederik Loerakker
Nishant Das
ericsson
Alex Stokes