Commit Graph

4396 Commits

Author SHA1 Message Date
Danny Ryan cb72a7d8a3
Merge pull request #1527 from MrChico/codespell
Add Codespell check to ci
2019-12-16 10:32:35 -07:00
Martin Lundfall 798fadc3cb Makefile: Use codespell as intended 2019-12-16 14:18:34 +01:00
Martin Lundfall 21c8c58cb1 edit comment to make line shorter 2019-12-16 13:22:08 +01:00
Martin Lundfall 5234e431ec Add codespell to ci 2019-12-16 13:06:01 +01:00
Martin Lundfall a4f8a77c02 Fix spelling errors found by codespell 2019-12-16 13:02:36 +01:00
Justin 412a06608c
Update 0_beacon-chain.md 2019-12-15 11:32:11 +00:00
Justin 48317d8ac0
Minor cosmetic cleanups
* remove `BLS_WITHDRAWAL_PREFIX` (it is not used in phase 1, not phase 0)
* avoid inline comment (# Validate state root)
* simplify header inequality check in `process_proposer_slashing` (using uniqueness of BLS signatures)
* add `block = signed_block.message` helper variable for readability
* (typo) clarify that the state transition function consumes a signed block (as opposed to a block)
* generally make comments more consistent
* consistent formatting of container instantiation for `DepositMessage`
* avoid using three lines for `rewards[index] += Gwei(max_attester_reward // attestation.inclusion_delay)`
* introduce `effective_balance` helper variable for readability, and to avoid multi-line statement
* consistent ordering of `MIN_EPOCHS_TO_INACTIVITY_PENALTY` in the time parameters table
* (typo) "Dequeued validators for activation up to churn limit" => Dequeue validators
* "Save current block as the new latest block" => "Cache current block" (for consistent with `process_slot`)
* (typo) "Verify the validator has not yet exited" => "Verify exit has not been initiated"
* Use Pythonic `default=` for `max()` call in `initiate_validator_exit`
2019-12-15 11:10:43 +00:00
Diederik Loerakker 88e954a9c7
Merge pull request #1522 from ethereum/master
backport v093 to dev
2019-12-13 18:56:31 +01:00
Danny Ryan e7c5d64ce8
Merge pull request #1507 from ethereum/v09x
Release v0.9.3 to master
2019-12-12 12:38:12 -07:00
Danny Ryan b09c45ffd2
remove last two references to signing root 2019-12-12 12:34:02 -07:00
Danny Ryan 47ecedb81d
update tocs 2019-12-12 09:48:53 -07:00
Danny Ryan 7343baf85a
Merge pull request #1512 from MrChico/toc_ci
Check table of content of markdown files with CI
2019-12-12 09:47:38 -07:00
Danny Ryan 49a8264f5d
Merge branch 'v09x' into toc_ci 2019-12-12 09:47:20 -07:00
Danny Ryan c1dc4a0063
Merge pull request #1518 from ethereum/proposers-1515
Two tests for proposer indices being off because of (in)active validators
2019-12-12 08:55:31 -07:00
protolambda 020af2707a
fix: don't get stuck in same slot doing a transition, and clean up latest-block-header with starting block for pre-state 2019-12-12 16:40:57 +01:00
Danny Ryan 4a31503ec0
Merge pull request #1516 from ethereum/dup-indices-attest
Fixes #1486: disallow duplicate indices in indexed attestation
2019-12-12 08:32:43 -07:00
protolambda 5c26d8e52f
fix normal signed case; only sign for 1 of the duplicate indices 2019-12-12 16:29:30 +01:00
protolambda 020dbb1ecd
fix missing transition 2019-12-12 16:16:52 +01:00
Danny Ryan 4271d3b0a2
Merge pull request #1519 from ethers/patch-1
Fix dead link to use Internet Archive
2019-12-12 08:16:05 -07:00
Danny Ryan 52a6cf7ba3
Merge pull request #1514 from ethereum/queue-fix-on-finality
Fix queue rate and only activate upon finality
2019-12-12 07:44:57 -07:00
Danny Ryan ba8a67ccd8
update registry tests to modified finality condition 2019-12-12 07:31:51 -07:00
Danny Ryan 199933cb26
fix tocs 2019-12-12 06:57:11 -07:00
Danny Ryan 86fb3acd59
minor changes to finality in activation queue 2019-12-12 06:53:56 -07:00
Danny Ryan 19ec01e4e9
add comment about activation queue sort order
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-12 06:43:37 -07:00
ethers 3d48a3e9eb
Fix dead link to use Internet Archive 2019-12-11 18:17:20 -08:00
protolambda 8d5d7387f9
Two tests for proposer indices being off because of active validators status, fixes #1515 2019-12-12 02:36:20 +01:00
Danny Ryan e2d93dae4b
Merge pull request #1517 from ethereum/mypy_update
update mypy to compile pyspec well with py 3.8.0, and minor mypy fix
2019-12-11 17:55:07 -07:00
protolambda 7691e312c7
update mypy to compile pyspec well with py 3.8.0, and minor mypy fix 2019-12-12 01:48:03 +01:00
protolambda 2405060a7e
Fixes #1486: disallow duplicate indices in indexed attestation 2019-12-12 01:45:59 +01:00
Danny Ryan 45620e345d
add test for activation_queue, activation, and ejection all in one 2019-12-11 17:31:05 -07:00
Danny Ryan b6d7cd93e9
Add ejection/exit queue test 2019-12-11 17:21:43 -07:00
Danny Ryan e8d079b366
fix and add tests for activation queue 2019-12-11 17:06:14 -07:00
Danny Ryan e117b58ae2
add queue eligibility helper 2019-12-11 16:10:18 -07:00
Danny Ryan 6610aeea2f
fix activation queue to finality 2019-12-11 16:00:46 -07:00
Danny Ryan 40025c96dd
Merge pull request #1509 from ethereum/match-slot-target
ensure that epoch of attestation slot matches the target epoch
2019-12-10 13:42:32 -07:00
Danny Ryan 66652d0ebd
Merge pull request #1508 from ethereum/better-best
ensure the best better-justification is stored in fork choice
2019-12-10 13:41:45 -07:00
Danny Ryan 4636b3e824
Merge pull request #1510 from ethereum/genesis-slot-time
explicit use of GENESIS_SLOT in fork choice
2019-12-10 13:41:13 -07:00
Danny Ryan e4d710590a
add test for queue efficiency 2019-12-10 11:49:26 -07:00
Danny Ryan d126162ca8
fix activation queue efficiency 2019-12-10 11:25:55 -07:00
Martin Lundfall c761feafdc checkout in same job 2019-12-10 18:57:19 +01:00
Martin Lundfall e090174d77 checkout specs before checking toc 2019-12-10 18:33:19 +01:00
Martin Lundfall 3190f58a15 ci: try with sudo 2019-12-10 18:29:50 +01:00
Martin Lundfall 8408ec6311 check table of contents in circleci 2019-12-10 18:29:50 +01:00
Martin Lundfall aa0c9f89c3 Add check_toc rule to makefile, which fails if table of contents of any of the MARKDOWN_FILES are out of sync 2019-12-10 18:29:50 +01:00
Martin Lundfall ca2b6a0e52 Use consistent header level for TOC generation 2019-12-10 18:29:50 +01:00
Martin Lundfall 12ff64ea1a Update ToC of specs to consistent use of doctoc 2019-12-10 18:29:40 +01:00
Danny Ryan 2c5c9cb71a
feedback from mikhail 2019-12-10 10:14:49 -07:00
Danny Ryan 8861ca0282
minor typo
Co-Authored-By: MrChico <martin.lundfall@protonmail.com>
2019-12-10 10:05:19 -07:00
Danny Ryan 9989f3ea9d
ensure fork choice functions when GENESIS_SLOT != 0 2019-12-09 19:02:16 -07:00
Danny Ryan 432257659e
add asserts to ensure that attestation slot must match the target epoch 2019-12-09 17:31:43 -07:00