Justin
412a06608c
Update 0_beacon-chain.md
2019-12-15 11:32:11 +00:00
Justin
48317d8ac0
Minor cosmetic cleanups
...
* remove `BLS_WITHDRAWAL_PREFIX` (it is not used in phase 1, not phase 0)
* avoid inline comment (# Validate state root)
* simplify header inequality check in `process_proposer_slashing` (using uniqueness of BLS signatures)
* add `block = signed_block.message` helper variable for readability
* (typo) clarify that the state transition function consumes a signed block (as opposed to a block)
* generally make comments more consistent
* consistent formatting of container instantiation for `DepositMessage`
* avoid using three lines for `rewards[index] += Gwei(max_attester_reward // attestation.inclusion_delay)`
* introduce `effective_balance` helper variable for readability, and to avoid multi-line statement
* consistent ordering of `MIN_EPOCHS_TO_INACTIVITY_PENALTY` in the time parameters table
* (typo) "Dequeued validators for activation up to churn limit" => Dequeue validators
* "Save current block as the new latest block" => "Cache current block" (for consistent with `process_slot`)
* (typo) "Verify the validator has not yet exited" => "Verify exit has not been initiated"
* Use Pythonic `default=` for `max()` call in `initiate_validator_exit`
2019-12-15 11:10:43 +00:00
Diederik Loerakker
88e954a9c7
Merge pull request #1522 from ethereum/master
...
backport v093 to dev
2019-12-13 18:56:31 +01:00
Danny Ryan
b09c45ffd2
remove last two references to signing root
2019-12-12 12:34:02 -07:00
Danny Ryan
47ecedb81d
update tocs
2019-12-12 09:48:53 -07:00
Danny Ryan
49a8264f5d
Merge branch 'v09x' into toc_ci
2019-12-12 09:47:20 -07:00
Danny Ryan
4a31503ec0
Merge pull request #1516 from ethereum/dup-indices-attest
...
Fixes #1486 : disallow duplicate indices in indexed attestation
2019-12-12 08:32:43 -07:00
Danny Ryan
52a6cf7ba3
Merge pull request #1514 from ethereum/queue-fix-on-finality
...
Fix queue rate and only activate upon finality
2019-12-12 07:44:57 -07:00
Danny Ryan
199933cb26
fix tocs
2019-12-12 06:57:11 -07:00
Danny Ryan
86fb3acd59
minor changes to finality in activation queue
2019-12-12 06:53:56 -07:00
Danny Ryan
19ec01e4e9
add comment about activation queue sort order
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-12 06:43:37 -07:00
ethers
3d48a3e9eb
Fix dead link to use Internet Archive
2019-12-11 18:17:20 -08:00
protolambda
2405060a7e
Fixes #1486 : disallow duplicate indices in indexed attestation
2019-12-12 01:45:59 +01:00
Danny Ryan
e117b58ae2
add queue eligibility helper
2019-12-11 16:10:18 -07:00
Danny Ryan
6610aeea2f
fix activation queue to finality
2019-12-11 16:00:46 -07:00
Danny Ryan
40025c96dd
Merge pull request #1509 from ethereum/match-slot-target
...
ensure that epoch of attestation slot matches the target epoch
2019-12-10 13:42:32 -07:00
Danny Ryan
66652d0ebd
Merge pull request #1508 from ethereum/better-best
...
ensure the best better-justification is stored in fork choice
2019-12-10 13:41:45 -07:00
Danny Ryan
4636b3e824
Merge pull request #1510 from ethereum/genesis-slot-time
...
explicit use of GENESIS_SLOT in fork choice
2019-12-10 13:41:13 -07:00
Danny Ryan
e4d710590a
add test for queue efficiency
2019-12-10 11:49:26 -07:00
Danny Ryan
d126162ca8
fix activation queue efficiency
2019-12-10 11:25:55 -07:00
Martin Lundfall
ca2b6a0e52
Use consistent header level for TOC generation
2019-12-10 18:29:50 +01:00
Martin Lundfall
12ff64ea1a
Update ToC of specs to consistent use of doctoc
2019-12-10 18:29:40 +01:00
Danny Ryan
2c5c9cb71a
feedback from mikhail
2019-12-10 10:14:49 -07:00
Danny Ryan
8861ca0282
minor typo
...
Co-Authored-By: MrChico <martin.lundfall@protonmail.com>
2019-12-10 10:05:19 -07:00
Danny Ryan
9989f3ea9d
ensure fork choice functions when GENESIS_SLOT != 0
2019-12-09 19:02:16 -07:00
Danny Ryan
432257659e
add asserts to ensure that attestation slot must match the target epoch
2019-12-09 17:31:43 -07:00
Danny Ryan
d4d17ecc4e
ensure the best better-justification is stored in fork choice
2019-12-09 16:47:43 -07:00
Danny Ryan
57aeed1473
Merge branch 'v09x' into filter-fc-justified
2019-12-08 12:17:28 -07:00
Danny Ryan
e53a6daecc
clarify fliter block tree through two line usage
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-08 11:53:45 -07:00
Danny Ryan
ce40666003
version pyspec module and test on one attesterslashing test
2019-12-05 15:06:32 -07:00
Diederik Loerakker
da17f4b3a8
Merge pull request #1505 from ethereum/v09x
...
backport V09x
2019-12-05 22:15:47 +01:00
Danny Ryan
e31f17f037
modify phase 1 to use new signature (no signing_root) pattern
2019-12-05 13:49:52 -07:00
Danny Ryan
a32b0100ff
rebase fixes
2019-12-05 13:31:42 -07:00
Danny Ryan
4bf5eb86c4
fix issues using indexed attestation and custody bit wrapper
2019-12-05 13:31:42 -07:00
Danny Ryan
f533fef167
add missing attestation validations; cleanup process_attestations and fix minor bugs
2019-12-05 13:31:41 -07:00
Danny Ryan
a1ac0d5a80
fix get_shard_committee
2019-12-05 13:31:41 -07:00
Danny Ryan
ddd7cd2964
divide new and old containers out in phase 1
2019-12-05 13:31:41 -07:00
protolambda
72a9dfc430
fix lint problems
2019-12-05 13:31:41 -07:00
protolambda
1623d40b6d
fix: check malefactor custody key
2019-12-05 13:31:41 -07:00
protolambda
41be2ed3ce
bugfix custody bit index lookup + lint fixes
2019-12-05 13:31:40 -07:00
protolambda
1a1c3773f9
implement custody game revamp for new shard proposal: simplifications and immediate processing, since custody data is bounded
2019-12-05 13:31:40 -07:00
protolambda
e73316c13f
change configs to be loaded in time; reload specs module to make new config presets effective. Also fix more lint and consistency problems.
2019-12-05 13:30:49 -07:00
Danny Ryan
d6bfe5d35c
lint phase 1 (2)
2019-12-05 13:29:52 -07:00
Danny Ryan
9f80a7f703
phase1 lint (1)
2019-12-05 13:29:51 -07:00
Danny Ryan
82c9adce8b
fix phase 1 make build (not lint or tests)
2019-12-05 13:29:51 -07:00
Danny Ryan
79be0345d6
fix call to process_attestation
2019-12-05 13:29:51 -07:00
protolambda
03e956f9c9
validator init adjustments
2019-12-05 13:29:51 -07:00
protolambda
36503f98e4
placeholder: rudimentary phase 0 to phase 1 fork process
2019-12-05 13:29:51 -07:00
protolambda
cc0aac3aae
typo
2019-12-05 13:29:50 -07:00
protolambda
74d6021507
PR comment fixes
2019-12-05 13:29:50 -07:00
protolambda
589d5a4f9a
Add notes on custody game spec funcs
2019-12-05 13:29:50 -07:00
protolambda
465f6cb7f0
update readme spec links
2019-12-05 13:29:50 -07:00
protolambda
edef2fd8ae
more refactoring: more immediate custody game, general phase1 beacon chain changes
2019-12-05 13:29:50 -07:00
protolambda
7d2341b40d
Note: is_valid_indexed_attestation is overriden
2019-12-05 13:29:49 -07:00
protolambda
a33e01dab2
Start making phase1 work in pyspec again
2019-12-05 13:29:49 -07:00
Vitalik Buterin
ef936b94fe
Added get_shard_proposer_index
2019-12-05 13:29:49 -07:00
Vitalik Buterin
4d6dcd15ba
Some fixes
2019-12-05 13:29:49 -07:00
Vitalik Buterin
7b4a6e8307
Simplified gasprice update
2019-12-05 13:29:49 -07:00
Vitalik Buterin
8f34a0788d
Some initial changes
2019-12-05 13:29:49 -07:00
vbuterin
b6680d28bb
Update specs/core/1_new_shards.md
...
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
2019-12-05 13:29:48 -07:00
vbuterin
e66b4e06ef
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:48 -07:00
vbuterin
8cb404d926
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:48 -07:00
vbuterin
ff3bd725a3
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:48 -07:00
vbuterin
2ea8eb9cc3
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:48 -07:00
vbuterin
c9cc110ab1
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:47 -07:00
vbuterin
a749dd9a77
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:47 -07:00
vbuterin
822ceade58
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:47 -07:00
vbuterin
0ddc0ba527
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:47 -07:00
vbuterin
bf13757722
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:47 -07:00
vbuterin
793c8616cd
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:47 -07:00
vbuterin
41be60ee6e
Update specs/core/1_new_shards.md
2019-12-05 13:29:46 -07:00
vbuterin
8a6bd201f9
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:46 -07:00
vbuterin
4d1e9e15c6
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:46 -07:00
vbuterin
9810a3d260
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:46 -07:00
vbuterin
9d3a230974
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:46 -07:00
vbuterin
bcd06d88ef
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:46 -07:00
vbuterin
d59e87f876
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:45 -07:00
vbuterin
d3f9bfe68d
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:45 -07:00
vbuterin
213032e51f
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:45 -07:00
vbuterin
462d05d6d8
Update specs/core/1_new_shards.md
...
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
2019-12-05 13:29:45 -07:00
Hsiao-Wei Wang
1fdd0332cc
Update ToC
2019-12-05 13:29:45 -07:00
Vitalik Buterin
03ab1d5785
A few cleanups
2019-12-05 13:29:45 -07:00
Vitalik Buterin
d723431616
Fixed pending attestation handling and added empty transition check
2019-12-05 13:29:44 -07:00
Vitalik Buterin
393436992d
Restructured shard blocks
2019-12-05 13:29:44 -07:00
Vitalik Buterin
6b1bc1e02f
Reformed attestations
2019-12-05 13:29:44 -07:00
Vitalik Buterin
b36820a26c
Changes to make Danny happy
2019-12-05 13:29:44 -07:00
Vitalik Buterin
bf886d698b
Small edits
2019-12-05 13:29:44 -07:00
Vitalik Buterin
bf0a2b7df9
Renaming
2019-12-05 13:29:43 -07:00
Vitalik Buterin
08fc024fbd
Changed fraud proof details
2019-12-05 13:29:43 -07:00
Hsiao-Wei Wang
0ff5985c01
Fix markdown and ToC
2019-12-05 13:29:43 -07:00
Vitalik Buterin
539c681921
Updates to add new proposals
2019-12-05 13:29:43 -07:00
Vitalik Buterin
bb2835ee1b
Shard slots to 128 bytes
2019-12-05 13:29:43 -07:00
Vitalik Buterin
7fc2830730
Some updates
2019-12-05 13:29:43 -07:00
Vitalik Buterin
e5544d055b
Made trace a commitment separate from state roots
2019-12-05 13:29:42 -07:00
Vitalik Buterin
9abfc6276a
Cleaned up state transition and honest committee member
2019-12-05 13:29:42 -07:00
Vitalik Buterin
b792fe696a
formatting
2019-12-05 13:29:42 -07:00
Vitalik Buterin
fe60b4deba
Variable max attestation length
2019-12-05 13:29:42 -07:00
Vitalik Buterin
26df98bf61
MAX_CATCHUP -> MAX_CATCHUP_RATIO
2019-12-05 13:29:42 -07:00
Vitalik Buterin
25db268bfb
Added a few more things
2019-12-05 13:29:42 -07:00
Vitalik Buterin
f6be6b2b8a
Added a few things
2019-12-05 13:29:41 -07:00
Vitalik Buterin
88aeba09f6
Added new shards
2019-12-05 13:29:41 -07:00
Danny Ryan
b4b5cc9115
Merge branch 'v09x' into dev
2019-12-05 13:29:04 -07:00
Danny Ryan
7af6945f53
Merge pull request #1491 from ethereum/rm-signing-root
...
rm signing root (fixes #1487 )
2019-12-05 13:16:39 -07:00
Danny Ryan
dfcd6f6402
add tests for block filter in get_head
2019-12-04 16:53:55 -07:00
Danny Ryan
e9dc2a1f03
Merge pull request #1492 from terencechain/patch-91
...
Remove duplicated attestation target root check
2019-12-04 11:49:08 -07:00
protolambda
afb9a1d7c0
move signed envelopes
2019-12-03 21:34:48 +01:00
protolambda
103a66b2af
remove signing_root: see issue #1487
2019-12-03 21:10:19 +01:00
terence tsao
0f4faf11ab
Update 0_fork-choice.md
2019-12-03 17:25:56 +08:00
terence tsao
1113953a59
Update p2p-interface.md
2019-12-03 17:17:17 +08:00
Danny Ryan
2275cdfeb8
fix child filter in get_head
2019-11-27 13:26:44 -07:00
Danny Ryan
5aa9f96558
Update specs/core/0_fork-choice.md
...
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
2019-11-27 13:11:30 -07:00
Danny Ryan
8021f34c06
fix existing fork choce tests with new filter
2019-11-25 15:44:22 -07:00
Danny Ryan
9004bcf1a5
WIP filter block tree
2019-11-25 15:06:33 -07:00
Danny Ryan
23abc11093
handle v0.9.2-dev conflict
2019-11-21 15:18:17 -07:00
Danny Ryan
3e96b43894
Merge pull request #1467 from ethereum/reduce-genesis-count
...
reduce genesis validator count for mainnet config
2019-11-18 13:30:04 -07:00
Danny Ryan
6ef79ac2a8
Merge pull request #1480 from ethereum/ssz-bytes-naming
...
Rename BytesN to ByteVector, rename Bytes to ByteList
2019-11-18 13:28:32 -07:00
Hsiao-Wei Wang
8fed220736
Update `AggregateAndProof` and rename `slot_signature` to `get_slot_signature`
...
1. Reorder the fields to fit the container name
2. Rename `AggregateAndProof.index: ValidatorIndex` to `AggregateAndProof.aggregator_index: ValidatorIndex`
- Since we also have similar naming style like
`ProposerSlashing.proposer_index` or `VoluntaryExit.validator_index`
2019-11-18 21:35:12 +08:00
Diederik Loerakker
b15669b7a5
Backport master (v0.9.1) to dev ( #1482 )
...
* p2p-interface: clarify that signing_root is used for block requests
* hash cleanups
* one more hash tree root gone for blocks - block hashes are always
signing roots!
* use simple serialize data types consistently
* Describe which finalized root/epoch to use
* remove custody_bits from attestation
* remove AttestationDataAndCustodyBit
* Specify inclusive range for genesis deposits
* add initial fork choice bounce prevention and tests
* PR feedback
* further test bounce attack
* wipe queued justified after epoch transition
* remove extra var
* minor fmt
* only allow attestatiosn to be considered from current and previous epoch
* use best_justified_checkpoint instead of queued_justified_checkpoints
* use helper for slots since epoch start
* be explicit about use of genesis epoch for previous epoch in fork choice on_block
* pr feedback
* add note aboutgenesis attestations
* cleanup get_eth1_vote
* make eth1_follow_distance clearer
* Update the expected proposer period
Since `SECONDS_PER_SLOT` is now `12`
* minor fix to comment in mainnet config
* Update 0_beacon-chain.md
2019-11-15 16:27:04 -05:00
protolambda
2c32274870
rename BytesN to ByteVector, rename Bytes to ByteList
2019-11-15 16:56:52 +01:00
Danny Ryan
89fa914e73
Merge pull request #1478 from ethereum/hash-type-fix
...
Avoid Hash <> hash() type and func confusion
2019-11-12 16:41:21 -07:00
Danny Ryan
1aad31df59
Merge pull request #1477 from ethereum/forkchoice-future-blocks
...
Forkchoice mods
2019-11-12 16:40:32 -07:00
Danny Ryan
117fb12888
add scheduling note to on_attestation
2019-11-12 16:24:33 -07:00
protolambda
c061abdd75
Avoid Hash <> hash() type and func confusion, intro Root and change to non-roots to Bytes32
2019-11-12 21:29:58 +01:00
Danny Ryan
e3a67fe52c
ensure not all validators switch at once
2019-11-12 12:00:30 -07:00
Danny Ryan
74253bdbaf
attestations for future blocks not valid in fork choice
2019-11-12 11:29:46 -07:00
Danny Ryan
29b073bcca
add random subnet subscriptions for phase 0 stability
2019-11-11 14:46:30 -07:00
Danny Ryan
32e6623915
clarify topic subscriptions for attestations
2019-11-11 14:27:46 -07:00
terence tsao
931ad45c53
Update 0_beacon-chain.md
2019-11-08 11:45:11 -07:00
Hsiao-Wei Wang
a029db3410
Update the expected proposer period
...
Since `SECONDS_PER_SLOT` is now `12`
2019-11-08 19:05:14 +08:00
Diederik Loerakker
f0999573f7
Merge pull request #1469 from ethereum/fix-eth1-distance
...
Clarify `previous_eth1_distance`
2019-11-07 20:37:36 +01:00
Danny Ryan
c84dce7b32
make eth1_follow_distance clearer
2019-11-07 12:32:02 -07:00
Danny Ryan
5159c69632
cleanup get_eth1_vote
2019-11-07 12:15:56 -07:00
Danny Ryan
e7f71886b0
Merge pull request #1466 from ethereum/decoy-flip-flop
...
Decoy flip flop resistance
2019-11-08 03:10:41 +08:00
Danny Ryan
9b21c0db93
add note aboutgenesis attestations
2019-11-07 12:06:23 -07:00
Danny Ryan
f331b55b9e
Merge pull request #1465 from ethereum/bounce-attack
...
Bounce attack resistance
2019-11-08 02:56:46 +08:00
Danny Ryan
bf78a71152
pr feedback
2019-11-07 11:51:53 -07:00
Danny Ryan
9ddae15e2e
reduce genesis validator count for mainnet config
2019-11-06 20:32:25 -07:00
Danny Ryan
a28c027943
be explicit about use of genesis epoch for previous epoch in fork choice on_block
2019-11-06 17:26:06 -07:00
Danny Ryan
e1d2823810
Merge branch 'bounce-attack' into decoy-flip-flop
2019-11-06 17:20:59 -07:00
Danny Ryan
09fd49ce89
use helper for slots since epoch start
2019-11-06 17:20:21 -07:00
Danny Ryan
fc40bff2a8
use best_justified_checkpoint instead of queued_justified_checkpoints
2019-11-06 17:10:32 -07:00
Danny Ryan
4f42f63e4e
only allow attestatiosn to be considered from current and previous epoch
2019-11-05 13:01:58 -07:00
Danny Ryan
2616210637
minor fmt
2019-11-05 12:51:47 -07:00
Danny Ryan
ba6637b4d9
remove extra var
2019-11-05 11:42:40 -07:00
Danny Ryan
79911a93b4
Merge pull request #1462 from ethereum/remove-custody
...
Remove custody_bits and AttestationDataAndCustodyBit
2019-11-06 02:03:50 +08:00
Danny Ryan
e20e11e0b5
wipe queued justified after epoch transition
2019-11-05 11:02:58 -07:00
Danny Ryan
97d7cf5190
further test bounce attack
2019-11-05 10:58:45 -07:00
Danny Ryan
40a21dc3ad
PR feedback
2019-11-05 09:08:37 -07:00
Danny Ryan
405e218598
add initial fork choice bounce prevention and tests
2019-11-05 08:55:34 -07:00
Paul Hauner
1c99ab2c96
Specify inclusive range for genesis deposits
2019-11-04 10:55:14 +11:00