Hsiao-Wei Wang
a4cc189f2b
Apply PR feedback from Danny
2020-06-06 05:19:46 +08:00
Danny Ryan
7f680dfca4
fix tests
2020-06-05 14:09:17 -06:00
Hsiao-Wei Wang
a71c0a5ccc
Per #1704 discussion, remove `on_time_slot`: the given `beacon_state`
...
should be transitioned.
2020-06-06 02:39:47 +08:00
Hsiao-Wei Wang
2afa315cb3
clean leftover
2020-06-06 02:39:47 +08:00
Hsiao-Wei Wang
2d4788fe7d
Fix `verify_shard_block_message`
...
Add check for `block.beacon_parent_root` per Terence's suggestion
Update `get_shard_transition`
1. Disable verification: it will be fix in v-guide
2. Use `on_time_slot` to compute offset_slots
Rework tests
2020-06-06 02:39:47 +08:00
Hsiao-Wei Wang
a154d0c22b
Fix typo
2020-06-06 02:39:11 +08:00
Hsiao-Wei Wang
ab42eee4c0
Update shard fork choice rule to be able to handle mainnet config
2020-06-06 02:39:11 +08:00
Hsiao-Wei Wang
c9a53b8039
WIP test case
2020-06-06 02:39:07 +08:00
Danny Ryan
b1ff00aab0
Merge branch 'dev' into phase1-validator
2020-06-03 12:18:17 -06:00
Danny Ryan
74204f795d
udpate validator guide to work with all updated phase 1 constructions
2020-06-03 12:16:39 -06:00
Hsiao-Wei Wang
e1981a7bfd
`head_shard_root` -> `shard_head_root`
2020-06-04 01:00:52 +08:00
Hsiao-Wei Wang
58e75c27ed
Merge branch 'dev' into hwwhww/shard_fork_choice
2020-06-04 00:56:25 +08:00
Hsiao-Wei Wang
eb21648146
Merge pull request #1858 from ethereum/hwwhww/get_start_shard
...
`get_start_shard` proposal
2020-06-04 00:46:12 +08:00
Hsiao-Wei Wang
a685be3bbe
PR feedback from Danny
...
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
2020-06-04 00:42:08 +08:00
Hsiao-Wei Wang
68e934bf15
Add `get_start_shard` unittests and update minimal config
...
1. Add unittests for testing `get_start_shard` with better granularity
2. Change `INITIAL_ACTIVE_SHARDS` from `4` to `2` for tight crosslinking
2020-06-03 23:08:38 +08:00
Danny Ryan
314dea97a5
bump VERSION.txt to 0.12.1
2020-06-02 17:26:26 -06:00
Danny Ryan
671fae6efe
change note about genesis delay in p2p spec to match new GENESIS_DELAY config value; fix tests
2020-06-02 11:09:42 -06:00
Danny Ryan
d6435d0cbf
Merge branch 'dev' into dankrad-custody-256bit
2020-06-01 18:49:11 -06:00
Danny Ryan
3a4db69a20
Merge branch 'dev' into dankrad-custody-256bit
2020-06-01 18:45:22 -06:00
Hsiao-Wei Wang
30f72dd696
Fix `get_shard` and `compute_shard_from_committee_index` calls
2020-06-01 23:15:16 +08:00
Hsiao-Wei Wang
9567c238d4
Merge branch 'dev' into hwwhww/get_start_shard
2020-06-01 18:17:58 +08:00
Hsiao-Wei Wang
8e5db1b49f
Merge pull request #1856 from ethereum/hwwhww/verify_empty_shard_transition
...
Rework `Shard transition processing`
2020-06-01 17:47:00 +08:00
Hsiao-Wei Wang
8f570b461d
Merge pull request #1854 from ethereum/hwwhww/phase1_refactor
...
Some phase1 refactoring
2020-06-01 17:46:16 +08:00
Hsiao-Wei Wang
63de59d5f6
Merge branch 'dev' into hwwhww/shard_fork_choice_3
2020-05-30 03:57:17 +08:00
Hsiao-Wei Wang
870ad8b921
Fix test
2020-05-30 03:56:56 +08:00
Hsiao-Wei Wang
cceeab2657
Combine `process_crosslinks` and `verify_empty_shard_transition` into `process_shard_transitions`
2020-05-30 03:13:20 +08:00
Hsiao-Wei Wang
2dc041807a
Implement `get_start_shard`
2020-05-30 01:26:00 +08:00
Hsiao-Wei Wang
ca48963032
Rename `head_shard_root` to `shard_head_root`
2020-05-28 21:38:11 +08:00
Hsiao-Wei Wang
c437578280
Add `shard` field to `ShardBlock`
2020-05-28 21:32:27 +08:00
Hsiao-Wei Wang
5e8457e62d
Fix phase1 on-time sign_indexed_attestation
2020-05-23 21:53:55 +08:00
Danny Ryan
7770accf96
Merge pull request #1803 from ethereum/fast-bls-option
...
BLS options for pyspec
2020-05-20 14:39:49 -06:00
Danny Ryan
61336a9c0b
add deposit_root to validator unit tets
2020-05-20 14:03:16 -06:00
Danny Ryan
96f785e84b
ensure only forward progress with eth1data voting
2020-05-20 13:56:43 -06:00
Hsiao-Wei Wang
d92efdf071
Should have signed the attestions in `test_filtered_block_tree` test
2020-05-21 03:02:02 +08:00
Hsiao-Wei Wang
763d74bbf5
Just learned bls was disabled by default; fixing the tests
2020-05-21 02:52:24 +08:00
Hsiao-Wei Wang
db1a90d2ee
`test_success_surround` changes the signing data of attestation, so it should be never_bls
2020-05-21 02:05:22 +08:00
Hsiao-Wei Wang
f72d14a747
Bump `milagro_bls_binding` to 1.2.0
...
Also verify it in BLS test generator
2020-05-21 01:37:12 +08:00
Danny Ryan
943e51aef1
hww feedback for finality rewards fix
2020-05-20 10:12:57 -06:00
Hsiao-Wei Wang
21a4143d99
Merge branch 'dev' into fast-bls-option
2020-05-20 16:26:43 +08:00
Danny Ryan
95c3295eeb
move proposer negation to inactivity_penalty deltas
2020-05-19 17:17:20 -06:00
Danny Ryan
85e78223dd
ensure when performing optimally that you don't lose money during a leak
2020-05-19 16:51:46 -06:00
Danny Ryan
6d45afeefb
add some more random reawrds tests
2020-05-18 19:59:50 -06:00
protolambda
85f6712363
fix comments based on PR feedback
2020-05-19 03:42:58 +02:00
protolambda
97e54b85d6
fix cache for config change during runtime
2020-05-19 02:47:16 +02:00
protolambda
75a0d60eb3
cached epoch attestation preparation
2020-05-19 02:25:32 +02:00
protolambda
0f20d8a9ba
leak state decorator, and test pre-state caching
2020-05-19 01:56:20 +02:00
Danny Ryan
8060505743
refactor rewards/penalties tests to use a single structure
2020-05-18 16:00:59 -06:00
Danny Ryan
5da4fe37f8
Merge pull request #1821 from ethereum/rewards-with-inactive-vals
...
Rewards with not yet activated validators
2020-05-18 14:13:27 -06:00
Danny Ryan
c5367295c3
Merge branch 'dev' into v012x
2020-05-18 13:32:24 -06:00
Danny Ryan
b7cfa94cb4
Merge branch 'dev' into v0113-dev-merge
2020-05-18 13:22:16 -06:00
Danny Ryan
96b5733086
cleanup set some new deposits helper for rewards tests
2020-05-18 12:06:24 -06:00
Danny Ryan
97b6db4971
add rewards tests for validators not yet activated
2020-05-18 10:07:30 -06:00
Danny Ryan
b975a92e90
ensure at least one validator is slashed for slashing rewards tests
2020-05-18 09:29:01 -06:00
Danny Ryan
4a86c39712
Merge pull request #1799 from ethereum/bls_v2
...
Update to IETF BLS draft-irtf-cfrg-bls-signature-02 + draft-irtf-cfrg-hash-to-curve-07
2020-05-18 07:35:49 -06:00
Danny Ryan
74c900f814
add conditoin that block must be later than latest_block_header
2020-05-15 16:43:53 -06:00
Hsiao-Wei Wang
d27f2350a2
Update BLS test suite to BLS standard draft v2 format
...
1. Make sure that BLS -Verify APIs would only return `True` or `False` , no exceptions.
2. Use `eth2spec.utils.bls` instead of py_ecc for test generator
3. Add assertions in test generator
4. Add some special test cases for the -Verify APIs
5. Clean up the test format documents
2020-05-15 00:55:06 +08:00
Danny Ryan
e7ae4be8a9
ensure that pre-state slot is less than block for all block tests
2020-05-13 17:25:39 -06:00
Danny Ryan
1d147037eb
write block tests for double slot proposal and genesis proposal
2020-05-13 11:52:04 -06:00
protolambda
68442c2eef
Update testing and restrict to incremental block transitions
2020-05-13 16:46:28 +02:00
protolambda
b1c2c6e3a2
Default BLS to ON, keep CI BLS off for now, add milagro option
2020-05-11 19:18:49 +02:00
Danny Ryan
65108aeee0
start on_block just slots test at time 0
2020-05-11 11:17:48 -06:00
Danny Ryan
17f656cefe
Merge branch 'dev' into v012x
2020-05-11 10:41:35 -06:00
Danny Ryan
6474218fb1
Merge pull request #1747 from ethereum/rewards-rework
...
[Proposal] rework rewards/penalties to be more granular
2020-05-11 08:16:49 -06:00
Danny Ryan
1636360426
remove todo comment
...
Co-authored-by: Hsiao-Wei Wang <hwwang156@gmail.com>
2020-05-11 08:09:07 -06:00
Hsiao-Wei Wang
cdd0ed0f7b
Update to IETF BLS draft-irtf-cfrg-bls-signature-02
2020-05-09 11:48:48 +08:00
Danny Ryan
1137e0332d
move MAX_ATTESTER_SLASHINGS to 2, add multiple slashings per block tests
2020-05-08 10:43:11 -06:00
Nathaniel Jensen
38a5f41c30
[Minor] Fix config example to not assign a return value.
2020-05-08 20:12:44 +10:00
Danny Ryan
3a71c6d9bd
Merge branch 'dev' into v012x
2020-05-07 12:48:47 -06:00
Danny Ryan
b317a7329f
Merge branch 'dev' into double-operations
2020-05-07 12:32:25 -06:00
Danny Ryan
4ad3d65d10
add multiple exits block sanity test
2020-05-07 12:23:37 -06:00
Danny Ryan
ee7d11d18f
clean up proposer slashing tests and add a couple
2020-05-07 12:00:07 -06:00
Danny Ryan
12aa84fc8a
PR feedback
2020-05-07 10:47:20 -06:00
Danny Ryan
08652f543b
Merge branch 'v012x' into empty-bits-case
2020-05-07 10:17:26 -06:00
Danny Ryan
7625728fb8
Merge pull request #1742 from ethereum/ffg_lmd_vote_consistency
...
Added FFG-LMD vote consistency checks
2020-05-07 09:36:52 -06:00
Danny Ryan
4ffa0dba60
Apply suggestions from code review
...
"rewards/penalties" -> "deltas" in throughout test comments/descriptions
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
2020-05-05 16:31:40 -06:00
Danny Ryan
f0742b2f2d
add exited tests for rewards. make some valiators exited/withdrawable in slashed tests
2020-05-05 16:28:29 -06:00
Danny Ryan
4f401133e1
address PR feedback from @protolambda
2020-05-05 15:37:14 -06:00
Danny Ryan
b109e7da5a
add test for inconsistent head and target in attestation fork choice
2020-05-05 14:46:02 -06:00
Danny Ryan
b2dfb6cebe
PR feedback from @hwwhww
2020-05-05 13:33:44 -06:00
Danny Ryan
d26cfd2e59
Apply suggestions from code review from @hwwhww
...
Co-authored-by: Hsiao-Wei Wang <hwwang156@gmail.com>
2020-05-05 13:08:41 -06:00
Danny Ryan
38f29ba0a8
remove PERSISTENT_COMMITTEE_PERIOD in favor of SHARD_COMMITTEE_PERIOD
2020-05-05 11:44:53 -06:00
Danny Ryan
5b3ed8a3e7
bump VERSION.txt to 0.12.0
2020-05-05 09:45:24 -06:00
Danny Ryan
b2c36112f6
Merge branch 'dev' into v012x
2020-05-05 09:44:27 -06:00
Danny Ryan
f35106d9ee
add comment for helper -- has_enouh_for_reward
2020-05-05 09:43:25 -06:00
Hsiao-Wei Wang
79b1b4bdbe
Add `(shard, shard_root)` to `LatestMessage`
2020-05-05 21:42:18 +08:00
Hsiao-Wei Wang
8fafb6a9e5
Make `ShardStore` an independent object
2020-05-05 21:42:06 +08:00
Hsiao-Wei Wang
cddf9cf114
Refactor
2020-05-05 21:42:00 +08:00
Hsiao-Wei Wang
dab5a936c4
wip shard fork choice rule
2020-05-05 21:41:46 +08:00
Hsiao-Wei Wang
f4334d1522
Delete outdated helper
2020-05-05 15:28:12 +08:00
Hsiao-Wei Wang
ee4c866575
Merge branch 'dev' into dankrad-custody-256bit-merging
2020-05-05 15:22:36 +08:00
Danny Ryan
8f569a8ddc
add inactivity penalty deltas tests
2020-05-04 20:58:42 -06:00
Danny Ryan
5194c1f2d2
add test_get_inclusion_delay_deltas
2020-05-04 17:00:43 -06:00
Danny Ryan
a7354bd358
Merge branch 'dev' into rewards-rework
2020-05-04 13:34:35 -06:00
Danny Ryan
eda249957e
basic generators work
2020-05-04 13:20:32 -06:00
Hsiao-Wei Wang
977cd73379
Refactor the tests
2020-05-02 02:32:37 +08:00
Hsiao-Wei Wang
524ba166d1
[squashed] shard chain updates wip
...
Fix wrong field names
Fix `build_attestation_data` and other PR feedback from Danny and
Terence
1. Rename `get_previous_slot` to `compute_previous_slot`
2. Break down `build_empty_block` into
`get_state_and_beacon_parent_root_at_slot`, use it in
`build_shard_block`
3. Set defult `slot` to `shard_state.slot + 1` in `build_shard_block`
Update `verify_shard_block_message`: check beacon_parent_root at fork
choice rule stage instead of state transition
Fix `beacon-chain.md`
1. Fix typo `attestation.slot == state.slot` -> `attestation.data.slot == state.slot` in `is_winning_attestation`
2. Check `verify_shard_transition_false_positives` **after** `process_operations`
3. Fix `shard_attestations` filter in `process_crosslinks`: since attestations come from block, should use `attestation.data.slot + MIN_ATTESTATION_INCLUSION_DELAY == state.slot`
4. [TBD] Allow empty `light_client_signature` to make the tests pass
5. [TBD] Add `is_shard_attestation`, filter out empty `ShardTransition()`
Rework `test_process_crosslink`
Add basic phase 1 `test_blocks`
Add more test cases
Revert `is_shard_attestation` and fix test cases backward compatibility.
Remove `test_process_beacon_block_no_shard_transition` and consider it as invalid case.
2020-05-02 02:32:31 +08:00
Hsiao-Wei Wang
85d5a9abaf
[squashed] shard chain updates wip
...
PR feedback from Danny and some refactor
1. Add stub `PHASE_1_GENESIS_SLOT`
2. Rename `get_updated_gasprice` to `compute_updated_gasprice`
3. Rename `compute_shard_data_roots` to `compute_shard_body_roots`
Apply shard transition for the skipped slots
Refactor `shard_state_transition`
Get `beacon_parent_root` from offset slot
Add more test
Add `verify_shard_block_message`
Add `> 0`
Keep `beacon_parent_block` unchanged in `is_valid_fraud_proof`
Remove some lines
Fix type
Refactor + simplify skipped slot processing
2020-05-02 02:31:54 +08:00
Hsiao-Wei Wang
e645d6b5fa
Rename `build_empty_shard_block` to `build_shard_block`
2020-05-02 02:31:53 +08:00
Hsiao-Wei Wang
4e8a7ff115
[squashed] shard transition wip
...
Fix the wrong `get_shard_proposer_index` parameters order
Phase 1 WIP
Add shard transition basic test
Fix lint error
Fix
2020-05-02 02:31:10 +08:00
protolambda
45ad270f76
test double proposer slashings and exits
2020-05-01 19:14:01 +02:00