Commit Graph

9008 Commits

Author SHA1 Message Date
Enrico Del Fante e2ca4b3519
add failed on_block condition 2023-11-30 15:20:35 +01:00
Enrico Del Fante ccf9e3419b
Update specs/deneb/p2p-interface.md
Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
2023-11-30 15:20:34 +01:00
Enrico Del Fante 6bbdeb88e0
Update specs/phase0/p2p-interface.md
Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
2023-11-30 15:20:34 +01:00
Enrico Del Fante c46c4ec7cb
fix typo 2023-11-30 15:20:34 +01:00
Enrico Del Fante e664d407ca
Specify RPC byRoot blocks-sidecars elegibility 2023-11-30 15:20:34 +01:00
danny 8fa1f8ed0a
Merge pull request #3550 from ethereum/on-tick-precondition
Check `assert time >= store.time` in fork-choice tests
2023-11-30 06:58:40 -07:00
Hsiao-Wei Wang 581a64be2b
cleanup leftover 2023-11-30 18:56:51 +08:00
Hsiao-Wei Wang a8d02685c2
Merge branch 'dev' into on-tick-precondition 2023-11-30 08:05:27 +08:00
Hsiao-Wei Wang 6fb9b0a9a4
Revert the spec. Only handle it in tests 2023-11-30 03:58:27 +08:00
Hsiao-Wei Wang 102809371e
Merge pull request #3548 from ethereum/fix-fc-script
Remove extra tick
2023-11-29 19:36:40 +09:00
Etan Kissling 321870cbe9
Align gossip validation for aggregates with single attestations
A couple gossip validation rules are only specced out for single
un-aggregated attestations, but are also checked by implementations
for aggregates. This adds a copy of the missing gossip validation rules
to the aggregated attestation docs.
2023-11-19 23:12:11 -08:00
Hsiao-Wei Wang 3d853b0ec9
Add `assert time >= store.time` to `on_tick` 2023-11-16 17:25:54 +03:00
Etan Kissling dd65aa0cb2
Gossip additional `LightClientFinalityUpdate` on new supermajority
When new finality is reached without supermajority sync committee
support, trigger another event push on beacon-API and libp2p once
the new finality gains supermajority support.

Without this, if the first `LightClientFinalityUpdate` that advances
finality has low participation, light clients monitoring gossip would
likely get stuck until the next time when finality advances (1 epoch).

Thanks to @DragonDev1906 for reporting this issue to Nimbus:

- https://github.com/status-im/nimbus-eth2/issues/5491
2023-11-14 22:28:16 -08:00
Hsiao-Wei Wang 70ce4f28c0
Remove extra tick 2023-11-14 12:06:33 +03:00
Jacek Sieka 04f5ec595d
remove obsolete comment 2023-11-09 07:51:39 +01:00
Etan Kissling d9e53cbaf5
Merge branch 'dev' into lc-gindexname 2023-11-06 12:32:53 +01:00
Etan Kissling e30e8af58f
Use fork choice to determine `finalized_checkpoint` in gossip validation
Update gossip validation rules to use the highest `finalized_checkpoint`
across _all_ branches (`store.finalized_checkpoint`), instead of the one
on the currently selected branch (`state.finalized_checkpoint`) when
deciding whether to ignore a block / blob because they are already
finalized.
2023-11-06 12:20:11 +01:00
danny 36f0bb0ed6
Merge pull request #3541 from etan-status/df-rmsigned
Remove `SignedBlobSidecar` refs from p2p spec
2023-11-03 14:03:04 -06:00
danny 088dd19905
Merge pull request #3542 from etan-status/df-nodomain
Remove unused `DOMAIN_BLOB_SIDECAR`
2023-11-03 14:02:52 -06:00
Etan Kissling 9338d37c15
Update toc 2023-11-03 11:47:30 +01:00
Etan Kissling 3ef362ce90
Remove unused `DOMAIN_BLOB_SIDECAR`
Blob sidecars are no longer signed, remove signing domain.
2023-11-03 11:30:28 +01:00
Etan Kissling 321f47bb27
Remove `SignedBlobSidecar` refs from p2p spec
P2P spec still mentions _signed_ blob sidecars. Remove _signed_ as that
is no longer accurate.
2023-11-03 11:28:17 +01:00
danny 09c14f0017
Merge pull request #3540 from ethereum/blob-by
clarify/fix things in blob requests
2023-11-02 10:59:45 -06:00
danny e21ed6de4f
clarify/fix things in blob requests 2023-11-02 10:03:56 -06:00
Hsiao-Wei Wang 7094833e07
Merge pull request #3538 from ethereum/bump-version
Bump v1.4.0-beta.4
2023-11-03 01:03:49 +09:00
danny c6f7adf319
Merge pull request #3531 from dapplion/blob-p2p-proof
Add blob sidecar inclusion proof
2023-11-02 09:56:08 -06:00
Hsiao-Wei Wang e0b87a665d
Bump v1.4.0-beta.4 2023-11-02 22:41:47 +07:00
danny 7118c30b67
a few cleanups to sidecar gossip conditions 2023-11-02 09:40:49 -06:00
Hsiao-Wei Wang 3492c0a99a
minor refactoring 2023-11-02 22:10:06 +07:00
Hsiao-Wei Wang 38d354fb01
Merge pull request #3034 from michaelsproul/proposer-boost-reorg
Allow honest validators to reorg late blocks
2023-11-02 23:54:43 +09:00
Hsiao-Wei Wang 71106f1d64
Remove `BLOB_KZG_COMMITMENTS_GINDEX` 2023-11-02 21:38:01 +07:00
dapplion 4a609cec57 rename to kzg_commitment_inclusion_proof 2023-11-01 15:57:41 +02:00
Etan Kissling 89c986ee6a
Rename `_INDEX` generalized index constants to `_GINDEX`
To assist with readability, use `_GINDEX` suffix when referring to
generalized index constants.

Does neither affect consensus, beacon-API nor builder API.
2023-11-01 13:30:55 +01:00
danny 4e5599f41b
Merge pull request #3535 from ethereum/ralexstokes-patch-3
`deneb`: Suggest sidecars by root callers verify blob sidecars
2023-10-31 10:28:01 -06:00
Lion - dapplion 7f63f003c0
Merge branch 'dev' into blob-p2p-proof 2023-10-31 11:45:54 +02:00
dapplion 19883ec592 Add verify_blob_kzg_proof condition 2023-10-31 11:39:57 +02:00
Hsiao-Wei Wang 1bac25a623
Add Merkle proof test 2023-10-31 01:29:30 +08:00
danny 9b1e0b7354
Merge pull request #3534 from ralexstokes/clean-up-deneb-tx-type
remove `BLOB_TX_TYPE` from spec (and move to tests)
2023-10-30 10:53:58 -06:00
danny 72869c5c2d
Merge pull request #3533 from ethereum/ralexstokes-patch-2
`deneb`: Update block production to more precisely reflect the latest flow
2023-10-30 10:53:24 -06:00
danny 914fe92c5d
Merge pull request #3529 from nisdas/patch-3
Reject Blobs Which Reference Already Finalized Parent Blocks
2023-10-30 08:52:04 -06:00
Hsiao-Wei Wang 51343f54fe
Fix typing and delete the `signed_sidecar` 2023-10-30 18:28:12 +08:00
Hsiao-Wei Wang a12441486c
Enhance `blob_sidecar_inclusion_proof` tests 2023-10-30 17:42:32 +08:00
dapplion d323f0568f drop sidecar alias 2023-10-30 10:39:33 +02:00
Lion - dapplion b803f1ceeb
Update specs/deneb/p2p-interface.md
Co-authored-by: Pop Chunhapanya <haxx.pop@gmail.com>
2023-10-30 10:38:48 +02:00
Lion - dapplion 126e807d19
Update specs/deneb/p2p-interface.md
Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
2023-10-30 10:34:51 +02:00
dapplion c680212183 drop is_valid_merkle_path 2023-10-30 10:33:49 +02:00
Hsiao-Wei Wang 0e4737eba2
Add a general `compute_merkle_proof` helper to replace container-specific helpers 2023-10-30 14:44:32 +08:00
Hsiao-Wei Wang ae6a9eba26
Fix lint 2023-10-29 03:39:39 +08:00
Hsiao-Wei Wang b018fbc46a
Remove `BLOB_KZG_COMMITMENTS_GINDEX` from the preset files 2023-10-29 03:39:24 +08:00
Hsiao-Wei Wang b7e0b88cb1
Fix test 2023-10-29 03:28:57 +08:00