status-im
/
eth2.0-specs
mirror of https://github.com/status-im/eth2.0-specs.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

PR feedback from terence

This commit is contained in:
Hsiao-Wei Wang 2020-05-02 01:56:25 +08:00
parent e758fb76c2
commit ff85025113
No known key found for this signature in database
GPG Key ID: 95B070122902DEA4
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
specs/phase1/beacon-chain.md
View File

@ -735,8 +735,12 @@ def apply_shard_transition(state: BeaconState, shard: Shard, transition: ShardTr
shard_parent_root = state.shard_states[shard].latest_block_root shard_parent_root = state.shard_states[shard].latest_block_root
for i in range(len(offset_slots)): for i in range(len(offset_slots)):
shard_block_length = transition.shard_block_lengths[i] shard_block_length = transition.shard_block_lengths[i]
is_empty_proposal = shard_block_length == 0
shard_state = transition.shard_states[i] shard_state = transition.shard_states[i]
# Verify correct calculation of gas prices and slots
assert shard_state.gasprice == compute_updated_gasprice(prev_gasprice, shard_block_length)
assert shard_state.slot == offset_slots[i]
# Collect the non-empty proposals result
is_empty_proposal = shard_block_length == 0
if not is_empty_proposal: if not is_empty_proposal:
proposal_index = get_shard_proposer_index(state, offset_slots[i], shard) proposal_index = get_shard_proposer_index(state, offset_slots[i], shard)
# Reconstruct shard headers # Reconstruct shard headers
@ -751,9 +755,6 @@ def apply_shard_transition(state: BeaconState, shard: Shard, transition: ShardTr
headers.append(header) headers.append(header)
proposers.append(proposal_index) proposers.append(proposal_index)
# Verify correct calculation of gas prices and slots
assert shard_state.gasprice == compute_updated_gasprice(prev_gasprice, shard_block_length)
assert shard_state.slot == offset_slots[i]
prev_gasprice = shard_state.gasprice prev_gasprice = shard_state.gasprice
pubkeys = [state.validators[proposer].pubkey for proposer in proposers] pubkeys = [state.validators[proposer].pubkey for proposer in proposers]