status-im/eth2.0-specs
2
0
Fork 0
mirror of https://github.com/status-im/eth2.0-specs.git synced 2025-02-01 13:25:39 +00:00
Code Issues Projects Releases Wiki Activity

Fix param order in prepare_execution_payload

Browse Source 
Documentation on how to call `prepare_execution_payload` had the params
for `safe_block_hash` and `finalized_block` hash flipped compared to the
function definition. Also updated tests for consistency.
This commit is contained in:
Etan Kissling 2022-04-25 16:49:00 +02:00
parent 83ac38c183
commit f125538122
No known key found for this signature in database
GPG Key ID: B21DA824C5A3D03D
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
specs/bellatrix/validator.md
View File

@ -110,7 +110,7 @@ All validator responsibilities remain unchanged other than those noted below. Na
To obtain an execution payload, a block proposer building a block on top of a `state` must take the following actions: To obtain an execution payload, a block proposer building a block on top of a `state` must take the following actions:
1. Set `payload_id = prepare_execution_payload(state, pow_chain, finalized_block_hash, safe_block_hash, suggested_fee_recipient, execution_engine)`, where: 1. Set `payload_id = prepare_execution_payload(state, pow_chain, safe_block_hash, finalized_block_hash, suggested_fee_recipient, execution_engine)`, where:
* `state` is the state object after applying `process_slots(state, slot)` transition to the resulting state of the parent block processing * `state` is the state object after applying `process_slots(state, slot)` transition to the resulting state of the parent block processing
* `pow_chain` is a `Dict[Hash32, PowBlock]` dictionary that abstractly represents all blocks in the PoW chain with block hash as the dictionary key * `pow_chain` is a `Dict[Hash32, PowBlock]` dictionary that abstractly represents all blocks in the PoW chain with block hash as the dictionary key
* `safe_block_hash` is the return value of the `get_safe_execution_payload_hash(store: Store)` function call * `safe_block_hash` is the return value of the `get_safe_execution_payload_hash(store: Store)` function call

2
tests/core/pyspec/eth2spec/test/bellatrix/unittests/validator/test_validator.py
View File

@ -158,8 +158,8 @@ def test_prepare_execution_payload(spec, state):
payload_id = spec.prepare_execution_payload( payload_id = spec.prepare_execution_payload(
state=state, state=state,
pow_chain=pow_chain.to_dict(), pow_chain=pow_chain.to_dict(),
finalized_block_hash=finalized_block_hash,
safe_block_hash=safe_block_hash, safe_block_hash=safe_block_hash,
finalized_block_hash=finalized_block_hash,
suggested_fee_recipient=suggested_fee_recipient, suggested_fee_recipient=suggested_fee_recipient,
execution_engine=TestEngine(), execution_engine=TestEngine(),
) )