status-im/eth2.0-specs
2
0
Fork 0
mirror of https://github.com/status-im/eth2.0-specs.git synced 2025-02-03 06:13:31 +00:00
Code Issues Projects Releases Wiki Activity

Replace assert messages with comments

Browse Source
This commit is contained in:
Justin Traglia 2024-11-06 13:26:59 -06:00
parent 276c56201a
commit ebbce03db5
No known key found for this signature in database
GPG Key ID: F099C9CD25DF82A1
2 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
specs/electra/validator.md
View File

@ -207,9 +207,14 @@ def get_execution_requests(execution_requests_list: Sequence[bytes]) -> Executio
prev_request_type = None prev_request_type = None
for request in execution_requests_list: for request in execution_requests_list:
request_type, request_data = request[0:1], request[1:] request_type, request_data = request[0:1], request[1:]
assert request_type in request_types, "unexpected request type"
assert len(request_data) != 0, "empty request data" # Check that the request type is valid
assert prev_request_type is None or prev_request_type < request_type, "not ascending order" assert request_type in request_types
# Check that the request data is not empty
assert len(request_data) != 0
# Check that requests are in strictly ascending order
# Each successive type must be greater than the last with no duplicates
assert prev_request_type is None or prev_request_type < request_type
prev_request_type = request_type prev_request_type = request_type
if request_type == DEPOSIT_REQUEST_TYPE: if request_type == DEPOSIT_REQUEST_TYPE:

16
tests/core/pyspec/eth2spec/test/electra/unittests/test_execution_requests.py
View File

@ -73,8 +73,8 @@ def test_requests_deserialize__reject_duplicate_request(spec):
try: try:
spec.get_execution_requests(serialized_execution_requests) spec.get_execution_requests(serialized_execution_requests)
assert False, "expected exception" assert False, "expected exception"
except Exception as e: except Exception:
assert "not ascending order" in str(e) pass
@with_electra_and_later @with_electra_and_later
@ -89,8 +89,8 @@ def test_requests_deserialize__reject_out_of_order_requests(spec):
try: try:
spec.get_execution_requests(serialized_execution_requests) spec.get_execution_requests(serialized_execution_requests)
assert False, "expected exception" assert False, "expected exception"
except Exception as e: except Exception:
assert "not ascending order" in str(e) pass
@with_electra_and_later @with_electra_and_later
@ -101,8 +101,8 @@ def test_requests_deserialize__reject_empty_request(spec):
try: try:
spec.get_execution_requests(serialized_execution_requests) spec.get_execution_requests(serialized_execution_requests)
assert False, "expected exception" assert False, "expected exception"
except Exception as e: except Exception:
assert "empty request data" in str(e) pass
@with_electra_and_later @with_electra_and_later
@ -115,5 +115,5 @@ def test_requests_deserialize__reject_unexpected_request_type(spec):
try: try:
spec.get_execution_requests(serialized_execution_requests) spec.get_execution_requests(serialized_execution_requests)
assert False, "expected exception" assert False, "expected exception"
except Exception as e: except Exception:
assert "unexpected request type" in str(e) pass