status-im/eth2.0-specs
2
0
Fork 0
mirror of https://github.com/status-im/eth2.0-specs.git synced 2025-03-01 18:50:35 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #3877 from fradamt/dev

Browse Source 
remove redundant copy()
This commit is contained in:
Hsiao-Wei Wang 2024-08-12 18:39:54 +09:00 committed by GitHub
commit d8cbca76b2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
specs/capella/fork-choice.md
View File

@ -75,8 +75,6 @@ def on_block(store: Store, signed_block: SignedBeaconBlock) -> None:
block = signed_block.message block = signed_block.message
# Parent block must be known # Parent block must be known
assert block.parent_root in store.block_states assert block.parent_root in store.block_states
# Make a copy of the state to avoid mutability issues
pre_state = copy(store.block_states[block.parent_root])
# Blocks cannot be in the future. If they are, their consideration must be delayed until they are in the past. # Blocks cannot be in the future. If they are, their consideration must be delayed until they are in the past.
assert get_current_slot(store) >= block.slot assert get_current_slot(store) >= block.slot
@ -92,7 +90,8 @@ def on_block(store: Store, signed_block: SignedBeaconBlock) -> None:
assert store.finalized_checkpoint.root == finalized_checkpoint_block assert store.finalized_checkpoint.root == finalized_checkpoint_block
# Check the block is valid and compute the post-state # Check the block is valid and compute the post-state
state = pre_state.copy() # Make a copy of the state to avoid mutability issues
state = copy(store.block_states[block.parent_root])
block_root = hash_tree_root(block) block_root = hash_tree_root(block)
state_transition(state, signed_block, True) state_transition(state, signed_block, True)

5
specs/deneb/fork-choice.md
View File

@ -74,8 +74,6 @@ def on_block(store: Store, signed_block: SignedBeaconBlock) -> None:
block = signed_block.message block = signed_block.message
# Parent block must be known # Parent block must be known
assert block.parent_root in store.block_states assert block.parent_root in store.block_states
# Make a copy of the state to avoid mutability issues
pre_state = copy(store.block_states[block.parent_root])
# Blocks cannot be in the future. If they are, their consideration must be delayed until they are in the past. # Blocks cannot be in the future. If they are, their consideration must be delayed until they are in the past.
assert get_current_slot(store) >= block.slot assert get_current_slot(store) >= block.slot
@ -98,7 +96,8 @@ def on_block(store: Store, signed_block: SignedBeaconBlock) -> None:
assert is_data_available(hash_tree_root(block), block.body.blob_kzg_commitments) assert is_data_available(hash_tree_root(block), block.body.blob_kzg_commitments)
# Check the block is valid and compute the post-state # Check the block is valid and compute the post-state
state = pre_state.copy() # Make a copy of the state to avoid mutability issues
state = copy(store.block_states[block.parent_root])
block_root = hash_tree_root(block) block_root = hash_tree_root(block)
state_transition(state, signed_block, True) state_transition(state, signed_block, True)