status-im
/
eth2.0-specs
mirror of https://github.com/status-im/eth2.0-specs.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Apply suggestions from code review from @hwwhww 

Co-authored-by: Hsiao-Wei Wang <hwwang156@gmail.com>
This commit is contained in:
Danny Ryan 2020-05-05 13:08:41 -06:00 committed by GitHub
parent f35106d9ee
commit d26cfd2e59
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tests/core/pyspec/eth2spec/test/helpers/rewards.py
View File

@ -99,7 +99,7 @@ def test_half_full(spec, state, runner):
def test_one_attestation_one_correct(spec, state, runner): def test_one_attestation_one_correct(spec, state, runner):
prepare_state_with_full_attestations(spec, state) prepare_state_with_full_attestations(spec, state)
# Remove half of attestations # Remove all attestations except for the first one
state.previous_epoch_attestations = state.previous_epoch_attestations[:1] state.previous_epoch_attestations = state.previous_epoch_attestations[:1]
yield from runner(spec, state) yield from runner(spec, state)
@ -120,11 +120,9 @@ def test_some_very_low_effective_balances_that_attested(spec, state, runner):
prepare_state_with_full_attestations(spec, state) prepare_state_with_full_attestations(spec, state)
# Set some balances to be very low (including 0) # Set some balances to be very low (including 0)
state.validators[0].effective_balance = 0 assert len(state.validators) >= 5:
state.validators[1].effective_balance = 2 for i, index in enumerate(5):
state.validators[2].effective_balance = 10 state.validators[index].effective_balance = i
state.validators[3].effective_balance = 100
state.validators[4].effective_balance = 1000
yield from runner(spec, state) yield from runner(spec, state)
@ -135,7 +133,7 @@ def test_some_very_low_effective_balances_that_did_not_attest(spec, state, runne
# Remove attestation # Remove attestation
attestation = state.previous_epoch_attestations[0] attestation = state.previous_epoch_attestations[0]
state.previous_epoch_attestations = state.previous_epoch_attestations[1:] state.previous_epoch_attestations = state.previous_epoch_attestations[1:]
# Set removed indices effective balance to zero # Set removed indices effective balance to very low amount
indices = spec.get_unslashed_attesting_indices(state, [attestation]) indices = spec.get_unslashed_attesting_indices(state, [attestation])
for i, index in enumerate(indices): for i, index in enumerate(indices):
state.validators[index].effective_balance = i state.validators[index].effective_balance = i