Apply suggestions from code review

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
This commit is contained in:
Diederik Loerakker 2019-07-31 02:05:52 +02:00 committed by GitHub
parent 9f0a601a40
commit d0985dbb5b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions

View File

@ -175,11 +175,11 @@ Separation of configuration and tests aims to:
- Prevent duplication of configuration - Prevent duplication of configuration
- Make all tests easy to upgrade (e.g. when a new config constant is introduced) - Make all tests easy to upgrade (e.g. when a new config constant is introduced)
- Clearly define which constants to use - Clearly define which constants to use
- Shareable between clients, for cross-client short- or long-lived testnets - Be easily shareable between clients, for cross-client short- or long-lived testnets
- Minimize the amounts of different constants permutations to compile as a client. - Minimize the amount of different constants permutations to compile as a client.
*Note*: Some clients prefer compile-time constants and optimizations. *Note*: Some clients prefer compile-time constants and optimizations.
They should compile for each configuration once, and run the corresponding tests per build target. They should compile for each configuration once, and run the corresponding tests per build target.
- Includes constants to coordinate forking with. - Include constants to coordinate forking with
The format is described in [`/configs`](../../configs/README.md#format). The format is described in [`/configs`](../../configs/README.md#format).