status-im
/
eth2.0-specs
mirror of https://github.com/status-im/eth2.0-specs.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Stricter aggregation_bitfield validation 

Make sure that there's at least one vote in attestations (`bls_verify_multiple` can return `True` with zero votes)
This commit is contained in:
Justin 2019-01-28 21:13:25 +00:00 committed by GitHub
parent d78fb66aac
commit b2855f9be4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
specs/core/0_beacon-chain.md
View File

@ -1604,8 +1604,9 @@ For each `attestation` in `block.body.attestations`:
* Verify that either `attestation.data.latest_crosslink_root` or `attestation.data.shard_block_root` equals `state.latest_crosslinks[shard].shard_block_root`.
* Verify bitfields and aggregate signature:
```python
```python
assert attestation.custody_bitfield == b'\x00' * len(attestation.custody_bitfield) # [TO BE REMOVED IN PHASE 1]
assert attestation.aggregation_bitfield != b'\x00' * len(attestation.aggregation_bitfield)
for i in range(len(crosslink_committee)):
if get_bitfield_bit(attestation.aggregation_bitfield) == 0b0: