status-im
/
eth2.0-specs
mirror of https://github.com/status-im/eth2.0-specs.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

PR feedback from @ralexstokes

This commit is contained in:
Danny Ryan 2021-07-08 12:18:54 -06:00
parent 19001055e9
commit a5a48d5a23
No known key found for this signature in database
GPG Key ID: 2765A792E42CE07A
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/core/pyspec/eth2spec/test/altair/epoch_processing/test_process_inactivity_updates.py
View File

@ -57,6 +57,7 @@ def run_inactivity_scores_test(spec, state, participation_fn=None, inactivity_sc
@spec_state_test @spec_state_test
def test_all_zero_inactivity_scores_empty_participation(spec, state): def test_all_zero_inactivity_scores_empty_participation(spec, state):
yield from run_inactivity_scores_test(spec, state, set_empty_participation, zero_inactivity_scores) yield from run_inactivity_scores_test(spec, state, set_empty_participation, zero_inactivity_scores)
# Not yet in leak so no leak score added even though no participation
assert set(state.inactivity_scores) == set([0]) assert set(state.inactivity_scores) == set([0])
@ -87,7 +88,7 @@ def test_all_zero_inactivity_scores_random_participation(spec, state):
@spec_state_test @spec_state_test
@leaking() @leaking()
def test_all_zero_inactivity_scores_random_participation_leaking(spec, state): def test_all_zero_inactivity_scores_random_participation_leaking(spec, state):
# Only randompize participation in previous epoch to remain in leak # Only randomize participation in previous epoch to remain in leak
yield from run_inactivity_scores_test( yield from run_inactivity_scores_test(
spec, state, spec, state,
randomize_previous_epoch_participation, zero_inactivity_scores, rng=Random(5555), randomize_previous_epoch_participation, zero_inactivity_scores, rng=Random(5555),

2
tests/core/pyspec/eth2spec/test/altair/sanity/test_blocks.py
View File

@ -131,7 +131,5 @@ def test_inactivity_scores_full_participation_leaking(spec, state):
yield 'post', state yield 'post', state
# Full particiaption during a leak so all scores should decrease by 1 # Full particiaption during a leak so all scores should decrease by 1
print(previous_inactivity_scores)
print(state.inactivity_scores)
for pre, post in zip(previous_inactivity_scores, state.inactivity_scores): for pre, post in zip(previous_inactivity_scores, state.inactivity_scores):
assert post == pre - 1 assert post == pre - 1

1
tests/core/pyspec/eth2spec/test/helpers/rewards.py
View File

@ -266,6 +266,7 @@ def transition_state_to_leak(spec, state, epochs=None):
for _ in range(epochs): for _ in range(epochs):
next_epoch(spec, state) next_epoch(spec, state)
assert spec.is_in_inactivity_leak(state)
_cache_dict = LRU(size=10) _cache_dict = LRU(size=10)