Apply suggestions from code review

Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
This commit is contained in:
Diederik Loerakker 2019-07-31 02:02:50 +02:00 committed by GitHub
parent 5f33560b47
commit 9f0a601a40
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions

View File

@ -27,7 +27,7 @@ deposits_count: int -- Amount of deposits.
A series of files, with `<index>` in range `[0, deposits_count)`. Deposits need to be processed in order.
Each file is a YAML-encoded `Deposit` object.
Each deposit is also available as `deposits_<index>.ssz`
Each deposit is also available as `deposits_<index>.ssz`.
### `state.yaml`

View File

@ -43,7 +43,7 @@ Operations:
|-------------------------|----------------------|----------------------|--------------------------------------------------------|
| `attestation` | `Attestation` | `attestation` | `process_attestation(state, attestation)` |
| `attester_slashing` | `AttesterSlashing` | `attester_slashing` | `process_attester_slashing(state, attester_slashing)` |
| `block_header` | `Block` | **`block** | `process_block_header(state, block)` |
| `block_header` | `Block` | **`block`** | `process_block_header(state, block)` |
| `deposit` | `Deposit` | `deposit` | `process_deposit(state, deposit)` |
| `proposer_slashing` | `ProposerSlashing` | `proposer_slashing` | `process_proposer_slashing(state, proposer_slashing)` |
| `transfer` | `Transfer` | `transfer` | `process_transfer(state, transfer)` |

View File

@ -26,7 +26,7 @@ The `ssz_generic` tests are split up into different handler, each specialized in
## Format
For each type, a `valid` and a `invalid` suite is implemented.
For each type, a `valid` and an `invalid` suite is implemented.
The cases have the same format, but those in the `invalid` suite only declare a subset of the data a test in the `valid` declares.
Each of the handlers encodes the SSZ type declaration in the file-name. See [Type Declarations](#type-declarations).
@ -79,7 +79,7 @@ This is a valid way of detecting `invalid` data too. E.g. a 0-length basic vecto
## Type declarations
Most types are not as static, and reasonably be constructed during test runtime from the test case name.
Most types are not as static, and can reasonably be constructed during test runtime from the test case name.
Formats are listed below.
For each test case, an additional `_{extra...}` may be appended to the name,